s3: smbd: SMB1 reply_copy() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense.
authorJeremy Allison <jra@samba.org>
Tue, 29 Sep 2020 03:06:04 +0000 (20:06 -0700)
committerRalph Boehme <slow@samba.org>
Wed, 30 Sep 2020 20:46:39 +0000 (20:46 +0000)
There's either a wildcard in the last component or not. Always use
UCF_ALWAYS_ALLOW_WCARD_LCOMP for calls that can take a wildcard.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/reply.c

index fcac68147b1c5df73ee91315cacd9884023e06f4..db41bb54531fa1cb9489f1ed5a587c6fa963c168 100644 (file)
@@ -8697,9 +8697,9 @@ void reply_copy(struct smb_request *req)
        bool source_has_wild = False;
        bool dest_has_wild = False;
        NTSTATUS status;
-       uint32_t ucf_flags_src = UCF_COND_ALLOW_WCARD_LCOMP |
+       uint32_t ucf_flags_src = UCF_ALWAYS_ALLOW_WCARD_LCOMP |
                ucf_flags_from_smb_request(req);
-       uint32_t ucf_flags_dst = UCF_COND_ALLOW_WCARD_LCOMP |
+       uint32_t ucf_flags_dst = UCF_ALWAYS_ALLOW_WCARD_LCOMP |
                ucf_flags_from_smb_request(req);
        TALLOC_CTX *ctx = talloc_tos();