auth: Fix CID 1458418 Null pointer dereferences (REVERSE_INULL)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/source3/auth/auth_sam.c b/source3/auth/auth_sam.c
index 738c2a2a788b3d0a4cafeb6791ab2355a7e8e7d8..3c12f959fafedf527b9364e1fefb30f3e6b53c42 100644 (file)
--- a/source3/auth/auth_sam.c
+++ b/source3/auth/auth_sam.c
@@ -188,12 +188,13 @@ static NTSTATUS auth_sam_netlogon3_auth(const struct auth_context *auth_context,
                                        const struct auth_usersupplied_info *user_info,
                                        struct auth_serversupplied_info **server_info)
 {
-       const char *effective_domain = user_info->mapped.domain_name;
+       const char *effective_domain = NULL;
        bool is_my_domain;
 
        if (!user_info || !auth_context) {
                return NT_STATUS_LOGON_FAILURE;
        }
+       effective_domain = user_info->mapped.domain_name;
 
        if (user_info->mapped.account_name == NULL ||
            user_info->mapped.account_name[0] == '\0')