s3/winbdind: cppcheck: fix nullPointerArithmetic error

Fixes

source3/winbindd/winbindd_cache.c:4386: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck]
source3/winbindd/winbindd_cache.c:4400: error: nullPointerArithmetic: Pointer addition with NULL pointer. <--[cppcheck]
source3/winbindd/winbindd_cache.c:1569:24: warning: Dereference of null pointer <--[clang]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
index abdfd11dc531398e98b695cad0ebf22a17d1adb7..394b0c774a9ef2358155088a1984e15b6d715542 100644 (file)
--- a/source3/winbindd/winbindd_cache.c
+++ b/source3/winbindd/winbindd_cache.c
@@ -4383,7 +4383,8 @@ static int pack_tdc_domains( struct winbindd_tdc_domain *domains,
        len = 0;
 
        /* Store the number of array items first */
-       len += tdb_pack( buffer+len, buflen-len, "d", 
+       len += tdb_pack( buffer ? buffer+len : NULL,
+                        buffer ? buflen-len : 0, "d",
                         num_domains );
 
        /* now pack each domain trust record */
@@ -4397,7 +4398,8 @@ static int pack_tdc_domains( struct winbindd_tdc_domain *domains,
                                  domains[i].dns_name ? domains[i].dns_name : "UNKNOWN" ));
                }
 
-               len += tdb_pack( buffer+len, buflen-len, "fffddd",
+               len += tdb_pack( buffer ? buffer+len : NULL,
+                                buffer ? buflen-len : 0, "fffddd",
                                 domains[i].domain_name,
                                 domains[i].dns_name ? domains[i].dns_name : "",
                                 dom_sid_str_buf(&domains[i].sid, &tmp),