s3:rpc_server: Add missing newlines to logging messages
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 7 Aug 2023 04:48:06 +0000 (16:48 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 8 Aug 2023 04:39:38 +0000 (04:39 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/rpc_server/eventlog/srv_eventlog_nt.c
source3/rpc_server/mdssvc/marshalling.c
source3/rpc_server/mdssvc/mdssvc.c
source3/rpc_server/rpc_host.c
source3/rpc_server/rpc_server.c
source3/rpc_server/rpc_worker.c
source3/rpc_server/spoolss/srv_spoolss_nt.c
source3/rpc_server/winreg/srv_winreg_nt.c

index dd555f8c533de40ac86d5ee3481839164dc65a6a..a946c5731437bb5a70f5bb02ae1b10cbe07a1086 100644 (file)
@@ -582,7 +582,7 @@ NTSTATUS _eventlog_ClearEventLogW(struct pipes_struct *p,
        if (r->in.backupfile && r->in.backupfile->string) {
 
                DEBUG(8,( "_eventlog_ClearEventLogW: Using [%s] as the backup "
-                       "file name for log [%s].",
+                       "file name for log [%s].\n",
                         r->in.backupfile->string, info->logname ) );
        }
 
index 0e323fa979e7c31e1d1639c0567b6eac6d0d3521..c85fae79e7eae5f9d3056a56ce4832432b4f2943 100644 (file)
@@ -90,7 +90,7 @@ static ssize_t sl_push_uint64_val(char *buf,
                                  uint64_t val)
 {
        if (offset + 8 > max_offset) {
-               DEBUG(1, ("%s: offset: %zd, max_offset: %zu",
+               DEBUG(1, ("%s: offset: %zd, max_offset: %zu\n",
                          __func__, offset, max_offset));
                return -1;
        }
@@ -634,7 +634,7 @@ static ssize_t sl_pack_loop(DALLOC_CTX *query, char *buf, ssize_t offset,
                        offset = sl_pack_CNID(p, buf, offset,
                                              bufsize, toc_buf, toc_idx);
                } else {
-                       DEBUG(1, ("unknown type: %s", type));
+                       DEBUG(1, ("unknown type: %s\n", type));
                        return -1;
                }
                if (offset == -1) {
@@ -999,7 +999,7 @@ static ssize_t sl_unpack_cpx(DALLOC_CTX *query,
                                buf, offset, slen, encoding);
                        mark_exists = (unicode_encoding & SL_ENC_UTF_16) ? true : false;
                        if (unicode_encoding & SL_ENC_BIG_ENDIAN) {
-                               DEBUG(1, ("Unsupported big endian UTF16 string"));
+                               DEBUG(1, ("Unsupported big endian UTF16 string\n"));
                                return -1;
                        }
                        slen -= mark_exists ? 2 : 0;
@@ -1068,7 +1068,7 @@ static ssize_t sl_unpack_cpx(DALLOC_CTX *query,
                break;
 
        default:
-               DEBUG(1, ("unknown complex query type: %u", cpx_query_type));
+               DEBUG(1, ("unknown complex query type: %u\n", cpx_query_type));
                return -1;
        }
 
@@ -1278,7 +1278,7 @@ static ssize_t sl_pack(DALLOC_CTX *query, char *buf, size_t bufsize)
        }
 
        if ((16 + len + ((toc_index + 1 ) * 8)) > bufsize) {
-               DEBUG(1, ("%s: exceeding size limit %zu", __func__, bufsize));
+               DEBUG(1, ("%s: exceeding size limit %zu\n", __func__, bufsize));
                return -1;
        }
 
index abeaac8263c20e4b1ba2940675ea907af0f1c738..e79be666dbe7d82ce38a10607d7f610d64d73288 100644 (file)
@@ -284,7 +284,7 @@ static bool create_result_handle(struct sl_query *slq)
 
        query_results->cnids->ca_unkn1 = 0xadd;
        if (slq->ctx2 > UINT32_MAX) {
-               DEBUG(1,("64bit ctx2 id too large: 0x%jx", (uintmax_t)slq->ctx2));
+               DEBUG(1,("64bit ctx2 id too large: 0x%jx\n", (uintmax_t)slq->ctx2));
                return false;
        }
        query_results->cnids->ca_context = (uint32_t)slq->ctx2;
index 2b9f05c1af36b5648ae288aeba7f48168f3e829d..c9ee9a3aca205c65c7cbbe53b0ecfccbcae71eca 100644 (file)
@@ -1317,7 +1317,7 @@ again:
 
                if ((worker->pid == -1) || !worker->available) {
                        DBG_DEBUG("Requested worker index %"PRIu8": "
-                                 "pid=%d, available=%d",
+                                 "pid=%d, available=%d\n",
                                  worker_index,
                                  (int)worker->pid,
                                  (int)worker->available);
index 6f50ca5fdb58462603de0b585879636022ca2c2f..a60f429440206d875b352d94f2544a182725c884 100644 (file)
@@ -97,7 +97,7 @@ void dcesrv_log_successful_authz(
        NTSTATUS status;
 
        if (frame == NULL) {
-               DBG_ERR("No memory");
+               DBG_ERR("No memory\n");
                return;
        }
 
@@ -218,7 +218,7 @@ static NTSTATUS dcesrv_assoc_group_reference(struct dcesrv_call_state *call,
                                transport);
 
                DBG_NOTICE("assoc_group 0x%08x (transport %s) "
-                          "is not available on transport %s",
+                          "is not available on transport %s\n",
                           assoc_group_id, at, ct);
                return NT_STATUS_UNSUCCESSFUL;
        }
index 4f47a0ad4f3b8a6fef78496f21e84f8b52b1e1ba..a58b6801f9ebb7249aab1624dd09d7ce01606aa3 100644 (file)
@@ -626,7 +626,7 @@ static struct dcesrv_assoc_group *rpc_worker_assoc_group_reference(
                        transport);
 
                DBG_NOTICE("assoc_group 0x%08x (transport %s) "
-                          "is not available on transport %s",
+                          "is not available on transport %s\n",
                           id, at, ct);
                return NULL;
        }
index 5a35b6a0e329e60ea005314e5a2b8746e2020c55..ef1051301be388318f057e3a75b5963c37edebc9 100644 (file)
@@ -324,7 +324,7 @@ static struct printer_handle *find_printer_index_by_hnd(struct pipes_struct *p,
                                          struct printer_handle,
                                          &status);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(2,("find_printer_index_by_hnd: Printer handle not found: "));
+               DEBUG(2,("find_printer_index_by_hnd: Printer handle not found: \n"));
                return NULL;
        }
 
@@ -7591,7 +7591,7 @@ static WERROR enumjobs_level2(TALLOC_CTX *mem_ctx,
                                                        pinfo2->printername,
                                                        &devmode);
                if (!W_ERROR_IS_OK(result)) {
-                       DEBUG(3, ("Can't proceed w/o a devmode!"));
+                       DEBUG(3, ("Can't proceed w/o a devmode!\n"));
                        goto err_pdb_drop;
                }
 
@@ -9816,7 +9816,7 @@ static WERROR getjob_level_2(TALLOC_CTX *mem_ctx,
                                                pinfo2->printername,
                                                &devmode);
                if (!W_ERROR_IS_OK(result)) {
-                       DEBUG(3, ("Can't proceed w/o a devmode!"));
+                       DEBUG(3, ("Can't proceed w/o a devmode!\n"));
                        return result;
                }
        }
index 3f282d4886e769c7b10ca07de82c19c518815bd9..8ab0f61ebdf259a6c3956e96767dac90251e35d9 100644 (file)
@@ -55,7 +55,7 @@ static struct registry_key *find_regkey_by_hnd(struct pipes_struct *p,
                                    struct registry_key,
                                    &status);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(2,("find_regkey_index_by_hnd: Registry Key not found: "));
+               DEBUG(2,("find_regkey_index_by_hnd: Registry Key not found: \n"));
                return NULL;
        }