git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0141c82
)
samba_bundled.py avoid inefficient string concatenations
author
Björn Jacke
<bj@sernet.de>
Sun, 25 Aug 2019 21:02:00 +0000
(23:02 +0200)
committer
Andrew Bartlett
<abartlet@samba.org>
Sat, 21 Sep 2019 19:33:25 +0000
(19:33 +0000)
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
buildtools/wafsamba/samba_bundled.py
patch
|
blob
|
history
diff --git
a/buildtools/wafsamba/samba_bundled.py
b/buildtools/wafsamba/samba_bundled.py
index 60ce7da7232f9fab4288cb6c599c7785a2d608eb..5f080dd8a7a6687ca836b5a23d6837cd93a047b5 100644
(file)
--- a/
buildtools/wafsamba/samba_bundled.py
+++ b/
buildtools/wafsamba/samba_bundled.py
@@
-204,8
+204,8
@@
def CHECK_BUNDLED_SYSTEM(conf, libname, minversion='0.0.0',
version_checks = '%s >= %s' % (pkg, minversion)
if maxversion is not None:
version_checks += ' %s <= %s' % (pkg, maxversion)
- for v in version_blacklist:
-
version_checks += ' %s != %s' % (pkg, v
)
+
+
version_checks += "".join(' %s != %s' % (pkg, v) for v in version_blacklist
)
# try pkgconfig first
if (conf.CHECK_CFG(package=pkg,