libcli:auth: Add test for decoding an RC4 password buffer

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/libcli/auth/tests/test_rc4_passwd_buffer.c b/libcli/auth/tests/test_rc4_passwd_buffer.c
new file mode 100644 (file)
index 0000000..f40ac3a
--- /dev/null
+++ b/libcli/auth/tests/test_rc4_passwd_buffer.c
@@ -0,0 +1,177 @@
+/*
+ * Unix SMB/CIFS implementation.
+ *
+ * Copyright (C) 2018-2019 Andreas Schneider <asn@samba.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <stdarg.h>
+#include <stddef.h>
+#include <stdint.h>
+#include <setjmp.h>
+#include <cmocka.h>
+
+#include "includes.h"
+#include "libcli/auth/libcli_auth.h"
+#include "rpc_client/init_samr.h"
+
+#define PASSWORD "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"
+
+static const uint8_t encrypted_test_blob[] = {
+       0x37, 0x8e, 0x1d, 0xd5, 0xd3, 0x9f, 0xca, 0x8e,
+       0x2f, 0x2d, 0xee, 0xc3, 0xb5, 0x50, 0xcd, 0x4e,
+       0xc9, 0x08, 0x04, 0x68, 0x32, 0xc3, 0xac, 0x8e,
+       0x53, 0x69, 0xd6, 0xb7, 0x56, 0xcc, 0xc0, 0xbe,
+       0x4e, 0x96, 0xa7, 0x74, 0xe9, 0xaa, 0x10, 0x3d,
+       0xd5, 0x8c, 0xaa, 0x12, 0x56, 0xb6, 0xf1, 0x85,
+       0x21, 0xfa, 0xe9, 0xa1, 0x76, 0xe6, 0xa5, 0x33,
+       0x33, 0x2f, 0x47, 0x29, 0xd6, 0xbd, 0xde, 0x64,
+       0x4d, 0x15, 0x3e, 0x6a, 0x11, 0x9b, 0x52, 0xbf,
+       0x7e, 0x3a, 0xeb, 0x1c, 0x55, 0xd1, 0xb2, 0xa4,
+       0x35, 0x03, 0x6c, 0x39, 0x61, 0x28, 0x98, 0xc3,
+       0x2d, 0xd4, 0x70, 0x69, 0x8b, 0x83, 0xe9, 0x62,
+       0xbe, 0xd8, 0x72, 0x4e, 0xdf, 0xd4, 0xe9, 0xe3,
+       0x46, 0x2a, 0xf9, 0x3c, 0x0f, 0x41, 0x62, 0xe1,
+       0x43, 0xf0, 0x91, 0xbe, 0x72, 0xa0, 0xc9, 0x08,
+       0x73, 0x20, 0x1f, 0x0d, 0x68, 0x2e, 0x32, 0xa1,
+       0xb8, 0x9b, 0x08, 0xa1, 0xb4, 0x81, 0x6b, 0xf1,
+       0xde, 0x0c, 0x28, 0x34, 0xe2, 0x65, 0x62, 0x54,
+       0xeb, 0xc0, 0x71, 0x14, 0xad, 0x36, 0x43, 0x0e,
+       0x92, 0x4d, 0x11, 0xe8, 0xdd, 0x2d, 0x5f, 0x05,
+       0xff, 0x07, 0xda, 0x81, 0x4e, 0x27, 0x42, 0xa8,
+       0xa9, 0x64, 0x4c, 0x74, 0xc8, 0x05, 0xbb, 0x83,
+       0x5a, 0xd9, 0x90, 0x3e, 0x0d, 0x9d, 0xe5, 0x2f,
+       0x08, 0xf9, 0x1b, 0xbd, 0x26, 0xc3, 0x0d, 0xac,
+       0x43, 0xd5, 0x17, 0xf2, 0x61, 0xf5, 0x74, 0x9b,
+       0xf3, 0x5b, 0x5f, 0xe1, 0x8a, 0xa6, 0xfd, 0xdf,
+       0xff, 0xb5, 0x8b, 0xf1, 0x26, 0xf7, 0xe0, 0xa7,
+       0x4f, 0x5b, 0xb8, 0x6d, 0xeb, 0xf6, 0x52, 0x68,
+       0x8d, 0xa3, 0xd4, 0x7f, 0x56, 0x43, 0xaa, 0xec,
+       0x58, 0x47, 0x03, 0xee, 0x9b, 0x59, 0xd9, 0x78,
+       0x9a, 0xfb, 0x9e, 0xe9, 0xa6, 0x61, 0x4e, 0x6d,
+       0x92, 0x35, 0xd3, 0x37, 0x6e, 0xf2, 0x34, 0x39,
+       0xd4, 0xd2, 0xeb, 0xcf, 0x1c, 0x10, 0xb3, 0x2b,
+       0x3e, 0x07, 0x42, 0x3e, 0x20, 0x90, 0x07, 0x3e,
+       0xc7, 0xed, 0xd4, 0xdf, 0x50, 0xe5, 0xff, 0xaf,
+       0x05, 0xce, 0x29, 0xbe, 0x01, 0xf8, 0xb0, 0x30,
+       0x96, 0xae, 0x1b, 0x62, 0x23, 0x93, 0x91, 0x1a,
+       0x52, 0x98, 0xd9, 0x59, 0xb8, 0x11, 0xec, 0xb8,
+       0xcf, 0x20, 0x32, 0x90, 0x9e, 0xf2, 0x06, 0x43,
+       0xb8, 0x36, 0xe3, 0x33, 0x4e, 0x6f, 0x75, 0xeb,
+       0xf7, 0x6c, 0xac, 0x06, 0x5f, 0x24, 0x8e, 0x4a,
+       0x03, 0xdf, 0x50, 0x31, 0xaa, 0x91, 0xd5, 0x85,
+       0x95, 0x78, 0x5b, 0xf4, 0x7f, 0x3e, 0xbc, 0x41,
+       0xfa, 0x10, 0xd3, 0x0f, 0x86, 0x8b, 0x23, 0xed,
+       0xfc, 0xcc, 0x3e, 0x7d, 0x8c, 0xb4, 0x7c, 0xec,
+       0x04, 0x7d, 0x12, 0x53, 0xa1, 0x30, 0xc5, 0xac,
+       0xf3, 0x1e, 0x54, 0x1f, 0x97, 0x05, 0x86, 0x74,
+       0x51, 0x13, 0x45, 0x98, 0xb8, 0x50, 0x62, 0x18,
+       0x0f, 0x6d, 0x66, 0xa4, 0x88, 0x31, 0x76, 0xa3,
+       0xb0, 0x75, 0x55, 0x44, 0x18, 0x7c, 0x67, 0xc7,
+       0x09, 0x9c, 0xab, 0x53, 0x49, 0xc0, 0xc9, 0x27,
+       0x53, 0xa6, 0x99, 0x01, 0x10, 0x49, 0x67, 0x8e,
+       0x5b, 0x12, 0x96, 0x40, 0x16, 0x39, 0x11, 0x53,
+       0x44, 0x8f, 0xa9, 0xbe, 0x84, 0xbe, 0xe0, 0x45,
+       0xe3, 0xfd, 0x48, 0x46, 0x43, 0x53, 0x13, 0x5f,
+       0xfa, 0xcf, 0x09, 0x67, 0x90, 0xa3, 0x94, 0xaa,
+       0x0d, 0x1f, 0xc2, 0xc3, 0xd4, 0x7e, 0xc8, 0x14,
+       0xbe, 0x84, 0xa5, 0x55, 0xee, 0x49, 0x8e, 0x03,
+       0x1d, 0xaf, 0xad, 0x65, 0x2f, 0xf0, 0xd5, 0x90,
+       0x5e, 0x8d, 0x29, 0x40, 0xba, 0x57, 0x26, 0xa8,
+       0x6c, 0x4b, 0x59, 0x40, 0x4e, 0xc2, 0xc4, 0x88,
+       0x0a, 0x06, 0x2b, 0x6c, 0x2a, 0xc7, 0x3f, 0xfe,
+       0x37, 0x2c, 0x41, 0x58, 0xfe, 0x7e, 0xaf, 0xd1,
+       0xd9, 0xd2, 0x9c, 0xd7, 0x8a, 0x01, 0x0e, 0x8c,
+       0x9e, 0x8b, 0x5d, 0x72, 0x54, 0x00, 0xbe, 0xb2,
+       0x9a, 0xc7, 0xfd, 0x83, 0x1e, 0x9c, 0x79, 0xdd,
+       0x15, 0x13, 0xdc, 0x15,
+};
+
+static void torture_decode_rc4_passwd_buffer(void **state)
+{
+       char *password_decoded = NULL;
+       size_t password_decoded_len = 0;
+       DATA_BLOB session_key = data_blob_const("SystemLibraryDTC", 16);
+       struct samr_CryptPasswordEx out_pwd_buf = {
+               .data = {0},
+       };
+       NTSTATUS status;
+       bool ok;
+
+       memcpy(out_pwd_buf.data,
+              encrypted_test_blob,
+              sizeof(out_pwd_buf.data));
+
+       status = encode_or_decode_arc4_passwd_buffer(out_pwd_buf.data,
+                                                    &session_key);
+       assert_true(NT_STATUS_IS_OK(status));
+
+       ok = decode_pw_buffer(NULL,
+                             out_pwd_buf.data,
+                             &password_decoded,
+                             &password_decoded_len,
+                             CH_UTF16);
+       assert_true(ok);
+       assert_int_equal(password_decoded_len, strlen(PASSWORD));
+       assert_string_equal(password_decoded, PASSWORD);
+}
+
+static void torture_rc4_passwd_buffer(void **state)
+{
+       char *password_decoded = NULL;
+       size_t password_decoded_len = 0;
+       DATA_BLOB session_key = data_blob_const("SystemLibraryDTC", 16);
+       struct samr_CryptPasswordEx out_pwd_buf = {
+               .data = {0},
+       };
+       NTSTATUS status;
+       bool ok;
+
+       status = init_samr_CryptPasswordEx(PASSWORD,
+                                          &session_key,
+                                          &out_pwd_buf);
+       assert_true(NT_STATUS_IS_OK(status));
+
+       status = encode_or_decode_arc4_passwd_buffer(out_pwd_buf.data,
+                                                    &session_key);
+       assert_true(NT_STATUS_IS_OK(status));
+
+       ok = decode_pw_buffer(NULL,
+                             out_pwd_buf.data,
+                             &password_decoded,
+                             &password_decoded_len,
+                             CH_UTF16);
+       assert_true(ok);
+       assert_int_equal(password_decoded_len, strlen(PASSWORD));
+       assert_string_equal(password_decoded, PASSWORD);
+}
+
+int main(int argc, char *argv[])
+{
+       int rc;
+       const struct CMUnitTest tests[] = {
+               cmocka_unit_test(torture_decode_rc4_passwd_buffer),
+               cmocka_unit_test(torture_rc4_passwd_buffer),
+       };
+
+       if (argc == 2) {
+               cmocka_set_test_filter(argv[1]);
+       }
+       cmocka_set_message_output(CM_OUTPUT_SUBUNIT);
+
+       rc = cmocka_run_group_tests(tests, NULL, NULL);
+
+       return rc;
+}

diff --git a/libcli/auth/wscript_build b/libcli/auth/wscript_build
index 39489c20b4e36e04a74847e10fe8aa45dd74b59b..5a4423e984e8594c682cb94c66226aa2e0f22d2b 100644 (file)
--- a/libcli/auth/wscript_build
+++ b/libcli/auth/wscript_build
@@ -54,3 +54,12 @@ bld.SAMBA_BINARY(
         ''',
         install=False
     )
+
+bld.SAMBA_BINARY('test_rc4_passwd_buffer',
+                 source='tests/test_rc4_passwd_buffer.c',
+                 deps='''
+                      INIT_SAMR
+                      LIBCLI_AUTH
+                      cmocka
+                      ''',
+                 install=False)

diff --git a/selftest/tests.py b/selftest/tests.py
index 1568f29b2128d4391e573b217b4d39178e7438b7..3377e7826bd903e532a1790bc4bda49c12e40719 100644 (file)
--- a/selftest/tests.py
+++ b/selftest/tests.py
@@ -261,6 +261,8 @@ plantestsuite("samba.unittests.byteorder", "none",
               [os.path.join(bindir(), "default/lib/util/test_byteorder")])
 plantestsuite("samba.unittests.ntlm_check", "none",
               [os.path.join(bindir(), "default/libcli/auth/test_ntlm_check")])
+plantestsuite("samba.unittests.rc4_passwd_buffer", "none",
+              [os.path.join(bindir(), "default/libcli/auth/test_rc4_passwd_buffer")])
 plantestsuite("samba.unittests.test_registry_regfio", "none",
               [os.path.join(bindir(), "default/source3/test_registry_regfio")])
 plantestsuite("samba.unittests.test_oLschema2ldif", "none",