s3:spoolss: Set remote and local address for accepted connections
authorSamuel Cabrero <scabrero@suse.de>
Mon, 18 Feb 2019 19:27:31 +0000 (20:27 +0100)
committerStefan Metzmacher <metze@samba.org>
Mon, 22 Jul 2019 16:49:15 +0000 (16:49 +0000)
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/printing/spoolssd.c

index bb0c03c32a69f50beae0157524b5baf552160597..cfd275418dea256b3a5d545f500100eb03843f58 100644 (file)
@@ -381,8 +381,6 @@ static void spoolss_client_terminated(void *pvt)
 
 struct spoolss_new_client {
        struct spoolss_children_data *data;
-       struct tsocket_address *srv_addr;
-       struct tsocket_address *cli_addr;
 };
 
 static void spoolss_handle_client(struct tevent_req *req);
@@ -426,12 +424,14 @@ static void spoolss_handle_client(struct tevent_req *req)
        const DATA_BLOB ping = data_blob_null;
        int ret;
        int sd;
+       struct tsocket_address *srv_addr = NULL;
+       struct tsocket_address *cli_addr = NULL;
 
        client = tevent_req_callback_data(req, struct spoolss_new_client);
        data = client->data;
 
-       ret = prefork_listen_recv(req, client, &sd, NULL,
-                                 &client->srv_addr, &client->cli_addr);
+       ret = prefork_listen_recv(req, data, &sd, NULL,
+                                 &srv_addr, &cli_addr);
 
        /* this will free the request too */
        talloc_free(client);
@@ -452,8 +452,8 @@ static void spoolss_handle_client(struct tevent_req *req)
                            data->msg_ctx,
                            NCACN_NP,
                            SPOOLSS_PIPE_NAME,
-                           NULL,  /* remote client address */
-                           NULL,  /* local server address */
+                           cli_addr,
+                           srv_addr,
                            sd,
                            NULL,  /* disconnect function */
                            spoolss_client_terminated,