libsocket: Make sure ifr.ifr_name is null-terminated
authorAndreas Schneider <asn@samba.org>
Wed, 22 Jun 2016 09:26:06 +0000 (11:26 +0200)
committerJeremy Allison <jra@samba.org>
Sat, 3 Dec 2016 02:40:53 +0000 (03:40 +0100)
Found by Coverity

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Dec  3 03:40:53 CET 2016 on sn-devel-144

lib/socket/interfaces.c

index dacd1180fa75b86bb9939cf294d608621f05161d..6409275d7bcf86057974de558c4dedea6efd29ca 100644 (file)
@@ -146,7 +146,7 @@ static void query_iface_speed_from_name(const char *name, uint64_t *speed)
        }
 
        ZERO_STRUCT(ifr);
-       strncpy(ifr.ifr_name, name, IF_NAMESIZE);
+       strlcpy(ifr.ifr_name, name, IF_NAMESIZE);
 
        ifr.ifr_data = (void *)&edata;
        edata.cmd = ETHTOOL_GLINK;