vfs_fruit: disable fd reopening optimisations for the two special macOS streams
authorRalph Boehme <slow@samba.org>
Tue, 24 Nov 2020 17:02:26 +0000 (18:02 +0100)
committerRalph Boehme <slow@samba.org>
Wed, 16 Dec 2020 09:08:31 +0000 (09:08 +0000)
I couldn't figure out why the reopen fails a few vfs.fruit tests, so for now
disable the optimisations. It only affects the two special Mac streams, so it's
not *that* bad, but definitely something we would want to improve on in the near
future.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/modules/vfs_fruit.c

index 352606b0f4a1e8c57e7755ce36d02019c8a86748..e3bcd9fff4e7f96aaa3095a5d4756251aeb6ceb3 100644 (file)
@@ -1656,6 +1656,8 @@ static int fruit_openat(vfs_handle_struct *handle,
 
        DBG_DEBUG("Path [%s] fd [%d]\n", smb_fname_str_dbg(smb_fname), fd);
 
+       /* Prevent reopen optimisation */
+       fsp->fsp_flags.have_proc_fds = false;
        return fd;
 }