s4/torture: initialise ACE structs to zero
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Tue, 22 Aug 2023 02:12:46 +0000 (14:12 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 24 Aug 2023 02:53:30 +0000 (02:53 +0000)
Because soon these structs will have more members, which are typically
going to be zero.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/torture/raw/acls.c
source4/torture/raw/streams.c
source4/torture/rpc/samr_accessmask.c
source4/torture/rpc/spoolss.c

index 9d9b6b130f3d1f229fc729cd6eae4fe491debd67..64977f5a719629df7e8f076ec1660dbc74a9f3bc 100644 (file)
@@ -140,7 +140,7 @@ static bool test_sd(struct torture_context *tctx, struct smbcli_state *cli)
        int fnum = -1;
        union smb_fileinfo q;
        union smb_setfileinfo set;
-       struct security_ace ace;
+       struct security_ace ace = {};
        struct security_descriptor *sd;
        struct dom_sid *test_sid;
 
index 0c493f5f1f2ea663963cb49c475554f6ca5ea801..415f223ef3ffe94f87550202676a1d4b73f20fd4 100644 (file)
@@ -1901,7 +1901,7 @@ static bool test_stream_permissions(struct torture_context *tctx,
        int fnum = -1;
        union smb_fileinfo q;
        union smb_setfileinfo set;
-       struct security_ace ace;
+       struct security_ace ace = {};
        struct security_descriptor *sd;
 
        torture_assert(tctx, torture_setup_dir(cli, BASEDIR),
index 07b8d44f6c24aaee7f2c723b968dd488f7936411..1ed0d673c719bc80e28f02d9b39a1d5fbeec3e46 100644 (file)
@@ -251,7 +251,7 @@ static bool test_samr_connect_user_acl(struct torture_context *tctx,
        struct policy_handle uch;
        struct samr_QuerySecurity qs;
        struct samr_SetSecurity ss;
-       struct security_ace ace;
+       struct security_ace ace = {};
        struct security_descriptor *sd;
        struct sec_desc_buf sdb, *sdbuf = NULL;
        bool ret = true;
index 0c71ed0073beca4a0466b92d61ccb2978291b3ff..05a0aef7e437a647a1e3b8a1dc15912c6e4ff837 100644 (file)
@@ -2019,7 +2019,7 @@ static bool test_PrinterInfo_SDs(struct torture_context *tctx,
        /* set modified sd level 3, query level 2 */
 
        for (i=0; i < 93; i++) {
-               struct security_ace a;
+               struct security_ace a = {};
                const char *sid_string = talloc_asprintf(tctx, "S-1-5-32-9999%i", i);
                a.type = SEC_ACE_TYPE_ACCESS_ALLOWED;
                a.flags = 0;