s3-spoolssd: Don't register spoolssd if epmd is not running.
authorAndreas Schneider <asn@samba.org>
Thu, 27 Feb 2014 08:58:27 +0000 (09:58 +0100)
committerKarolin Seeger <kseeger@samba.org>
Mon, 10 Mar 2014 17:37:25 +0000 (18:37 +0100)
https://bugzilla.samba.org/show_bug.cgi?id=10474

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit 562ade624a78a11a5af0f26b04df93d76d6166bd)

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Mon Mar 10 18:37:25 CET 2014 on sn-devel-104

source3/printing/spoolssd.c

index bb043bdba7b8c59c0afade10ce459b2e826c8bb2..55aa9c779244aa8143eb0420fa8d6d05f04b3dde 100644 (file)
@@ -31,6 +31,7 @@
 #include "librpc/gen_ndr/srv_spoolss.h"
 #include "rpc_server/rpc_server.h"
 #include "rpc_server/rpc_ep_register.h"
+#include "rpc_server/rpc_config.h"
 #include "rpc_server/spoolss/srv_spoolss_nt.h"
 #include "librpc/rpc/dcerpc_ep.h"
 #include "lib/server_prefork.h"
@@ -627,6 +628,7 @@ static char *get_bq_logfile(void)
 pid_t start_spoolssd(struct tevent_context *ev_ctx,
                    struct messaging_context *msg_ctx)
 {
+       enum rpc_service_mode_e epm_mode = rpc_epmapper_mode();
        struct rpc_srv_callbacks spoolss_cb;
        struct dcerpc_binding_vector *v;
        TALLOC_CTX *mem_ctx;
@@ -772,25 +774,28 @@ pid_t start_spoolssd(struct tevent_context *ev_ctx,
                exit(1);
        }
 
-       status = dcerpc_binding_vector_new(mem_ctx, &v);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Failed to create binding vector (%s)\n",
-                         nt_errstr(status)));
-               exit(1);
-       }
+       if (epm_mode != RPC_SERVICE_MODE_DISABLED &&
+           (lp_parm_bool(-1, "rpc_server", "register_embedded_np", false))) {
+               status = dcerpc_binding_vector_new(mem_ctx, &v);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0, ("Failed to create binding vector (%s)\n",
+                                 nt_errstr(status)));
+                       exit(1);
+               }
 
-       status = dcerpc_binding_vector_add_np_default(&ndr_table_spoolss, v);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Failed to add np to binding vector (%s)\n",
-                         nt_errstr(status)));
-               exit(1);
-       }
+               status = dcerpc_binding_vector_add_np_default(&ndr_table_spoolss, v);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0, ("Failed to add np to binding vector (%s)\n",
+                                 nt_errstr(status)));
+                       exit(1);
+               }
 
-       status = rpc_ep_register(ev_ctx, msg_ctx, &ndr_table_spoolss, v);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Failed to register spoolss endpoint! (%s)\n",
-                         nt_errstr(status)));
-               exit(1);
+               status = rpc_ep_register(ev_ctx, msg_ctx, &ndr_table_spoolss, v);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0, ("Failed to register spoolss endpoint! (%s)\n",
+                                 nt_errstr(status)));
+                       exit(1);
+               }
        }
 
        talloc_free(mem_ctx);