s3: smbd: Inside unix_convert(), never set state->name_is_wildcard.

We error out immediately if it's set anyway.
Preparing to remove 'state->name_is_wildcard' structure element.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source3/smbd/filename.c b/source3/smbd/filename.c
index 995547aecaa74651cf91cd0c63817820e3ec3789..266815d540eeb40b7eb52819a9e711cdd205f744 100644 (file)
--- a/source3/smbd/filename.c
+++ b/source3/smbd/filename.c
@@ -1152,8 +1152,8 @@ NTSTATUS unix_convert(TALLOC_CTX *mem_ctx,
 
        if (!state->posix_pathnames) {
                /* POSIX pathnames have no wildcards. */
-               state->name_has_wildcard = ms_has_wild(state->smb_fname->base_name);
-               if (state->name_has_wildcard) {
+               bool name_has_wildcard = ms_has_wild(state->smb_fname->base_name);
+               if (name_has_wildcard) {
                        /* Wildcard not valid anywhere. */
                        status = NT_STATUS_OBJECT_NAME_INVALID;
                        goto fail;