Fix an empty if statement.
authorJose A. Rivera <jarrpa@redhat.com>
Mon, 5 May 2014 11:46:58 +0000 (06:46 -0500)
committerKarolin Seeger <kseeger@samba.org>
Mon, 19 May 2014 10:10:11 +0000 (12:10 +0200)
Primarily following the precedent set by other uses of composite_is_ok(), but
also making sure nothing tries to use c after this point if it is in fact not
ok.

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Fix bug #10348 - Empty body in if-statement in continue_domain_open_lookup.

source4/libnet/libnet_domain.c

index 70ed31d02be1aefd41fbebbe35d6cadfecc4501c..27a3e5521d0eacea493a4d2496af3525045825d4 100644 (file)
@@ -207,7 +207,7 @@ static void continue_domain_open_lookup(struct tevent_req *subreq)
        r = &s->open;
 
        /* check the rpc layer status */
-       if (!composite_is_ok(c));
+       if (!composite_is_ok(c)) return;
 
        /* check the rpc call itself status */
        if (!NT_STATUS_IS_OK(s->lookup.out.result)) {