s3:passdb: Add missing newlines to logging messages

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source3/passdb/pdb_ldap.c b/source3/passdb/pdb_ldap.c
index 83c61e206b5860bc42e8d967c2a1e03eaf276d99..ed682de47ea8cffc6f56d89aa23a76ea810b7dff 100644 (file)
--- a/source3/passdb/pdb_ldap.c
+++ b/source3/passdb/pdb_ldap.c
@@ -4619,7 +4619,7 @@ static bool ldapuser2displayentry(struct ldap_search_state *state,
                              discard_const_p(char *, &result->account_name),
                              vals[0], &converted_size))
        {
-               DEBUG(0,("ldapuser2displayentry: pull_utf8_talloc failed: %s",
+               DEBUG(0,("ldapuser2displayentry: pull_utf8_talloc failed: %s\n",
                         strerror(errno)));
        }
 
@@ -4632,7 +4632,7 @@ static bool ldapuser2displayentry(struct ldap_search_state *state,
                                   discard_const_p(char *, &result->fullname),
                                   vals[0], &converted_size))
        {
-               DEBUG(0,("ldapuser2displayentry: pull_utf8_talloc failed: %s",
+               DEBUG(0,("ldapuser2displayentry: pull_utf8_talloc failed: %s\n",
                         strerror(errno)));
        }
 
@@ -4645,7 +4645,7 @@ static bool ldapuser2displayentry(struct ldap_search_state *state,
                                   discard_const_p(char *, &result->description),
                                   vals[0], &converted_size))
        {
-               DEBUG(0,("ldapuser2displayentry: pull_utf8_talloc failed: %s",
+               DEBUG(0,("ldapuser2displayentry: pull_utf8_talloc failed: %s\n",
                         strerror(errno)));
        }
 
@@ -4782,7 +4782,7 @@ static bool ldapgroup2displayentry(struct ldap_search_state *state,
                                      vals[0], &converted_size))
                {
                        DEBUG(0,("ldapgroup2displayentry: pull_utf8_talloc "
-                                 "failed: %s", strerror(errno)));
+                                 "failed: %s\n", strerror(errno)));
                }
        }
        else if (!pull_utf8_talloc(mem_ctx,
@@ -4790,7 +4790,7 @@ static bool ldapgroup2displayentry(struct ldap_search_state *state,
                                                 &result->account_name),
                                   vals[0], &converted_size))
        {
-               DEBUG(0,("ldapgroup2displayentry: pull_utf8_talloc failed: %s",
+               DEBUG(0,("ldapgroup2displayentry: pull_utf8_talloc failed: %s\n",
                          strerror(errno)));
        }
 
@@ -4803,7 +4803,7 @@ static bool ldapgroup2displayentry(struct ldap_search_state *state,
                                   discard_const_p(char *, &result->description),
                                   vals[0], &converted_size))
        {
-               DEBUG(0,("ldapgroup2displayentry: pull_utf8_talloc failed: %s",
+               DEBUG(0,("ldapgroup2displayentry: pull_utf8_talloc failed: %s\n",
                          strerror(errno)));
        }
        ldap_value_free(vals);
@@ -5961,10 +5961,10 @@ static NTSTATUS ldapsam_change_groupmem(struct pdb_methods *my_methods,
 
        switch (modop) {
        case LDAP_MOD_ADD:
-               DEBUG(1,("ldapsam_change_groupmem: add new member(rid=%d) to a domain group(rid=%d)", member_rid, group_rid));
+               DEBUG(1,("ldapsam_change_groupmem: add new member(rid=%d) to a domain group(rid=%d)\n", member_rid, group_rid));
                break;
        case LDAP_MOD_DELETE:
-               DEBUG(1,("ldapsam_change_groupmem: delete member(rid=%d) from a domain group(rid=%d)", member_rid, group_rid));
+               DEBUG(1,("ldapsam_change_groupmem: delete member(rid=%d) from a domain group(rid=%d)\n", member_rid, group_rid));
                break;
        default:
                return NT_STATUS_UNSUCCESSFUL;

diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c
index dee40bf217553c124276b261399b11cc0a04df81..1d55a45ef17ad52ab6ed1d38e2cd796cc46c615a 100644 (file)
--- a/source3/passdb/pdb_samba_dsdb.c
+++ b/source3/passdb/pdb_samba_dsdb.c
@@ -974,12 +974,12 @@ static NTSTATUS pdb_samba_dsdb_getgrfilter(struct pdb_methods *m, GROUP_MAP *map
                if (id_map.xid.type == ID_TYPE_GID || id_map.xid.type == ID_TYPE_BOTH) {
                        map->gid = id_map.xid.id;
                } else {
-                       DEBUG(1, (__location__ "Did not get GUID when mapping SID for %s", expression));
+                       DEBUG(1, (__location__ "Did not get GUID when mapping SID for %s\n", expression));
                        talloc_free(tmp_ctx);
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
        } else if (samdb_find_attribute(state->ldb, msg, "objectClass", "user")) {
-               DEBUG(1, (__location__ "Got SID_NAME_USER when searching for a group with %s", expression));
+               DEBUG(1, (__location__ "Got SID_NAME_USER when searching for a group with %s\n", expression));
                talloc_free(tmp_ctx);
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -2855,7 +2855,7 @@ static NTSTATUS pdb_samba_dsdb_enum_trusteddoms(struct pdb_methods *m,
        status = dsdb_trust_search_tdos(state->ldb, NULL,
                                        attrs, tmp_ctx, &res);
        if (!NT_STATUS_IS_OK(status)) {
-               DBG_ERR("dsdb_trust_search_tdos() - %s ", nt_errstr(status));
+               DBG_ERR("dsdb_trust_search_tdos() - %s\n", nt_errstr(status));
                TALLOC_FREE(tmp_ctx);
                return status;
        }
@@ -3043,7 +3043,7 @@ static NTSTATUS pdb_samba_dsdb_get_trusted_domain(struct pdb_methods *m,
        status = dsdb_trust_search_tdo(state->ldb, domain, NULL,
                                       attrs, tmp_ctx, &msg);
        if (!NT_STATUS_IS_OK(status)) {
-               DBG_ERR("dsdb_trust_search_tdo(%s) - %s ",
+               DBG_ERR("dsdb_trust_search_tdo(%s) - %s\n",
                        domain, nt_errstr(status));
                TALLOC_FREE(tmp_ctx);
                return status;
@@ -3051,7 +3051,7 @@ static NTSTATUS pdb_samba_dsdb_get_trusted_domain(struct pdb_methods *m,
 
        status = pdb_samba_dsdb_msg_to_trusted_domain(msg, mem_ctx, &d);
        if (!NT_STATUS_IS_OK(status)) {
-               DBG_ERR("pdb_samba_dsdb_msg_to_trusted_domain(%s) - %s ",
+               DBG_ERR("pdb_samba_dsdb_msg_to_trusted_domain(%s) - %s\n",
                        domain, nt_errstr(status));
                TALLOC_FREE(tmp_ctx);
                return status;
@@ -3092,7 +3092,7 @@ static NTSTATUS pdb_samba_dsdb_get_trusted_domain_by_sid(struct pdb_methods *m,
        status = dsdb_trust_search_tdo_by_sid(state->ldb, sid,
                                              attrs, tmp_ctx, &msg);
        if (!NT_STATUS_IS_OK(status)) {
-               DBG_ERR("dsdb_trust_search_tdo_by_sid(%s) - %s ",
+               DBG_ERR("dsdb_trust_search_tdo_by_sid(%s) - %s\n",
                        dom_sid_str_buf(sid, &buf),
                        nt_errstr(status));
                TALLOC_FREE(tmp_ctx);
@@ -3101,7 +3101,7 @@ static NTSTATUS pdb_samba_dsdb_get_trusted_domain_by_sid(struct pdb_methods *m,
 
        status = pdb_samba_dsdb_msg_to_trusted_domain(msg, mem_ctx, &d);
        if (!NT_STATUS_IS_OK(status)) {
-               DBG_ERR("pdb_samba_dsdb_msg_to_trusted_domain(%s) - %s ",
+               DBG_ERR("pdb_samba_dsdb_msg_to_trusted_domain(%s) - %s\n",
                        dom_sid_str_buf(sid, &buf),
                        nt_errstr(status));
                TALLOC_FREE(tmp_ctx);
@@ -3633,7 +3633,7 @@ static NTSTATUS pdb_samba_dsdb_enum_trusted_domains(struct pdb_methods *m,
        status = dsdb_trust_search_tdos(state->ldb, NULL,
                                        attrs, tmp_ctx, &res);
        if (!NT_STATUS_IS_OK(status)) {
-               DBG_ERR("dsdb_trust_search_tdos() - %s ", nt_errstr(status));
+               DBG_ERR("dsdb_trust_search_tdos() - %s\n", nt_errstr(status));
                TALLOC_FREE(tmp_ctx);
                return status;
        }
@@ -3656,7 +3656,7 @@ static NTSTATUS pdb_samba_dsdb_enum_trusted_domains(struct pdb_methods *m,
 
                status = pdb_samba_dsdb_msg_to_trusted_domain(msg, domains, &d);
                if (!NT_STATUS_IS_OK(status)) {
-                       DBG_ERR("pdb_samba_dsdb_msg_to_trusted_domain() - %s ",
+                       DBG_ERR("pdb_samba_dsdb_msg_to_trusted_domain() - %s\n",
                                nt_errstr(status));
                        TALLOC_FREE(tmp_ctx);
                        return status;

diff --git a/source3/passdb/pdb_smbpasswd.c b/source3/passdb/pdb_smbpasswd.c
index 36e016f02c4291e7a012615a283fcdc9d2fdf362..c7aa4dbb18e1d94cac1662c895cdc2419fb40aa9 100644 (file)
--- a/source3/passdb/pdb_smbpasswd.c
+++ b/source3/passdb/pdb_smbpasswd.c
@@ -250,7 +250,7 @@ creating file %s\n", pfile));
 exist. File successfully created.\n", pfile));
                                } else {
                                        DEBUG(0, ("startsmbfilepwent_internal: file %s did not \
-exist. Couldn't create new one. Error was: %s",
+exist. Couldn't create new one. Error was: %s\n",
                                        pfile, strerror(errno)));
                                        return NULL;
                                }

diff --git a/source3/passdb/pdb_tdb.c b/source3/passdb/pdb_tdb.c
index ab632dc596f86ff1441aa187ee8b283be69ebfa0..fb64af4a0b8e5978047b43409ec2b76485b547f0 100644 (file)
--- a/source3/passdb/pdb_tdb.c
+++ b/source3/passdb/pdb_tdb.c
@@ -821,7 +821,7 @@ static bool tdb_update_samacct_only( struct samu* newpwd, int flag )
 
        status = dbwrap_store_bystring(db_sam, keystr, data, flag);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Unable to modify passwd TDB: %s!",
+               DEBUG(0, ("Unable to modify passwd TDB: %s!\n",
                          nt_errstr(status)));
                goto done;
        }

diff --git a/source3/passdb/secrets.c b/source3/passdb/secrets.c
index 10692d6588b76e6d3f293afe73da515d15b22169..6bbc21a3b3874fd59ea593ee4019d612948ac616 100644 (file)
--- a/source3/passdb/secrets.c
+++ b/source3/passdb/secrets.c
@@ -529,7 +529,7 @@ char *secrets_fetch_generic(const char *owner, const char *key)
        char *tdbkey = NULL;
 
        if (( ! owner) || ( ! key)) {
-               DEBUG(1, ("Invalid Parameters"));
+               DEBUG(1, ("Invalid Parameters\n"));
                return NULL;
        }