librpc: Simplify GUID_string2() by using GUID_buf_string()
authorVolker Lendecke <vl@samba.org>
Wed, 18 Aug 2021 04:25:00 +0000 (06:25 +0200)
committerJeremy Allison <jra@samba.org>
Tue, 24 Aug 2021 17:32:28 +0000 (17:32 +0000)
Avoid unnecessary talloc

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
librpc/ndr/uuid.c

index 99d1a1be082182e660fc0c0013ce6f89999de76e..f7753a85f1a8d0b54e96fb155e6744f92f95342e 100644 (file)
@@ -222,9 +222,9 @@ _PUBLIC_ char* GUID_buf_string(const struct GUID *guid,
 
 _PUBLIC_ char *GUID_string2(TALLOC_CTX *mem_ctx, const struct GUID *guid)
 {
-       char *ret, *s = GUID_string(mem_ctx, guid);
-       ret = talloc_asprintf(mem_ctx, "{%s}", s);
-       talloc_free(s);
+       struct GUID_txt_buf buf;
+       char *ret = talloc_asprintf(
+               mem_ctx, "{%s}", GUID_buf_string(guid, &buf));
        return ret;
 }