Revert "tevent: fix crash bug in tevent_queue_immediate_trigger()"

This reverts commit fc185a5f4cb34f4a2488eb336844c32812f930e7.

See https://bugzilla.samba.org/show_bug.cgi?id=10344 for details.

Stefan (metze) Metzmacher 2014-04-11 07:28:18 UTC

Karolin, please revert fc185a5f4cb34f4a2488eb336844c32812f930e7 in v4-0-test,
this somehow went in twice. 87a02403ee4fcc404dc3b887a851c421660cb4d8 is the
first commit.

It's not a real problem to have the same check twice, but it's a bit confusing
and may generate problems with future backports.

diff --git a/lib/tevent/tevent_queue.c b/lib/tevent/tevent_queue.c
index e32468098d762512d8bf31672c3087924477c6fc..eeb922fbbc80644421889e679420599b12bff2aa 100644 (file)
--- a/lib/tevent/tevent_queue.c
+++ b/lib/tevent/tevent_queue.c
@@ -144,10 +144,6 @@ static void tevent_queue_immediate_trigger(struct tevent_context *ev,
                return;
        }
 
-       if (!q->list) {
-               return;
-       }
-
        q->list->triggered = true;
        q->list->trigger(q->list->req, q->list->private_data);
 }