s3: smbd: mkdir_internal(). 1 of 2. All calls to SMB_VFS_FSTAT(fsp, &fsp->fsp_name...
authorJeremy Allison <jra@samba.org>
Fri, 18 Mar 2022 19:19:44 +0000 (12:19 -0700)
committerJeremy Allison <jra@samba.org>
Thu, 24 Mar 2022 16:28:37 +0000 (16:28 +0000)
If doing an SMB_VFS_FSTAT() returning onto the stat struct stored in the fsp,
we must call vfs_stat_fsp() as this preserves the iflags.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15022

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/open.c

index 8f6bb8eb12041414dcb0db0dcfcc46d0aa5cd9cc..a0ade5dd87bf29d6ac316b8d867c43db663c74f7 100644 (file)
@@ -4352,10 +4352,11 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
        /* Ensure we're checking for a symlink here.... */
        /* We don't want to get caught by a symlink racer. */
 
-       if (SMB_VFS_FSTAT(fsp, &smb_dname->st) == -1) {
+       status = vfs_stat_fsp(fsp);
+       if (!NT_STATUS_IS_OK(status)) {
                DEBUG(2, ("Could not stat directory '%s' just created: %s\n",
-                         smb_fname_str_dbg(smb_dname), strerror(errno)));
-               return map_nt_error_from_unix(errno);
+                         smb_fname_str_dbg(smb_dname), nt_errstr(status)));
+               return status;
        }
 
        if (!S_ISDIR(smb_dname->st.st_ex_mode)) {