fec_mpc52xx: delete unneeded test before of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 8 Aug 2014 10:07:54 +0000 (12:07 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Aug 2014 17:28:08 +0000 (10:28 -0700)
Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_mpc52xx.c

index 9947765e90c547e97eee26edbc55aa06fd436329..ff55fbb20a75c774f72418bdca4e14d9e956a047 100644 (file)
@@ -1015,8 +1015,7 @@ mpc52xx_fec_remove(struct platform_device *op)
 
        unregister_netdev(ndev);
 
-       if (priv->phy_node)
-               of_node_put(priv->phy_node);
+       of_node_put(priv->phy_node);
        priv->phy_node = NULL;
 
        irq_dispose_mapping(ndev->irq);