python:tests: Add missing result checks for samba_tool.gpo tests
authorAndreas Schneider <asn@samba.org>
Thu, 9 Feb 2023 17:32:59 +0000 (18:32 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 20 Feb 2023 21:58:32 +0000 (21:58 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15308

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/samba_tool/gpo.py

index d192c1b8115553c3aaa618e2da65e5d4de572c29..e8d02d62f0cfd51240706d37f45f926f4c20c754 100644 (file)
@@ -266,6 +266,9 @@ class GpoCmdTestCase(SambaToolCmdTest):
                                                  os.environ["PASSWORD"]),
                                                 "--restore-metadata")
 
+            self.assertCmdSuccess(result, out, err,
+                                  "Ensure gpo restore successful")
+
             gpo_guid = "{%s}" % out.split("{")[1].split("}")[0]
 
             (result, out, err) = self.runsubcmd("gpo", "backup", gpo_guid,
@@ -320,6 +323,9 @@ class GpoCmdTestCase(SambaToolCmdTest):
                                                  os.environ["PASSWORD"]),
                                                 "--restore-metadata")
 
+            self.assertCmdSuccess(result, out, err,
+                                  "Ensure gpo restore successful")
+
             gpo_guid = "{%s}" % out.split("{")[1].split("}")[0]
             gpo_guid1 = gpo_guid
 
@@ -342,6 +348,9 @@ class GpoCmdTestCase(SambaToolCmdTest):
                                                  os.environ["PASSWORD"]),
                                                 "--restore-metadata")
 
+            self.assertCmdSuccess(result, out, err,
+                                  "Ensure gpo restore successful")
+
             gpo_guid = "{%s}" % out.split("{")[1].split("}")[0]
             gpo_guid2 = gpo_guid
 
@@ -405,6 +414,9 @@ class GpoCmdTestCase(SambaToolCmdTest):
                                                  os.environ["PASSWORD"]),
                                                 "--restore-metadata")
 
+            self.assertCmdSuccess(result, out, err,
+                                  "Ensure gpo restore successful")
+
             gpo_guid = "{%s}" % out.split("{")[1].split("}")[0]
             gpo_guid1 = gpo_guid
 
@@ -425,6 +437,9 @@ class GpoCmdTestCase(SambaToolCmdTest):
                                                  os.environ["PASSWORD"]),
                                                 "--restore-metadata")
 
+            self.assertCmdSuccess(result, out, err,
+                                  "Ensure gpo restore successful")
+
             gpo_guid = "{%s}" % out.split("{")[1].split("}")[0]
             gpo_guid2 = gpo_guid