Use tevent_req_oom

This fixes a few Coverity errors

diff --git a/lib/tsocket/tsocket_helpers.c b/lib/tsocket/tsocket_helpers.c
index 3a41a3efc3df71ee7e7297696e282c158bdb9cbf..db6b6148e959e26a4b23c64628ffaa66325a989c 100644 (file)
--- a/lib/tsocket/tsocket_helpers.c
+++ b/lib/tsocket/tsocket_helpers.c
@@ -73,7 +73,7 @@ struct tevent_req *tdgram_sendto_queue_send(TALLOC_CTX *mem_ctx,
                              tdgram_sendto_queue_trigger,
                              NULL);
        if (!ok) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                goto post;
        }
 
@@ -346,7 +346,7 @@ struct tevent_req *tstream_readv_pdu_queue_send(TALLOC_CTX *mem_ctx,
                              tstream_readv_pdu_queue_trigger,
                              NULL);
        if (!ok) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                goto post;
        }
 
@@ -453,7 +453,7 @@ struct tevent_req *tstream_writev_queue_send(TALLOC_CTX *mem_ctx,
                              tstream_writev_queue_trigger,
                              NULL);
        if (!ok) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                goto post;
        }
 

diff --git a/libcli/cldap/cldap.c b/libcli/cldap/cldap.c
index 59c54eabea943f02fce72b44e552d2f950ffcb86..a5a0e415988abdf6ac1b9eaf1853c44df4ef2088 100644 (file)
--- a/libcli/cldap/cldap.c
+++ b/libcli/cldap/cldap.c
@@ -631,7 +631,7 @@ struct tevent_req *cldap_search_send(TALLOC_CTX *mem_ctx,
        }
 
        if (!tevent_req_set_endtime(req, state->caller.cldap->event.ctx, end)) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                goto post;
        }
 
@@ -680,7 +680,7 @@ static void cldap_search_state_queue_done(struct tevent_req *subreq)
 
        /* wait for incoming traffic */
        if (!cldap_recvfrom_setup(state->caller.cldap)) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return;
        }
 

diff --git a/source3/lib/fncall.c b/source3/lib/fncall.c
index 4a013e9ee60d64d6026c5c362a74974be813d000..6e6b7c92504f7c1553b73a6a67891f4a65cc471b 100644 (file)
--- a/source3/lib/fncall.c
+++ b/source3/lib/fncall.c
@@ -266,7 +266,7 @@ struct tevent_req *fncall_send(TALLOC_CTX *mem_ctx, struct tevent_context *ev,
                return tevent_req_post(req, ev);
        }
        if (!fncall_set_pending(req, state->ctx, ev)) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return tevent_req_post(req, ev);
        }
        return req;

diff --git a/source3/lib/tldap.c b/source3/lib/tldap.c
index c2f5b2ced7143497dab9ad9eabe5375767ee8802..8b04d0063675e137c6fd2d25fba42bfd229f8081 100644 (file)
--- a/source3/lib/tldap.c
+++ b/source3/lib/tldap.c
@@ -541,7 +541,7 @@ static void tldap_msg_sent(struct tevent_req *subreq)
        }
 
        if (!tldap_msg_set_pending(req)) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return;
        }
 }
@@ -1703,7 +1703,7 @@ static void tldap_search_done(struct tevent_req *subreq)
        case TLDAP_RES_SEARCH_ENTRY:
        case TLDAP_RES_SEARCH_REFERENCE:
                if (!tldap_msg_set_pending(subreq)) {
-                       tevent_req_nomem(NULL, req);
+                       tevent_req_oom(req);
                        return;
                }
                tevent_req_notify_callback(req);

diff --git a/source3/libsmb/async_smb.c b/source3/libsmb/async_smb.c
index 145e0aeb551220fee9cc841572334ae5ee76482b..ee15caee7a555c4da5525a021d78d2d0a999fe95 100644 (file)
--- a/source3/libsmb/async_smb.c
+++ b/source3/libsmb/async_smb.c
@@ -369,7 +369,7 @@ struct tevent_req *cli_smb_req_create(TALLOC_CTX *mem_ctx,
        if (cli->timeout) {
                endtime = timeval_current_ofs_msec(cli->timeout);
                if (!tevent_req_set_endtime(result, ev, endtime)) {
-                       tevent_req_nomem(NULL, result);
+                       tevent_req_oom(result);
                }
        }
        return result;

diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c
index a9a1847f1c9ebd79a44deb5dbd592f2eeb1f7121..62e3a35a3693605250d75cd69997d3a56ab5572b 100644 (file)
--- a/source3/libsmb/cliconnect.c
+++ b/source3/libsmb/cliconnect.c
@@ -1365,7 +1365,7 @@ static void cli_sesssetup_blob_done(struct tevent_req *subreq)
                 * More to send
                 */
                if (!cli_sesssetup_blob_next(state, &subreq)) {
-                       tevent_req_nomem(NULL, req);
+                       tevent_req_oom(req);
                        return;
                }
                tevent_req_set_callback(subreq, cli_sesssetup_blob_done, req);

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 8d843745d3486ca5cd41ce528b7fc295b6788a2e..dca740d3e6bb8d737c1d95ad2b82f411f33774c4 100644 (file)
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -1595,7 +1595,7 @@ static struct tevent_req *name_queries_send(
        if (!tevent_req_set_endtime(
                    subreq, state->ev,
                    timeval_current_ofs(0, state->timeout_msec * 1000))) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return tevent_req_post(req, ev);
        }
        tevent_req_set_callback(subreq, name_queries_done, req);
@@ -1678,7 +1678,7 @@ static void name_queries_next(struct tevent_req *subreq)
        if (!tevent_req_set_endtime(
                    subreq, state->ev,
                    timeval_current_ofs(0, state->timeout_msec * 1000))) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return;
        }
        state->subreqs[state->num_sent] = subreq;
@@ -1915,7 +1915,7 @@ static struct tevent_req *query_wins_list_send(
        }
        if (!tevent_req_set_endtime(subreq, state->ev,
                                    timeval_current_ofs(2, 0))) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return tevent_req_post(req, ev);
        }
        tevent_req_set_callback(subreq, query_wins_list_done, req);
@@ -1962,7 +1962,7 @@ static void query_wins_list_done(struct tevent_req *subreq)
        }
        if (!tevent_req_set_endtime(subreq, state->ev,
                                    timeval_current_ofs(2, 0))) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return;
        }
        tevent_req_set_callback(subreq, query_wins_list_done, req);

diff --git a/source3/torture/wbc_async.c b/source3/torture/wbc_async.c
index 182474c21670048019cab99097e2bcd0b65cb290..9252b58bc98a93ecccf778093bfdab1ed99dc66e 100644 (file)
--- a/source3/torture/wbc_async.c
+++ b/source3/torture/wbc_async.c
@@ -551,7 +551,7 @@ struct tevent_req *wb_trans_send(TALLOC_CTX *mem_ctx,
 
        if (!tevent_queue_add(wb_ctx->queue, ev, req, wb_trans_trigger,
                              NULL)) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return tevent_req_post(req, ev);
        }
        return req;

diff --git a/source3/winbindd/wb_lookupsids.c b/source3/winbindd/wb_lookupsids.c
index 92eee039ed9a076cab57bf63f3f31cefa440a71f..03b2ca9029b0c0e61a81c4c1fc1a419a2a1e15f2 100644 (file)
--- a/source3/winbindd/wb_lookupsids.c
+++ b/source3/winbindd/wb_lookupsids.c
@@ -481,7 +481,7 @@ static void wb_lookupsids_done(struct tevent_req *subreq)
                            &state->tmp_domains, &state->tmp_names.names[i],
                            state->res_domains, state->res_names,
                            res_sid_index)) {
-                       tevent_req_nomem(NULL, req);
+                       tevent_req_oom(req);
                        return;
                }
        }
@@ -544,7 +544,7 @@ static void wb_lookupsids_single_done(struct tevent_req *subreq)
                    &src_domains, &src_name,
                    state->res_domains, state->res_names,
                    res_sid_index)) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return;
        }
        state->single_sids_done += 1;
@@ -619,7 +619,7 @@ static void wb_lookupsids_lookuprids_done(struct tevent_req *subreq)
                            &src_domains, &src_name,
                            state->res_domains, state->res_names,
                            res_sid_index)) {
-                       tevent_req_nomem(NULL, req);
+                       tevent_req_oom(req);
                        return;
                }
        }

diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c
index 9f827375448cd397dac747899262ffa2e0c4dfb4..5bf90b122237207928d1b63354adc30a8acddf6e 100644 (file)
--- a/source3/winbindd/winbindd_dual.c
+++ b/source3/winbindd/winbindd_dual.c
@@ -127,7 +127,7 @@ struct tevent_req *wb_child_request_send(TALLOC_CTX *mem_ctx,
 
        if (!tevent_queue_add(child->queue, ev, req,
                              wb_child_request_trigger, NULL)) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return tevent_req_post(req, ev);
        }
        return req;

diff --git a/source3/winbindd/winbindd_dual_ndr.c b/source3/winbindd/winbindd_dual_ndr.c
index fb89c3f27fda29cfa5ef09407742bc225e8bed8e..f5f143f6126ba37733bee47d1e420eacb36138e9 100644 (file)
--- a/source3/winbindd/winbindd_dual_ndr.c
+++ b/source3/winbindd/winbindd_dual_ndr.c
@@ -144,7 +144,7 @@ static void wbint_bh_raw_call_done(struct tevent_req *subreq)
                state->response->extra_data.data,
                state->response->length - sizeof(struct winbindd_response));
        if (state->response->extra_data.data && !state->out_data.data) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return;
        }
 

diff --git a/source4/kdc/proxy.c b/source4/kdc/proxy.c
index 98db956f65e89c7493517039b22c9eca0ab9d3dc..324bfb8e2e1cececf8ec5025af43424da62d241e 100644 (file)
--- a/source4/kdc/proxy.c
+++ b/source4/kdc/proxy.c
@@ -556,7 +556,7 @@ static void kdc_tcp_proxy_read_pdu_done(struct tevent_req *subreq)
         */
        state->out = data_blob_talloc(state, raw.data + 4, raw.length - 4);
        if (state->out.length != raw.length - 4) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return;
        }
 

diff --git a/source4/ldap_server/ldap_server.c b/source4/ldap_server/ldap_server.c
index 2d45766b88f443bf78390fc4e2790d080e4a1066..411be294401a67b3b4567783a9fb9faae45d857f 100644 (file)
--- a/source4/ldap_server/ldap_server.c
+++ b/source4/ldap_server/ldap_server.c
@@ -708,7 +708,7 @@ static struct tevent_req *ldapsrv_process_call_send(TALLOC_CTX *mem_ctx,
        ok = tevent_queue_add(call_queue, ev, req,
                              ldapsrv_process_call_trigger, NULL);
        if (!ok) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return tevent_req_post(req, ev);
        }
 

diff --git a/source4/lib/messaging/messaging.c b/source4/lib/messaging/messaging.c
index 13fc188155f661707d69cb0fd933d8e0ed2cf1ce..484f22b2ee2a43312214fa80565ed385656c18a6 100644 (file)
--- a/source4/lib/messaging/messaging.c
+++ b/source4/lib/messaging/messaging.c
@@ -1178,7 +1178,7 @@ static void irpc_bh_raw_call_incoming_handler(struct irpc_request *irpc,
                m->ndr->data + m->ndr->offset,
                m->ndr->data_size - m->ndr->offset);
        if ((m->ndr->data_size - m->ndr->offset) > 0 && !state->out_data.data) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return;
        }
 

diff --git a/source4/libcli/wrepl/winsrepl.c b/source4/libcli/wrepl/winsrepl.c
index 72c040d3a16d64dd9aaeb1a781f2e374d2bfbf34..c7f1ad07cb8666884a995047f2539f456ee6a88e 100644 (file)
--- a/source4/libcli/wrepl/winsrepl.c
+++ b/source4/libcli/wrepl/winsrepl.c
@@ -201,7 +201,7 @@ struct tevent_req *wrepl_connect_send(TALLOC_CTX *mem_ctx,
                              wrepl_connect_trigger,
                              NULL);
        if (!ok) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return tevent_req_post(req, ev);
        }
 
@@ -382,7 +382,7 @@ struct tevent_req *wrepl_request_send(TALLOC_CTX *mem_ctx,
                              wrepl_request_trigger,
                              NULL);
        if (!ok) {
-               tevent_req_nomem(NULL, req);
+               tevent_req_oom(req);
                return tevent_req_post(req, ev);
        }