vfs_gpfs: Only clear sharemode on close when sharemode has been taken
authorChristof Schmitt <cs@samba.org>
Mon, 6 Jan 2020 21:14:17 +0000 (14:14 -0700)
committerJeremy Allison <jra@samba.org>
Wed, 8 Jan 2020 00:01:37 +0000 (00:01 +0000)
This avoids a redundant error message in case the call to acquire the
sharemode had failed before.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/modules/vfs_gpfs.c

index 2f949ec8c1bd4eff1bc0a256796f893044f4f2cd..760bb892ef97b91182e38da60ce9b5cf13d89590 100644 (file)
@@ -193,7 +193,7 @@ static int vfs_gpfs_close(vfs_handle_struct *handle, files_struct *fsp)
                                struct gpfs_config_data,
                                return -1);
 
-       if (config->sharemodes) {
+       if (config->sharemodes && fsp->kernel_share_modes_taken) {
                /*
                 * Always clear GPFS sharemode in case the actual
                 * close gets deferred due to outstanding POSIX locks