git.samba.org
/
amitay
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dd0837c
)
samba_abi.py: avoid inefficient string concatenations
author
Björn Jacke
<bj@sernet.de>
Sun, 25 Aug 2019 20:53:59 +0000
(22:53 +0200)
committer
Andrew Bartlett
<abartlet@samba.org>
Sat, 21 Sep 2019 19:33:25 +0000
(19:33 +0000)
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
buildtools/wafsamba/samba_abi.py
patch
|
blob
|
history
diff --git
a/buildtools/wafsamba/samba_abi.py
b/buildtools/wafsamba/samba_abi.py
index 5e7686da3d68b1ebcd842b8a319a5997fa9cf600..bf82fc5fe1fc806c1996e179a2682ca769109bb0 100644
(file)
--- a/
buildtools/wafsamba/samba_abi.py
+++ b/
buildtools/wafsamba/samba_abi.py
@@
-72,9
+72,7
@@
def parse_sigs(sigs, abi_match):
def save_sigs(sig_file, parsed_sigs):
'''save ABI signatures to a file'''
- sigs = ''
- for s in sorted(parsed_sigs.keys()):
- sigs += '%s: %s\n' % (s, parsed_sigs[s])
+ sigs = "".join('%s: %s\n' % (s, parsed_sigs[s]) for s in sorted(parsed_sigs.keys()))
return samba_utils.save_file(sig_file, sigs, create_dir=True)