s3:rpc_server: use make_session_info_guest() directly
authorStefan Metzmacher <metze@samba.org>
Fri, 29 Nov 2013 08:46:01 +0000 (09:46 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 10 Dec 2013 22:29:08 +0000 (11:29 +1300)
This removes the useless static auth_anonymous_session_info() wrapper.

auth_anonymous_session_info() is also a public function in source4.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
source3/rpc_server/rpc_server.c

index f283559dddd4e6d6966453abba1cba01938f64d4..680445a610ac6b2e1006e0269ab1d9af65e76989 100644 (file)
 #define SERVER_TCP_LOW_PORT  1024
 #define SERVER_TCP_HIGH_PORT 1300
 
-static NTSTATUS auth_anonymous_session_info(TALLOC_CTX *mem_ctx,
-                                           struct auth_session_info **session_info)
-{
-       NTSTATUS status;
-
-       status = make_session_info_guest(mem_ctx, session_info);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       return NT_STATUS_OK;
-}
-
 /* Creates a pipes_struct and initializes it with the information
  * sent from the client */
 int make_server_pipes_struct(TALLOC_CTX *mem_ctx,
@@ -1074,11 +1061,14 @@ void dcerpc_ncacn_accept(struct tevent_context *ev_ctx,
        }
 
        if (ncacn_conn->session_info == NULL) {
-               status = auth_anonymous_session_info(ncacn_conn,
-                                                    &ncacn_conn->session_info);
+               /*
+                * TODO: use auth_anonymous_session_info() here?
+                */
+               status = make_session_info_guest(ncacn_conn,
+                                                &ncacn_conn->session_info);
                if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(2, ("Failed to create "
-                                 "auth_anonymous_session_info - %s\n",
+                                 "make_session_info_guest - %s\n",
                                  nt_errstr(status)));
                        talloc_free(ncacn_conn);
                        return;