r4037: fixed a bunch of "might be uninitialised" warnings after enabling -O1 in my...
authorAndrew Tridgell <tridge@samba.org>
Thu, 2 Dec 2004 04:51:56 +0000 (04:51 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 18:06:16 +0000 (13:06 -0500)
(This used to be commit 0928b1f5b68c858922c3ea6c27ed03b5091c6221)

22 files changed:
source4/auth/auth_util.c
source4/client/client.c
source4/ldap_server/ldap_simple_ldb.c
source4/lib/dcom/common/main.c
source4/lib/registry/common/reg_interface.c
source4/lib/registry/reg_backend_w95/reg_backend_w95.c
source4/lib/registry/tools/regshell.c
source4/libcli/auth/ntlmssp_sign.c
source4/libcli/raw/clisession.c
source4/librpc/rpc/dcerpc_util.c
source4/ntvfs/posix/pvfs_resolve.c
source4/rpc_server/dcom/remact.c
source4/torture/basic/denytest.c
source4/torture/basic/locking.c
source4/torture/dcom/simple.c
source4/torture/raw/acls.c
source4/torture/raw/eas.c
source4/torture/raw/rename.c
source4/torture/raw/streams.c
source4/torture/rpc/samlogon.c
source4/torture/rpc/xplogin.c
source4/utils/net/net.c

index e929e59cc7f8eb7f9f0ecf5d3d63ac8154b75021..1ea7da467248ecfe7001746297323f619a99526b 100644 (file)
@@ -500,26 +500,28 @@ NTSTATUS make_server_info_netlogon_validation(TALLOC_CTX *mem_ctx,
                                              union netr_Validation *validation) 
 {
        NTSTATUS nt_status;
-       struct netr_SamBaseInfo *base;
+       struct netr_SamBaseInfo *base = NULL;
        switch (validation_level) {
-               case 2:
-                       if (!validation || !validation->sam2) {
-                               return NT_STATUS_INVALID_PARAMETER;
-                       }
-                       base = &validation->sam2->base;
+       case 2:
+               if (!validation || !validation->sam2) {
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+               base = &validation->sam2->base;
                break;
-               case 3:
-                       if (!validation || !validation->sam3) {
-                               return NT_STATUS_INVALID_PARAMETER;
-                       }
-                       base = &validation->sam3->base;
+       case 3:
+               if (!validation || !validation->sam3) {
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+               base = &validation->sam3->base;
                break;
-               case 6:
-                       if (!validation || !validation->sam6) {
-                               return NT_STATUS_INVALID_PARAMETER;
-                       }
-                       base = &validation->sam6->base;
+       case 6:
+               if (!validation || !validation->sam6) {
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+               base = &validation->sam6->base;
                break;
+       default:
+               return NT_STATUS_INVALID_LEVEL;
        }
 
        nt_status = make_server_info(mem_ctx, server_info, internal_username);
index b438e986cd15e760fc089c22d3afc774747e51f3..d9e995f1806eee5df129c3da7484b879e046d47f 100644 (file)
@@ -2671,7 +2671,7 @@ static char **completion_fn(const char *text, int start, int end)
                        return NULL;
        } else {
                char **matches;
-               int i, len, samelen, count=1;
+               int i, len, samelen = 0, count=1;
 
                matches = (char **)malloc(sizeof(matches[0])*MAX_COMPLETIONS);
                if (!matches) return NULL;
index 1b000f53eacca4d50735b2b15fb83286eaa65d3f..c33f04cafbb847c6192efb8605e45775092de3d4 100644 (file)
@@ -59,7 +59,7 @@ static NTSTATUS sldb_Search(struct ldapsrv_partition *partition, struct ldapsrv_
        int result = LDAP_SUCCESS;
        struct samdb_context *samdb;
        struct ldb_message **res;
-       int i, j, y, count;
+       int i, j, y, count = 0;
        enum ldb_scope scope = LDB_SCOPE_DEFAULT;
        const char **attrs = NULL;
        const char *errstr = NULL;
@@ -183,7 +183,7 @@ static NTSTATUS sldb_Add(struct ldapsrv_partition *partition, struct ldapsrv_cal
        struct ldapsrv_reply *add_reply;
        int ldb_ret;
        struct samdb_context *samdb;
-       struct ldb_message *msg;
+       struct ldb_message *msg = NULL;
        int result = LDAP_SUCCESS;
        const char *errstr = NULL;
        int i,j;
@@ -336,7 +336,7 @@ static NTSTATUS sldb_Modify(struct ldapsrv_partition *partition, struct ldapsrv_
        struct ldapsrv_reply *modify_reply;
        int ldb_ret;
        struct samdb_context *samdb;
-       struct ldb_message *msg;
+       struct ldb_message *msg = NULL;
        int result = LDAP_SUCCESS;
        const char *errstr = NULL;
        int i,j;
@@ -450,7 +450,7 @@ static NTSTATUS sldb_Compare(struct ldapsrv_partition *partition, struct ldapsrv
        struct ldb_message **res;
        const char *attrs[1];
        const char *errstr = NULL;
-       const char *filter;
+       const char *filter = NULL;
        int count;
 
        local_ctx = talloc_named(call, 0, "sldb_Compare local_memory_context");
@@ -517,7 +517,7 @@ NTSTATUS sldb_ModifyDN(struct ldapsrv_partition *partition, struct ldapsrv_call
        struct samdb_context *samdb;
        const char *errstr = NULL;
        int result = LDAP_SUCCESS;
-       const char *newdn;
+       const char *newdn = NULL;
        char *parentdn = NULL;
 
        local_ctx = talloc_named(call, 0, "sldb_ModifyDN local memory context");
index 61fd7d3ff763d601899ded594b6e021a5cde0d2b..09c5fd280c6f15eace1b749b381a711ecd002027 100644 (file)
@@ -209,7 +209,7 @@ static WERROR dcom_create_object_remote(struct dcom_context *ctx, struct GUID *c
 
 WERROR dcom_create_object(struct dcom_context *ctx, struct GUID *clsid, const char *server, int num_ifaces, struct GUID *iid, struct dcom_interface_p ***ip, WERROR *results)
 {
-       struct dcom_interface_p *factory, *iunk;
+       struct dcom_interface_p *factory, *iunk = NULL;
        struct QueryInterface qr;
        struct Release rr;
        struct CreateInstance cr;
index 77440cea0fe505ba0a7b4d14e1010ddda895f748..dea88617451d8a6579afd4de409b9d181d885556 100644 (file)
@@ -614,7 +614,7 @@ WERROR reg_key_get_parent(TALLOC_CTX *mem_ctx, struct registry_key *key, struct
 {
        char *parent_name;
        char *last;
-       struct registry_key *root;
+       struct registry_key *root = NULL;
        WERROR error;
 
        parent_name = strdup(key->path);
index fb73e9052c296c006066ce4e2cb90a4fddfd9497..445d13a99c16448519aaa91a096514f0b6a9eb09 100644 (file)
@@ -320,7 +320,7 @@ static WERROR w95_get_value_by_id(TALLOC_CTX *mem_ctx, struct registry_key *k, i
        DWORD i;
        DWORD offset = 0;
        RGDB_KEY *rgdb_key = LOCN_RGDB_KEY((CREG *)k->hive->backend_data, rgkn_key->id.rgdb, rgkn_key->id.id);
-       RGDB_VALUE *curval;
+       RGDB_VALUE *curval = NULL;
 
        if(!rgdb_key) return WERR_FOOBAR;
        
index 8d044f6fa2d641d7cbe02383e183bc1ab8c3700a..333329908887558d5debd9246418986b5b27401d 100644 (file)
@@ -245,7 +245,7 @@ static char **reg_complete_command(const char *text, int end)
 {
        /* Complete command */
        char **matches;
-       int i, len, samelen, count=1;
+       int i, len, samelen=0, count=1;
 
        matches = (char **)malloc(sizeof(matches[0])*MAX_COMPLETIONS);
        if (!matches) return NULL;
index e2f5237a882af7a93248451c4761f5a645824dfa..1b391306bceb6433153f111e53aaf644ed136522 100644 (file)
@@ -368,6 +368,8 @@ NTSTATUS ntlmssp_sign_init(struct ntlmssp_state *ntlmssp_state)
                        recv_sign_const = CLI_SIGN;
                        recv_seal_const = CLI_SEAL;
                        break;
+               default:
+                       return NT_STATUS_INTERNAL_ERROR;
                }
                
                /**
index b7802d8065cb212fbc3aca6b8e6e4e8efd287ad2..c92e3ecb0b963266d67d4095ea572b1965aca806 100644 (file)
@@ -393,7 +393,7 @@ static NTSTATUS smb_raw_session_setup_generic_spnego(struct smbcli_session *sess
        union smb_sesssetup s2;
        DATA_BLOB session_key = data_blob(NULL, 0);
        DATA_BLOB null_data_blob = data_blob(NULL, 0);
-       const char *chosen_oid;
+       const char *chosen_oid = NULL;
 
        s2.generic.level = RAW_SESSSETUP_SPNEGO;
        s2.spnego.in.bufsize = session->transport->options.max_xmit;
index b77c365858c19b787e9e4de06978725b9ab965f0..8c454ab64f2426ab4140319c52ceb07ce9634ad8 100644 (file)
@@ -602,7 +602,7 @@ NTSTATUS dcerpc_binding_from_tower(TALLOC_CTX *mem_ctx, struct epm_tower *tower,
 
 NTSTATUS dcerpc_binding_build_tower(TALLOC_CTX *mem_ctx, struct dcerpc_binding *binding, struct epm_tower *tower)
 {
-       const enum epm_protocols *protseq;
+       const enum epm_protocols *protseq = NULL;
        int num_protocols = -1, i;
        NTSTATUS status;
        
index 7329968d6c5270bf7d07e70b90d5b5b3e26886d3..7e7f49d0afdb50961b0addf98a2ac95d78f6f676 100644 (file)
@@ -546,8 +546,8 @@ NTSTATUS pvfs_resolve_partial(struct pvfs_state *pvfs, TALLOC_CTX *mem_ctx,
 NTSTATUS pvfs_resolve_name_fd(struct pvfs_state *pvfs, int fd,
                              struct pvfs_filename *name)
 {
-       dev_t device;
-       ino_t inode;
+       dev_t device = 0;
+       ino_t inode = 0;
 
        if (name->exists) {
                device = name->st.st_dev;
index ee16d2ce104d469e4c830004804c10c0b9d254b8..30e508d65ba5fa1add76e0f8e92988e883e0a4a8 100644 (file)
@@ -37,9 +37,9 @@ struct dcom_interface_pointer *dcom_interface_pointer_by_ipid(struct GUID *ipid)
 */
 static WERROR RemoteActivation(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx, struct RemoteActivation *r)
 {
-       struct CreateInstance *cr;
+       struct CreateInstance *cr = NULL;
        /*struct Release *ur;*/
-       struct dcom_interface_p *o;
+       struct dcom_interface_p *o = NULL;
        int i;
 
        /* FIXME: CoGetClassObject() */
index 70d7a2b2a14b1d49f2df054284611496f4045606..7979778c3f2229bb637472de03f8e9b5c842502c 100644 (file)
@@ -1968,7 +1968,7 @@ BOOL torture_denydos_sharing(void)
        union smb_fileinfo finfo;
        const char *fname = "\\torture_denydos.txt";
        NTSTATUS status;
-       int fnum1, fnum2;
+       int fnum1 = -1, fnum2 = -1;
        BOOL ret = True;
        union smb_setfileinfo sfinfo;
        TALLOC_CTX *mem_ctx;
index c1dd598018e0a3e0d861fb18d2a229dd1a503c6f..ba7d5687060e128f6f05d7ac155c7d0705cb1e88 100644 (file)
@@ -790,7 +790,7 @@ BOOL torture_locktest7(void)
        struct smbcli_state *cli1;
        const char *fname = "\\lockt7.lck";
        int fnum1;
-       int fnum2;
+       int fnum2 = -1;
        size_t size;
        char buf[200];
        BOOL correct = False;
index 68bf9be813f8859377342a015f2f28bb378088b8..9dd750baad12aa563966a6f27e3e6ce533b41d30 100644 (file)
@@ -29,7 +29,7 @@
 BOOL torture_dcom_simple(void)
 {
        NTSTATUS status;
-       struct dcerpc_pipe *p;
+       struct dcerpc_pipe *p = NULL;
        TALLOC_CTX *mem_ctx;
        BOOL ret = True;
        struct GUID IID[2];
index 84d2238a9e986176463ce31c642fbf80d16beca6..24f18e6ccec3b2f207c8d9b1c20fd207845f16af 100644 (file)
@@ -41,7 +41,7 @@ static BOOL test_sd(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        union smb_open io;
        const char *fname = BASEDIR "\\sd.txt";
        BOOL ret = True;
-       int fnum;
+       int fnum = -1;
        union smb_fileinfo q;
        union smb_setfileinfo set;
        struct security_ace ace;
@@ -249,7 +249,7 @@ static BOOL test_creator_sid(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        union smb_open io;
        const char *fname = BASEDIR "\\creator.txt";
        BOOL ret = True;
-       int fnum;
+       int fnum = -1;
        union smb_fileinfo q;
        union smb_setfileinfo set;
        struct security_descriptor *sd, *sd_orig, *sd2;
@@ -323,7 +323,7 @@ static BOOL test_creator_sid(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
 
        printf("set a sec desc allowing no write by owner\n");
        sd = security_descriptor_create(mem_ctx,
-                                       NULL, NULL,
+                                       owner_sid, NULL,
                                        owner_sid,
                                        SEC_ACE_TYPE_ACCESS_ALLOWED,
                                        SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
@@ -440,7 +440,7 @@ static BOOL test_generic_bits(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        union smb_open io;
        const char *fname = BASEDIR "\\generic.txt";
        BOOL ret = True;
-       int fnum, i;
+       int fnum = -1, i;
        union smb_fileinfo q;
        union smb_setfileinfo set;
        struct security_descriptor *sd, *sd_orig, *sd2;
index 13ebea2401b762a0befb730947da2b5bb5dec896..044fe9ebb4f492f949b42db77f7757856aedb3a3 100644 (file)
@@ -99,7 +99,7 @@ static BOOL test_eas(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        union smb_open io;
        const char *fname = BASEDIR "\\ea.txt";
        BOOL ret = True;
-       int fnum;
+       int fnum = -1;
 
        printf("TESTING SETFILEINFO EA_SET\n");
 
index 6b1661269876da682a2144909f14635768cec8f6..c839100e7cbe1d364171dcfdd9b0f32de6e18731 100644 (file)
@@ -46,7 +46,7 @@ static BOOL test_mv(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        union smb_rename io;
        NTSTATUS status;
        BOOL ret = True;
-       int fnum;
+       int fnum = -1;
        const char *fname1 = BASEDIR "\\test1.txt";
        const char *fname2 = BASEDIR "\\test2.txt";
        union smb_open op;
index 83ba08ee0afc221a458f5ad580a4ff711b023cd5..7053f6c99844baf4df8c57d330af377a5ef6d483 100644 (file)
@@ -99,7 +99,7 @@ static BOOL test_stream_io(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
        const char *fname = BASEDIR "\\stream.txt";
        const char *sname1, *sname2;
        BOOL ret = True;
-       int fnum;
+       int fnum = -1;
        ssize_t retsize;
 
        sname1 = talloc_asprintf(mem_ctx, "%s:%s", fname, "Stream One");
index e7c04b6ad13e778df01c36a6f564e32165d1f72b..821a8235950f438279abd2fc25d21d9008731eac 100644 (file)
@@ -72,10 +72,8 @@ static NTSTATUS check_samlogon(struct samlogon_state *samlogon_state,
        struct netr_LogonSamLogonEx *r_ex = &samlogon_state->r_ex;
        struct netr_LogonSamLogonWithFlags *r_flags = &samlogon_state->r_flags;
        struct netr_NetworkInfo ninfo;
-       
-       struct netr_SamBaseInfo *base;
-
-       uint16 validation_level;
+       struct netr_SamBaseInfo *base = NULL;
+       uint16 validation_level = 0;
        
        samlogon_state->r.in.logon.network = &ninfo;
        samlogon_state->r_ex.in.logon.network = &ninfo;
index 8b7ccf115dfe9aa771275b6c8a9dc45493c22d34..0007955e081c900f20fbe25c3bd641a0839f50db 100644 (file)
@@ -775,7 +775,7 @@ static NTSTATUS test_getallsids(struct smbcli_transport *transport,
        struct samr_Connect4 r4;
        struct policy_handle connect_handle, user_handle;
        struct policy_handle builtin_handle, domain_handle;
-       struct dom_sid *domain_sid;
+       struct dom_sid *domain_sid = NULL;
 
        struct dom_sid *user_sid;
        struct dom_sid *primary_group_sid;
index ac427c49353f1a2a33ef45bff4d3f64ce6366209..199f0429d6f0584017793b7fa465d50089847333 100644 (file)
@@ -159,7 +159,7 @@ static int binary_net(int argc, const char **argv)
        int argc_new;
        const char **argv_new;
        TALLOC_CTX *mem_ctx;
-       struct net_context *ctx;
+       struct net_context *ctx = NULL;
        poptContext pc;
        struct poptOption long_options[] = {
                POPT_AUTOHELP