vlendec/samba-autobuild/.git
15 years agos3: Fix 'net rpc join' for users with the SeMachineAccountPrivilege. samba-3.2.8
Volker Lendecke [Tue, 3 Feb 2009 13:41:49 +0000 (14:41 +0100)]
s3: Fix 'net rpc join' for users with the SeMachineAccountPrivilege.

This used to be commit fda8abac in master.
(cherry picked from commit 8ddb30ca90d31624ba86cd731f573aedad43face)

15 years agoWHATSNEW: Update changes since 3.2.7.
Karolin Seeger [Tue, 3 Feb 2009 13:49:08 +0000 (14:49 +0100)]
WHATSNEW: Update changes since 3.2.7.

Karolin
(cherry picked from commit 11c966b7bc30b17de1bb360f405f6cb956dd5c83)

15 years agoWHATSNEW: Update changes since 3.2.7.
Karolin Seeger [Tue, 3 Feb 2009 08:48:40 +0000 (09:48 +0100)]
WHATSNEW: Update changes since 3.2.7.

Karolin
(cherry picked from commit c415b6a48dae2809d5d60b0af23eb7781f1146db)

15 years agoAdjust regex to match variable names including underscores
Lars Müller [Mon, 2 Feb 2009 20:38:38 +0000 (21:38 +0100)]
Adjust regex to match variable names including underscores

This is required to get the CIFSUPCALL_PROGS setting extracted from
config.log.
(cherry picked from commit 1c3313dea793a7eea72afb990da125f6c2a8444c)

15 years agoConditional install of the cifs.upcall man page
Lars Müller [Mon, 2 Feb 2009 20:12:52 +0000 (21:12 +0100)]
Conditional install of the cifs.upcall man page

Only install the cifs.upcall man page if CIFSUPCALL_PROGS was set while
configure.
(cherry picked from commit b44b29e5d9047f79202fa8fb3ca0eb86b2a98090)

15 years agodocs: Describe "service" in man mount.cifs.
Karolin Seeger [Mon, 2 Feb 2009 10:46:39 +0000 (11:46 +0100)]
docs: Describe "service" in man mount.cifs.

This fixes bug #5346.
Thanks to the Debian Samba package maintainers for reporting and providing a
patch!

Karolin
(cherry picked from commit 73f4fc1f802f31459b70dba4777d142d00fcdd92)
(cherry picked from commit ab4768452811e67f6606253b5a79101184f777d0)
(cherry picked from commit 876b0b001976226a7c1887570c08178d72842a48)

15 years agoWHATSNEW: Update changes since 3.2.7.
Karolin Seeger [Mon, 2 Feb 2009 09:13:38 +0000 (10:13 +0100)]
WHATSNEW: Update changes since 3.2.7.

Karolin
(cherry picked from commit e6c46844b2bbc34a8f87ba438f5cc16fcc12d095)

15 years agofix build with external dns_sd libraries
Björn Jacke [Sun, 1 Feb 2009 02:22:41 +0000 (03:22 +0100)]
fix build with external dns_sd libraries

This used to be commit 16f07280 in master.
(cherry picked from commit 89919a131b234485564ff2f2f20e3d9f9eb83522)
(cherry picked from commit 5d76e219ab4856a5c72835eebf48d5dd1cf0e01e)

15 years agos3-docs: fix typo in eventlogadm manpage.
Günther Deschner [Thu, 22 Jan 2009 18:31:22 +0000 (19:31 +0100)]
s3-docs: fix typo in eventlogadm manpage.

Guenther
(cherry picked from commit fb7b92abc2bea4b3d91cdd896f02db88065a4b8f)
(cherry picked from commit 0cc588ac53316299d2e1ff7d61947fd864d412f9)
(cherry picked from commit a0d32cbc36a52bcd6b9b542919edee72ce95acdf)

15 years agoadd Tru64 sub-second resolution timestamp support
Björn Jacke [Thu, 29 Jan 2009 21:59:00 +0000 (22:59 +0100)]
add Tru64 sub-second resolution timestamp support
(cherry picked from commit ce440096473d4db0e43f65ced6c2084a5bdbabc6)

15 years agoadd configure check for Tru64 sub-second timestamp resolution
Björn Jacke [Thu, 29 Jan 2009 20:59:44 +0000 (21:59 +0100)]
add configure check for Tru64 sub-second timestamp resolution
(cherry picked from commit bbfe82768add789a98ce3711fb5f378d19363401)

15 years agoadd missing semicolons
Björn Jacke [Thu, 29 Jan 2009 19:56:51 +0000 (20:56 +0100)]
add missing semicolons

the fixed configure check led to a missing semicolon in the now activated BSD
code. Then this error was even copypasted into the new AIX code. grrr
(cherry picked from commit 5e4f6639e7ed96f3457177d203283c1c55ec52dd)

15 years agoFollowing Björn JACKE's patch, unify the detection of the timespec code in configure...
Jeremy Allison [Thu, 29 Jan 2009 18:47:02 +0000 (10:47 -0800)]
Following Björn JACKE's patch, unify the detection of the timespec code in configure.in, and the application of it in time.c
Jeremy.
(cherry picked from commit d7c7acee813b3cd9649b381a3e63c0be56e67d29)

15 years agoadd configure check for AIX style sub-second resolution support
Björn Jacke [Wed, 28 Jan 2009 23:33:19 +0000 (00:33 +0100)]
add configure check for AIX style sub-second resolution support
(cherry picked from commit e0381d6a173dcf64910ac597a10a3f0fa59ffe43)

15 years agorather cosmetic fix for failed birthtime configure checks
Björn Jacke [Wed, 28 Jan 2009 23:20:00 +0000 (00:20 +0100)]
rather cosmetic fix for failed birthtime configure checks
(cherry picked from commit ca155297bf932df6fd4a0ff223e5a7f1b8340f6b)

15 years agogive configure check "sub-second timestamps without struct timespec" a chance to...
Björn Jacke [Wed, 28 Jan 2009 23:17:12 +0000 (00:17 +0100)]
give configure check "sub-second timestamps without struct timespec" a chance to succeed
(cherry picked from commit 772dcc3b3703507af6baee090602a0ae8633fe2f)

15 years agoWHATSNEW: Update changes since 3.2.7.
Karolin Seeger [Thu, 29 Jan 2009 07:42:55 +0000 (08:42 +0100)]
WHATSNEW: Update changes since 3.2.7.

Karolin
(cherry picked from commit 31ea6bbc4a964604377509d3c096bae647c614a2)

15 years agoUse talloc_tos() instead of the talloc NULL context.
Andreas Schneider [Wed, 14 Jan 2009 11:11:36 +0000 (12:11 +0100)]
Use talloc_tos() instead of the talloc NULL context.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
(cherry picked from commit ef76b71683f3d420fa8062bc5364493c44ab68ce)

15 years agoAvoid valgrind errors
Volker Lendecke [Wed, 28 Jan 2009 09:35:35 +0000 (10:35 +0100)]
Avoid valgrind errors

In event handlers, we might destroy other events that are pending in the lists.
We can only run one event safely per select call.

Yes, I've seen these valgrind errors :-)

Jeremy, with ccdd921e61 you had checked in the change to run multiple events.
Do you remember why it was necessary and could not be solved in a different
way?

Volker
(cherry picked from commit 077e0ed31315242c571ccd9e9579f53aac0dbbc7)

15 years agoFix a valgrind error when the socket dies
Volker Lendecke [Tue, 27 Jan 2009 18:41:34 +0000 (19:41 +0100)]
Fix a valgrind error when the socket dies

Don't reference anything that might have been deleted in the async_req_error
call.
(cherry picked from commit 8e7d0cf27cf9eb18be497d13bd0dbbe1d76b97a0)

15 years agoVERSION: Raise version number up to 3.2.8.
Karolin Seeger [Wed, 28 Jan 2009 11:06:02 +0000 (12:06 +0100)]
VERSION: Raise version number up to 3.2.8.

Karolin
(cherry picked from commit a8eb8de94f5bfe4de000c5e85a43469af555a717)

15 years agoWHATSNEW: Prepare WHATSNEW for 3.2.8.
Karolin Seeger [Wed, 28 Jan 2009 10:34:15 +0000 (11:34 +0100)]
WHATSNEW: Prepare WHATSNEW for 3.2.8.

Karolin
(cherry picked from commit c21720a3c47748dcbf04d94377c36c47262c4953)

15 years agoFix usrmgr opening a user object as non-root.
Jeremy Allison [Wed, 10 Dec 2008 23:22:02 +0000 (15:22 -0800)]
Fix usrmgr opening a user object as non-root.
Jeremy.
(cherry picked from commit 239a2d0ac6f1b56d67d7fffdb7388a3008eeb4e2)

15 years agoMake the LookupRid access check match LookupName until
Jeremy Allison [Thu, 11 Dec 2008 01:04:45 +0000 (17:04 -0800)]
Make the LookupRid access check match LookupName until
we know the correct bits to use here.
Jeremy.
(cherry picked from commit 1497c6964767d6d73d6c1c1f6bbbeff2f05b35bc)

15 years agoSamba3-HOWTO: Fix usage of 'net idmap restore'.
Karolin Seeger [Thu, 11 Dec 2008 17:08:29 +0000 (18:08 +0100)]
Samba3-HOWTO: Fix usage of 'net idmap restore'.

This fixes bug #5883.

Karolin
(cherry picked from commit b4a4e635246b88277b235fa343eda48bd4bb4ce3)
(cherry picked from commit 5744177740120524740db884564142df19358ae7)
(cherry picked from commit 7584fe4e8bcbaf73f509d6981a70ff9dde92db1c)
(cherry picked from commit fda3f00246c3ecb664d2bf387ecd0e28dec16e34)
(cherry picked from commit e4ae4becbe5ea1454d15f0fb2d6cd4fe7e8edfd7)

15 years agoFix detection of dns_sd libraries.
Jeremy Allison [Wed, 28 Jan 2009 00:21:04 +0000 (16:21 -0800)]
Fix detection of dns_sd libraries.
Jeremy.
(cherry picked from commit e0c56d65f4096cdbcf9e560309e71fc21faa7d9a)

15 years agolibreplace: fix detection of netinet/ip.h on solaris 8
Michael Adam [Tue, 27 Jan 2009 14:48:20 +0000 (15:48 +0100)]
libreplace: fix detection of netinet/ip.h on solaris 8

(The test needs to additionally include <netinet/in_systm.h>.)

Michael
(cherry picked from commit a223b096700bc54b446a0e152c842b088566720b)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit ac4d07ef8300a2b571296b8b3f7c23e8850b526a)

15 years agolibreplace: fix bug #6066 - netinet/ip.h present but cannot be compiled
Michael Adam [Tue, 27 Jan 2009 11:13:55 +0000 (12:13 +0100)]
libreplace: fix bug #6066 - netinet/ip.h present but cannot be compiled

under solaris

Michael
(cherry picked from commit 1b7beaed69823b3c401bc4c0b1c502b671169168)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 74534203b5b91445cd8ae4cd7f2a0d35ea73a281)

15 years agoDocument default of the printing config variable.
Andreas Schneider [Mon, 26 Jan 2009 13:38:34 +0000 (14:38 +0100)]
Document default of the printing config variable.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
(cherry picked from commit d8f15e4efc00b9d509ff5761e9ca8ff5c6f443f7)
(cherry picked from commit 541704e253f06f8b33006b6c27f51b934c2eb51f)
(cherry picked from commit 69880dac28ac1681bb0c3d84280494de3d788cc6)
(cherry picked from commit c2d30b0a8e3609854908aeff19174e8e4e291cb7)

15 years agodocs: Add manpage for vfs_shadow_copy2.
Karolin Seeger [Mon, 26 Jan 2009 13:17:23 +0000 (14:17 +0100)]
docs: Add manpage for vfs_shadow_copy2.

Karolin
(cherry picked from commit 512cf0ad50d30fcb35a28b0ef1b859d754f42a99)
(cherry picked from commit 7ca4b8ec65d5f8794c58f27f3f17033143732897)
(cherry picked from commit addd0f41eeaf255217f1ab156e970c41a929aa43)
(cherry picked from commit a09ca37c438f31133943238b15c63a5834226c73)

15 years agos3-eventlog: fix various invalid memcpy in read_package_entry().
Günther Deschner [Sat, 24 Jan 2009 01:10:47 +0000 (02:10 +0100)]
s3-eventlog: fix various invalid memcpy in read_package_entry().

Guenther
(cherry picked from commit 75fff603625e0259f187e0fa47efd85887092fae)
(cherry picked from commit a691e29b466fdf1776160d92704e1ca958fa9eee)

15 years agos3-eventlog: fix buffer allocation in eventlog read call.
Günther Deschner [Sat, 24 Jan 2009 01:07:40 +0000 (02:07 +0100)]
s3-eventlog: fix buffer allocation in eventlog read call.

This broke with f6fa3080fee1b20df9f1968500840a88cf0ee592 back in April 2007...

Guenther
(cherry picked from commit 547c70e896b6890dd5f7b911e4e0ca107c8a3fa3)
(cherry picked from commit 632f4b83158d46ae456713286a27ac0c2aa2ee25)

15 years agodocs: Fix formatting issue in man libsmbclient.
Karolin Seeger [Fri, 23 Jan 2009 12:02:46 +0000 (13:02 +0100)]
docs: Fix formatting issue in man libsmbclient.

Karolin
(cherry picked from commit aa2fb0efb7ce2bc732569b4baf20c57375fdce59)
(cherry picked from commit e1e3a0554fcaabacc5bec51c213622271a83ad04)
(cherry picked from commit 84237fb48aad5f11789d75a6767a6f47465f140b)

15 years agolib/replace: add defines to let the callers find out if pwrite and pread are thread...
Stefan Metzmacher [Thu, 22 Jan 2009 10:52:54 +0000 (11:52 +0100)]
lib/replace: add defines to let the callers find out if pwrite and pread are thread/fork safe

metze
(cherry picked from commit 7fc7ee9331d0539359ad88c527f59d5fdf212209)
(cherry picked from commit d74b63091781e442e42b1fa7881e903a0bcc928c)
(cherry picked from commit 9483b143fe473d374e7f5c71f0d497f28f4e69f7)

15 years agoApply same logic fix for #4308 Excel save operation corrupts file ACLs
Jeremy Allison [Fri, 23 Jan 2009 00:25:30 +0000 (16:25 -0800)]
Apply same logic fix for #4308 Excel save operation corrupts file ACLs
to NFSv4 ACL code as this uses the same flawed logic as posix_acls.c.
Jeremy.
(cherry picked from commit 7b994fc658ad175bc40af9e38a8f1b870276d980)

15 years agoFix logic error in try_chown - we shouldn't arbitrarily chown
Jeremy Allison [Fri, 23 Jan 2009 00:10:36 +0000 (16:10 -0800)]
Fix logic error in try_chown - we shouldn't arbitrarily chown
to ourselves unless that was passed in.
Jeremy.
(cherry picked from commit d04d93f783533612e20326b7b6ea5958eb5fcdc6)

15 years agoSecond part of the attemt to fix #4308 - Excel save operation corrupts file ACLs.
Jeremy Allison [Thu, 22 Jan 2009 22:32:44 +0000 (14:32 -0800)]
Second part of the attemt to fix #4308 - Excel save operation corrupts file ACLs.
If the chown succeeds then the ACL set should also. Ensure this is the case
(refactor some of this code to make it simpler to read also).
Jeremy.
(cherry picked from commit 7e38054a94d3feacda9c249549d2721a4ee0b261)

15 years agoAnother attempt to fix bug #4308 - Excel save operation corrupts file ACLs.
Jeremy Allison [Thu, 22 Jan 2009 18:59:47 +0000 (10:59 -0800)]
Another attempt to fix bug #4308 - Excel save operation corrupts file ACLs.
Simo is completely correct. We should be doing the chown *first*, and fail the
ACL set if this fails. The long standing assumption I made when writing the
initial POSIX ACL code was that Windows didn't control who could chown a file
in the same was as POSIX. In POSIX only root can do this whereas I wasn't sure
who could do this in Windows at the time (I didn't understand the privilege
model). So the assumption was that setting the ACL was more important (early
tests showed many failed ACL set's due to inability to chown). But now we have
privileges in smbd, and we must always fail an ACL set when we can't chown
first. The key that Simo noticed is that the CREATOR_OWNER bits in the ACL
incoming are relative to the *new* owner, not the old one. This is why the old
user owner disappears on ACL set - their access was set via the USER_OBJ in the
creator POSIX ACL and when the ownership changes they lose their access.

Patch is simple - just ensure we do the chown first before evaluating the
incoming ACL re-read the owners. We already have code to do this it just wasn't
rigorously being applied.
Jeremy.
(cherry picked from commit 9c3da895e6dd5df2f4e3377e1bf562b376436081)

15 years agobuild-docs: cleanup exit of the script
Michael Adam [Wed, 21 Jan 2009 14:10:10 +0000 (15:10 +0100)]
build-docs: cleanup exit of the script

exit in the directory where it was called using pushd/popd.

Michael
(cherry picked from commit b319549f129b1c79afc9bfd4a84f2730b96d69a3)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 0ee05c012e5f58c9132549c59cfd1ed74dd27759)

15 years agos3:docs: clean build/catalog.xml in "make clean"
Michael Adam [Wed, 21 Jan 2009 14:09:46 +0000 (15:09 +0100)]
s3:docs: clean build/catalog.xml in "make clean"

Michael
(cherry picked from commit 5e21fc3506f2ba7b1135b1acad2697dfb86b5df0)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit c421d57e69de4d8c135123ed9f78dc9712bc7b3d)

15 years agos3:docs: clean generated .png images in "make clean"
Michael Adam [Wed, 21 Jan 2009 14:09:12 +0000 (15:09 +0100)]
s3:docs: clean generated .png images in "make clean"

Michael
(cherry picked from commit 9b32e839bec8611c30745607a3a6b124d5b34c01)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit bd3bb83824803c5301201f7fa2703a52971eae8f)

15 years agos3:docs: fix ommission in fix of (real)distclean targets
Michael Adam [Wed, 21 Jan 2009 10:47:46 +0000 (11:47 +0100)]
s3:docs: fix ommission in fix of (real)distclean targets

Michael
(cherry picked from commit 37412017c5dd2f05a7f4bbe0410a6e00ce4805e5)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit f3d355ffa75cd2b0f8cc51189e80aaf3552766d0)

15 years agos3:docs: fix distclean target and add realdistclean target
Michael Adam [Wed, 21 Jan 2009 10:41:14 +0000 (11:41 +0100)]
s3:docs: fix distclean target and add realdistclean target

- remove stuff created by configure in distclean
- remove stuff created by autoconf in realdistclean

Michael
(cherry picked from commit 65c92fea3d18c3520ff2a1e53a0c5c8825c9788f)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 410acb0410ce3c33da15dbefd0b59e971494d2fb)

15 years agoDepend on latexfigures files directly as using a rule in between causes problems.
Jelmer Vernooij [Tue, 27 May 2008 16:40:14 +0000 (18:40 +0200)]
Depend on latexfigures files directly as using a rule in between causes problems.
(This used to be commit bf3c2773f94c1db29a8a3e5935ff587f16f9a905)
(cherry picked from commit 5f6d0078d41e790ab4fa7dac15294821cdb4d4f0)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit d2e79f3e54cf1762df2ef814af90dcb16cb8e859)

15 years agoUse double colon targets.
Jelmer Vernooij [Wed, 21 May 2008 15:55:20 +0000 (17:55 +0200)]
Use double colon targets.
(This used to be commit 825cf91fa8b30a67d04cbda8885ff62a4c26458f)
(cherry picked from commit 323be4a6907e4915bb76aa103bf5b868f0b459b1)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit fe3680cb7ab54142d589c89789af73a3e32a6b79)

15 years agoAdd test target in Makefile.
Jelmer Vernooij [Fri, 16 May 2008 13:46:36 +0000 (15:46 +0200)]
Add test target in Makefile.
(This used to be commit ac0d768676b1b8105a9141169b1afa248df6ce66)
(cherry picked from commit 0f3ba4b766ed83d2a38e6cae8db8690374d88989)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit d5f74cfc4434d754afc9fdd746c2a575ebdd3641)

15 years agoMake the make output a bit less chatty.
Jelmer Vernooij [Fri, 16 May 2008 13:31:54 +0000 (15:31 +0200)]
Make the make output a bit less chatty.
(This used to be commit 1fa4ef553c437bae07389c0f6a5410ba22ee4905)
(cherry picked from commit 70f52c06ba1d0d9638f1dfb8c42cd0d70364e9df)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 299f1ae3f335ce99cb9b5d477e0950a4108f80cb)

15 years agobuild_docs: Use 'make distclean' instead of 'make clean'.
Karolin Seeger [Wed, 21 Jan 2009 10:37:30 +0000 (11:37 +0100)]
build_docs: Use 'make distclean' instead of 'make clean'.

This fixes bug #6058.
Thanks to Christian Perrier for reporting!

Karolin
(cherry picked from commit 162e4b66601b41dd5adb24e192f3b5a91dfb41cc)
(cherry picked from commit 2545fcc48888628eef2d6b83ef5656be1e53bf7e)

15 years agoFix mistake in DEBUG message
Richard Sharpe [Tue, 20 Jan 2009 02:11:04 +0000 (18:11 -0800)]
Fix  mistake in DEBUG message
(cherry picked from commit e9de9cd33a3260c0b1b019208db9c3f96d9d5f3a)

15 years agoAvoid flooding of syslog with failing pam_putenv messages.
Andreas Schneider [Mon, 19 Jan 2009 15:26:07 +0000 (16:26 +0100)]
Avoid flooding of syslog with failing pam_putenv messages.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 5db09d4dd27e10c926c3413bcd3088e72a4af487)

15 years agoS3-ByExample: Use 'winbindd -D' instead of 'winbindd -B'.
Karolin Seeger [Mon, 19 Jan 2009 09:22:46 +0000 (10:22 +0100)]
S3-ByExample: Use 'winbindd -D' instead of 'winbindd -B'.

The option '-B' does not exist at all.

Thanks to Jason Ellison for reporting!

Karolin
(cherry picked from commit 4b26c7bbf4fe93f5ffb92d3f04012be290be25be)
(cherry picked from commit 05c7d97e6cf25c05ba6a661c0a31c88946ffd5cd)
(cherry picked from commit f89c3db4ae0bcf1680c2532833ee115005b8ed70)

15 years agoS3-HowTo: Change 'winbindd -B' to 'winbindd -D'.
Karolin Seeger [Mon, 19 Jan 2009 07:55:30 +0000 (08:55 +0100)]
S3-HowTo: Change 'winbindd -B' to 'winbindd -D'.

There is no option '-B' at all.

Thanks to Jason Ellison for reporting!

Karolin
(cherry picked from commit 7c1e08518bfbe054db270e72476c642d5db93c0a)
(cherry picked from commit 3b5d2fd4cc5f7cbe22be1dfc593ca4ba29197b66)
(cherry picked from commit 0900b10f64fbb9f2e55591d1b11be9bb29526744)

15 years agos3:docs: vfs_fileid manpage
Stefan Metzmacher [Wed, 14 Jan 2009 10:52:01 +0000 (11:52 +0100)]
s3:docs: vfs_fileid manpage

metze
(cherry picked from commit 6a94b7b9270f3d69595b93e2632051c9842645c9)
(cherry picked from commit 8e13be1db5c51002ae72c42c505a79406b2f4f63)
(cherry picked from commit 652151fe7b0a48b5ae6272a088ce80ad428f1928)

15 years agos3:vfs_fileid: readd "fileid:algorithm" as option.
Stefan Metzmacher [Wed, 14 Jan 2009 12:59:09 +0000 (13:59 +0100)]
s3:vfs_fileid: readd "fileid:algorithm" as option.

"fileid:mapping" is still supported as fallback.

metze
(cherry picked from commit 554a89df0cf6d9832778e2913f9fe50b78baeedc)
(cherry picked from commit fe9ad21b8cb5286845350fe2280da2cbe2647bb7)
(cherry picked from commit 3c56cd9f701254dec33aa60b6f6b3fa90a28557a)

15 years agokeep compatibility with v3-0-ctdb name for fileid:mapping option
Andrew Tridgell [Mon, 21 Apr 2008 16:40:45 +0000 (18:40 +0200)]
keep compatibility with v3-0-ctdb name for fileid:mapping option
(cherry picked from commit 2856d2e4a43fbcc6c8f8ac7b1613828170362861)
(cherry picked from commit 174b595bb171c32be9079f9f691b415ac0fdc635)

15 years agoDetermine case sensitivity based on file system attributes.
Derrell Lipman [Sat, 17 Jan 2009 18:35:12 +0000 (13:35 -0500)]
Determine case sensitivity based on file system attributes.

- Most of the time, we can determine from the file system we're connecting to
  whether it supports case sensitivity. In those cases, we now set the
  internal case sensitivity flag automatically. For those cases where the
  request to retrieve file system attributes fails, we'll use the
  user-specified option value.

Derrell
(cherry picked from commit ded86426c222b11b9c2e8d8e4cae5ed0eff19edd)

15 years ago[Bug 6022] smbc_urlencode and smbc_urldecode were not exported
Derrell Lipman [Sat, 17 Jan 2009 01:29:28 +0000 (20:29 -0500)]
[Bug 6022] smbc_urlencode and smbc_urldecode were not exported

- Since the revamp of libsmbclient, there has still been an external
  declaration for smbc_urlencode and smbc_urldecode in libsmbclient.h, yet
  those functions were renamed and made private. The two choices were to
  remove the function names from libsmbclient.h or to make them public
  again. The reported requested that they be public. This commit makes it so.

Derrell
(cherry picked from commit 91d30b8a3406d01b5fca97a96ad5964703813f0e)

15 years agoTreat file names in POSIX-like case-sensitive fashion by default
Derrell Lipman [Fri, 16 Jan 2009 21:00:41 +0000 (16:00 -0500)]
Treat file names in POSIX-like case-sensitive fashion by default

*** THIS COMMIT CAUSES A CHANGE OF DEFAULT BEHAVIOR IN libsmbclient!!! ***

- libsmbclient now calls cli_set_case_sensitive() for a new CLI. By default,
  it requests case-sensitive, but the old behavior of case-insensitive can be
  requested with smbc_setOptionCaseSensitive(context, False);

  The change of behavior is considered a bug fix, as it was previously
  possible to accidentally overwrite a file that had the same case-insensitive
  name but a different case-sensitive name as a previously-existing file,
  while creating a new file.

Derrell
(cherry picked from commit ac4baafeb8d74bf1db7f2ce84b2bc3abdef90337)

15 years agoFix a segfault if ? is there but the options are NULL. This is the case if SMBC_parse...
Andreas Schneider [Fri, 16 Jan 2009 20:23:00 +0000 (12:23 -0800)]
Fix a segfault if ? is there but the options are NULL. This is the case if SMBC_parse_path is called by SMBC_stat_ctx.
(cherry picked from commit d9f66f3e3d9af9c3323029207e62391f382632e9)

15 years ago"First thing, kill all the language lawyers" :-). Ensure possible insane compilers
Jeremy Allison [Fri, 16 Jan 2009 19:55:40 +0000 (11:55 -0800)]
"First thing, kill all the language lawyers" :-). Ensure possible insane compilers
can't kill us later.
Jeremy.
(cherry picked from commit 3504910d91fa6d174861815255062efefb0c46aa)

15 years agos3: Remove a few unnecessary checks from the streams depot module and fix to work...
Tim Prouty [Fri, 9 Jan 2009 01:21:08 +0000 (17:21 -0800)]
s3: Remove a few unnecessary checks from the streams depot module and fix to work with NTRENAME

Handling of error codes when renaming a file to a stream and a stream
to a file is now done in rename_internals_fsp.

The NTRENAME stream path only passes in the stream name, so the new
base can now be different from the old base.
(cherry picked from commit 2cca28b3e999a8886539b9a5dde267bb8a3a1db7)

15 years agos3: Remove a few unnecessary checks from the streams xattr module
Tim Prouty [Fri, 9 Jan 2009 01:20:14 +0000 (17:20 -0800)]
s3: Remove a few unnecessary checks from the streams xattr module

Handling of error codes when renaming a file to a stream and a stream
to a file is now done in rename_internals_fsp.

The NTRENAME stream path only passes in the stream name, so the new
base can now be different from the old base.
(cherry picked from commit 078c4fbab8a5be2e23acda1978fd6d6071898dd9)

15 years agos3: Allow renames of streams via NTRENAME and fix stream error codes on rename
Tim Prouty [Fri, 9 Jan 2009 01:19:24 +0000 (17:19 -0800)]
s3: Allow renames of streams via NTRENAME and fix stream error codes on rename

The test_streams_rename2 test in RAW-STREAMS verifies these changes
(cherry picked from commit ac7c18d642bef231730927347e7b0296b1c9d82b)

15 years agoFix bug #6040 - Missing <th> header in Status page.
Jeremy Allison [Thu, 15 Jan 2009 23:54:07 +0000 (15:54 -0800)]
Fix bug #6040 -  Missing <th> header in Status page.
Based on a patch from pkg-samba-maint@lists.alioth.debian.org.
Jeremy.
(cherry picked from commit b13f7e296a70e1280baae9f2f3156043c48bafa9)

15 years agoAllow reinit_after_fork to be called safely from within swat and other binaries that...
Jeremy Allison [Thu, 15 Jan 2009 23:51:40 +0000 (15:51 -0800)]
Allow reinit_after_fork to be called safely from within swat and other binaries that don't have
an event context or a msg context. Fixes crash bug in swat.
Jeremy.
(cherry picked from commit a2944e99825943f91d0260c218de06817acfcf51)

15 years agoFix bug #6040 - Calling Samba print server with an aliased DNS-name fails.
Jeremy Allison [Thu, 15 Jan 2009 18:30:19 +0000 (10:30 -0800)]
Fix bug #6040 - Calling Samba print server with an aliased DNS-name fails.
Jeremy.
(cherry picked from commit 76555085fd9bb40a4c0e2c18b5bf965dcf636cb1)

15 years agoFix bug #6035 - Possible race between fcntl F_SETLKW and alarm delivery.
Jeremy Allison [Wed, 14 Jan 2009 21:17:02 +0000 (13:17 -0800)]
Fix bug #6035 - Possible race between fcntl F_SETLKW and alarm delivery.
Jeremy.
(cherry picked from commit 7c0b99baafc4a0bc04251c9a456bf2cc104058c4)

15 years agoFix bug in get_dc_name_via_netlogon(), null pointer refrence.
Bo Yang [Wed, 14 Jan 2009 19:49:11 +0000 (11:49 -0800)]
Fix bug in get_dc_name_via_netlogon(), null pointer refrence.
(cherry picked from commit 25e035815681136e69b9d49d548b7d7b908011c5)

15 years agoDon't send message to any other child in child process.
Bo Yang [Wed, 14 Jan 2009 19:13:27 +0000 (11:13 -0800)]
Don't send message to any other child in child process.
(cherry picked from commit e443cfaa25c26a7761113bdde9b7453a97f8e5d5)

15 years agoRemove proto.h that got accidentially committet to v3-2-test
Michael Adam [Wed, 14 Jan 2009 08:48:19 +0000 (09:48 +0100)]
Remove proto.h that got accidentially committet to v3-2-test

in commit 61c5589d1fa4d6fe7ce7293a6f6ceab96d4ee193
(fix for bug #6019)

When cherry-picking from v3-3-test (or master) to v3-2-test,
we need to check that proto.h gets removed before committing,
since v3-2-test still has make proto.

Michael
(cherry picked from commit 3ac7289b4d7fef830b05a8cb351476480681b28a)

15 years agoFrom boyang - ensure we never "return" from a forked child, always _exit().
Jeremy Allison [Tue, 13 Jan 2009 23:57:53 +0000 (15:57 -0800)]
From boyang - ensure we never "return" from a forked child, always _exit().
Jeremy.
(cherry picked from commit e1af2b4bc824450615454adec460e6698a83cefc)

15 years agoFix bug #6019 File corruption in Clustered SMB/NFS environment managed via CTDB
Jeremy Allison [Tue, 13 Jan 2009 19:15:10 +0000 (11:15 -0800)]
Fix bug #6019 File corruption in Clustered SMB/NFS environment managed via CTDB
Jeremy.
(cherry picked from commit 61c5589d1fa4d6fe7ce7293a6f6ceab96d4ee193)

15 years agos3:libsmb: handle the smb signing states the same in the krb5 and ntlmssp cases
Stefan Metzmacher [Mon, 12 Jan 2009 11:32:46 +0000 (12:32 +0100)]
s3:libsmb: handle the smb signing states the same in the krb5 and ntlmssp cases

SMB signing works the same regardless of the used auth mech.

We need to start with the temp signing ("BSRSPYL ")
and the session setup response with NT_STATUS_OK
is the first signed packet.

Now we set the krb5 session key if we got the NT_STATUS_OK
from the server and then recheck the packet.

All this is needed to make the fallback from krb5 to
ntlmssp possible. This commit also resets the cli->vuid
value to 0, if the krb5 auth didn't succeed. Otherwise
the server handles NTLMSSP packets as krb5 packets.

The restructuring of the SMB signing code is needed to
make sure the krb5 code only starts the signing engine
on success. Otherwise the NTLMSSP fallback could not initialize
the signing engine (again).

metze
(cherry picked from commit 7d9fd64f38aa5821b38c1223cf87979fc87bfb71)
(cherry picked from commit 8e29070ccd0b5103af2e6da75644169f46700313)
(cherry picked from commit 38b297f99ec166e5c40ba33774222b37b45b4fec)

15 years agoEven for srclen == 0 we have to return something
Volker Lendecke [Sat, 10 Jan 2009 16:59:43 +0000 (17:59 +0100)]
Even for srclen == 0 we have to return something

This fixes a regression reported by Corinna Vinschen <corinna@vinschen.de>

Thanks,

Volker
(cherry picked from commit a77b622f05c50512626b2636343eb8da6d5e4549)

15 years agoFix null pointer refrence in event context in backport from v3-3-test
Bo Yang [Mon, 12 Jan 2009 07:41:02 +0000 (15:41 +0800)]
Fix null pointer refrence in event context in backport from v3-3-test

Signed-off-by: Bo Yang <boyang@novell.com>
(cherry picked from commit d50a487b11c4c256c674327344a824e97eeb620e)

15 years agoFix logic bug introduce in backport of ccache_regain_all_now, sync with
Jeremy Allison [Sun, 11 Jan 2009 04:02:09 +0000 (20:02 -0800)]
Fix logic bug introduce in backport of ccache_regain_all_now, sync with
3.3 implementation.
Jeremy.
(cherry picked from commit e0b70923298a0f33d92b9a2901098328d914ab1e)

15 years agoBackport of the clean event context after fork and
Bo Yang [Sat, 10 Jan 2009 22:33:36 +0000 (14:33 -0800)]
Backport of the clean event context after fork and
krb5 refresh chain fixes.
(cherry picked from commit 80a37595ef5c289fcc02a8902e18eb9ab289b28c)

15 years agoDon't set child->requests to NULL in parent after fork
Bo Yang [Sat, 10 Jan 2009 22:09:48 +0000 (14:09 -0800)]
Don't set child->requests to NULL in parent after fork
(cherry picked from commit 9811454d8ae3f09d9a206f14ed533fa6382a914c)

15 years agos3/smbpasswd: Check if Unix account exists before asking for the password.
Karolin Seeger [Sat, 10 Jan 2009 03:43:13 +0000 (19:43 -0800)]
s3/smbpasswd: Check if Unix account exists before asking for the password.

Admins shouldn't have to type in the password twice when the passdb account
cannot be created because the Unix account is missing.

Karolin
(cherry picked from commit 3bb5e3e0b44c25eede60925cfdc89d7df0d0e486)

15 years agodocs: Improve man mount.cifs.
Karolin Seeger [Fri, 9 Jan 2009 10:22:00 +0000 (11:22 +0100)]
docs: Improve man mount.cifs.

Add hint about specifying the workgroup in the credentials file.
Whitespace cleanup.

This fixes bug #4541.
Patch based on proposed patch from Christian Perrier <bubulle@debian.org>.
Thanks for reporting and providing a patch!

Karolin
(cherry picked from commit 1f7e09ea542df3a2f5f553c0cb11a39c74712950)
(cherry picked from commit b99d98ff2ef5491979301656e7f516d3c8829f6e)
(cherry picked from commit 1900233ede3083410eb3dc691d2d486c5340ccc4)

15 years agoFix a delete on close divergence from windows [2/2]
Tim Prouty [Sun, 7 Dec 2008 00:08:35 +0000 (16:08 -0800)]
Fix a delete on close divergence from windows [2/2]

This second patch cleans up by removing all of the code that is made
obsolete by the first patch.  It should cause no functional changes.
(cherry picked from commit 62d547e1b853b6c5c871f1f9cb265d3cdd40a21d)

15 years agoFix a delete on close divergence from windows [1/2]
Tim Prouty [Sun, 7 Dec 2008 18:30:01 +0000 (10:30 -0800)]
Fix a delete on close divergence from windows [1/2]

smbtorture4's BASE-DELETE:deltest17 was failing against win2k8,
win2k3, and winXPsp2 but passing against samba.

deltest17 does the following:

1. open file -> file is created
2. closes file
3. open file with DOC -> fnum1
4. check that DOC is not reported as being set from fnum1
5. opens file again Read Only -> fnum2
6. check that DOC is not reported as being set from either file handle
7. close fnum1 (the file handle that requested DOC to be set)
8. check if DOC is reported as being set from fnum2
 * This is where windows and samba begin to diverge.  Windows
   reports that the DOC bit is set, while samba reports that it is not set.
9. close fnum2 (the last remaining open handle for the file)
10.See if the file has been deleted.
 * On samba the file still exists.  On windows the file was deleted.

The way open_file_ntcreate is written now, if an open has the DOC bit
set on the wire, DOC (fsp->initial_delete_on_close) is not set unless:
a. the open creates the file, or b. there is an open file handle with
a share_entry in the struct lck that has the
SHARE_MODE_ALLOW_INITIAL_DELETE_ON_CLOSE bit set (let's call it
SM_AIDOC).

My understanding of SM_AIDOC is that it was added to differentiate
between DOC being set on an open that creates a file vs an open that
opens an existing.  As described in step 8/10 above, it appears that
windows does not make this differentiation.

To resolve this issue there are two patches.  This first patch is a
simple proof of concept change that is sufficient to fix the bug.  It
removes the differentiation in open_file_ntcreate, and updates
deltest17 to allow it to pass against win2k3/xp.  This makes
open_file_ntcreate more closely match the semantics in open_directory
and rename_internals_fsp.  This change also does not break any other
tests in BASE-DELETE or "make test".  Specifically test deltest20b
which verifies the CIFSFS rename DOC semantics still passes :).
(cherry picked from commit e2b4e25b433a43960bb37258c0f24d9b77598056)

15 years agoFix bug #6021 - smbclient du command does not recuse properly
Jeremy Allison [Thu, 8 Jan 2009 23:42:53 +0000 (15:42 -0800)]
Fix bug #6021 - smbclient du command does not recuse properly
Jeremy.
(cherry picked from commit f21a6d66f0bde933e5bf8cf673fc380e5dd52793)

15 years agoRemove "strict allocate = partial" code that got accidentally committed.
Jeremy Allison [Thu, 8 Jan 2009 18:55:28 +0000 (10:55 -0800)]
Remove "strict allocate = partial" code that got accidentally committed.
Jeremy.
(cherry picked from commit ab0359a19986f744075bf861dd43626210c2ecf7)

15 years agoFix race condition in alarm lock processing noticed by Richard Sharpe <realrichardsha...
Jeremy Allison [Thu, 8 Jan 2009 18:38:44 +0000 (10:38 -0800)]
Fix race condition in alarm lock processing noticed by Richard Sharpe <realrichardsharpe@gmail.com>.
"It seems to me that if the lock is already held by another process when we
enter this code, there is a race between the timeout and the granting. If
the lock is subsequently granted, the process releasing the lock will signal
the wait variable (or whatever) and our process will be scheduled. However,
if the timeout occurs before we are scheduled, the timeout will be delivered
first.

We will have the lock but will forget we have the lock, and never release
it."
Jeremy.
(cherry picked from commit 0e30f6d835016a73e89e3159d827a2703058d34b)

15 years agopackaging RHEL: Fix syntax error in samba.spec.tmpl.
Karolin Seeger [Thu, 8 Jan 2009 12:10:59 +0000 (13:10 +0100)]
packaging RHEL: Fix syntax error in samba.spec.tmpl.

Karolin
(cherry picked from commit 097e9d64ade609da9f920156c98b466dc6c42dab)

15 years agoFix bug #6016 - Alternate Data Streams / Extended Attributes seem to conflict.
Jeremy Allison [Wed, 7 Jan 2009 22:55:51 +0000 (14:55 -0800)]
Fix bug #6016 - Alternate Data Streams / Extended Attributes seem to conflict.
Jeremy.
(cherry picked from commit a2042edb42e312d5b8fc5b4750bf5b91b5ee1b3c)

15 years agorefresh sequence number as soon as possible when domain->sequence_number == -1 or...
boyang [Wed, 7 Jan 2009 19:07:42 +0000 (11:07 -0800)]
refresh sequence number as soon as possible when domain->sequence_number == -1 or domain->last_status is not ok.
(cherry picked from commit 3954c6965240836a467d16f447197681b7396a31)

15 years agopackaging(RHEL): fix typo in [u]mount.cifs installation
Michael Adam [Wed, 17 Dec 2008 21:27:39 +0000 (22:27 +0100)]
packaging(RHEL): fix typo in [u]mount.cifs installation

Michael
(cherry picked from commit 835108bcf84a5f47f46d237c7a93c572348125a1)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 71c74725bce403e36e4dc38287802c95b8d4de66)
(cherry picked from commit cfc140d3924dd6be893d242ce5df22e2128f09f8)
(cherry picked from commit 8b4c199deffd724a4a2219ccb8ffb91524101cd9)
(cherry picked from commit 9995378cf3f28af183030c3867513552d85bf935)

15 years agopackaging(RHEL): fix build of [u]mount.cifs
Michael Adam [Wed, 17 Dec 2008 17:56:34 +0000 (18:56 +0100)]
packaging(RHEL): fix build of [u]mount.cifs

mount.cifs is now built by make everything.
And it needs extra objects anyways (mtab.o),
which is why the build of mount.cifs failed.

Michael
(cherry picked from commit 96c811cf222be5463a6705feae73d6215685c5f1)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 308dbca653ce1d689b75f9b781237c67df4233a8)
(cherry picked from commit 9745e36c011a76669aad7a0a861ba1520ef8cec3)
(cherry picked from commit 1c1e196b648ae3ef241401f859842450c5153181)
(cherry picked from commit c93a5131913a1a18645c4f972be6f6b2c1715f28)

15 years agoFix bug #6017, - magic script does not work. based on a patch from monyo@samba.gr.jp.
Jeremy Allison [Wed, 7 Jan 2009 00:06:43 +0000 (16:06 -0800)]
Fix bug #6017, - magic script does not work. based on a patch from monyo@samba.gr.jp.
Jeremy.
(cherry picked from commit 4af1d077915c7bbe5268b78bde71b102861a2b98)

15 years agos3/swat: Fix creation of the first share using SWAT.
Volker Lendecke [Tue, 6 Jan 2009 14:13:43 +0000 (15:13 +0100)]
s3/swat: Fix creation of the first share using SWAT.

This fixes bug #5965.
(cherry picked from commit f76614169f1e0a932cf2895702cfa9e8a5735875)
(cherry picked from commit 148437fcd0896591ebbf6c2808723575d025123f)

15 years agodocs: Improve description of the share commands in man smb.conf.
Karolin Seeger [Tue, 6 Jan 2009 11:26:23 +0000 (12:26 +0100)]
docs: Improve description of the share commands in man smb.conf.

-Correct the parameter names.
-Fix typos.
-Fix related parameters.

This fixes bug #6008.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!

Karolin
(cherry picked from commit 8b7f66c548ed170d2dab0c91ccff4aca00f4b52d)
(cherry picked from commit 6f38786aa878bd1a7fc10069773c19b28437fbbb)
(cherry picked from commit f420b5c2af7d46e88269d9ec89c5dcd37f1f8f46)

15 years agodocs: Fix example in man vfs_recycle.
Karolin Seeger [Tue, 6 Jan 2009 09:26:37 +0000 (10:26 +0100)]
docs: Fix example in man vfs_recycle.

This fixes bug #6001.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!

Karolin
(cherry picked from commit 9f44a17c3bf36067d04cec036c3e529798932cd7)
(cherry picked from commit 5e073807f7c4679dd299a2b8f3e2643dc1c82405)
(cherry picked from commit c0877d14cb04956b29ca329897a7b4bface7f363)

15 years agoFix the build (event context init was different).
Jeremy Allison [Tue, 6 Jan 2009 02:06:20 +0000 (18:06 -0800)]
Fix the build (event context init was different).
Jeremy.
(cherry picked from commit aef7ad9d2f65c5e2a3b9622b352cafd30be79663)

15 years agoclean event context after child is forked.
Bo Yang [Tue, 6 Jan 2009 01:55:22 +0000 (17:55 -0800)]
clean event context after child is forked.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 7045272e5436e3a24d187945e405cb3cc407ce73)

15 years agoAttempt to fix crash seen with new CUPS async printcap loading code.
Jeremy Allison [Mon, 5 Jan 2009 20:34:02 +0000 (12:34 -0800)]
Attempt to fix crash seen with new CUPS async printcap loading code.
Jeremy.
(cherry picked from commit 101ef64e3181335b66524296af08f7df04391b9a)

15 years agoexamples: Avoid bashism in perfcount.init.
Karolin Seeger [Mon, 5 Jan 2009 15:33:00 +0000 (16:33 +0100)]
examples: Avoid bashism in perfcount.init.

This fixes bug #6000.
Thanks to the Debian Samba package maintainers for providing the patch!
Remove trailing whitespaces.

Karolin
(cherry picked from commit 2e09746a4db4186c9d648370b9004971bc18e5c9)
(cherry picked from commit 9b17f7907bca32282d6e56fa28ca62ef84bf7afc)
(cherry picked from commit de41f0e9a08b796873bdd319fe784b6c90e28b23)

15 years agoRevert "examples: Avoid bashism in perfcount.init."
Karolin Seeger [Mon, 5 Jan 2009 15:37:01 +0000 (16:37 +0100)]
Revert "examples: Avoid bashism in perfcount.init."

This reverts commit b4ffffc5c03b69ac2f8e0ed74fd7788549f7e822.
(cherry picked from commit fbee9f20b30a426d5c336066522d047a504914b9)

15 years agoFix bug 6014 -- mget shouldn't segfault without arguments
Volker Lendecke [Mon, 5 Jan 2009 14:47:19 +0000 (15:47 +0100)]
Fix bug 6014 -- mget shouldn't segfault without arguments

Thanks to kevin.paulus@mtm.kuleuven.be for the bug report

Volker
(cherry picked from commit 2ad41fedc50f764e77e2ba56b4d53d1045947a9c)