Alexander Bokovoy [Thu, 13 Sep 2012 12:40:31 +0000 (15:40 +0300)]
s3: make ldapsam-related functions a smbldaphelper subsystem
Since these functions are used in pdb_ldap and idmap_ldap, and
pdb_ldap might be statically linked to libpdb (default), it is
better to keep them as separate subsystem to avoid polluting libpdb
namespace.
This is first step in refactoring libpdb. Right now I cannot move
these functions into proper libsmbldaphelper as it uses more of
libpdb-included functions and linking pdb_ldap against libsmbldaphelper
library would have created a loop if pdb_ldap is included into libpdb.
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Thu Sep 13 17:36:07 CEST 2012 on sn-devel-104
Michael Adam [Wed, 12 Sep 2012 13:34:29 +0000 (15:34 +0200)]
VERSION: Bump version up to 4.1.0pre1
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Sep 13 01:35:33 CEST 2012 on sn-devel-104
Michael Adam [Wed, 12 Sep 2012 13:30:24 +0000 (15:30 +0200)]
VERSION: Release Samba 4.0.0rc1
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 13:27:48 +0000 (15:27 +0200)]
WHATSNEW: prepare release notes for 4.0.0rc1
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:11:28 +0000 (17:11 +0200)]
build:dist: call source3/autogen.sh and packaged generated files
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:10:31 +0000 (17:10 +0200)]
build:dist: call build-manpages-nogit for make dist and package generated files
so that we always have generated manpages under docs/manpages in the release
tarball
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:06:23 +0000 (17:06 +0200)]
build:dist: extend meaning of DIST_FILES to also recurse into directories
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 21:45:50 +0000 (23:45 +0200)]
build:dist: make use of file / distfile more obvious in handling of DIST_FILES in "make dist"
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:04:50 +0000 (17:04 +0200)]
build:dist: for snapshot builds, call DIST_DIRS with extend=True
to allow the distversion file to be an addition to the list
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:02:39 +0000 (17:02 +0200)]
build:dist: extend samba_dist.DIST_FILES() to take optional parameter extend(=False)
This allows to do multpile DIST_FILES() calls that will extend the list
rather than only setting it initially.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:01:40 +0000 (17:01 +0200)]
build:waf dist: factor out function to add list of files to the tarball
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:48:12 +0000 (17:48 +0200)]
s3:build: rewrite autogen.sh to be called from any directory
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:38:04 +0000 (17:38 +0200)]
release-scripts: run build-manpages-nogit with bash
On debian/ubuntu, the "dash" which is sh, does not
provide pushd/popd...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 15:37:17 +0000 (17:37 +0200)]
release-scripts: run build-manpages-git with bash
On debian/ubuntu, the "dash" which is sh, does not
provide pushd/popd...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 13:46:35 +0000 (15:46 +0200)]
release-scripts: let build-manpages-nogit store generated docs under ./bin/docs
not under ./docs
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 12 Sep 2012 13:45:59 +0000 (15:45 +0200)]
release-scripts: let build-manpages-git store generated docs under bin/docs/
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Jeremy Allison [Wed, 12 Sep 2012 18:42:57 +0000 (11:42 -0700)]
In vfs modules, don't use 'conn->origpath' when we really mean 'conn->cwd'.
This allows VFS modules to work even when we've changed directory
under the connect path in order to do root-safe calls.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 12 23:45:23 CEST 2012 on sn-devel-104
Jeremy Allison [Wed, 12 Sep 2012 18:39:37 +0000 (11:39 -0700)]
Move cached cwd onto conn struct.
This enables us to make VFS modules safe for use in root called
code when we've changed directory under conn->connectpath.
Jeremy Allison [Wed, 12 Sep 2012 18:21:01 +0000 (11:21 -0700)]
Remove ancient "optimization" global LastDir.
Simo Sorce [Fri, 7 Sep 2012 18:14:08 +0000 (14:14 -0400)]
Avoid overriding default ccache for ads operations.
Avoid overriding default ccache for ads operations.
Nowadays various samba components may need to use GSSAPI and a default cred
cache to perform their tasks.
This code was completely overriding the whole process default ccache name, thus
altering the current credentials and sometimes hijacking them (or getting
preemptively hijaked).
By using gss_krb5_import_cred we can instead use a private ccache (necessary
sometimes to use a different set of credentials fromt he default
cifs/fqdn@realm one, for example when contacting foreign DCs using trust
credentials) that does not affect the rest of the process.
For the kerberos versions which don't have gss_krb5_import_cred
we fallback to temp override of KRB5CCNAME and gss_acquire_cred.
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed Sep 12 21:18:09 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 12 Sep 2012 12:10:55 +0000 (14:10 +0200)]
selftest: let provision_plugin_s4_dc use SMB3
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Sep 12 18:30:48 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 12 Sep 2012 09:40:16 +0000 (19:40 +1000)]
wintest: Fix --use-ntvfs handling
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 12 Sep 2012 08:34:41 +0000 (18:34 +1000)]
wintest: Rework support for the internal DNS server
We still have to run BIND, the change is if BIND is run to support our own
zone, or if we forward to as well as to windows.
This also adapts to the new defaults.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Kai Blin [Wed, 12 Sep 2012 10:31:38 +0000 (12:31 +0200)]
s4 provision: Ask for the dns forwarder IP address during interactive provision
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 12 Sep 2012 08:07:58 +0000 (18:07 +1000)]
dns_server: Remove parameter 'dns recursive queries' and base this on 'dns forwarder'
This simplifies a very common configuration.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 12 Sep 2012 07:49:59 +0000 (09:49 +0200)]
wintest: try to fix settings for the internal dns server
metze
Stefan Metzmacher [Wed, 12 Sep 2012 07:31:17 +0000 (09:31 +0200)]
lib/param: change the default for 'allow dns updates' to 'secure only'
metze
Stefan Metzmacher [Wed, 12 Sep 2012 07:39:06 +0000 (09:39 +0200)]
lib/param: add some more alias for 'allow dns updates' options.
metze
Kai Blin [Tue, 11 Sep 2012 23:59:03 +0000 (01:59 +0200)]
WHATSNEW.txt: Update DNS server description
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 12 Sep 2012 12:42:18 +0000 (14:42 +0200)]
s4:dns_server: remove wrong and unused dsdb_check_access_on_dn() check
metze
Andrew Bartlett [Tue, 11 Sep 2012 10:59:51 +0000 (20:59 +1000)]
dns_server: Attempt to SET and UNSET the sessionInfo to match the incoming user
This avoids re-opening the DB as the correct user, but applies all the right ACLs
and resulting owner.
This needs a bit more testing...
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Kai Blin <kai@samba.org>
Stefan Metzmacher [Wed, 12 Sep 2012 06:53:18 +0000 (08:53 +0200)]
s4:samba_upgradedns: delete dns-HOSTNAME account if using the internal dns server
metze
Stefan Metzmacher [Wed, 12 Sep 2012 06:52:15 +0000 (08:52 +0200)]
selftest:Samba4: don't provision with BIND9_DLZ
metze
Stefan Metzmacher [Wed, 12 Sep 2012 14:31:38 +0000 (16:31 +0200)]
s4:upgradehelpers.py: don't require a dns-$HOSTNAME account
metze
Stefan Metzmacher [Wed, 12 Sep 2012 06:46:35 +0000 (08:46 +0200)]
s4:provision: don't add the dns-HOSTNAME account if we use the internal dns server
metze
Kai Blin [Tue, 11 Sep 2012 23:44:30 +0000 (01:44 +0200)]
loadparm: dns is now a default server service
Kai Blin [Tue, 11 Sep 2012 07:07:47 +0000 (09:07 +0200)]
s4 dns: use the internal DNS server per default
Kai Blin [Mon, 10 Sep 2012 20:22:43 +0000 (22:22 +0200)]
s4 dns: Add libaddns-based simple tests
Kai Blin [Mon, 10 Sep 2012 22:14:39 +0000 (00:14 +0200)]
s4 dns: Run python tests in fl2003dc env
Kai Blin [Mon, 10 Sep 2012 20:16:54 +0000 (22:16 +0200)]
s4 dns: Improve logging of delegated dns updates
Stefan Metzmacher [Wed, 12 Sep 2012 12:15:21 +0000 (14:15 +0200)]
s4:selftest: run thet dlz_bind9. tests in the chgdcpass env
metze
Björn Jacke [Tue, 11 Sep 2012 07:22:11 +0000 (09:22 +0200)]
s3: remove unneeded noquota.c file
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Sep 12 16:50:50 CEST 2012 on sn-devel-104
Andreas Schneider [Wed, 12 Sep 2012 10:12:58 +0000 (12:12 +0200)]
s3-rap: Open printers with the right access mask.
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Sep 12 14:05:42 CEST 2012 on sn-devel-104
Andreas Schneider [Tue, 11 Sep 2012 15:50:45 +0000 (17:50 +0200)]
docs: Build manpages correctly.
Andreas Schneider [Tue, 11 Sep 2012 15:50:26 +0000 (17:50 +0200)]
wafsamba: Add a SAMBAMANPAGES function.
Andreas Schneider [Tue, 11 Sep 2012 12:47:06 +0000 (14:47 +0200)]
docs: Bump version up to 4.0.
Karolin Seeger [Wed, 12 Sep 2012 07:55:41 +0000 (09:55 +0200)]
docs: Fix typo.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Wed Sep 12 12:21:00 CEST 2012 on sn-devel-104
Alexander Bokovoy [Tue, 11 Sep 2012 17:12:42 +0000 (20:12 +0300)]
lib/krb5_wrap: when deleting default realm, pass char*, not char**
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed Sep 12 10:33:37 CEST 2012 on sn-devel-104
Alexander Bokovoy [Tue, 11 Sep 2012 09:29:49 +0000 (12:29 +0300)]
s3-pdb: filter out more symbols only used in ldapsam internals
Stefan Metzmacher [Tue, 11 Sep 2012 08:22:14 +0000 (10:22 +0200)]
WHATSNEW: provision and updateprovision have new names
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Sep 12 08:48:16 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 10 Sep 2012 12:52:35 +0000 (14:52 +0200)]
s4:scripting: rename upgradeprovision -> samba_upgradeprovision
metze
Stefan Metzmacher [Mon, 10 Sep 2012 13:15:41 +0000 (15:15 +0200)]
s4:setup: remove standalone 'provision'
metze
Andrew Bartlett [Mon, 10 Sep 2012 02:44:01 +0000 (12:44 +1000)]
smbd: Add extra VFS hooks to get the posix ACL as a blob
This will allow us to hash this, rather than the NT ACL it maps to.
This will in turn allow us to know if the NT ACL is valid even if we
have to change the mapping code.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep 12 07:06:01 CEST 2012 on sn-devel-104
Andrew Bartlett [Fri, 7 Sep 2012 07:44:24 +0000 (17:44 +1000)]
smbd: Remove pre-allocation of ACL array in sys_acl_init()
Instead, this is just handled with realloc in sys_acl_create_entry()
This allows us to remove the size element from the SMB_ACL_T.
Andrew Bartlett
Andrew Bartlett [Fri, 7 Sep 2012 05:49:47 +0000 (15:49 +1000)]
smbd-posix_acls: Use a IDL union to store the ACL entry
This is a clearer, long-term-stable structure we can hash without
risking it changing.
Andrew Bartlett
Jeremy Allison [Tue, 11 Sep 2012 23:16:37 +0000 (16:16 -0700)]
Make metze happy and the code clearer :-).
Ensure we know after the destructor fires we're never going to
look at this again.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 12 03:00:21 CEST 2012 on sn-devel-104
Luca Lorenzetto [Tue, 11 Sep 2012 16:35:42 +0000 (18:35 +0200)]
nsswitch: fix crash on null pam change pw response
The function _pam_winbind_change_pwd crashes due to a null value passed
to the function strcasecmp and denies to login via graphical login
manager. Check for a null value before doing a strcasecmp.
Bug-Ubuntu: https://bugs.launchpad.net/bugs/
1003296
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9013
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Sep 12 00:07:28 CEST 2012 on sn-devel-104
Michael Adam [Tue, 11 Sep 2012 14:28:45 +0000 (16:28 +0200)]
s4:torture:smb2: fix error reporting in the oplock-brl3 test
(Error was set to an unused variable)
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep 11 22:09:18 CEST 2012 on sn-devel-104
Michael Adam [Tue, 11 Sep 2012 14:28:15 +0000 (16:28 +0200)]
s4:torture:smb2: fix error reporting in the oplock-brl2 test
(Error was set to an unused variable)
Michael Adam [Tue, 11 Sep 2012 14:27:19 +0000 (16:27 +0200)]
s4:torture:smb2: fix error reporting in the oplock-brl1 test
(Error was set to an unused variable)
Michael Adam [Tue, 11 Sep 2012 14:26:44 +0000 (16:26 +0200)]
s4:torture:smb2: remove an unused variable from the oplock-exclusive2 test
Michael Adam [Tue, 11 Sep 2012 14:25:50 +0000 (16:25 +0200)]
s4:torture:smb2: remove an unused variable from the oplock-exclusive1 test
Jeremy Allison [Tue, 11 Sep 2012 16:06:45 +0000 (09:06 -0700)]
At Michael's suggestion, factor common code into a function. My bad :-).
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 11 20:08:37 CEST 2012 on sn-devel-104
Andrew Bartlett [Sun, 9 Sep 2012 22:43:09 +0000 (08:43 +1000)]
smbd: Print ACL used to create hash in vfs_xattr_common
This should help us understand why sometimes an ACL set won't stick.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Sep 11 18:19:53 CEST 2012 on sn-devel-104
Andrew Bartlett [Sun, 9 Sep 2012 07:08:49 +0000 (17:08 +1000)]
provision: Only give the "no posix ACLs" exception if we could not set the SD
This will allow us to run make test on all platforms again, as we emululate the posix ACLs using the fake_acls
module. By then testing smbd.have_posix_acls() we gain a more specific error message.
Andrew Bartlett
Andrew Bartlett [Fri, 7 Sep 2012 05:10:24 +0000 (15:10 +1000)]
torture: Add discard_const_p() to work around dlz_create prototype
Michael Adam [Tue, 11 Sep 2012 12:13:51 +0000 (14:13 +0200)]
selftest: we fail the smb2.durable-open.delete_on_close2 test
(we currently do not grant durable on reconnect when delete-on-close is set)
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep 11 16:22:20 CEST 2012 on sn-devel-104
Michael Adam [Tue, 11 Sep 2012 12:08:28 +0000 (14:08 +0200)]
s4:torture:smb2: add a durable-open.delete_on_close2 test
This test verifies that the delete on close flag is kept during
a disconnect and is still active on the reconnected handle.
When the reconnected handle is closed, the file is deleted.
Michael Adam [Tue, 11 Sep 2012 11:07:21 +0000 (13:07 +0200)]
selftest: pass smb2.durable-open.delete_on_close1
Michael Adam [Tue, 11 Sep 2012 11:06:22 +0000 (13:06 +0200)]
selftest: smb2.durable-open.delete_on_close1 is not flapping any more
The entry into flapping was not effective anyways since, the test
was also listed in knownfail...
Michael Adam [Tue, 11 Sep 2012 11:43:17 +0000 (13:43 +0200)]
s4:torture:smb2: fix the durable-open.delete_on_close1 test
This test used to flap because there was an invalid check of
the file-id. This might or might not be the same after a
new open. Hence the flapping.
The new version simply opens a file as durable handle with
delete_on_close set, writes a byte and closes the file.
Then on a new connect, the file is opened again, and it is checked
that the file has been created (again) and that it is empty.
Michael Adam [Tue, 11 Sep 2012 10:49:14 +0000 (12:49 +0200)]
lib/replace: remove duplicate check for inotify
Andreas Schneider [Mon, 10 Sep 2012 14:56:23 +0000 (16:56 +0200)]
docs: Move idmap manpage to there old location.
This wasn't planned and slipped trough, sorry.
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Sep 11 14:28:53 CEST 2012 on sn-devel-104
Karolin Seeger [Tue, 11 Sep 2012 08:50:08 +0000 (10:50 +0200)]
docs: Bump version up to 4.0.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Sep 11 12:37:17 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 10 Sep 2012 12:47:21 +0000 (14:47 +0200)]
selftest/Samba4: make use of samba-tool domain provision
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Sep 11 10:15:23 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 10 Sep 2012 12:47:21 +0000 (14:47 +0200)]
wintest: make use of samba-tool domain provision
metze
Stefan Metzmacher [Mon, 10 Sep 2012 12:47:21 +0000 (14:47 +0200)]
testprogs/blackbox: make use of samba-tool domain provision
metze
Stefan Metzmacher [Mon, 10 Sep 2012 12:47:21 +0000 (14:47 +0200)]
s4:setup/tests: make use of samba-tool domain provision
metze
Stefan Metzmacher [Mon, 10 Sep 2012 12:21:57 +0000 (14:21 +0200)]
s4:scripting: install samba_kcc to SBINDIR
It's use as "%s/samba_kcc", dyn_SCRIPTSBINDIR" similar
to samba_spnupdate and samba_dnsupdate.
metze
Stefan Metzmacher [Mon, 10 Sep 2012 12:18:54 +0000 (14:18 +0200)]
s4:scripting: use the 'sbin_files' variable
metze
Stefan Metzmacher [Mon, 10 Sep 2012 12:05:14 +0000 (14:05 +0200)]
s4:samba-tool: add 'samba-tool domain provision'
This is mostly a copy of the standalone source4/setup/provision.
metze
Stefan Metzmacher [Mon, 10 Sep 2012 12:02:19 +0000 (14:02 +0200)]
s4:python/netcmd: give the Commad implementations access to the raw arguments
metze
Stefan Metzmacher [Mon, 10 Sep 2012 10:12:48 +0000 (12:12 +0200)]
s4:samba-tool: remove unused code in testparm.py
metze
Stefan Metzmacher [Tue, 11 Sep 2012 06:21:27 +0000 (08:21 +0200)]
s4:samba-tool: allow sys.exit(ret) to control the exit code
Some subcommands may use sys.exit(0), which shouldn't be reported
as an error to the caller.
metze
Björn Jacke [Mon, 10 Sep 2012 23:00:50 +0000 (01:00 +0200)]
quota: move function again to its belonging ifdef block
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Tue Sep 11 04:44:28 CEST 2012 on sn-devel-104
Björn Jacke [Mon, 10 Sep 2012 22:44:04 +0000 (00:44 +0200)]
s3:proto.h: remove duplicate disk_quotas prototypes
Björn Jacke [Mon, 10 Sep 2012 22:07:45 +0000 (00:07 +0200)]
quota: fix configure test for HP-UX
while HP-UX does have the 4A quota interface our test failed due to a missing
function prototype in HP-UX and our test running in strict mode with
compile warnings be errors. So let's make our own prototype in the test when we
are on HP*UX
Jeremy Allison [Mon, 10 Sep 2012 22:46:27 +0000 (15:46 -0700)]
samba3.smb2.durable-open.delete_on_close1 is now flapping (sometimes passes).
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 11 02:30:55 CEST 2012 on sn-devel-104
Volker Lendecke [Mon, 10 Sep 2012 13:52:20 +0000 (15:52 +0200)]
s3: Run raw.oplock
Signed-off-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Mon, 10 Sep 2012 10:25:06 +0000 (12:25 +0200)]
smbtorture: Test that delete requests are not special
Signed-off-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Mon, 10 Sep 2012 09:25:03 +0000 (11:25 +0200)]
s3: delete requests are not special
The only difference between batch and exclusive oplocks is the time of
the check: Batch is checked before the share mode check, exclusive after.
Signed-off-by: Jeremy Allison <jra@samba.org>
Michele Baldessari [Mon, 10 Sep 2012 21:58:28 +0000 (14:58 -0700)]
Set trans to a value that is not LDB_SUCCESS (all LDB_ constants are
positive) so that any "goto failed:" call does not end up calling
ldb_transaction_cancel() if trans is initialized to 0 (LDB_SUCCESS)
by chance.
Signed-off-by: Jeremy Allison <jra@samba.org>
Michele Baldessari [Mon, 10 Sep 2012 20:31:11 +0000 (13:31 -0700)]
Call TALLOC_FREE() before we return otherwise we will never free sam_account
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Fri, 7 Sep 2012 00:14:52 +0000 (17:14 -0700)]
Fix talloc memory heirarchy bug. If there's an SMB2 sessionsetup in flight when we're shut down, we end up freeing the struct smbXsrv_session *session pointer twice.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Sep 10 23:34:06 CEST 2012 on sn-devel-104
Jeremy Allison [Mon, 10 Sep 2012 16:30:49 +0000 (09:30 -0700)]
Fix bug #9147 - winbind can't fetch user or group info from AD via LDAP
Don't use "isprint" in ldb_binary_encode(). This is locale specific.
Restrict to ASCII only, hex encode everything else.
Björn Jacke [Mon, 10 Sep 2012 10:35:40 +0000 (12:35 +0200)]
wafbuild: add defines for linux quota and sysquota support
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Mon Sep 10 21:55:53 CEST 2012 on sn-devel-104
Christian Ambach [Mon, 10 Sep 2012 15:24:57 +0000 (17:24 +0200)]
s3:smbd Bump the smbd vfs interface version to 30
that is what Samba 4.0.0 will ship with
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Mon Sep 10 19:40:01 CEST 2012 on sn-devel-104
Christof Schmitt [Fri, 31 Aug 2012 17:33:57 +0000 (10:33 -0700)]
s3:vfs/time_audit: Add back pointer for sys_acl_delete_def_file_fn
Commit
e25830dcd87387a237b96f0d70deb204a5bf0a54 removed the function
pointer from the time_audit module, although the VFS function still
exists. Add the function pointer again in time_audit as this seems
to be an accidentally deletion.
Signed-off-by: Christian Ambach <ambi@samba.org>
Ralph Wuerthner [Wed, 25 Jul 2012 16:39:57 +0000 (18:39 +0200)]
s3:vfs/time_audit: add path names to log messages
Signed-off-by: Christian Ambach <ambi@samba.org>
Christian Ambach [Wed, 5 Sep 2012 13:07:54 +0000 (15:07 +0200)]
s3:client use more access bits for snapshot display
otherwise Windows server will reject the request for shadow copy enumeration
with access denied