Günther Deschner [Mon, 1 Feb 2016 15:06:18 +0000 (16:06 +0100)]
s4-torture: fix gcc6 build warning.
source4/torture/ndr/drsuapi.c:272:22: warning: 'DsBind_req2_dat' defined but
not used [-Wunused-const-variable]
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Günther Deschner [Fri, 5 Feb 2016 10:14:58 +0000 (11:14 +0100)]
s4-torture: fix gcc6 build warning.
source4/torture/raw/eas.c:322:17: warning: comparison of constant '0' with
boolean expression is always false [-Wbool-compare]
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 11:05:26 +0000 (12:05 +0100)]
ldb: remove outdated comment about type argument in dlist
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 11:05:06 +0000 (12:05 +0100)]
tevent: remove outdated comment about type argument in dlist
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 11:04:44 +0000 (12:04 +0100)]
dlist: remove outdated comment about type argument
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 11:03:33 +0000 (12:03 +0100)]
dlist: remove unneeded type argument from DLIST_CONCATENATE()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 11:02:54 +0000 (12:02 +0100)]
tevent: remove unneeded type argument from DLIST_CONCATENATE()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 11:02:26 +0000 (12:02 +0100)]
ldb: remove unneeded argument type from DLIST_CONCATENATE()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 10:53:30 +0000 (11:53 +0100)]
tevent: remove uneeded type argument from DLIST_DEMOTE()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 10:53:11 +0000 (11:53 +0100)]
ldb: remove uneeded type argument from DLIST_DEMOTE()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 10:52:36 +0000 (11:52 +0100)]
dlist: remove unneeded argument from DLIST_DEMOTE()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 10:35:38 +0000 (11:35 +0100)]
ldb: remove unneeded type arg from DLIST_ADD_END
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 10:37:42 +0000 (11:37 +0100)]
tevent: remove unneeded type argument from DLIST_ADD_END
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Fri, 5 Feb 2016 10:32:18 +0000 (11:32 +0100)]
dlist: remove unneeded type argument from DLIST_ADD_END()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Luca Olivetti [Fri, 5 Feb 2016 11:02:51 +0000 (12:02 +0100)]
pdb: Fix segfault in pdb_ldap for missing gecos
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11530
Signed-off-by: Luca Olivetti <luca@wetron.es>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Feb 5 16:47:00 CET 2016 on sn-devel-144
Christian Ambach [Thu, 4 Feb 2016 20:39:47 +0000 (21:39 +0100)]
s3:utils/smbget set default blocksize
this got lost in the recent refactorings and causes problems
when smbget attempts to use a zero byte read buffer
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Feb 5 12:10:16 CET 2016 on sn-devel-144
Christian Ambach [Thu, 4 Feb 2016 20:38:20 +0000 (21:38 +0100)]
s3:utils/smbget add a error message on allocation error
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Martin Schwenke [Thu, 4 Feb 2016 09:03:49 +0000 (20:03 +1100)]
util: Move util_strlist.c into samba-util-core
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Martin Schwenke [Thu, 4 Feb 2016 09:00:58 +0000 (20:00 +1100)]
util: Make util_strlist.c standalone with its own header file
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Martin Schwenke [Thu, 4 Feb 2016 08:42:54 +0000 (19:42 +1100)]
util: Split str_list_make_v3() into separate file
str_list_make_v3() calls next_token_talloc(), which has deep
dependencies, so can't be used without dragging in a lot of code. The
other functions in this file are generally useful and have minimal
dependencies.
So leave the easily reusable code and split out the more difficult
stuff.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Jose A. Rivera [Thu, 4 Feb 2016 02:58:19 +0000 (20:58 -0600)]
s3:smbd:open: Skip redundant call to file_set_dosmode when creating a new file.
Signed-off-by: Jose A. Rivera <jarrpa@samba.org>
Pair-programmed-with: Ira Cooper <ira@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Feb 5 04:37:43 CET 2016 on sn-devel-144
Hemanth Thummala [Tue, 2 Feb 2016 18:33:20 +0000 (10:33 -0800)]
loadparm: Fix memory leak issue.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11708
Signed-off-by: Hemanth Thummala <hemanth.thummala@nutanix.com>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Feb 4 12:39:14 CET 2016 on sn-devel-144
Volker Lendecke [Thu, 14 Jan 2016 20:42:33 +0000 (21:42 +0100)]
libwbclient: Fix a few resource leak CIDs
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Thu, 14 Jan 2016 20:42:04 +0000 (21:42 +0100)]
libwbclient: Add "goto fail" test macros
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 17 Nov 2015 17:35:29 +0000 (18:35 +0100)]
s4-torture: flesh out ntlmssp_AUTHENTICATE_MESSAGE_check().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 17 Nov 2015 17:32:28 +0000 (18:32 +0100)]
s4-torture: add ndr pullpush validation for NTLMSSP CHALLENGE and AUTHENTICATE messages.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 17 Nov 2015 17:30:16 +0000 (18:30 +0100)]
s4-torture: flesh out ntlmssp_CHALLENGE_MESSAGE_check().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 17 Nov 2015 17:29:16 +0000 (18:29 +0100)]
s4-torture: activate testing of CHALLENGE and AUTHENTICATE ntlmssp messages.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 17 Nov 2015 17:27:29 +0000 (18:27 +0100)]
s4-torture: fill in ntlmssp_NEGOTIATE_MESSAGE_check().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 17 Nov 2015 14:35:29 +0000 (15:35 +0100)]
ntlmssp: when pulling messages it is important to clear memory first.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 17 Nov 2015 14:34:47 +0000 (15:34 +0100)]
ntlmssp: properly document version defines in IDL (from MS-NLMP).
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Tue, 17 Nov 2015 15:42:08 +0000 (16:42 +0100)]
ntlmssp: fix copy/paste typo in CHALLENGE_MESSAGE in IDL.
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Mon, 16 Nov 2015 15:31:27 +0000 (16:31 +0100)]
ntlmssp: add some missing defines from MS-NLMP to our IDL.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 3 Feb 2016 23:00:46 +0000 (00:00 +0100)]
docs-xml: fix typo in smbspool_krb5_wrapper manpage.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Robin Hack [Fri, 4 Dec 2015 13:50:56 +0000 (14:50 +0100)]
samba3.blackbox.smbclient.forceuser_validusers: Add new test for force user option.
Test covers commit
cf0934caf282f4ade8c8a701b0e40b68a2f17ace
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9878
RH BUG: https://bugzilla.redhat.com/show_bug.cgi?id=
1077651
How to test:
$ make -j test TESTS="samba3.blackbox.smbclient.forceuser_validusers"
RESULD: Should PASS
$ git revert
cf0934caf282f4ade8c8a701b0e40b68a2f17ace
$ make -j test TESTS="samba3.blackbox.smbclient.forceuser_validusers"
RESULT: Should FAIL
Signed-off-by: Robin Hack <rhack@redhat.com>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Thu Feb 4 03:44:42 CET 2016 on sn-devel-144
Michael Adam [Wed, 3 Feb 2016 10:28:32 +0000 (11:28 +0100)]
lib:socket: fix CID
1350010 - integer OVERFLOW_BEFORE_WIDEN
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Feb 4 00:35:11 CET 2016 on sn-devel-144
Christof Schmitt [Tue, 2 Feb 2016 19:57:25 +0000 (12:57 -0700)]
gencache: Remove unused defines
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Andreas Schneider [Wed, 3 Feb 2016 08:20:27 +0000 (09:20 +0100)]
docs: Add smbspool_krb5_wrapper manpage
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11690
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Feb 3 21:25:54 CET 2016 on sn-devel-144
Volker Lendecke [Tue, 2 Feb 2016 11:15:49 +0000 (12:15 +0100)]
tldap: Parse a search entry only if it is one
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Feb 3 18:12:44 CET 2016 on sn-devel-144
Volker Lendecke [Sun, 31 Jan 2016 14:29:29 +0000 (15:29 +0100)]
tldap: Make tldap_search use tldap_search_all
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Sun, 31 Jan 2016 14:15:46 +0000 (15:15 +0100)]
tldap: Add tldap_pending_reqs()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Tue, 22 Dec 2015 12:32:01 +0000 (13:32 +0100)]
tldap: Add tldap_search_all
Signed-off-by: Volker Lendecke <vl@samba.org>
TLDAPRC
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Sun, 31 Jan 2016 11:25:32 +0000 (12:25 +0100)]
tldap: Avoid a "ret == false"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Sun, 31 Jan 2016 10:12:23 +0000 (11:12 +0100)]
asn1: Fix whitespace
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 11 Jan 2016 20:58:25 +0000 (21:58 +0100)]
spnego: Some simplifications
asn1_tag_remaining already checks for has_error and only
returns positive if there is error-free space left
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 11 Jan 2016 21:05:43 +0000 (22:05 +0100)]
asn1: Simplify _ber_read_OID_String_impl
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 11 Jan 2016 20:49:21 +0000 (21:49 +0100)]
ldap: Correctly check asn1_tag_remaining retval
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 11 Jan 2016 20:49:21 +0000 (21:49 +0100)]
spnego: Correctly check asn1_tag_remaining retval
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 25 Jan 2016 15:29:01 +0000 (16:29 +0100)]
libads: Factor out ldap_schema_oids.h
Make the oids accessible without having to include ADS_STRUCT&friends
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 25 Jan 2016 11:40:53 +0000 (12:40 +0100)]
ldb: Avoid a "talloc_steal"
There's only one caller of "next_chunk" that does a talloc_steal right
after the call. Pass in a talloc context.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 25 Jan 2016 11:38:36 +0000 (12:38 +0100)]
ldb: Fix some whitespace
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 25 Jan 2016 08:26:06 +0000 (09:26 +0100)]
smbtorture3: Convert the tldap caller to TLDAPRC
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Sun, 24 Jan 2016 10:53:48 +0000 (11:53 +0100)]
lib: Introduce TLDAPRC
Make ldap return codes type safe
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Sat, 26 Dec 2015 21:40:36 +0000 (22:40 +0100)]
tldap: Parse the sasl output blob
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Mon, 21 Dec 2015 20:28:35 +0000 (21:28 +0100)]
tldap: Slightly simplify tldap_search_cb
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Fri, 18 Dec 2015 15:31:46 +0000 (16:31 +0100)]
tldap: Mark server down if read failed
This matches tldap_msg_sent
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Fri, 18 Dec 2015 16:23:19 +0000 (17:23 +0100)]
tldap: Add some required includes
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Volker Lendecke [Wed, 3 Feb 2016 08:18:14 +0000 (09:18 +0100)]
smbd: Fix CID
1351215 Improper use of negative value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Feb 3 15:03:09 CET 2016 on sn-devel-144
Volker Lendecke [Wed, 3 Feb 2016 08:10:46 +0000 (09:10 +0100)]
smbd: Fix CID
1351216 Dereference null return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Thu, 28 Jan 2016 14:10:00 +0000 (15:10 +0100)]
python:tests/core: add tests for arcfour_encrypt() and string_to_byte_array()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11699
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb 3 11:42:29 CET 2016 on sn-devel-144
Stefan Metzmacher [Thu, 28 Jan 2016 13:00:38 +0000 (14:00 +0100)]
s4:scripting/devel: make use of the generic arcfour_encrypt() and string_to_byte_array() functions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11699
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Stefan Metzmacher [Thu, 28 Jan 2016 13:00:38 +0000 (14:00 +0100)]
python:samba/netcmd/domain: make use of the generic arcfour_encrypt() and string_to_byte_array() functions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11699
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Stefan Metzmacher [Thu, 28 Jan 2016 13:00:38 +0000 (14:00 +0100)]
python:samba/join.py: make use of the generic arcfour_encrypt() and string_to_byte_array() functions
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11699
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Stefan Metzmacher [Thu, 28 Jan 2016 12:52:44 +0000 (13:52 +0100)]
python:samba: add a generic arcfour_encrypt() helper function
This works with Crypto.Cipher.ARC4 (from python*-crypto) and
fallback to M2Crypto.RC4.RC4 (from [python*-]m2crypto).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11699
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Stefan Metzmacher [Thu, 28 Jan 2016 12:44:33 +0000 (13:44 +0100)]
python:samba: add a generic string_to_byte_array() helper function
We should avoid implementing this again and again.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11699
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Günther Deschner [Mon, 1 Feb 2016 22:11:13 +0000 (23:11 +0100)]
libsmb/pysmb: add pytalloc-util dependency to fix the build.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Feb 2 15:49:14 CET 2016 on sn-devel-144
Andreas Schneider [Mon, 25 Jan 2016 15:39:59 +0000 (16:39 +0100)]
s4-dsdb: Add debug message if we have a ldb error string
When trying to change the password with kpasswd, the KDC returns
"Unspecified password quality failure". Because we do not get the ldb
error which is e.g.: password is too young to change!
This way at least the admin can find out what is going on.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Feb 2 11:49:51 CET 2016 on sn-devel-144
Volker Lendecke [Mon, 1 Feb 2016 20:45:48 +0000 (21:45 +0100)]
idl: Rename "principle" to "principal_name"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Amitay Isaacs [Thu, 28 Jan 2016 12:45:10 +0000 (23:45 +1100)]
ctdb-build: Add missing dependency on tdb
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Amitay Isaacs [Thu, 28 Jan 2016 13:06:18 +0000 (00:06 +1100)]
ctdb-common: Use documented names for protocol family in socket()
Instead of using PF_*, use AF_*.
https://bugzilla.samba.org/show_bug.cgi?id=11705
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Amitay Isaacs [Thu, 28 Jan 2016 13:05:26 +0000 (00:05 +1100)]
ctdb-common: Protocol argument must be in host order for socket() call
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11705
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Mon, 1 Feb 2016 15:06:18 +0000 (16:06 +0100)]
s3:vfs:glusterfs: fix build after quota changes.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Mon Feb 1 22:09:18 CET 2016 on sn-devel-144
Stefan Metzmacher [Fri, 22 Jan 2016 09:00:25 +0000 (10:00 +0100)]
s3:libads: we always have arcfour-hmac-md5 support
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Feb 1 13:02:32 CET 2016 on sn-devel-144
Stefan Metzmacher [Thu, 23 Jul 2015 10:17:02 +0000 (12:17 +0200)]
s4:ldap_server: use LDAP_AUTH_METHOD_NOT_SUPPORTED define
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Stefan Metzmacher [Fri, 22 Jan 2016 15:57:15 +0000 (16:57 +0100)]
selftest: specify a maximum runtime for 'make testenv' of 1 year
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Stefan Metzmacher [Thu, 14 Jan 2016 10:50:56 +0000 (11:50 +0100)]
s4:dsdb/ldb_modules: make it possible to find a reason for LDB_ERR_NO_SUCH_OBJECT in util.c
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Stefan Metzmacher [Thu, 14 Jan 2016 10:50:56 +0000 (11:50 +0100)]
s4:dsdb/common: make it possible to find a reason for LDB_ERR_NO_SUCH_OBJECT
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Stefan Metzmacher [Tue, 12 Jan 2016 14:51:01 +0000 (15:51 +0100)]
s4:dsdb/common: add dsdb_module_werror() helper function
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Stefan Metzmacher [Thu, 28 Jan 2016 13:11:52 +0000 (14:11 +0100)]
s4:dsdb/common: add some const to dsdb_dn_is_upgraded_link_val()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Stefan Metzmacher [Sun, 31 Jan 2016 18:36:52 +0000 (19:36 +0100)]
drsuapi.idl: add DRSUAPI_ATTID_objectGUID and DRSUAPI_ATTID_replPropertyMetaData
These might be usefull in future if we want to fast check
against dsdb_attribute->attributeID_id, instead of an expensive
ldb_attr_cmp(). They will never appear in replPropertyMetaData.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Stefan Metzmacher [Thu, 28 Jan 2016 14:50:06 +0000 (15:50 +0100)]
s3:clispnego: fix confusing warning in spnego_gen_krb5_wrap()
asn1_extract_blob() stops further asn1 processing by setting has_error.
Don't call asn1_has_error() after asn1_extract_blob() has been successful
otherwise we get an "Failed to build krb5 wrapper at" message
on success.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11702
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Jeremy Allison [Fri, 29 Jan 2016 00:35:13 +0000 (16:35 -0800)]
s3: smbd: Fix timestamp rounding inside SMB2 create.
Setting "dos filetime resolution = yes" should round
to 2 second increments. Fix missing path inside smbd.
Fix confirmed by reporter Hubert Gilch <hg@sepag.de>.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11703
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jan 29 10:41:01 CET 2016 on sn-devel-144
Günther Deschner [Wed, 27 Jan 2016 14:40:33 +0000 (15:40 +0100)]
ctdb: do not provide a useless pkgconfig file for ctdb.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11696
We neither have public headers nor a public library.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Jan 29 04:33:36 CET 2016 on sn-devel-144
Christian Ambach [Wed, 27 Jan 2016 21:59:25 +0000 (22:59 +0100)]
WHATSNEW: update with latest parameter updates for smbget
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jan 28 13:07:34 CET 2016 on sn-devel-144
Christian Ambach [Wed, 27 Jan 2016 21:37:36 +0000 (22:37 +0100)]
s3-utils/smbget: Update manpages for parameter changes
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Christian Ambach [Wed, 27 Jan 2016 21:00:31 +0000 (22:00 +0100)]
s3-utils/smbget: Fix user-/name password reading from rcfile
As the password option is gone, code needs to be able to read password
from user parameter when user%password syntax is used.
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Christian Ambach [Wed, 27 Jan 2016 20:56:10 +0000 (21:56 +0100)]
s3-utils/smbget: Fix reading the rcfile
shortName in POPT_AUTOHELP is null, so the loop always stopped at this
item.
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Andreas Schneider [Wed, 28 Oct 2015 11:37:36 +0000 (12:37 +0100)]
s3-utils/smbget: Fix option parsing and apply samba defaults
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
Uri Simchoni [Wed, 27 Jan 2016 20:09:51 +0000 (22:09 +0200)]
selftest: un-flap samba3.blackbox.dfree_quota
Remove test from flapping list after fix.
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 28 01:10:54 CET 2016 on sn-devel-144
Uri Simchoni [Wed, 27 Jan 2016 19:47:30 +0000 (21:47 +0200)]
selftest: fix test_dfree_quota.sh
Eliminate backslashes from smbcquotas output so that we
don't have to deal with them correctly when parsing the output.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11697
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Uri Simchoni [Tue, 19 Jan 2016 12:38:03 +0000 (14:38 +0200)]
selftest: add test case for different quote/dfree block size
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11681
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Uri Simchoni [Tue, 19 Jan 2016 12:57:16 +0000 (14:57 +0200)]
smbd: show correct disk size for different quota and dfree block sizes
When file system stats (VFS disk_free_fn) and quota (VFS get_quota_fn)
return different block sizes, normalize values before comparing.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11681
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Martin Schwenke [Tue, 5 Jan 2016 05:02:09 +0000 (16:02 +1100)]
ctdb: NAT gateway capability and control to set it are obsolete
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Jan 27 18:35:24 CET 2016 on sn-devel-144
Martin Schwenke [Tue, 5 Jan 2016 05:00:57 +0000 (16:00 +1100)]
ctdb-protocol: Drop protocol support for setting NAT gatway capability
This is no longer used.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Tue, 5 Jan 2016 04:59:43 +0000 (15:59 +1100)]
ctdb-client: Drop support for updating NAT gateway capability
This is no longer used.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Uri Simchoni [Wed, 27 Jan 2016 09:37:42 +0000 (11:37 +0200)]
selftest: mark samba3.blackbox.dfree_quota as flakey
samba3.blackbox.dfree_quota fails repeatedly on sn-devel-144,
although it seems like it initially passed. Marking as flapping
until further investigation.
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Jan 27 15:27:52 CET 2016 on sn-devel-144
Martin Schwenke [Thu, 21 Jan 2016 09:02:41 +0000 (20:02 +1100)]
ctdb-doc: Document reasons for separating private and public networks
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Uri Simchoni [Mon, 18 Jan 2016 21:34:48 +0000 (23:34 +0200)]
smbd quotas: avoid stat of foreign file systems
When determining the block device of our file system, avoid
stat'ing paths which are definitely not the mount point of
our file system. This is done to avoid stalling smbd due to
unresponsive network file systems (e.g. NFS) which are not
related to the SMB shares.
See discussion in samba-technical for vfs_fileid:
https://lists.samba.org/archive/samba-technical/2016-January/111553.html
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 27 03:35:48 CET 2016 on sn-devel-144
Uri Simchoni [Mon, 18 Jan 2016 21:34:06 +0000 (23:34 +0200)]
s3-lib: introduce sys_realpath()
Add sys_realpath() function that captures the OS variations
on realpath().
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Uri Simchoni [Thu, 21 Jan 2016 11:18:20 +0000 (13:18 +0200)]
dbwrap_file: fix use of read_data()
Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 27 00:09:05 CET 2016 on sn-devel-144
git.samba.org / vlendec / samba-autobuild / .git / log