Matthias Dieter Wallnöfer [Thu, 13 Oct 2011 06:48:08 +0000 (08:48 +0200)]
s4:objectclass_attrs LDB module - implement the dSHeuristics length checks correctly
Consider bug #8489
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Thu, 13 Oct 2011 06:21:31 +0000 (08:21 +0200)]
s4:ldap.py - we test the creation of secrets already in the "systemOnly" testcase
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 06:53:17 +0000 (08:53 +0200)]
s4:ldap.py - enhance and fix up the object class test
Also address the problem described in bug #8486.
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:17:33 +0000 (20:17 +0200)]
s4:objectclass LDB module - objectclass modify op. - remove superflous "talloc_strdup"
We are adding strings embedded in the schema structure which is basically
global and lives longer than the request - hence no duplication needed.
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 15:58:37 +0000 (17:58 +0200)]
s4:objectclass LDB module - objectclass modify operations
According to bug #8486 the modification to direct related structural
object classes is possible (equal, child, parent).
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:33:53 +0000 (20:33 +0200)]
s4:objectclass LDB module - forbid to add unrelated objectclasses
E.g. unsatisfied abstract objectclasses, additional top-most structural
classes
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 07:29:08 +0000 (09:29 +0200)]
s4:objectclass LDB module - "objectclass_add" - small optimisation
This saves us from doing one "ldb_msg_find_element".
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:34:17 +0000 (20:34 +0200)]
s4:objectclass LDB module - "check_rodc_ntdsdsa_add"
For convention use "ldb_attr_cmp()".
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 17:49:31 +0000 (19:49 +0200)]
s4:objectclass LDB module - update copyright
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 26 Oct 2011 08:04:11 +0000 (10:04 +0200)]
s4:password_hash LDB module - fix compiler warning due to unsatisfied "switch"
Bail out on other LDB request types (only add and modify allowed).
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 11:03:44 +0000 (13:03 +0200)]
s4:ldap.py - fix up the UTF8 tests
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 10:54:23 +0000 (12:54 +0200)]
s4:ldap.py - reactivate some assertions in "test_all"
There should always be one result on both s4 and Windows.
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 10:34:42 +0000 (12:34 +0200)]
s4:torture/ldap/basic.c - fix a typo
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Thu, 20 Oct 2011 20:29:43 +0000 (22:29 +0200)]
ldb:common/ldb_modules.c - fix a typo in comment
Reviewed-by: abartlet
Andreas Schneider [Mon, 26 Sep 2011 15:48:01 +0000 (17:48 +0200)]
s4-torture: Add a user creation check.
This adds a patch which creates a non-privileged user and then tries to
create a new user as the non-privileged user.
Pretty simple test but it found #8509.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Oct 27 18:51:14 CEST 2011 on sn-devel-104
Andreas Schneider [Thu, 15 Sep 2011 06:54:44 +0000 (08:54 +0200)]
s4-torture: Add a samr privilege check.
This is the first part which checks if a deleted user is propagated
correctly to all daemons and caches with user information are emtpy.
Andreas Schneider [Fri, 23 Sep 2011 14:57:25 +0000 (16:57 +0200)]
s4-torture: Add torture_delete_testuser().
Andreas Schneider [Fri, 23 Sep 2011 14:56:59 +0000 (16:56 +0200)]
s4-torture: Add domain_handle to test_join struct.
Andreas Schneider [Thu, 15 Sep 2011 15:26:18 +0000 (17:26 +0200)]
s3-build: Add .clang_complete.
Stefan Metzmacher [Thu, 27 Oct 2011 12:50:37 +0000 (14:50 +0200)]
s3:rpc_client: remove references to auth_ntlmssp_state
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct 27 16:40:15 CEST 2011 on sn-devel-104
Andreas Schneider [Thu, 27 Oct 2011 10:01:09 +0000 (12:01 +0200)]
s3: Enable uid wrapper.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Oct 27 15:06:58 CEST 2011 on sn-devel-104
Andreas Schneider [Sat, 8 Oct 2011 10:10:20 +0000 (12:10 +0200)]
replace: Add don't include unistd.h directly and add uid_wrapper.
Andreas Schneider [Fri, 7 Oct 2011 17:00:29 +0000 (19:00 +0200)]
s3: Include uid_wrapper where it is missing.
Andreas Schneider [Thu, 27 Oct 2011 10:00:53 +0000 (12:00 +0200)]
Include uid_wrapper correctly.
Andreas Schneider [Fri, 7 Oct 2011 14:01:13 +0000 (16:01 +0200)]
s3-waf: Don't link uid_wrapper more than once.
The uid_wrapper is linked in globally by default if enabled.
Andreas Schneider [Fri, 7 Oct 2011 19:06:57 +0000 (21:06 +0200)]
nsswitch: Disable uid_wrapper in libwbclient.
This way we don't have to link against it in the autoconf build.
Andreas Schneider [Sat, 8 Oct 2011 08:52:02 +0000 (10:52 +0200)]
uid_wrapper: Add uwrap_setresgid().
Andreas Schneider [Sat, 8 Oct 2011 08:08:37 +0000 (10:08 +0200)]
uid_wrapper: Fix build on UNIX platforms.
Andreas Schneider [Fri, 7 Oct 2011 16:58:58 +0000 (18:58 +0200)]
uid_wrapper: Handle euid and egid 0.
Andreas Schneider [Fri, 7 Oct 2011 16:02:33 +0000 (18:02 +0200)]
uid_wrapper: Make sure we have initialized the wrapper.
Andreas Schneider [Fri, 7 Oct 2011 16:06:53 +0000 (18:06 +0200)]
uid_wrapper: Fix prototypes.
Andreas Schneider [Sat, 8 Oct 2011 08:47:57 +0000 (10:47 +0200)]
replace: Add checks for setreuid and setregid.
Andreas Schneider [Fri, 7 Oct 2011 16:05:43 +0000 (18:05 +0200)]
replace: Make sure we compile without uid_wrapper.
Andreas Schneider [Thu, 27 Oct 2011 09:21:08 +0000 (11:21 +0200)]
s3-netlogon: Fix setting the machinge account password.
This bug has been found with uid wrapper.
Jeremy Allison [Wed, 26 Oct 2011 19:41:18 +0000 (12:41 -0700)]
Factor out the code checking if a parent should override DELETE_ACCESS into a function.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 26 23:15:05 CEST 2011 on sn-devel-104
Jeremy Allison [Wed, 26 Oct 2011 18:00:11 +0000 (11:00 -0700)]
Remove another level of indentation - deal with !NT_STATUS_OK individually.
Jeremy Allison [Wed, 26 Oct 2011 19:08:51 +0000 (12:08 -0700)]
Add early return on stat open without O_CREAT if file doesn't exist.
Reduces one level of indentation.
Stefan Metzmacher [Wed, 26 Oct 2011 13:47:21 +0000 (15:47 +0200)]
s3:libsmb: make use of map_nt_error_from_unix_common() in clitrans.c
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 26 17:53:15 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 26 Oct 2011 13:46:33 +0000 (15:46 +0200)]
s3:libsmb: avoid using smb_flg2 in cli_trans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:44:52 +0000 (15:44 +0200)]
s3:libsmb: replace smb_size - 4 with MIN_SMB_SIZE in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:43:08 +0000 (15:43 +0200)]
s3:libsmb: use 'tevent_' instead of 'event_' in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:41:34 +0000 (15:41 +0200)]
s3:libsmb: make use of smb_buffer_oob() in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 13:41:02 +0000 (15:41 +0200)]
s3:libsmb: use smb_len_nbt() in clitrans.c
metze
Stefan Metzmacher [Wed, 26 Oct 2011 12:23:48 +0000 (14:23 +0200)]
s3:include: implement trans_oob() as wrapper to smb_buffer_oob()
metze
Stefan Metzmacher [Wed, 26 Oct 2011 12:20:53 +0000 (14:20 +0200)]
libcli/smb: add smb_buffer_oob() helper
A copy of trans_oob().
metze
Günther Deschner [Wed, 26 Oct 2011 09:46:36 +0000 (11:46 +0200)]
s3-netapi: remove pointless use_memory_krb5_ccache.
This breaks the ABI.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 26 13:23:58 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 26 Oct 2011 07:28:10 +0000 (09:28 +0200)]
libcli/smb: merge NEGOTIATE_SECURITY_* flags to smb_constants.h
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 26 11:27:12 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date3() is the same as pull_dos_date3()
Except for a 'void *' vs. 'uint8_t *'.
As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.
metze
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date2() is the same as pull_dos_date2()
Except for a 'void *' vs. 'uint8_t *'.
As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.
metze
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date() is the same as pull_dos_date()
Except for a 'void *' vs. 'uint8_t *'.
As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.
metze
Björn Baumbach [Wed, 19 Oct 2011 08:54:53 +0000 (10:54 +0200)]
s3-util: dbwrap_tool: fix fetch_string function
We do not want truncated strings.
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Oct 26 04:17:05 CEST 2011 on sn-devel-104
Gregor Beck [Thu, 20 Oct 2011 15:38:06 +0000 (17:38 +0200)]
s3:net registry check: fix a case where automatic and read only mode take the wrong action
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Thu, 20 Oct 2011 15:36:10 +0000 (17:36 +0200)]
s3:net registry check: do not silently replace separators
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Sun, 23 Oct 2011 20:17:03 +0000 (22:17 +0200)]
s4:torture:smb2: fix broken indentation/formatting in torture_smb2_connection()
this was not readable well
Michael Adam [Sun, 23 Oct 2011 14:57:07 +0000 (16:57 +0200)]
talloc: fix a comment typo
Jeremy Allison [Tue, 25 Oct 2011 22:31:48 +0000 (15:31 -0700)]
Second attempt to fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.
Don't just use the first entry in back_channels as a talloc context
to allocate a long-lived chan entry on - must be NULL. It's already
correctly deleted when the last reference goes away.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 26 02:42:35 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 25 Oct 2011 13:47:10 +0000 (15:47 +0200)]
s3:smb2cli_base: make use of [_]smb_[set]len_tcp()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Oct 25 19:30:43 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 25 Oct 2011 12:56:38 +0000 (14:56 +0200)]
s3:smb2cli_base: make use of map_nt_error_from_unix_common()
metze
Stefan Metzmacher [Tue, 25 Oct 2011 13:12:05 +0000 (15:12 +0200)]
s3:lib/errmap_unix: map EPIPE to NT_STATUS_CONNECTION_DISCONNECTED
This lets map_nt_error_from_unix() return the same value as
map_nt_error_from_unix_common().
There are no callers relying on NT_STATUS_PIPE_BROKEN.
metze
Stefan Metzmacher [Tue, 25 Oct 2011 12:26:17 +0000 (14:26 +0200)]
s3:libsmb: s/event_context/tevent_context/ in async_smb.[ch]
metze
Stefan Metzmacher [Tue, 25 Oct 2011 13:53:41 +0000 (15:53 +0200)]
s3:lib/addrchange.h: include libreplace headers before others
Also we typically don't use an explicit "lib/replace/" prefix.
metze
Andrew Bartlett [Tue, 25 Oct 2011 00:26:52 +0000 (11:26 +1100)]
build: always include tevent with <tevent.h>
This ensures we do the right thing if we are built against the system
tevent.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 25 Oct 2011 00:23:54 +0000 (11:23 +1100)]
build: always include talloc with <talloc.h>
This ensures we do the right thing if we are built against the system
talloc.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Sun, 23 Oct 2011 23:05:19 +0000 (10:05 +1100)]
torture: Remove unused smbiconv
smbiconv is not used in any test script, and has only had changes
since being introduced by Jelmer to keep it building.
It is also not installed on the system. I have also checked with
Jelmer, who approved the removal.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Tue, 25 Oct 2011 10:38:41 +0000 (12:38 +0200)]
s3-libsmbclient: make some functions static in testsuite code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct 25 17:57:25 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 22:49:08 +0000 (00:49 +0200)]
s3:libsmb: make use of map_nt_error_from_unix_common() in async_smb.c
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Oct 25 03:21:06 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 16:13:09 +0000 (18:13 +0200)]
s3:libsmb: use HDR_* defines in cli_state_dispatch_smb1()
metze
Stefan Metzmacher [Mon, 24 Oct 2011 15:51:17 +0000 (17:51 +0200)]
s3:libsmb: make use of smb_[set]len_nbt() in async_smb.c
metze
Stefan Metzmacher [Mon, 24 Oct 2011 15:47:50 +0000 (17:47 +0200)]
s3:libsmb: use HDR_* defines in cli_pull_raw_error()
metze
Stefan Metzmacher [Mon, 24 Oct 2011 14:50:19 +0000 (16:50 +0200)]
libcli/smb: move smb_signing.[ch] to the toplevel
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:39:16 +0000 (09:39 +0200)]
s3:libsmb/smb_signing: make use of HDR_* defines
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:39:16 +0000 (09:39 +0200)]
s3:libsmb/smb_signing: make use of smb_len_nbt()
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:30:47 +0000 (09:30 +0200)]
s3:libsmb/smb_signing: avoid usage of smb_ss_field
metze
Stefan Metzmacher [Mon, 24 Oct 2011 15:12:51 +0000 (17:12 +0200)]
s4:libcli: rename smb_signing.h to smb_raw_signing.h in the install directory
metze
Stefan Metzmacher [Mon, 24 Oct 2011 22:22:50 +0000 (00:22 +0200)]
libcli/smb: remove unused includes from read_smb.h
metze
Jeremy Allison [Mon, 24 Oct 2011 19:20:46 +0000 (12:20 -0700)]
Try and fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.
Remove the copy of the binding handle from struct notify_back_channel, use
the direct pointer in struct rpc_pipe_client instead. Ensure we can't call
the functions with a NULL binding handle.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Oct 24 22:56:40 CEST 2011 on sn-devel-104
Günther Deschner [Mon, 24 Oct 2011 15:38:16 +0000 (17:38 +0200)]
s3-docs: Remove -Y option from winbind manpage.
This option no longer exists.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Oct 24 20:59:22 CEST 2011 on sn-devel-104
Simo Sorce [Fri, 21 Oct 2011 20:10:43 +0000 (16:10 -0400)]
idl: Improve MS-PAC IDL
Change some misleading variable names to reflect the actual function.
Add missing field name/types previously marked as unkown.
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Oct 24 19:19:28 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 09:39:28 +0000 (11:39 +0200)]
libcli/smb: merge LOCKING_ANDX_* and OPLOCK_* defines to smb_constants.h
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 17:46:47 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 09:19:06 +0000 (11:19 +0200)]
s4:libcli/raw: remove unuded CMD_REPLY define
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:55:57 +0000 (09:55 +0200)]
libcli/smb: move more defines to smb_constants.h
metze
Stefan Metzmacher [Mon, 24 Oct 2011 07:35:48 +0000 (09:35 +0200)]
libcli/smb: move CAP_* defines to smb_constants.h
metze
Stefan Metzmacher [Mon, 24 Oct 2011 09:07:32 +0000 (11:07 +0200)]
auth/gensec: fix missleading comment
We don't talloc_reference for tsocket_addresses.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 15:29:47 CEST 2011 on sn-devel-104
Andrew Bartlett [Mon, 24 Oct 2011 06:33:59 +0000 (17:33 +1100)]
libcli/smb Move smb_seal.h include to files that use it.
This is required because at the moment, smb_seal.h includes references to gssapi structures
and this causes issues with header dependencies on subsystems that otherwise do not need
a gssapi dependency.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Mon, 24 Oct 2011 05:57:29 +0000 (16:57 +1100)]
lib/util/charset Remove unused header smb_common.h
This should fix a compile issue on hosts without gssapi/gssapi.h.
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 24 Oct 2011 06:42:10 +0000 (08:42 +0200)]
libcli/smb: move source3/libsmb/read_smb.* to the toplevel
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 10:18:06 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 24 Oct 2011 06:41:15 +0000 (08:41 +0200)]
s3:libsmb/read_smb: make use of smb_len_tcp()
metze
Stefan Metzmacher [Tue, 20 Sep 2011 02:47:21 +0000 (04:47 +0200)]
s3:libsmb: remove unused sync read_smb()
metze
Stefan Metzmacher [Tue, 20 Sep 2011 02:43:05 +0000 (04:43 +0200)]
s3:torture: avoid using read_smb()
metze
Stefan Metzmacher [Sat, 22 Oct 2011 07:38:22 +0000 (09:38 +0200)]
talloc: simplifiy the logic to build talloc_testsuite in the standalone build
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Oct 22 13:15:52 CEST 2011 on sn-devel-104
Stefan Metzmacher [Fri, 21 Oct 2011 11:42:34 +0000 (13:42 +0200)]
lib/util: remove the "includes.h" dependeny from xfile.c
metze
Stefan Metzmacher [Fri, 21 Oct 2011 11:42:34 +0000 (13:42 +0200)]
lib/util: remove the "includes.h" dependeny from util_file.c
metze
Stefan Metzmacher [Fri, 21 Oct 2011 11:18:25 +0000 (13:18 +0200)]
dynconfig: replace #if (_SAMBA_BUILD_ >= 4) by feature tests
metze
Stefan Metzmacher [Fri, 21 Oct 2011 11:17:22 +0000 (13:17 +0200)]
talloc/testsuite: remove #if _SAMBA_BUILD_==3
We don't include "includes.h" anymore...
metze
Stefan Metzmacher [Fri, 21 Oct 2011 11:16:44 +0000 (13:16 +0200)]
auth/gensec: replace #if _SAMBA_BUILD_ == 4 by a feature test
metze
Jeremy Allison [Sat, 22 Oct 2011 01:35:15 +0000 (18:35 -0700)]
Third part of fix for bug #8541 - readlink() on Linux clients fails if the symlink target is outside of the share.
Missed passing ucf_flags instead of hard coded flags in findfirst call.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 22 06:30:16 CEST 2011 on sn-devel-104
Jeremy Allison [Sat, 22 Oct 2011 00:46:12 +0000 (17:46 -0700)]
Second part of fix for bug #8541 - readlink() on Linux clients fails if the symlink target is outside of the share.
The statcache has to do lstat instead of stat when returning cached
posix pathnames.
Stefan Metzmacher [Sat, 22 Oct 2011 01:09:59 +0000 (03:09 +0200)]
s4:finddcs_cldap: talloc free old memory before allocating a new netlogon struct
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Oct 22 04:55:54 CEST 2011 on sn-devel-104
Stefan Metzmacher [Sat, 22 Oct 2011 01:09:59 +0000 (03:09 +0200)]
s4:finddcs_cldap: close the socket when it's not used anymore
The amount of possible fd's might be restricted, so close them early.
metze
Stefan Metzmacher [Sat, 22 Oct 2011 01:09:59 +0000 (03:09 +0200)]
s4:finddcs_cldap: finddcs_cldap_recv() returns NTSTATUS
We need to convert the errno based error to NTSTATUS
before calling tevent_req_error (via tevent_req_nterror).
metze