From: Ralph Boehme <slow@samba.org>
Date: Fri, 9 Nov 2018 11:19:16 +0000 (+0100)
Subject: s4:torture/smb2/session: add force_signing to test_session_expire1i
X-Git-Tag: tdb-1.3.17~788
X-Git-Url: http://git.samba.org/samba.git/?p=vlendec%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=5fdea4095ac82536192c8d91c411b22e2683a5c1

s4:torture/smb2/session: add force_signing to test_session_expire1i

Existing callers pass true, so no change in behaviour. The next commit
adds an additional test that passes force_signing=false.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13661

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source4/torture/smb2/session.c b/source4/torture/smb2/session.c
index a088754ec00..0a0b54774e2 100644
--- a/source4/torture/smb2/session.c
+++ b/source4/torture/smb2/session.c
@@ -1047,6 +1047,7 @@ done:
 
 
 static bool test_session_expire1i(struct torture_context *tctx,
+				  bool force_signing,
 				  bool force_encryption)
 {
 	NTSTATUS status;
@@ -1078,7 +1079,9 @@ static bool test_session_expire1i(struct torture_context *tctx,
 	lpcfg_set_option(tctx->lp_ctx, "gensec_gssapi:requested_life_time=4");
 
 	lpcfg_smbcli_options(tctx->lp_ctx, &options);
-	options.signing = SMB_SIGNING_REQUIRED;
+	if (force_signing) {
+		options.signing = SMB_SIGNING_REQUIRED;
+	}
 
 	status = smb2_connect(tctx,
 			      host,
@@ -1191,12 +1194,14 @@ done:
 static bool test_session_expire1s(struct torture_context *tctx)
 {
 	return test_session_expire1i(tctx,
+				     true,   /* force_signing */
 				     false); /* force_encryption */
 }
 
 static bool test_session_expire1e(struct torture_context *tctx)
 {
 	return test_session_expire1i(tctx,
+				     true,   /* force_signing */
 				     true); /* force_encryption */
 }