s3-torture Remove t_stringoverflow as fstrcpy now uses strlcpy
authorAndrew Bartlett <abartlet@samba.org>
Wed, 26 Oct 2011 06:30:45 +0000 (17:30 +1100)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 28 Oct 2011 11:10:28 +0000 (13:10 +0200)
Because we no longer use safe_strcpy() internally, we no longer have a
mode where we write to the end of the buffer in developer mode, and so
there isn't anything for this test to test.

Andrew Bartlett

source3/Makefile.in
source3/torture/t_stringoverflow.c [deleted file]

index b8841e6c913f0ca7c5fe89850a479dd7742ad561..b1c8a57b9f795c713bcd13a93ba9838f660fc5ec 100644 (file)
@@ -3184,10 +3184,6 @@ bin/tdbtorture@EXEEXT@: $(BINARY_PREREQS) $(TDBTORTURE_OBJ) $(LIBTALLOC) $(LIBTD
        @$(CC) -o $@ $(LDFLAGS) $(TDBTORTURE_OBJ) $(DYNEXP) \
                $(LIBS) $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
 
-bin/t_stringoverflow@EXEEXT@: $(BINARY_PREREQS) bin/libbigballofmud.@SHLIBEXT@ torture/t_stringoverflow.o
-       $(CC) -o $@ $(DYNEXP) torture/t_stringoverflow.o \
-               -L./bin -lbigballofmud $(LIBWBCLIENT_LIBS)
-
 bin/timelimit@EXEEXT@: script/tests/timelimit.o
        @echo Linking $@
        @$(CC) -o $@ $(DYNEXP) script/tests/timelimit.o
diff --git a/source3/torture/t_stringoverflow.c b/source3/torture/t_stringoverflow.c
deleted file mode 100644 (file)
index 17765e6..0000000
+++ /dev/null
@@ -1,23 +0,0 @@
-#include "includes.h"
-
- int main(void)
-{
-       char dest[100];
-       char *ptr = dest;
-
-       printf("running on valgrind? %d\n", RUNNING_ON_VALGRIND);
-
-       /* Try copying a string into an fstring buffer.  The string
-        * will actually fit, but this is still wrong because you
-        * can't pstrcpy into an fstring.  This should trap in a
-        * developer build. */
-
-#if 0
-       /* As of CVS 20030318, this will be trapped at compile time! */
-       pstrcpy(dest, "hello");
-#endif /* 0 */
-
-       fstrcpy(ptr, "hello!");
-
-       return 0;
-}