CVE-2018-1139 s3-utils: use enum ntlm_auth_level in ntlm_password_check().
authorGünther Deschner <gd@samba.org>
Wed, 14 Mar 2018 14:35:01 +0000 (15:35 +0100)
committerKarolin Seeger <kseeger@samba.org>
Sat, 11 Aug 2018 06:16:03 +0000 (08:16 +0200)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13360

CVE-2018-1139: Weak authentication protocol allowed.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/utils/ntlm_auth.c

index 3f54490..8f77680 100644 (file)
@@ -1010,7 +1010,7 @@ static NTSTATUS local_pw_check(struct auth4_context *auth4_context,
        *pauthoritative = 1;
 
        nt_status = ntlm_password_check(mem_ctx,
-                                       true, true, 0,
+                                       true, NTLM_AUTH_ON, 0,
                                        &auth4_context->challenge.data,
                                        &user_info->password.response.lanman,
                                        &user_info->password.response.nt,
@@ -1719,7 +1719,9 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
 
                                nt_lm_owf_gen (opt_password, nt_pw.hash, lm_pw.hash);
                                nt_status = ntlm_password_check(mem_ctx,
-                                                               true, true, 0,
+                                                               true,
+                                                               NTLM_AUTH_ON,
+                                                               0,
                                                                &challenge,
                                                                &lm_response,
                                                                &nt_response,