s4/param/provision py_dom_sid_FromSid: avoid python memleak

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Jan 29 16:54:48 CET 2019 on sn-devel-144

diff --git a/source4/param/provision.c b/source4/param/provision.c
index 153850667b12742234d1987243cdc35b9da3fa4e..ee84cd021e1fa60828d6bad8f300e2e6ea9b503d 100644 (file)
--- a/source4/param/provision.c
+++ b/source4/param/provision.c
@@ -199,13 +199,15 @@ static PyObject *py_dom_sid_FromSid(struct dom_sid *sid)
        PyObject *mod_security, *dom_sid_Type;
 
        mod_security = PyImport_ImportModule("samba.dcerpc.security");
-       if (mod_security == NULL)
+       if (mod_security == NULL) {
                return NULL;
-
+       }
        dom_sid_Type = PyObject_GetAttrString(mod_security, "dom_sid");
-       if (dom_sid_Type == NULL)
+       if (dom_sid_Type == NULL) {
+               Py_DECREF(mod_security);
                return NULL;
-
+       }
+       Py_DECREF(mod_security);
        return pytalloc_reference((PyTypeObject *)dom_sid_Type, sid);
 }