selftest: Load time_audit and full_audit modules for all tests
authorChristof Schmitt <cs@samba.org>
Fri, 10 Aug 2018 17:38:28 +0000 (10:38 -0700)
committerKarolin Seeger <kseeger@samba.org>
Thu, 23 Aug 2018 08:38:28 +0000 (10:38 +0200)
Previously the only test was to load these modules to trigger the
smb_vfs_assert_all_fns check. As these modules just pass through the
calls, they can be loaded for all tests to ensure that the codepaths are
exercised. This would have found the problem in
smb_time_audit_offload_read_recv.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13568

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Aug 13 22:35:20 CEST 2018 on sn-devel-144

(cherry picked from commit a98f09a09db2fc7be85f9171b586e65344a39e92)

selftest/target/Samba3.pm

index 1ee5242fdfac62fdcf47fde9641a84db264ca605..f6f852dde06b3a73328c2c713efdf5ff493244ad 100755 (executable)
@@ -790,14 +790,10 @@ sub setup_simpleserver($$)
        my $simpleserver_options = "
        lanman auth = yes
        ntlm auth = yes
        my $simpleserver_options = "
        lanman auth = yes
        ntlm auth = yes
-       vfs objects = xattr_tdb streams_depot time_audit full_audit
+       vfs objects = xattr_tdb streams_depot
        change notify = no
        smb encrypt = off
 
        change notify = no
        smb encrypt = off
 
-       full_audit:syslog = no
-       full_audit:success = none
-       full_audit:failure = none
-
 [vfs_aio_fork]
        path = $prefix_abs/share
         vfs objects = aio_fork
 [vfs_aio_fork]
        path = $prefix_abs/share
         vfs objects = aio_fork
@@ -1747,7 +1743,11 @@ sub provision($$$$$$$$$)
        dos filemode = yes
        strict rename = yes
        strict sync = yes
        dos filemode = yes
        strict rename = yes
        strict sync = yes
-       vfs objects = acl_xattr fake_acls xattr_tdb streams_depot
+       vfs objects = acl_xattr fake_acls xattr_tdb streams_depot time_audit full_audit
+
+       full_audit:syslog = no
+       full_audit:success = none
+       full_audit:failure = none
 
        printing = vlp
        print command = $bindir_abs/vlp tdbfile=$lockdir/vlp.tdb print %p %s
 
        printing = vlp
        print command = $bindir_abs/vlp tdbfile=$lockdir/vlp.tdb print %p %s