CVE-2019-3880 s3: rpc: winreg: Remove implementations of SaveKey/RestoreKey.
authorJeremy Allison <jra@samba.org>
Thu, 21 Mar 2019 21:51:30 +0000 (14:51 -0700)
committerKarolin Seeger <kseeger@samba.org>
Mon, 8 Apr 2019 10:27:34 +0000 (10:27 +0000)
commitc79f719a840dfa5e9682462ea58c8f48ca0012e5
tree0b715b7d3443defdab36e02a472ba85739ac2801
parent17b3d2ebffd2775a3f7f5cdbe4330855f2e1b356
CVE-2019-3880 s3: rpc: winreg: Remove implementations of SaveKey/RestoreKey.

The were not using VFS backend calls and could only work
locally, and were unsafe against symlink races and other
security issues.

If the incoming handle is valid, return WERR_BAD_PATHNAME.

[MS-RRP] states "The format of the file name is implementation-specific"
so ensure we don't allow this.

As reported by Michael Hanselmann.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13851

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/rpc_server/winreg/srv_winreg_nt.c