s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.
authorJeremy Allison <jra@samba.org>
Thu, 12 Jul 2018 19:18:50 +0000 (12:18 -0700)
committerKarolin Seeger <kseeger@samba.org>
Mon, 13 Aug 2018 10:56:35 +0000 (12:56 +0200)
commita970d45d1774b5b55bea23488035ca44de0cb7f2
tree2b0a72f54403956ec8663aa1e390ff76438163bd
parent41302b40301b410ca618c92df67394de51d6b1bc
s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.

We were always asking for SPLICE_BLOCK_SIZE even when the
remaining bytes we wanted were smaller than that. This works
when using cli_splice() on a complete file, as the cli_read()
terminated the read at the right place. We always have the
space to read SPLICE_BLOCK_SIZE bytes so this isn't an overflow.

Found by Bailey Berro <baileyberro@google.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527

Signed-off-by: Bailey Berro <baileyberro@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jul 13 14:57:14 CEST 2018 on sn-devel-144

(cherry picked from commit c9656fd2977557ab20ec4e3d87c385a9b2f1bf43)
selftest/knownfail
source3/libsmb/clireadwrite.c