Modified revamp of the libsmbclient interface.
authorDerrell Lipman <derrell.lipman@unwireduniverse.com>
Fri, 29 Feb 2008 18:34:35 +0000 (13:34 -0500)
committerDerrell Lipman <derrell.lipman@unwireduniverse.com>
Sun, 2 Mar 2008 01:47:22 +0000 (20:47 -0500)
commit4ba42cbe0f6bbd25848786e1a87c06aca79b98ea
treefa2417599eca2565d0a3f8ace8ef005909fcd6ab
parent257b7b09298f7cb983b2f31b87fc5e46e0f62f0c
Modified revamp of the libsmbclient interface.

Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach.  This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility.  I retain, here, the setter and getter functions which all new
code should use.  Older programs already compiled should continue to work
fine.  Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.

Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval.  I hope that this compromise is adequate.

Derrell
(This used to be commit 56429a3d60b2a48963342f6340b3c01469a892c6)
source3/include/libsmb_internal.h
source3/include/libsmbclient.h
source3/libsmb/libsmb_cache.c
source3/libsmb/libsmb_context.c
source3/libsmb/libsmb_dir.c
source3/libsmb/libsmb_file.c
source3/libsmb/libsmb_path.c
source3/libsmb/libsmb_printjob.c
source3/libsmb/libsmb_server.c
source3/libsmb/libsmb_stat.c
source3/libsmb/libsmb_xattr.c