ctdb-scripts: Don't bother checking PID file when starting ctdbd

[vlendec/samba-autobuild/.git] / ctdb / tcp / tcp_io.c

diff --git a/ctdb/tcp/tcp_io.c b/ctdb/tcp/tcp_io.c
index 3e267e504cdbf70da9a8f3126dae2fd9e409bc38..5bb4b5bd1a7bdd54425f599a824f62345d8bc3a6 100644 (file)
--- a/ctdb/tcp/tcp_io.c
+++ b/ctdb/tcp/tcp_io.c
@@ -3,28 +3,32 @@
 
    Copyright (C) Andrew Tridgell  2006
 
-   This library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2 of the License, or (at your option) any later version.
-
-   This library is distributed in the hope that it will be useful,
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with this library; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, see <http://www.gnu.org/licenses/>.
 */
 
-#include "includes.h"
-#include "lib/events/events.h"
-#include "lib/util/dlinklist.h"
-#include "lib/tdb/include/tdb.h"
+#include "replace.h"
 #include "system/network.h"
 #include "system/filesys.h"
-#include "../include/ctdb_private.h"
+
+#include "lib/util/dlinklist.h"
+#include "lib/util/debug.h"
+
+#include "ctdb_private.h"
+
+#include "common/common.h"
+#include "common/logging.h"
+
 #include "ctdb_tcp.h"
 
 
@@ -34,38 +38,49 @@
 void ctdb_tcp_read_cb(uint8_t *data, size_t cnt, void *args)
 {
        struct ctdb_incoming *in = talloc_get_type(args, struct ctdb_incoming);
-       struct ctdb_req_header *hdr;
+       struct ctdb_req_header *hdr = (struct ctdb_req_header *)data;
 
        if (data == NULL) {
                /* incoming socket has died */
-               talloc_free(in);
-               return;
+               goto failed;
        }
 
        if (cnt < sizeof(*hdr)) {
-               ctdb_set_error(in->ctdb, "Bad packet length %u\n", (unsigned)cnt);
-               return;
+               DEBUG(DEBUG_ALERT,(__location__ " Bad packet length %u\n", (unsigned)cnt));
+               goto failed;
+       }
+
+       if (cnt & (CTDB_TCP_ALIGNMENT-1)) {
+               DEBUG(DEBUG_ALERT,(__location__ " Length 0x%x not multiple of alignment\n", 
+                        (unsigned)cnt));
+               goto failed;
        }
-       hdr = (struct ctdb_req_header *)data;
+
+
        if (cnt != hdr->length) {
-               ctdb_set_error(in->ctdb, "Bad header length %u expected %u\n", 
-                              (unsigned)hdr->length, (unsigned)cnt);
-               return;
+               DEBUG(DEBUG_ALERT,(__location__ " Bad header length %u expected %u\n", 
+                        (unsigned)hdr->length, (unsigned)cnt));
+               goto failed;
        }
 
        if (hdr->ctdb_magic != CTDB_MAGIC) {
-               ctdb_set_error(in->ctdb, "Non CTDB packet rejected\n");
-               return;
+               DEBUG(DEBUG_ALERT,(__location__ " Non CTDB packet 0x%x rejected\n", 
+                        hdr->ctdb_magic));
+               goto failed;
        }
 
-       if (hdr->ctdb_version != CTDB_VERSION) {
-               ctdb_set_error(in->ctdb, "Bad CTDB version 0x%x rejected\n", hdr->ctdb_version);
-               return;
+       if (hdr->ctdb_version != CTDB_PROTOCOL) {
+               DEBUG(DEBUG_ALERT, (__location__ " Bad CTDB version 0x%x rejected\n", 
+                         hdr->ctdb_version));
+               goto failed;
        }
 
-       /* most common case - we got a whole packet in one go
-          tell the ctdb layer above that we have a packet */
+       /* tell the ctdb layer above that we have a packet */
        in->ctdb->upcalls->recv_pkt(in->ctdb, data, cnt);
+       return;
+
+failed:
+       talloc_free(in);
 }
 
 /*
@@ -75,5 +90,5 @@ int ctdb_tcp_queue_pkt(struct ctdb_node *node, uint8_t *data, uint32_t length)
 {
        struct ctdb_tcp_node *tnode = talloc_get_type(node->private_data,
                                                      struct ctdb_tcp_node);
-       return ctdb_queue_send(tnode->queue, data, length);
+       return ctdb_queue_send(tnode->out_queue, data, length);
 }