10 years agonet_dns: Make "lwinet ads dns register" honor the "interfaces" parameter. v3-2-test
Gerald (Jerry) Carter [Fri, 3 Oct 2008 15:51:54 +0000 (10:51 -0500)]
net_dns: Make "lwinet ads dns register" honor the "interfaces" parameter.

This is helpful on multihomed hosts that only require a subset
of IP addresses be registered with DNS.
(cherry picked from commit 17c9f8810598d8117befc896d12a597a52b0ac3b)

10 years agolibaddns: Use the same prerequisite for DDNS update as Windows XP.
Gerald (Jerry) Carter [Fri, 3 Oct 2008 15:51:21 +0000 (10:51 -0500)]
libaddns: Use the same prerequisite for DDNS update as Windows XP.


This has to have been broken for ages.  I cannot see
how it would have worked in any environment.
(cherry picked from commit 6b6402bce318a48b0890ed6fc23ed5b30440927b)

10 years agoFix bug #5080. Access to cups-printers via samba broken with cups 1.3.4, Unsupported...
Jeremy Allison [Thu, 2 Oct 2008 21:02:20 +0000 (14:02 -0700)]
Fix bug #5080. Access to cups-printers via samba broken with cups 1.3.4, Unsupported character set.
Cups 1.3.4 expects utf8 to be used in all messages to/from the server. We may be using a
different character set so we need to use talloc utf8 push/pull functions in all communication.
Contains the !server fix already applied to 3.3.

10 years agoFix bug 5805: don't close stdout
Derrell Lipman [Thu, 2 Oct 2008 13:17:49 +0000 (09:17 -0400)]
Fix bug 5805: don't close stdout

- When calling setup_logging multiple times, the code was closing the debug
  file descriptor before opening or assigning the new one.  We don't, however,
  want to close the debug file descriptor if it is stdout.


10 years agoWhitespace cleanup.
Jeremy Allison [Wed, 1 Oct 2008 22:00:35 +0000 (15:00 -0700)]
Whitespace cleanup.

10 years agoFix use of DLIST_REMOVE as spotted by Constantine Vetoshev <>.
Jeremy Allison [Wed, 1 Oct 2008 20:22:02 +0000 (13:22 -0700)]
Fix use of DLIST_REMOVE as spotted by Constantine Vetoshev <>.
This API is unusual in that if used to remove a non-list head it nulls out
the next and prev pointers. This is what you want for debugging (don't want
an entry removed from the list to be still virtually linked into it) but
means there is no consistent idiom for use as the next and prev pointers
get trashed on removal from the list, meaning you must save them yourself.
You can use it one way when deleting everything via the head pointer, as
this preserves the next pointer, but you *must* use it another way when not
deleting everything via the head pointer. Fix all known uses of this (the main
one is in conn_free_internal() and would not free all the private data entries
for vfs modules. The other changes in web/statuspage.c and winbindd_util.c
are not strictly neccessary, as the head pointer is being used, but I've done
them for consistency. Long term we must revisit this as this API is too hard
to use correctly.

10 years agoTurn the socket connections into a refcounted list - in the common case there'll...
Jeremy Allison [Wed, 1 Oct 2008 19:30:12 +0000 (12:30 -0700)]
Turn the socket connections into a refcounted list - in the common case there'll now only be one socket per smbd.
Changed the format of the wire data to (a) include a version number (V1) as the first element. (b) removed the
";)" at the end an replaced it with a "\n". Receiver can change back if needed, and now receiver can just log
"as-is" to a text file (making testing easier). Added my (C). Sorry Holger, but I've changed quite a bit now.

10 years agoConvert to allocated strings. Use write_data(), not send as this doesn't correctly
Jeremy Allison [Tue, 30 Sep 2008 23:20:29 +0000 (16:20 -0700)]
Convert to allocated strings. Use write_data(), not send as this doesn't correctly
deal with EINTR. Jim and Holger please check this still works.

10 years agoRestructure the module so it connects to the remote data sink
Jeremy Allison [Tue, 30 Sep 2008 22:09:49 +0000 (15:09 -0700)]
Restructure the module so it connects to the remote data sink
on connect, and closes the socket on client disconnect. This should
make it much more efficient. Store the remote fd in a private data
pointer off the handle. Finally we need to remove the fstrings and
convert to allocated buffer storage.

10 years agoFix the make test problem Karolin reported. Now rename_open_files actually works...
Jeremy Allison [Tue, 30 Sep 2008 20:21:27 +0000 (13:21 -0700)]
Fix the make test problem Karolin reported. Now rename_open_files actually works correctly we must emit the change notify before we change the name, not before.

10 years agore-added "winbind:ignore domains" patch
Andrew Tridgell [Mon, 29 Sep 2008 23:04:23 +0000 (16:04 -0700)]
re-added "winbind:ignore domains" patch

This option really is essential, as we discover again and again at
customer sites. Due to bugs in winbind some domains are toxic. When
you are installing at a site and a particular domain in a complex
setup causes winbind to segfault or hang then you need a way to
disable that domain and continue.

In an ideal world winbind could handle arbitrarily complex ADS
domains, but we are nowhere near that yet. If we ever get to that
stage then we won't need this option.

10 years agofixed segv on startup with trusted domains
Andrew Tridgell [Mon, 29 Sep 2008 18:24:00 +0000 (11:24 -0700)]
fixed segv on startup with trusted domains

With some setups, idmap_tdb2_allocate_id can be called before the
allocate backend is initialised, leading to a segv. This change
ensures that the db is opened in all paths that use it

10 years agoEnsure we null out fsp after a close in all paths.
Jeremy Allison [Mon, 29 Sep 2008 17:57:32 +0000 (10:57 -0700)]
Ensure we null out fsp after a close in all paths.

10 years agoAvoid freeing fsp twice when opening new_file fails. (Debian #431696)
Jelmer Vernooij [Mon, 29 Sep 2008 17:53:36 +0000 (10:53 -0700)]
Avoid freeing fsp twice when opening new_file fails. (Debian #431696)
If opening new_file fails, fsp would still be set to the files_struct of

10 years agoAdd an initial version of a manpage for the vfs_smb_traffic_analyzer module.
Holger Hetterich [Mon, 29 Sep 2008 12:34:36 +0000 (14:34 +0200)]
Add an initial version of a manpage for the vfs_smb_traffic_analyzer module.

10 years agoSecond part of the fix for bug #5790 - samba returns STATUS_OBJECT_NAME_NOT_FOUND...
Jeremy Allison [Sat, 27 Sep 2008 01:37:33 +0000 (18:37 -0700)]
Second part of the fix for bug #5790 - samba returns STATUS_OBJECT_NAME_NOT_FOUND on set file disposition call.
This was my fault. I use a singleton cache (positive and negative) to speed up pathname based qfileinfo/setfileinfo lookups for alternate fsp's open on the same path. I only invalidated the negative cache on adding a new file fsp, as I incorrectly imagined the new fsp was put at the *end* of the open files list. DLIST_ADD puts it at the start, meaning any subsequent open wasn't seen once the cache was set. Doh !

10 years agoFix bug #5797 - Moving readonly files fails. Reported by
Jeremy Allison [Fri, 26 Sep 2008 22:18:18 +0000 (15:18 -0700)]
Fix bug #5797 - Moving readonly files fails. Reported by
We don't need to deny a DELETE open on a readonly file (I'm also adding a s4
torture test for this), the set_file_disposition call will return
NT_STATUS_CANNOT_DELETE if the delete-on-close bit is set
on a readonly file (and we already do this).

10 years agos3-srvsvc: fix _srvsvc_NetShareAdd segfault.
Günther Deschner [Thu, 25 Sep 2008 23:32:16 +0000 (01:32 +0200)]
s3-srvsvc: fix _srvsvc_NetShareAdd segfault.

parm_err is not a ref pointer.

(cherry picked from commit 29942b7043c1a31ad4fb76d01ab19fd3dbf26f0a)

10 years agoUse IPv4/v6 independent calls. Change safe_strcpy/cat to strlcpy/cat (this
Jeremy Allison [Thu, 25 Sep 2008 18:56:10 +0000 (11:56 -0700)]
Use IPv4/v6 independent calls. Change safe_strcpy/cat to strlcpy/cat (this
needs changing to talloc_sprintf) and fix file descriptor resource leaks
in error paths. Jim and Holger please check !

10 years agoFix the new vfs_smb_traffic_analyzer build for static links
Jim McDonough [Thu, 25 Sep 2008 00:47:03 +0000 (20:47 -0400)]
Fix the new vfs_smb_traffic_analyzer build for static links

10 years agoSMB traffic analyzer vfs module from Holger Hetterich <>
Holger Hetterich [Wed, 24 Sep 2008 23:01:00 +0000 (19:01 -0400)]
SMB traffic analyzer vfs module from Holger Hetterich <>

Used to gather data to feed to a database for live and historical
analysis of usage per user, per share, etc.

Helper apps to read the data still to come.  This one still needs to be
made ipv6 enabled (connection is made to the helper app).

10 years agoFix bug #5790 samba returns STATUS_OBJECT_NAME_NOT_FOUND on set file disposition.
Jeremy Allison [Wed, 24 Sep 2008 21:26:06 +0000 (14:26 -0700)]
Fix bug #5790 samba returns STATUS_OBJECT_NAME_NOT_FOUND on set file disposition.
We were checking that fd != -1 in file_find_di_XXX calls which is no longer
needed due to a change in internal semantics.

10 years agoFix winbindd crash in an unusual failure mode. Bug #5737. Based on original patch...
Jeremy Allison [Tue, 23 Sep 2008 23:38:04 +0000 (16:38 -0700)]
Fix winbindd crash in an unusual failure mode. Bug #5737. Based on original patch from

10 years agoFix bug #5783 FindFirst fails where search pattern == mangled filename.
Jeremy Allison [Tue, 23 Sep 2008 22:04:18 +0000 (15:04 -0700)]
Fix bug #5783 FindFirst fails where search pattern == mangled filename.
That was an old and subtle bug.

10 years agoAttempt to fix bug 5778
Volker Lendecke [Sun, 21 Sep 2008 18:39:17 +0000 (20:39 +0200)]
Attempt to fix bug 5778

Jeff, Steve, please check!
(cherry picked from commit 110756cc7bcaed5a9d6aa58f3b3fe4481f8d1f31)

10 years agobuild: don't install the cifs.upcall binary twice.
Günther Deschner [Fri, 5 Sep 2008 12:01:45 +0000 (14:01 +0200)]
build: don't install the cifs.upcall binary twice.

(cherry picked from commit 1f44b4aaa5f700827ee2ab272ae4b59e559b094b)
(cherry picked from commit 020c03bff844ef976dd786a755c4d682bf161a3d)
(cherry picked from commit 5a9a190a5588b0cf938bc5c9659b7704d18cd4a3)

10 years agobuild-docs: Add 'make clean'.
Karolin Seeger [Thu, 18 Sep 2008 13:52:06 +0000 (15:52 +0200)]
build-docs: Add 'make clean'.

(cherry picked from commit cf40fb97239ed9a11e5750fde6e078233e567bba)
(cherry picked from commit 6e1d92e3b324a0759486f914a0e4b32be1142aee)

10 years agoWHATSNEW: Start WHATSNEW for 3.2.5.
Karolin Seeger [Thu, 18 Sep 2008 13:58:02 +0000 (15:58 +0200)]
WHATSNEW: Start WHATSNEW for 3.2.5.


10 years agoVERSION: Raise version number up to 3.2.5.
Karolin Seeger [Thu, 18 Sep 2008 13:56:02 +0000 (15:56 +0200)]
VERSION: Raise version number up to 3.2.5.


10 years Adapt script to changed directory structure.
Karolin Seeger [Wed, 17 Sep 2008 06:48:19 +0000 (08:48 +0200)] Adapt script to changed directory structure.

(cherry picked from commit b6b7aa023b62ab8994d13cb91d5185204c1500b2)

10 years agoWHATSNEW: Improve description of Simo's bug fix.
Karolin Seeger [Thu, 18 Sep 2008 06:46:54 +0000 (08:46 +0200)]
WHATSNEW: Improve description of Simo's bug fix.


10 years agoEnsure all pointers are initialized. Without this we can crash when looking up a...
Jeremy Allison [Wed, 17 Sep 2008 18:59:18 +0000 (11:59 -0700)]
Ensure all pointers are initialized. Without this we can crash when looking up a non-existant uid.

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Wed, 17 Sep 2008 13:32:51 +0000 (15:32 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agoidmap_ad: Fix a segfault when calling nss_get_info() with a NULL ads structure.
Gerald W. Carter [Mon, 15 Sep 2008 17:38:36 +0000 (12:38 -0500)]
idmap_ad: Fix a segfault when calling nss_get_info() with a NULL ads structure.

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Tue, 16 Sep 2008 07:54:12 +0000 (09:54 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agoman cifs.upcall: Fix typo, wrap lines.
Karolin Seeger [Mon, 15 Sep 2008 14:33:16 +0000 (16:33 +0200)]
man cifs.upcall: Fix typo, wrap lines.

(cherry picked from commit c4f361a17f51e4897ac2faafc65ebc8349e19001)

10 years agoFix aio on FreeBSD.
Timur [Tue, 16 Sep 2008 01:43:26 +0000 (18:43 -0700)]
Fix aio on FreeBSD.

10 years agoFix display of POSIX ACLs.
Timur [Tue, 16 Sep 2008 01:24:58 +0000 (18:24 -0700)]
Fix display of POSIX ACLs.

10 years agoFix cut and paste error in quota code.
Timur [Tue, 16 Sep 2008 01:19:01 +0000 (18:19 -0700)]
Fix cut and paste error in quota code.

10 years agoSimple fix for warning:
Steven Danneman [Tue, 16 Sep 2008 00:55:22 +0000 (17:55 -0700)]
Simple fix for warning:

Compiling utils/sharesec.c
utils/sharesec.c: In function `change_share_sec':
utils/sharesec.c:404: warning: 'sd' might be used uninitialized in this function

10 years agoFix build warning on FreeBSD
Steven Danneman [Mon, 15 Sep 2008 23:28:30 +0000 (16:28 -0700)]
Fix build warning on FreeBSD

Fix for the following build warning:

Compiling torture/cmd_vfs.c
torture/cmd_vfs.c: In function `cmd_open':
torture/cmd_vfs.c:275: warning: unsigned int format, different type arg (arg 3)
torture/cmd_vfs.c: In function `cmd_mknod':
torture/cmd_vfs.c:992: warning: unsigned int format, different type arg (arg 3)

sccanf had mismatched types for mode_t between formating parameter and var args.

10 years agoFix bug 5761 "open of mangled directory name results in 'is a stream name'"
Jeremy Allison [Mon, 15 Sep 2008 21:13:23 +0000 (14:13 -0700)]
Fix bug 5761 "open of mangled directory name results in 'is a stream name'"
reported by Regan Heath <>.

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Mon, 15 Sep 2008 09:08:06 +0000 (11:08 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agomount.cifs: make local versions of strlcat and strlcpy static
Jeff Layton [Sun, 14 Sep 2008 12:37:45 +0000 (08:37 -0400)]
mount.cifs: make local versions of strlcat and strlcpy static silence -Wmissing-prototypes

Signed-off-by: Jeff Layton <>
10 years agocifs.upcall: make most functions static and silence compiler warnings
Jeff Layton [Sun, 14 Sep 2008 12:37:45 +0000 (08:37 -0400)]
cifs.upcall: make most functions static and silence compiler warnings silence -Wmissing-prototypes and some uninit'ed variable
warnings. Thanks to GD for the extra-paranoid compiler flags.

Signed-off-by: Jeff Layton <>
10 years agoModify a comment to make things clearer.
Jeremy Allison [Fri, 12 Sep 2008 22:04:11 +0000 (15:04 -0700)]
Modify a comment to make things clearer.

10 years agocifs.upcall: move default install location to EPREFIX/sbin
Jeff Layton [Fri, 12 Sep 2008 17:37:13 +0000 (13:37 -0400)]
cifs.upcall: move default install location to EPREFIX/sbin

cifs.upcall links to libraries that live under /usr, so installing it
in /sbin doesn't seem appropriate. Move it to EPREFIX/sbin instead
(i.e. /usr/sbin).

Signed-off-by: Jeff Layton <>
10 years agocifs.upcall: enable building by default on linux
Jeff Layton [Fri, 12 Sep 2008 17:37:13 +0000 (13:37 -0400)]
cifs.upcall: enable building by default on linux

When building on linux, default to building cifs.upcall. Throw a
warning if ADS support is disabled or keyutils isn't installed.

Signed-off-by: Jeff Layton <>
10 years agoUse the given name, not the absolute pathname, when printing out ACL info.
Jeremy Allison [Fri, 12 Sep 2008 00:31:36 +0000 (17:31 -0700)]
Use the given name, not the absolute pathname, when printing out ACL info.
Make this match the non-ACL case.

10 years agoFix bug #5751 cannot show ACLs on DFS reported by SATOH Fumiyasu <fumiyas@osstech...
Jeremy Allison [Thu, 11 Sep 2008 23:18:54 +0000 (16:18 -0700)]
Fix bug #5751 cannot show ACLs on DFS reported by SATOH Fumiyasu <>.
Fix for smbclient and libsmbclient.

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Thu, 11 Sep 2008 14:09:32 +0000 (16:09 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agoFix for bug 5571
Simo Sorce [Thu, 11 Sep 2008 13:51:39 +0000 (09:51 -0400)]
Fix for bug 5571
Make sure that usernames are parsed using the correct separator.
Otherwise group memeberships in winbind may be result broken.

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Thu, 11 Sep 2008 11:48:25 +0000 (13:48 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agopackaging(RHEL): fix direction of link (.so) of nss libs.
Michael Adam [Wed, 10 Sep 2008 21:31:26 +0000 (23:31 +0200)]
packaging(RHEL): fix direction of link (.so) of nss libs. -> ->


10 years agopackaging(RHEL): workaround all library installations by mv to %{_libarchdir}
Michael Adam [Wed, 10 Sep 2008 11:48:13 +0000 (13:48 +0200)]
packaging(RHEL): workaround all library installations by mv to %{_libarchdir}

This is all that is still necessary in 3.2.3+.
(The eloquent workarounds for libsmbclient and libsmbsharemodes
are removed.)
In 3.3.0, with the separation of libdir and modulesdir, even this
step becomes unnecessary.


10 years agopackaging(RHEL): remove even another manual installation of
Michael Adam [Wed, 10 Sep 2008 11:46:07 +0000 (13:46 +0200)]
packaging(RHEL): remove even another manual installation of


10 years agopackaging(RHEL): fix installation of pam modules.
Michael Adam [Mon, 8 Sep 2008 13:51:33 +0000 (15:51 +0200)]
packaging(RHEL): fix installation of pam modules.


10 years agopackaging(RHEL): fix libdir installation by using _libarch/_libarchdir
Michael Adam [Fri, 29 Aug 2008 14:55:55 +0000 (16:55 +0200)]
packaging(RHEL): fix libdir installation by using _libarch/_libarchdir


10 years agoFix bug #5052 - not work cancel inheritance on share. We were
Jeremy Allison [Wed, 10 Sep 2008 23:21:25 +0000 (16:21 -0700)]
Fix bug #5052 - not work cancel inheritance on share. We were
using the parent security descriptor type and flags instead
of using the passed in SD.

10 years agoWhen requesting UNIX info levels on findfirst/findnext, don't play games with write...
Jeremy Allison [Wed, 10 Sep 2008 21:52:34 +0000 (14:52 -0700)]
When requesting UNIX info levels on findfirst/findnext, don't play games with write time,
just return what the underlying filesystem says. Trying not to confuse UNIX apps any more than necessary.

10 years agoFix blocker bug 5745 kerberos authentication with (lib)smbclient is broken.
Jeremy Allison [Wed, 10 Sep 2008 17:16:42 +0000 (10:16 -0700)]
Fix blocker bug 5745 kerberos authentication with (lib)smbclient is broken.

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Wed, 10 Sep 2008 10:11:05 +0000 (12:11 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agopackaging(RHEL): remove duplicate installation of
Michael Adam [Fri, 29 Aug 2008 14:44:06 +0000 (16:44 +0200)]
packaging(RHEL): remove duplicate installation of

(cherry picked from commit cdc24fbb195b1a5460c05fcd20d7ba81ad69ef22)

10 years agopackaging(RHEL): use ccache if available
Michael Adam [Mon, 8 Sep 2008 15:38:55 +0000 (17:38 +0200)]
packaging(RHEL): use ccache if available

(cherry picked from commit e8abbfabde3da0844ffb4e2507084c139a70d503)

10 years agopackaging(RHEL): add ldbtools binaries and man pages to common package
Michael Adam [Mon, 8 Sep 2008 13:52:27 +0000 (15:52 +0200)]
packaging(RHEL): add ldbtools binaries and man pages to common package

(cherry picked from commit 206985dfda5a9f62df975629046b00a88ec666f5)

10 years agopackaging(RHEL): remove leftovers of smbmount from SPEC file.
Michael Adam [Mon, 8 Sep 2008 12:46:31 +0000 (14:46 +0200)]
packaging(RHEL): remove leftovers of smbmount from SPEC file.

(cherry picked from commit 041875c64daba3d185b1954eb0eb9a21b2f41ee1)

10 years agopackaging(RHEL): add new libs (talloc, tdb, ...) to the common package
Michael Adam [Fri, 29 Aug 2008 15:45:45 +0000 (17:45 +0200)]
packaging(RHEL): add new libs (talloc, tdb, ...) to the common package

(cherry picked from commit f23183bbec55faf2d6496e04e73f8dd415a08d1c)

10 years agopackaging(RHEL): remove smbmount related stuff from spec file
Michael Adam [Fri, 29 Aug 2008 14:41:30 +0000 (16:41 +0200)]
packaging(RHEL): remove smbmount related stuff from spec file

(cherry picked from commit 4420cf6199e3c718a3dea84fe814d6ad6e83c2d8)

10 years agopackaging(RHEL): fix version of GPL (2 --> 3)
Michael Adam [Fri, 29 Aug 2008 13:45:18 +0000 (15:45 +0200)]
packaging(RHEL): fix version of GPL (2 --> 3)

(cherry picked from commit c015e8e0cf4131f21305451943df13b81f51ea6a)

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Wed, 10 Sep 2008 09:15:02 +0000 (11:15 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agopackaging(RHEL): remove libmsrpc stuff which is no more...
Michael Adam [Fri, 29 Aug 2008 14:48:37 +0000 (16:48 +0200)]
packaging(RHEL): remove libmsrpc stuff which is no more...

(cherry picked from commit 3eaa33e9df6d58ef93f13a840b38a063649fffbc)

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Tue, 9 Sep 2008 11:23:28 +0000 (13:23 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agoFix calculation of useable_space for trans2 and nttrans replies
Volker Lendecke [Mon, 8 Sep 2008 20:53:50 +0000 (22:53 +0200)]
Fix calculation of useable_space for trans2 and nttrans replies

When alignment was in place, we pretended to send more data/params according to
the param_offset/param_length and data_offset/data_length parameters than would
actually fit into the SMB according to the NBSS length field.

10 years agosmbd: some write time fixes
Stefan Metzmacher [Mon, 8 Sep 2008 13:12:24 +0000 (15:12 +0200)]
smbd: some write time fixes

- only the first non truncating write causes
  the write time update with 2 seconds delay.
  It's not enough to check for an existing update event
  as it will be NULL after the event was triggered.

- SMBwrite truncates always update the write time
  unless the sticky write time is set.

- SMBwrite truncates don't trigger a write time update on close.


10 years agoWhen setting an NFSv4 ACL, map generic bits
Volker Lendecke [Mon, 8 Sep 2008 14:42:06 +0000 (16:42 +0200)]
When setting an NFSv4 ACL, map generic bits
(cherry picked from commit dbe7a61be2beac50d1665e38ac374cefbbabec00)

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Mon, 8 Sep 2008 10:42:52 +0000 (12:42 +0200)]
WHATSNEW: Update changes since 3.2.3.


10 years agoFix debug message to show correct function name.
Jeremy Allison [Sat, 6 Sep 2008 03:40:02 +0000 (20:40 -0700)]
Fix debug message to show correct function name.

10 years agoWrite times code update.
Jeremy Allison [Sat, 6 Sep 2008 02:01:09 +0000 (19:01 -0700)]
Write times code update.

Ok, here's the fix for the write times breakage
with the new tests in S4 smbtorture.

The key is keeping in the share mode struct
the "old_file_time" as the real write time,
set by all the write and allocation calls,
and the "changed_write_time" as the "sticky"
write time - set by the SET_FILE_TIME calls.

We can set them independently (although I
kept the optimization of not setting the
"old_file_time" is a "changed_write_time"
was already set, as we'll never see it.

This allows us to update the write time
immediately on the SMBwrite truncate case,
whilst still have the 2 second delay on the
"normal" SMBwrite, SMBwriteX calls.

I think in a subsequent patch I'd like to
change the name of these from "old_file_time"
to "write_time" and "changed_write_time" to
"sticky_write_time" to make this clearer.

I think I also fixed a bug in Metze's original
code in that once a write timestamp had been
set from a "normal" SMBwriteX call the fsp->update_write_time_triggered
variable was set and then never reset - thus
meaning the write timestamp would never get
updated again on subsequent SMBwriteX's.

The new code checks the update_write_time_event
event instead, and doesn't update is there's
an event already scheduled.

Metze especially, please check this over for
your understanding.


10 years agoRemove unecessary msync.
Jeremy Allison [Fri, 5 Sep 2008 22:35:04 +0000 (15:35 -0700)]
Remove unecessary msync.

10 years agoFix a memleak
Qiao Yang [Fri, 5 Sep 2008 12:08:09 +0000 (14:08 +0200)]
Fix a memleak

request.extra_data is not freed if there is no extra_data in response or
when there is some error happens in processing. This patch will free the
buffer right after processing a request before sending back a response.
(cherry picked from commit be6f12273f171a3eb1967d2299064e57d737f6a4)

10 years agoDo proper error handling if the socket is closed
Volker Lendecke [Fri, 5 Sep 2008 09:48:36 +0000 (11:48 +0200)]
Do proper error handling if the socket is closed

This is a step in fixing bug 5707.

Thanks to Igor Galić <> for reporting!


10 years agorun "make idl" after after idl change "Handle arbitrary new PAC types"
Michael Adam [Tue, 26 Aug 2008 15:19:33 +0000 (17:19 +0200)]
run "make idl" after after idl change "Handle arbitrary new PAC types"


10 years agoHandle arbitrary new PAC types
Andrew Tridgell [Sun, 24 Aug 2008 04:00:58 +0000 (14:00 +1000)]
Handle arbitrary new PAC types

When MS introduces a new PAC type, we should just ignore it, not
generate a parse error. New PAC info structures are supposed to be
backwards compatible with old ones
(cherry picked from commit 2971b926c835412b02c93ad1e30f1471bc0a3612)

10 years agore-run make idl after Jelmer's "poperly cast array lengths" pidl change.
Michael Adam [Tue, 26 Aug 2008 15:17:14 +0000 (17:17 +0200)]
re-run make idl after Jelmer's "poperly cast array lengths" pidl change.



10 years agofixed an errno handling bug that could lead to an infinite loop
Andrew Tridgell [Sun, 24 Aug 2008 03:53:19 +0000 (13:53 +1000)]
fixed an errno handling bug that could lead to an infinite loop
(cherry picked from commit 5ccdc58ce91ee40ca7171dd040191291aeb7fe02)

10 years agofixed tsmsm_sendfile(). The logic was totally broken.
Andrew Tridgell [Sat, 23 Aug 2008 01:36:27 +0000 (11:36 +1000)]
fixed tsmsm_sendfile(). The logic was totally broken.
(cherry picked from commit 794e48b809036871287df8416a2c669b7e26f216)

10 years agoconfigure: fix typo in GNU ld version-script test.
Michael Adam [Fri, 5 Sep 2008 09:39:38 +0000 (11:39 +0200)]
configure: fix typo in GNU ld version-script test.

(cherry picked from commit 0d9f3dfc4c139938ee57b6cf60c29cf4ce404be7)

10 years agoAdd workaround for docs build and dependency on parameters.all.xml
Gerald (Jerry) Carter [Mon, 25 Aug 2008 21:08:28 +0000 (16:08 -0500)]
Add workaround for docs build and dependency on parameters.all.xml
(cherry picked from commit d4f5b5255f9b95050ddd9d67bd3958402be77918)
(cherry picked from commit c8154142d97ccf973feb36d77f932c893fda0af5)
(cherry picked from commit c91e7e9f7f392d5ba850619395eddac34617f1e4)
(cherry picked from commit bdb0a5d5fdbc331e11391f7b6e0aae963cebd3fc)

10 years agoRelease scripts: Update create-tarball to include docs and other packaging details.
Gerald W. Carter [Tue, 27 May 2008 21:27:21 +0000 (16:27 -0500)]
Release scripts: Update create-tarball to include docs and other packaging details.

I've updated the create-tarball script to support command line options,
docs build (or copy and existing build), and to run the packaging update

  $ release-scripts/create-tarball --help
  Usage release-scripts/create-tarball [options]
      --help             Print command usage
      --branch <name>    Specify the branch to to create the archive file from
      --copy-docs <dir>  Copy documentation from <dir> rather than building
      --tag <name>       Tag name for release
      --keyid <email>    The GnuPG key ID used to sign the release tag
(cherry picked from commit 7c96795e5954b6a716beb6f5a30d6c7bb1647717)

10 years agoAdd simple script to build docs
Gerald (Jerry) Carter [Tue, 27 May 2008 17:00:00 +0000 (12:00 -0500)]
Add simple script to build docs
(cherry picked from commit 0865f4615d3ee91673dd6d02c6537765f34b3129)

10 years agoFix winbindd crash bug with trusted domains. Bug #5736
James Ding [Thu, 4 Sep 2008 22:17:18 +0000 (15:17 -0700)]
Fix winbindd crash bug with trusted domains. Bug #5736

10 years agoget rid of unneeded argument for get_alloc_methods as well
Herb Lewis [Thu, 4 Sep 2008 21:32:09 +0000 (14:32 -0700)]
get rid of unneeded argument for get_alloc_methods as well

10 years agoget rid of unneeded argument for get_methods
Herb Lewis [Thu, 4 Sep 2008 20:58:06 +0000 (13:58 -0700)]
get rid of unneeded argument for get_methods

10 years agoCleanup of DC enumeration in get_dcs()
Steven Danneman [Thu, 4 Sep 2008 19:05:13 +0000 (12:05 -0700)]
Cleanup of DC enumeration in get_dcs()

This is a fix for a few small inefficiencies/bugs in the get_dcs() path.

* because the third add_one_dc_unique() loop was outside the ADS check all DCs
  returned from the non-sitename lookup were being tacked onto the dc_name_ip
  list twice.
* add_one_dc_unique() now checks if the given IP address already exists before
  adding it to the list, making the returned list actually unique
* added more thorough doxygen comment headers

10 years agokerberos: fix indent of enc type lines in generated krb5.conf files.
Günther Deschner [Thu, 4 Sep 2008 13:11:22 +0000 (15:11 +0200)]
kerberos: fix indent of enc type lines in generated krb5.conf files.

(cherry picked from commit 18a26f08b6fab4119a1421a7ca59c32dde8bb8cb)

10 years agoFix bug #5729. Explicitly allow "-valid".
Jeremy Allison [Wed, 3 Sep 2008 20:06:20 +0000 (13:06 -0700)]
Fix bug #5729. Explicitly allow "-valid".

10 years agoThe msync manpage reports that msync *must* be called before munmap. Failure to do...
Simo Sorce [Wed, 3 Sep 2008 14:44:09 +0000 (10:44 -0400)]
The msync manpage reports that msync *must* be called before munmap. Failure to do so may result in lost data. Fix an ifdef check, I really think we meant to check HAVE_MMAP here.

10 years agoFix Coverity ID 587
Volker Lendecke [Mon, 1 Sep 2008 11:46:27 +0000 (13:46 +0200)]
Fix Coverity ID 587

The following test program prints "8" on 64-bit :-)

static void print_size(const char lenbuf[4])
        printf("sizeof(lenbuf) = %d\n", (int)sizeof(lenbuf));
int main(void)
        const char lenbuf[4];
        return 0;

Jeremy, please check :-)

(cherry picked from commit 9daea0ccfdda58450be3c9a9a94c016f5900c319)

10 years agoDeal with systems that don't initialize birthtime correctly.
Jeremy Allison [Fri, 29 Aug 2008 16:29:35 +0000 (09:29 -0700)]
Deal with systems that don't initialize birthtime correctly.
Pointed out by SATOH Fumiyasu <>.

10 years agoClarify usage of "force create mode".
Jeremy Allison [Thu, 28 Aug 2008 23:04:30 +0000 (16:04 -0700)]
Clarify usage of "force create mode".