Michael Adam [Tue, 26 Aug 2008 15:17:14 +0000 (17:17 +0200)]
re-run make idl after Jelmer's "poperly cast array lengths" pidl change.
(
f321240fa91fa19c1131f119c42f64897d220682)
Michael
(cherry picked from commit
cd3f4ee593e606e48cd104df222f8bda8e370a58)
Andrew Tridgell [Sun, 24 Aug 2008 03:53:19 +0000 (13:53 +1000)]
fixed an errno handling bug that could lead to an infinite loop
(cherry picked from commit
5ccdc58ce91ee40ca7171dd040191291aeb7fe02)
(cherry picked from commit
1361caecb355047001f8a351ec2e6f10d7f0e741)
Andrew Tridgell [Sat, 23 Aug 2008 01:36:27 +0000 (11:36 +1000)]
fixed tsmsm_sendfile(). The logic was totally broken.
(cherry picked from commit
794e48b809036871287df8416a2c669b7e26f216)
(cherry picked from commit
3ce3f7f58402b98ce386bab1c40988e5ccd40d15)
Michael Adam [Fri, 5 Sep 2008 09:39:38 +0000 (11:39 +0200)]
configure: fix typo in GNU ld version-script test.
Michael
(cherry picked from commit
0d9f3dfc4c139938ee57b6cf60c29cf4ce404be7)
(cherry picked from commit
2381ec3b3f6a4798c15f4d3f3aee8caea8f48941)
James Ding [Thu, 4 Sep 2008 22:17:18 +0000 (15:17 -0700)]
Fix winbindd crash bug with trusted domains. Bug #5736
(cherry picked from commit
2d84b9a1024f68657f75aa7e0c4091b8c7afd194)
Herb Lewis [Thu, 4 Sep 2008 21:32:09 +0000 (14:32 -0700)]
get rid of unneeded argument for get_alloc_methods as well
(cherry picked from commit
59415cb8b3ce7981dbf576086e13675f343581a4)
Herb Lewis [Thu, 4 Sep 2008 20:58:06 +0000 (13:58 -0700)]
get rid of unneeded argument for get_methods
(cherry picked from commit
2a085d5343ab954e1bd60c11033506dc7c9040e3)
Steven Danneman [Thu, 4 Sep 2008 19:05:13 +0000 (12:05 -0700)]
Cleanup of DC enumeration in get_dcs()
This is a fix for a few small inefficiencies/bugs in the get_dcs() path.
* because the third add_one_dc_unique() loop was outside the ADS check all DCs
returned from the non-sitename lookup were being tacked onto the dc_name_ip
list twice.
* add_one_dc_unique() now checks if the given IP address already exists before
adding it to the list, making the returned list actually unique
* added more thorough doxygen comment headers
(cherry picked from commit
edd234e7a22dab105256f90df36d86f168dcea4c)
Günther Deschner [Thu, 4 Sep 2008 13:11:22 +0000 (15:11 +0200)]
kerberos: fix indent of enc type lines in generated krb5.conf files.
Guenther
(cherry picked from commit
18a26f08b6fab4119a1421a7ca59c32dde8bb8cb)
(cherry picked from commit
8d6220a94667c5906ead5fa80b6afabc82159b53)
Jeremy Allison [Wed, 3 Sep 2008 20:06:20 +0000 (13:06 -0700)]
Fix bug #5729. Explicitly allow "-valid".
Jeremy
(cherry picked from commit
96b5e691149c449253e4875a743c8603b3298c2b)
Simo Sorce [Wed, 3 Sep 2008 14:44:09 +0000 (10:44 -0400)]
The msync manpage reports that msync *must* be called before munmap. Failure to do so may result in lost data. Fix an ifdef check, I really think we meant to check HAVE_MMAP here.
(cherry picked from commit
bfced01a92ae1a4913c0c9aba27e7b43e06f9032)
Volker Lendecke [Mon, 1 Sep 2008 11:46:27 +0000 (13:46 +0200)]
Fix Coverity ID 587
The following test program prints "8" on 64-bit :-)
static void print_size(const char lenbuf[4])
{
printf("sizeof(lenbuf) = %d\n", (int)sizeof(lenbuf));
}
int main(void)
{
const char lenbuf[4];
print_size(lenbuf);
return 0;
}
Jeremy, please check :-)
Volker
(cherry picked from commit
9daea0ccfdda58450be3c9a9a94c016f5900c319)
(cherry picked from commit
11fdeeeb551ac3287b75e114b15bc4f76cf2d337)
Gerald (Jerry) Carter [Mon, 25 Aug 2008 21:08:28 +0000 (16:08 -0500)]
Add workaround for docs build and dependency on parameters.all.xml
(cherry picked from commit
d4f5b5255f9b95050ddd9d67bd3958402be77918)
(cherry picked from commit
c8154142d97ccf973feb36d77f932c893fda0af5)
(cherry picked from commit
c91e7e9f7f392d5ba850619395eddac34617f1e4)
(cherry picked from commit
bdb0a5d5fdbc331e11391f7b6e0aae963cebd3fc)
(cherry picked from commit
babe47a0ca130888eb478e2f5ff8d5ec04810938)
Gerald W. Carter [Tue, 27 May 2008 21:27:21 +0000 (16:27 -0500)]
Release scripts: Update create-tarball to include docs and other packaging details.
I've updated the create-tarball script to support command line options,
docs build (or copy and existing build), and to run the packaging update
scripts.
$ release-scripts/create-tarball --help
Usage release-scripts/create-tarball [options]
--help Print command usage
--branch <name> Specify the branch to to create the archive file from
--copy-docs <dir> Copy documentation from <dir> rather than building
--tag <name> Tag name for release
--keyid <email> The GnuPG key ID used to sign the release tag
(cherry picked from commit
7c96795e5954b6a716beb6f5a30d6c7bb1647717)
(cherry picked from commit
4a5830fb03152cf59f27c762046554eb6df5cb65)
Gerald (Jerry) Carter [Tue, 27 May 2008 17:00:00 +0000 (12:00 -0500)]
Add simple script to build docs
(cherry picked from commit
0865f4615d3ee91673dd6d02c6537765f34b3129)
(cherry picked from commit
16fe020367f3d63c4ff1391f265bdaa48764900f)
Jeremy Allison [Fri, 29 Aug 2008 16:29:35 +0000 (09:29 -0700)]
Deal with systems that don't initialize birthtime correctly.
Pointed out by SATOH Fumiyasu <fumiyas@osstech.jp>.
Jeremy.
(cherry picked from commit
4876e4ffe9f5142bf90dc14b105436eaca35d3f4)
Jeremy Allison [Thu, 28 Aug 2008 23:04:30 +0000 (16:04 -0700)]
Clarify usage of "force create mode".
Jeremy.
(cherry picked from commit
10f036829aca0b6b4cde03893f71effbf4d30a91)
Jeremy Allison [Thu, 28 Aug 2008 19:09:06 +0000 (12:09 -0700)]
Add st_birthtime and friends for accurate create times on systems that support it (*BSD and MacOSX). This really needs to be in 3.2.x.
Should have done this ages ago, sorry.
Jeremy.
(cherry picked from commit
0cba30073410ba499834ac26dee3f81a75c8de4f)
Günther Deschner [Thu, 28 Aug 2008 10:29:24 +0000 (12:29 +0200)]
winbindd: fix invalid sid copy (hit when enumerating sibling domains).
Guenther
(cherry picked from commit
5eee7423351ffd05486e33ff8eb905babcbc9422)
(cherry picked from commit
9f0bc4ff17b5a11dc412d0b5bc136476f3209a0c)
Jeremy Allison [Thu, 28 Aug 2008 00:26:59 +0000 (17:26 -0700)]
Fix the wcache_invalidate_samlogon calls.
Jeremy.
(cherry picked from commit
0a0795fd0310cc44dac0df312325df6d08e38cdb)
Ephi Dror [Thu, 28 Aug 2008 00:26:36 +0000 (17:26 -0700)]
Correct the netsamlogon_clear_cached_user function.
(cherry picked from commit
85dd9c64ca2ffa31d02ee10a3745fd596e80786e)
Jeremy Allison [Wed, 27 Aug 2008 18:30:02 +0000 (11:30 -0700)]
Be explicit about setting perms for the ldb. Helps others who may use this api.
Jeremy.
(cherry picked from commit
9f1bb27bf566069dab48eea125c22a5e20849774)
Steve French [Tue, 26 Aug 2008 18:04:44 +0000 (13:04 -0500)]
mount.cifs: unclear error message with "credentials"
Thanks to Christophe Curis for the suggestion
(cherry picked from commit
a122df5dc01ed9767c53d77a73aabd44f7c8a7ca)
Andrew Tridgell [Sun, 24 Aug 2008 03:58:05 +0000 (13:58 +1000)]
become root for AIO operations
We need to become root for AIO read and write to allow the AIO thread
to send a completion signal to the parent process when the IO
completes
(cherry picked from commit
27b1ae601542ebe2e23ab4ff81eb14f8e03a3caf)
Andrew Tridgell [Tue, 26 Aug 2008 04:06:42 +0000 (14:06 +1000)]
EINVAL is also a valid error return, meaning "this filesystem
cannot do sendfile for this file"
(cherry picked from commit
dc04b5adf7569b3501cb95f86d01e00276b41c23)
Andrew Tridgell [Sun, 24 Aug 2008 03:56:59 +0000 (13:56 +1000)]
Avoid a race condition in glibc between AIO and setresuid().
See this test: http://samba.org/~tridge/junkcode/aio_uid.c
The problem is that setresuid() tries to be clever about threads, and
tries to change the euid of any threads that are running. If a AIO read
or write completes while this is going on then the signal from the thread
where the IO completed is lost, as it gets -1/EPERM from rt_sigqueueinfo()
The simplest fix is to try to use setreuid() instead of setresuid(),
as setreuid() doesn't try to be clever. Unfortunately this also means
we must use become_root()/unbecome_root() in the aio code.
(cherry picked from commit
319cea52d259e347061658cfbae56ab350b09671)
David Leonard [Mon, 25 Aug 2008 22:15:35 +0000 (15:15 -0700)]
Fix bug 4516, no IPv6 on Solaris 2.6.
(cherry picked from commit
ec178599d37d6633697650c54c3588afedea9b7e)
Jeff Layton [Sun, 24 Aug 2008 21:31:49 +0000 (17:31 -0400)]
cifs.upcall: bump SPNEGO msg version number and don't reject old versions
When we added the ability for the kernel to send sec=mskrb5 to the
upcall, we subtly broke old cifs.upcall versions that don't understand
it. Bump the spnego message version to 2 to make this clear. Also,
change cifs.upcall to not reject requests with a version that's lower
than the current one, and to send the reply with the same version that
the request sent. The idea is to try and keep cifs.upcall backward
compatible with old kernels.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit
2744bcbf3f22102911b5a3c4676e7d2f970a86eb)
Jeremy Allison [Fri, 22 Aug 2008 20:50:53 +0000 (13:50 -0700)]
Don't re-initialize a token when we already have one. This fixes the build farm failures when winbindd connects as guest.
This one took a *lot* of tracking down :-).
Jeremy.
(cherry picked from commit
f845c95dcfa0b1630a0057c62941bb8a72ebdd83)
Gerald (Jerry) Carter [Fri, 22 Aug 2008 15:17:04 +0000 (10:17 -0500)]
winbindd: Fix crash in cm_connect_sam()
Fix segv when talking to parent DC (joined to child domain).
The root cause was
(a) storing the parent domain in the cli_state struct caused
the NTLMSSP pipe bind to fail which made us fallover to
the schannel code path
(b) the dcinfo pointer in cm_get_schannel_dcinfo() was returning
NULL even though the function indicated success.
(cherry picked from commit
5ce4a2ae6697970ea37d0078a506615b4b7a9a9c)
(cherry picked from commit
72d138adc200ab36e324721900af1a06d0879318)
Jeff Layton [Fri, 22 Aug 2008 01:41:19 +0000 (21:41 -0400)]
cifs.upcall: fix build warning
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit
dffb2d8eea03bb75224c3d8b4d0ab210993c645a)
Günther Deschner [Thu, 21 Aug 2008 13:05:35 +0000 (15:05 +0200)]
Fix Bug #5710 and make machine account password changing work again.
When we negotiated NETLOGON_NEG_PASSWORD_SET2 we need to use
NetrServerPasswordSet2 to change the machine password.
Tested with NT4, W2k, W2k3 and W2k8.
Guenther
(cherry picked from commit
8ae7040a5e64f1a1d2088aeca1dab90470455d8a)
Günther Deschner [Thu, 21 Aug 2008 13:02:03 +0000 (15:02 +0200)]
re-run make idl.
Guenther
(cherry picked from commit
f24cef9fa7be45212744d39b7c66804e64147afd)
(cherry picked from commit
059979f8e7d7d0459f83184ad5b06a8e6281f558)
Günther Deschner [Thu, 21 Aug 2008 13:01:36 +0000 (15:01 +0200)]
IDL: fix IDL for netr_ServerPasswordSet2().
Guenther
(cherry picked from commit
7b312a0abc6de5a51555ccfbde7f8f78fc11d043)
(cherry picked from commit
d9fa27a079dde0ebd9c2d6dc1c1bff3ae570f9e8)
Jeremy Allison [Thu, 21 Aug 2008 17:25:51 +0000 (10:25 -0700)]
Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegscheid@whirlpool.com>.
Jeremy.
(cherry picked from commit
02e260ab5254c9691846f7009f685e1b11032f80)
Michael Adam [Wed, 20 Aug 2008 12:56:18 +0000 (14:56 +0200)]
build: fix bug #5590 by not linking in the static libs but the objects.
Michael
(cherry picked from commit
6ad2090391a92ebe822b2d7b80e180c251dc8e7a)
(cherry picked from commit
24459c7eda080a4fed2d4f2a576c97f878f905f9)
Michael Adam [Wed, 20 Aug 2008 12:55:24 +0000 (14:55 +0200)]
build: fall down to the same place when using an internal lib statically.
Michael
(cherry picked from commit
702c0bc04668117e3521d687b9b5a87fd7e0f1b1)
(cherry picked from commit
f3ad03d0f909ff862411511d9f63e77047034c01)
Michael Adam [Wed, 20 Aug 2008 11:22:13 +0000 (13:22 +0200)]
build: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency.
Michael
(cherry picked from commit
ead9b9d7167d999d73cf4111f3b321236aac2a15)
(cherry picked from commit
8dd57f31b2ba621654f989e1ed58bd2dd80b7849)
Günther Deschner [Wed, 20 Aug 2008 16:40:58 +0000 (18:40 +0200)]
fix build warning.
Guenther
(cherry picked from commit
a75055be5ff7ebe3476cfac86c6597a56a843c23)
(cherry picked from commit
d0a4b9f69984ca5da0007af91013f1bc78dcbf2b)
Günther Deschner [Wed, 20 Aug 2008 18:24:45 +0000 (20:24 +0200)]
fix another build warning.
Guenther
(cherry picked from commit
43693ce6c678b961fa516bbf502af92f87cd5346)
(cherry picked from commit
2a5ae59f77c05c41c97747dee9bc8c196dfe6b89)
Gerald (Jerry) Carter [Wed, 20 Aug 2008 18:00:40 +0000 (13:00 -0500)]
nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT
According to the GNU libc nss guide, we should always set
errno to ENOENT when returning NSS_UNAVAIL.
http://www.gnu.org/software/libtool/manual/libc/NSS-Modules-Interface.html#NSS-Modules-Interface
At least the MQ Series message queing service that runs
on WebSphere will fail if you return any other errno in this case.
(cherry picked from commit
ee26664602445fa7798e2061f6bcbef0756d6528)
(cherry picked from commit
29b39723b82f363d32dc4678d6b71a78485c65ce)
Stefan Metzmacher [Tue, 19 Aug 2008 14:34:50 +0000 (16:34 +0200)]
smbd: fix the handling of create_options to pass RAW-OPEN
Some of the bits generate INVALID_PARAMETER and some bits
are ignored when they come from a client, that's why we need
to use bits from the ignored range for our internal usage.
metze
(cherry picked from commit
7b4c8a4e39f310eb450918fa841b0ea1b4af19f7)
(cherry picked from commit
3366ac2857820d87fb36a1357786a3564d258da5)
Jeff Layton [Wed, 20 Aug 2008 01:35:35 +0000 (21:35 -0400)]
cifs.upcall: handle MSKRB5 OID properly
When the kernel sends the upcall a sec=mskrb5 parameter, that means
the the MSKRB5 OID is preferred by the server. This patch fixes the
upcall to use that OID in place of the "normal" krb5 OID when it
gets a sec=mskrb5 parameter.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <smfrench@gmail.com>
(cherry picked from commit
3d96409c115b3ad4ef29ff75e40b39a26e316afe)
Jeremy Allison [Wed, 20 Aug 2008 00:31:46 +0000 (17:31 -0700)]
Fix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address
reported by Ted Percival <ted@midg3t.net>.
Jeremy.
(cherry picked from commit
4ac537d1b78c915fe25c219958312cf22f3cba80)
Michael Adam [Tue, 19 Aug 2008 11:29:24 +0000 (13:29 +0200)]
build: fix linking cifs.upcall when nscd_flush_cache() is found.
Michael
(cherry picked from commit
661b7fdffda40a9ca7cb36627dbaf91cb4357cd0)
(cherry picked from commit
7401c6a5b74c9c82c02923e6eafa6072a5d5678f)
Karolin Seeger [Thu, 28 Aug 2008 14:04:42 +0000 (16:04 +0200)]
VERSION: Raise version number up tp 3.2.4.
Karolin
Karolin Seeger [Wed, 27 Aug 2008 11:23:20 +0000 (13:23 +0200)]
ldb: Fix permissions of new ldg files.
This one fixes together with
2eaf4ed62 bug #5715 and CVE-2008-3789.
Thanks to Steve Langasek <vorlon@debian.org> for reporting!
Karolin
Karolin Seeger [Wed, 27 Aug 2008 09:09:54 +0000 (11:09 +0200)]
WHATSNEW: Add updates for 3.2.3.
Karolin
Andrew Tridgell [Wed, 27 Aug 2008 08:45:43 +0000 (10:45 +0200)]
ldb: Fix permissions of group_mapping.ldb.
This one fixes bug #5715 and CVE-2008-3789.
Karolin Seeger [Wed, 27 Aug 2008 08:38:42 +0000 (10:38 +0200)]
Revert "build: fix linking cifs.upcall when nscd_flush_cache() is found."
This reverts commit
a7058ed1ef2622abdb75fe997ce4a5c570898929.
Karolin Seeger [Wed, 27 Aug 2008 08:38:35 +0000 (10:38 +0200)]
Revert "Fix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address"
This reverts commit
435c10268bb6987ab7e8206cd6c45bd9961c5632.
Karolin Seeger [Wed, 27 Aug 2008 08:38:25 +0000 (10:38 +0200)]
Revert "cifs.upcall: handle MSKRB5 OID properly"
This reverts commit
64ebfe4b2e5b7e3e07a0af424b35000693148e48.
Karolin Seeger [Wed, 27 Aug 2008 08:38:18 +0000 (10:38 +0200)]
Revert "smbd: fix the handling of create_options to pass RAW-OPEN"
This reverts commit
ebd1f8f9297b31353d094ddccc320a83f02877ce.
Karolin Seeger [Wed, 27 Aug 2008 08:38:08 +0000 (10:38 +0200)]
Revert "nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT"
This reverts commit
15e8e23466ae959bd0efc540c287338dbcd0b7a6.
Karolin Seeger [Wed, 27 Aug 2008 08:38:00 +0000 (10:38 +0200)]
Revert "fix another build warning."
This reverts commit
e3ff1cb7709d93fb91602d3d25deca3f4ecce2ce.
Karolin Seeger [Wed, 27 Aug 2008 08:37:49 +0000 (10:37 +0200)]
Revert "fix build warning."
This reverts commit
c48f247d76569bfdc844499cc64f504bce7085cd.
Karolin Seeger [Wed, 27 Aug 2008 08:37:41 +0000 (10:37 +0200)]
Revert "build: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency."
This reverts commit
eb892f90c9be0ebc2217fc459d4249190986c003.
Karolin Seeger [Wed, 27 Aug 2008 08:37:30 +0000 (10:37 +0200)]
Revert "build: fall down to the same place when using an internal lib statically."
This reverts commit
8145b0a7d7bacb818b8dadadae65ecd0877b5ce2.
Karolin Seeger [Wed, 27 Aug 2008 08:37:22 +0000 (10:37 +0200)]
Revert "build: fix bug #5590 by not linking in the static libs but the objects."
This reverts commit
ef801d12a309c4c9f6429739b835fb32f5c309b8.
Karolin Seeger [Wed, 27 Aug 2008 08:36:58 +0000 (10:36 +0200)]
Revert "Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegscheid@whirlpool.com>."
This reverts commit
3c205320cd1eb19ed275572f975487e92c611f13.
Karolin Seeger [Wed, 27 Aug 2008 08:36:51 +0000 (10:36 +0200)]
Revert "IDL: fix IDL for netr_ServerPasswordSet2()."
This reverts commit
7a53e1e83a070394f77da4a0f7b2ed480165c376.
Karolin Seeger [Wed, 27 Aug 2008 08:36:31 +0000 (10:36 +0200)]
Revert "re-run make idl."
This reverts commit
94dd61a4e8e070e175339defce4da08eaf87429d.
Karolin Seeger [Wed, 27 Aug 2008 08:36:20 +0000 (10:36 +0200)]
Revert "Fix Bug #5710 and make machine account password changing work again."
This reverts commit
6d42b1e372b67eba83dbd5200bfb131b74cac180.
Karolin Seeger [Wed, 27 Aug 2008 08:36:10 +0000 (10:36 +0200)]
Revert "cifs.upcall: fix build warning"
This reverts commit
b3a8b823361d6144f14c2d800e956f26ff9ad6d6.
Karolin Seeger [Wed, 27 Aug 2008 08:36:00 +0000 (10:36 +0200)]
Revert "winbindd: Fix crash in cm_connect_sam()"
This reverts commit
9bbd6ee5db03747499bd263bb1365c8cd352076d.
Karolin Seeger [Wed, 27 Aug 2008 08:35:51 +0000 (10:35 +0200)]
Revert "Don't re-initialize a token when we already have one. This fixes the build farm failures when winbindd connects as guest."
This reverts commit
a90648e905aebc98c78897adf76729bea269cedf.
Jeremy Allison [Fri, 22 Aug 2008 20:50:53 +0000 (13:50 -0700)]
Don't re-initialize a token when we already have one. This fixes the build farm failures when winbindd connects as guest.
This one took a *lot* of tracking down :-).
Jeremy.
(cherry picked from commit
f845c95dcfa0b1630a0057c62941bb8a72ebdd83)
Gerald (Jerry) Carter [Fri, 22 Aug 2008 15:17:04 +0000 (10:17 -0500)]
winbindd: Fix crash in cm_connect_sam()
Fix segv when talking to parent DC (joined to child domain).
The root cause was
(a) storing the parent domain in the cli_state struct caused
the NTLMSSP pipe bind to fail which made us fallover to
the schannel code path
(b) the dcinfo pointer in cm_get_schannel_dcinfo() was returning
NULL even though the function indicated success.
(cherry picked from commit
5ce4a2ae6697970ea37d0078a506615b4b7a9a9c)
(cherry picked from commit
72d138adc200ab36e324721900af1a06d0879318)
Jeff Layton [Fri, 22 Aug 2008 01:41:19 +0000 (21:41 -0400)]
cifs.upcall: fix build warning
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit
dffb2d8eea03bb75224c3d8b4d0ab210993c645a)
Günther Deschner [Thu, 21 Aug 2008 13:05:35 +0000 (15:05 +0200)]
Fix Bug #5710 and make machine account password changing work again.
When we negotiated NETLOGON_NEG_PASSWORD_SET2 we need to use
NetrServerPasswordSet2 to change the machine password.
Tested with NT4, W2k, W2k3 and W2k8.
Guenther
(cherry picked from commit
8ae7040a5e64f1a1d2088aeca1dab90470455d8a)
Günther Deschner [Thu, 21 Aug 2008 13:02:03 +0000 (15:02 +0200)]
re-run make idl.
Guenther
(cherry picked from commit
f24cef9fa7be45212744d39b7c66804e64147afd)
(cherry picked from commit
059979f8e7d7d0459f83184ad5b06a8e6281f558)
Günther Deschner [Thu, 21 Aug 2008 13:01:36 +0000 (15:01 +0200)]
IDL: fix IDL for netr_ServerPasswordSet2().
Guenther
(cherry picked from commit
7b312a0abc6de5a51555ccfbde7f8f78fc11d043)
(cherry picked from commit
d9fa27a079dde0ebd9c2d6dc1c1bff3ae570f9e8)
Jeremy Allison [Thu, 21 Aug 2008 17:25:51 +0000 (10:25 -0700)]
Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegscheid@whirlpool.com>.
Jeremy.
(cherry picked from commit
02e260ab5254c9691846f7009f685e1b11032f80)
Michael Adam [Wed, 20 Aug 2008 12:56:18 +0000 (14:56 +0200)]
build: fix bug #5590 by not linking in the static libs but the objects.
Michael
(cherry picked from commit
6ad2090391a92ebe822b2d7b80e180c251dc8e7a)
(cherry picked from commit
24459c7eda080a4fed2d4f2a576c97f878f905f9)
Michael Adam [Wed, 20 Aug 2008 12:55:24 +0000 (14:55 +0200)]
build: fall down to the same place when using an internal lib statically.
Michael
(cherry picked from commit
702c0bc04668117e3521d687b9b5a87fd7e0f1b1)
(cherry picked from commit
f3ad03d0f909ff862411511d9f63e77047034c01)
Michael Adam [Wed, 20 Aug 2008 11:22:13 +0000 (13:22 +0200)]
build: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency.
Michael
(cherry picked from commit
ead9b9d7167d999d73cf4111f3b321236aac2a15)
(cherry picked from commit
8dd57f31b2ba621654f989e1ed58bd2dd80b7849)
Günther Deschner [Wed, 20 Aug 2008 16:40:58 +0000 (18:40 +0200)]
fix build warning.
Guenther
(cherry picked from commit
a75055be5ff7ebe3476cfac86c6597a56a843c23)
(cherry picked from commit
d0a4b9f69984ca5da0007af91013f1bc78dcbf2b)
Günther Deschner [Wed, 20 Aug 2008 18:24:45 +0000 (20:24 +0200)]
fix another build warning.
Guenther
(cherry picked from commit
43693ce6c678b961fa516bbf502af92f87cd5346)
(cherry picked from commit
2a5ae59f77c05c41c97747dee9bc8c196dfe6b89)
Gerald (Jerry) Carter [Wed, 20 Aug 2008 18:00:40 +0000 (13:00 -0500)]
nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT
According to the GNU libc nss guide, we should always set
errno to ENOENT when returning NSS_UNAVAIL.
http://www.gnu.org/software/libtool/manual/libc/NSS-Modules-Interface.html#NSS-Modules-Interface
At least the MQ Series message queing service that runs
on WebSphere will fail if you return any other errno in this case.
(cherry picked from commit
ee26664602445fa7798e2061f6bcbef0756d6528)
(cherry picked from commit
29b39723b82f363d32dc4678d6b71a78485c65ce)
Stefan Metzmacher [Tue, 19 Aug 2008 14:34:50 +0000 (16:34 +0200)]
smbd: fix the handling of create_options to pass RAW-OPEN
Some of the bits generate INVALID_PARAMETER and some bits
are ignored when they come from a client, that's why we need
to use bits from the ignored range for our internal usage.
metze
(cherry picked from commit
7b4c8a4e39f310eb450918fa841b0ea1b4af19f7)
(cherry picked from commit
3366ac2857820d87fb36a1357786a3564d258da5)
Jeff Layton [Wed, 20 Aug 2008 01:35:35 +0000 (21:35 -0400)]
cifs.upcall: handle MSKRB5 OID properly
When the kernel sends the upcall a sec=mskrb5 parameter, that means
the the MSKRB5 OID is preferred by the server. This patch fixes the
upcall to use that OID in place of the "normal" krb5 OID when it
gets a sec=mskrb5 parameter.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <smfrench@gmail.com>
(cherry picked from commit
3d96409c115b3ad4ef29ff75e40b39a26e316afe)
Jeremy Allison [Wed, 20 Aug 2008 00:31:46 +0000 (17:31 -0700)]
Fix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address
reported by Ted Percival <ted@midg3t.net>.
Jeremy.
(cherry picked from commit
4ac537d1b78c915fe25c219958312cf22f3cba80)
Michael Adam [Tue, 19 Aug 2008 11:29:24 +0000 (13:29 +0200)]
build: fix linking cifs.upcall when nscd_flush_cache() is found.
Michael
(cherry picked from commit
661b7fdffda40a9ca7cb36627dbaf91cb4357cd0)
(cherry picked from commit
7401c6a5b74c9c82c02923e6eafa6072a5d5678f)
Karolin Seeger [Tue, 19 Aug 2008 09:36:45 +0000 (11:36 +0200)]
WHATSNEW: Start WHATSNEW for 3.2.3.
Karolin
(cherry picked from commit
efbd263131228281eca30d7834de52502d2806d6)
Karolin Seeger [Tue, 19 Aug 2008 09:35:27 +0000 (11:35 +0200)]
VERSION: Raise version number up to 3.2.3.
Karolin
(cherry picked from commit
902349b956e26f4f9255045162ce5310c44a4166)
Igor Mammedov [Mon, 18 Aug 2008 16:55:44 +0000 (09:55 -0700)]
Fix length error in wrapping spnego blob. Karoling this needs to be in 3.2.2 (sorry).
(cherry picked from commit
e2caa65a698ca7109aa44656ff9399104cf0663b)
Karolin Seeger [Mon, 18 Aug 2008 14:36:53 +0000 (16:36 +0200)]
WHATSNEW: Update release date.
Karolin
(cherry picked from commit
9f74480cc6c4f1f41c1a4fe71580cd623ef41407)
Karolin Seeger [Mon, 18 Aug 2008 13:59:07 +0000 (15:59 +0200)]
WHATSNEW: Add some more major bug fixes.
Karolin
(cherry picked from commit
986c52dca86cc82dd62d1b9f71ee2269d5ba5cb4)
Karolin Seeger [Mon, 18 Aug 2008 13:56:52 +0000 (15:56 +0200)]
WHATSNEW: Add corresponding bug number.
Karolin
(cherry picked from commit
25c354f8d194624d9ef8924d861af377cb89275d)
Karolin Seeger [Mon, 18 Aug 2008 13:52:09 +0000 (15:52 +0200)]
WHATSNEW: Update changes since 3.2.1.
Karolin
(cherry picked from commit
d1738c966cc090fbe4bcd246bebb9c693235152a)
Jeremy Allison [Sun, 17 Aug 2008 02:25:22 +0000 (19:25 -0700)]
Fix bug 5696. The problem was when smbd
was asking for a winbindd name to SID lookup of
"Unix Group\name" where "name" was also a valid username,
the winbindd passdb lookup of that name was losing the
domain string info before calling lookup name (ie. lookup_name()
was being called with just the string "name", not the
full string "Unix Group\name").
The passdb backend of winbindd has to cope with
not only names from it's own global SAM domain,
but it does lookups for BUILTIN and "Unix User"
and "Unix Group" also, so making it guess by
losing the domain string is "A Bad Idea" (tm) :-).
Note that as winbind globally calls winbind_off()
at startup, it's safe for winbind to call sys_getgrnam()
to do the "Unix Group" lookup from inside lookup_name().
Jeremy.
(cherry picked from commit
780a4ff80dfd03a2c422920dbd101e8f58f7136e)
Jeff Layton [Sat, 16 Aug 2008 18:30:20 +0000 (14:30 -0400)]
cifs.upcall: negatively instantiate keys on error
When a request-key upcall exits without instantiating a key, the kernel
will negatively instantiate the key with a 60s timeout. Older kernels,
however seem to also link that key into the session keyring. This
behavior can interefere with subsequent mount attempts until the
key times out. The next request_key() call will get this negative key
even if the upcall would have worked the second time.
Fix this by having cifs.upcall negatively instantiate the key itself
with a 1s timeout and don't attach it to the session keyring.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit
7e05ff65a7907bf34e2d422f7c941002cfb86971)
Steve French [Sat, 16 Aug 2008 18:30:19 +0000 (14:30 -0400)]
Building cifs.upcall is giving this build warning:
client/cifs.upcall.c:205: warning: function declaration isn’t a prototype
This patch fixes this by properly declaring usage() args as void.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
(cherry picked from commit
7b25c4d2363ee772eed44174c882a7fbc59f0568)
Steve French [Sat, 16 Aug 2008 18:30:18 +0000 (14:30 -0400)]
cifs.upcall: fix manpage and comments
The "cifs.resolver" key type has been changed to "dns_resolver". Fix
the comments at the top of cifs.upcall and the manpage accordingly.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
---
docs-xml/manpages-3/cifs.upcall.8.xml | 4 ++--
source/client/cifs.upcall.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
(cherry picked from commit
34cf3c012e463d0ea04616308738aadea438f48b)
Steve French [Sat, 16 Aug 2008 18:30:17 +0000 (14:30 -0400)]
cifs.upcall was not recognizing the newer name "dns_resolver" key type
(as a synonym for the older "cifs.resolver" name) when resolving host
names to ip addresses for the kernel.
Acked-by: Jeff Layton
(cherry picked from commit
370722392d7f42f8094f574cac08a6a12e5893a3)
Steve French [Sat, 16 Aug 2008 18:30:16 +0000 (14:30 -0400)]
cifs.upcall: fix compile warning
Steve French noticed these warnings when building cifs.upcall:
Compiling client/cifs.upcall.c
client/cifs.upcall.c: In function 'usage':
client/cifs.upcall.c:204: warning: declaration of 'prog' shadows a global declaration
client/cifs.upcall.c:33: warning: shadowed declaration is here
Change the usage function to not take and arg and have it just use the global
"prog" variable. Fix a typo in the log message generated when an unknown
option is specified. Also getopt() always returns '?' when it sees an unknown
option so there's no point in printing it out.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit
bd1cf48d7e20cb534bd672bacbf3ac4a87d1a7b4)
Jeremy Allison [Sat, 16 Aug 2008 18:30:08 +0000 (14:30 -0400)]
This patchset comprises a number of cleanups for the cifs upcall
binary. The biggest change is that it renames it from cifs.spnego
to cifs.upcall since the cifs.spnego name really isn't applicable
anymore.
It also fixes a segfault when the program is run without any args
and adds a manpage. Comments and/or suggestions appreciated.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit
1d88c3431a1abf5fe6527fcbdf43972607a317ee)
Volker Lendecke [Sat, 16 Aug 2008 09:12:35 +0000 (11:12 +0200)]
Attempt to fix Coverity ID 596
Jeremy, please check & push if it's ok.
(cherry picked from commit
7e9b24a12d91fc558864e91852028adb9a381838)
Volker Lendecke [Sat, 16 Aug 2008 09:17:09 +0000 (11:17 +0200)]
Attempt to fix Coverity ID 595
is_ipaddress already dereferences "name", so the NULL check is pointless after
calling it.
(cherry picked from commit
a252ad90136fbc338c0946a5fd5e5322b8d95a01)
Herb Lewis [Fri, 15 Aug 2008 22:30:40 +0000 (15:30 -0700)]
I think the problem with these functions is that lookup_usergroups
should never include the user SID.
The comment for the function in winbindd/winbindd_ads.c says
/* Lookup groups a user is a member of. */
The following patch makes the wbinfo calls return the correct data
before and after a login.
(cherry picked from commit
ecf96a26bfe18899133d68032b0cda00177d57d0)