Jeremy Allison [Mon, 13 Mar 2006 22:49:56 +0000 (22:49 +0000)]
r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring).
Fix Coverity #59.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 21:11:15 +0000 (21:11 +0000)]
r14345: Fix Coverity #71. We don't currently propagate *any*
alloc error back up the stack from smbldap_set_mod()
so ensure we abort correctly.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 19:47:18 +0000 (19:47 +0000)]
r14342: Fix coverity #68, resource leak on error path.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 19:40:51 +0000 (19:40 +0000)]
r14340: Fix coverity #78, resource leak in error path.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 18:59:31 +0000 (18:59 +0000)]
r14338: Fix coverity #55 by explicit cast.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 18:56:26 +0000 (18:56 +0000)]
r14336: Try and quieten coverity #53 and #54. Make it obvious
we're using -1 as a special size_t case by casting.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 18:42:57 +0000 (18:42 +0000)]
r14333: Fix coverity #77, ensure we can't exit after allocation.
Jeremy.
Lars Müller [Mon, 13 Mar 2006 17:45:04 +0000 (17:45 +0000)]
r14331: Add a comment on top of test_pam_modules about what we're testing.
Günther Deschner [Mon, 13 Mar 2006 17:26:52 +0000 (17:26 +0000)]
r14329: Fix the build on systems without libcom_err.
Guenther
Lars Müller [Mon, 13 Mar 2006 16:19:44 +0000 (16:19 +0000)]
r14326: First catch of make test_pam_modules.
Testing pam_smbpass pam_winbind
dlopen() of "./bin/pam_smbpass.so" succeeded.
dlopen() of "./bin/pam_winbind.so" failed: ././bin/pam_winbind.so:
undefined symbol: secrets_fetch_domain_sid
make: *** [test_pam_modules] Error 1
Lars Müller [Mon, 13 Mar 2006 16:10:26 +0000 (16:10 +0000)]
r14325: Add pam_modules rule which builds the configure(d) pam modules. This is
called as part of the all rule (again only if pam modules are requested
by configure).
Add pam_winbind rule.
Ensure proto_exists before we build the pam modules.
Add test_pam_modules rule to test if the built pam modules have any
unresolved symbols. For test_pam_modules we use script/tests/dlopen.sh
which was written by Nalin Dahyabhai <nalin@redhat.com>. Thanks Nalin!
RedHat and SuSE use this script to test nss and pam modules since
several years.
Günther Deschner [Mon, 13 Mar 2006 15:13:35 +0000 (15:13 +0000)]
r14321: When we have libnscd and winbindd comes (back) online, try to flush the
nscd caches so that NSS-calls can deliver accurate information.
Guenther
Lars Müller [Mon, 13 Mar 2006 14:22:43 +0000 (14:22 +0000)]
r14317: Use source/bin as dir to link pam_winbind instead of source/nsswitch/
The intention is to have the resulting binaries at one place. This is
also usefull for upcoming changes to provide a test_pammodules rule.
With these changes I even got aware of
testsuite/nsswitch/pam_winbind_syms.exp But this only covers
pam_winbind.
Jeremy Allison [Mon, 13 Mar 2006 06:52:03 +0000 (06:52 +0000)]
r14303: Fix coverity #223. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 06:50:33 +0000 (06:50 +0000)]
r14301: Fix coverity #224. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 06:48:41 +0000 (06:48 +0000)]
r14299: Fix coverity #225. In a loop we were forgetting to free
resources on error exit path.
Jeremy.
Volker Lendecke [Mon, 13 Mar 2006 06:44:10 +0000 (06:44 +0000)]
r14298: The other half of Coverity # 217
Jeremy Allison [Mon, 13 Mar 2006 04:27:53 +0000 (04:27 +0000)]
r14292: Janitor for tridge (samba3 talloc is almost identical
to Samba4 talloc).
Jeremy
- make the snprintf call in talloc portable to older solaris boxes
- fixed an error found sing the beam analyser
Jeremy Allison [Mon, 13 Mar 2006 04:05:47 +0000 (04:05 +0000)]
r14289: Fix coverity #101, resource leak on error code path.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 03:59:53 +0000 (03:59 +0000)]
r14286: Similar clarifiction fix for coverity #102.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 03:56:24 +0000 (03:56 +0000)]
r14284: Fix coverity bug #103. Make code clearer - probably
not a real issue but this code is easier to read.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 03:50:26 +0000 (03:50 +0000)]
r14282: Change centry_string to only use talloc. Should
quieten coverity bug #194 (which I think is a
false positive).
Jeremy.
Jim McDonough [Mon, 13 Mar 2006 01:49:01 +0000 (01:49 +0000)]
r14280: Fix Coverity #129 and 130: check before dereferencing a pointer. This
was especially silly as we checked immediately _after_ dereferencing it
:-/
Jim McDonough [Mon, 13 Mar 2006 01:42:40 +0000 (01:42 +0000)]
r14279: Fix coverity #86, 87, 88, 89:
Free grp_sid and owner_sid before returning. Also, only allow one group
or owner.
Jim McDonough [Mon, 13 Mar 2006 01:32:30 +0000 (01:32 +0000)]
r14278: Remainder of fix for Coverity #79,80,81: only allow GROUP or OWNER to be
specified once in an ACL, so it can be allocated a second time,
overwriting the first
Jeremy Allison [Mon, 13 Mar 2006 01:08:27 +0000 (01:08 +0000)]
r14275: Shut-up coverity false positive (bug #199) by making an assertion
explicit.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 00:37:57 +0000 (00:37 +0000)]
r14273: Fix coverity bug #202. Memory leak on error path.
Jeremy.
Jim McDonough [Mon, 13 Mar 2006 00:35:33 +0000 (00:35 +0000)]
r14272: Fix Coverity # 81: free alloc'ed storage before returning
Jeremy Allison [Mon, 13 Mar 2006 00:30:18 +0000 (00:30 +0000)]
r14270: Fix coverity #203. Ensure we free on error exit.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 00:26:38 +0000 (00:26 +0000)]
r14268: Fix coverity error #204. Resource leak on error path.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 00:25:04 +0000 (00:25 +0000)]
r14266: Fix coverity #205. Resource leak on error path.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 00:23:17 +0000 (00:23 +0000)]
r14264: Fix coverity #207. Resource leak on error path.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 00:08:39 +0000 (00:08 +0000)]
r14261: Fix coverity #38. No null deref.
Jeremy.
Jeremy Allison [Mon, 13 Mar 2006 00:05:47 +0000 (00:05 +0000)]
r14259: Fix coverity #42. Ensure contact_domain can't be null derefed
in error code path.
Jeremy.
James Peach [Sun, 12 Mar 2006 22:27:01 +0000 (22:27 +0000)]
r14255: Revert r14204 which was horribly broken.
Jim McDonough [Sun, 12 Mar 2006 19:56:10 +0000 (19:56 +0000)]
r14252: Fix Coverity #72: free alloc'ed storage before return. Also found one
more that coverity didn't find from asprintf.
Jeremy Allison [Sun, 12 Mar 2006 19:16:45 +0000 (19:16 +0000)]
r14250: Fix coverity bug #107. Resource leak on error path.
Jeremy.
Volker Lendecke [Sun, 12 Mar 2006 18:01:36 +0000 (18:01 +0000)]
r14249: We've dereferenced the_acl before, no point in checking.
Fix Coverity bug # 128.
Volker
Volker Lendecke [Sun, 12 Mar 2006 17:57:05 +0000 (17:57 +0000)]
r14248: Fix Coverity bug # 84
Volker Lendecke [Sun, 12 Mar 2006 17:53:57 +0000 (17:53 +0000)]
r14247: Fix Coverity bug # 136
Volker Lendecke [Sun, 12 Mar 2006 17:48:51 +0000 (17:48 +0000)]
r14246: Fix Coverity bug # 85
Volker Lendecke [Sun, 12 Mar 2006 17:44:00 +0000 (17:44 +0000)]
r14245: We've dereferenced argv before, no point in checking.
Fix Coverity bug # 144.
Volker
Volker Lendecke [Sun, 12 Mar 2006 17:29:42 +0000 (17:29 +0000)]
r14244: Okay, had not seen that this happened twice.
Fix Coverity bug # 142.
Volker
Volker Lendecke [Sun, 12 Mar 2006 17:26:56 +0000 (17:26 +0000)]
r14243: Fix Coverity bug # 143
Volker Lendecke [Sun, 12 Mar 2006 17:24:10 +0000 (17:24 +0000)]
r14242: Fix Coverity bug # 82
Volker Lendecke [Sun, 12 Mar 2006 17:18:26 +0000 (17:18 +0000)]
r14241: Fix Coverity bug # 146
Volker Lendecke [Sun, 12 Mar 2006 11:00:06 +0000 (11:00 +0000)]
r14236: Fix Coverity bug # 90
Volker Lendecke [Sun, 12 Mar 2006 10:57:42 +0000 (10:57 +0000)]
r14235: Fix Coverity bug # 91
Volker Lendecke [Sun, 12 Mar 2006 10:52:56 +0000 (10:52 +0000)]
r14234: Fix Coverity bug # 93
Volker Lendecke [Sun, 12 Mar 2006 10:47:02 +0000 (10:47 +0000)]
r14233: Fix Coverity bug # 206
Volker Lendecke [Sun, 12 Mar 2006 10:44:19 +0000 (10:44 +0000)]
r14232: Fix Coverity Bug # 218
Jeremy Allison [Sun, 12 Mar 2006 04:18:43 +0000 (04:18 +0000)]
r14229: Something Coverity hasn't caught (yet) but I've gotten
sensitive to null derefs. get_timed_events_timeout()
can potentially return NULL. Cope with this.
Jeremy.
Volker Lendecke [Sun, 12 Mar 2006 00:08:12 +0000 (00:08 +0000)]
r14228: Fix Coverity bug # 217
Volker Lendecke [Sun, 12 Mar 2006 00:03:00 +0000 (00:03 +0000)]
r14226: Fix Coverity bug # 109
Volker Lendecke [Sat, 11 Mar 2006 23:58:18 +0000 (23:58 +0000)]
r14225: Fix Coverity Bug # 67
Volker Lendecke [Sat, 11 Mar 2006 23:52:09 +0000 (23:52 +0000)]
r14224: Fix Coverity bug # 6
Jeremy Allison [Sat, 11 Mar 2006 23:14:42 +0000 (23:14 +0000)]
r14221: Fix coverity #76. My previous change wasn't quite enough :-).
Jeremy.
Jeremy Allison [Sat, 11 Mar 2006 23:11:24 +0000 (23:11 +0000)]
r14219: Fix coverity #135. Don't deref a ptr if it can be NULL.
Jeremy.
Volker Lendecke [Sat, 11 Mar 2006 23:10:31 +0000 (23:10 +0000)]
r14218: Fix Coverity Bug # 2
Volker Lendecke [Sat, 11 Mar 2006 23:07:22 +0000 (23:07 +0000)]
r14217: Fix Coverity Bug # 7
Volker Lendecke [Sat, 11 Mar 2006 23:02:46 +0000 (23:02 +0000)]
r14216: Fix Coverity bug # 8
Volker Lendecke [Sat, 11 Mar 2006 22:21:27 +0000 (22:21 +0000)]
r14214: Fix Coverity Bug # 57
Jeremy Allison [Sat, 11 Mar 2006 20:23:50 +0000 (20:23 +0000)]
r14212: Definately fixes a coverity issue but I've lost track
of the coverity id.... Oh well - definately needs a fix.
Jeremy.
James Peach [Sat, 11 Mar 2006 10:59:03 +0000 (10:59 +0000)]
r14207: Convert the lp_acl_compatibility() param into an enum.
James Peach [Sat, 11 Mar 2006 10:23:02 +0000 (10:23 +0000)]
r14204: Remove the basically unused P_GSTRING and P_UGSTRING
parameter types.
Jeremy Allison [Sat, 11 Mar 2006 02:48:20 +0000 (02:48 +0000)]
r14196: Move to using talloc, not malloc for all policy handles.
Jeremy
Jeremy Allison [Sat, 11 Mar 2006 02:43:25 +0000 (02:43 +0000)]
r14194: Coverity bug #35. Fix uninitialized pipe_hnd.
Jeremy.
Jeremy Allison [Sat, 11 Mar 2006 02:29:23 +0000 (02:29 +0000)]
r14192: Don't forget to correctly initialize pipe_hnd.
Coverity fix #34.
Jeremy.
Jeremy Allison [Sat, 11 Mar 2006 02:20:58 +0000 (02:20 +0000)]
r14190: Coverity bug #33. Missing initialization of pipe_hnd.
Jeremy.
Jeremy Allison [Sat, 11 Mar 2006 02:17:00 +0000 (02:17 +0000)]
r14188: Coverity fix #32. Don't deref null.
Jeremy.
Jeremy Allison [Sat, 11 Mar 2006 02:14:49 +0000 (02:14 +0000)]
r14186: Coverity fix #31. Don't deref null.
Jeremy.
Jeremy Allison [Sat, 11 Mar 2006 02:12:25 +0000 (02:12 +0000)]
r14184: Coverity fix #56. Ensure we can't deref null.
Jeremy.
Jeremy Allison [Sat, 11 Mar 2006 02:09:18 +0000 (02:09 +0000)]
r14182: Ensure we know that dom_sid cannot be null.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 23:52:37 +0000 (23:52 +0000)]
r14178: Clarify code for Coverity #49. Ensure we know we
can't have an uninitialized *returned val.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 23:22:38 +0000 (23:22 +0000)]
r14176: Fix coverity bug #30. Ensure no possible null deref.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 18:32:18 +0000 (18:32 +0000)]
r14170: Paranioa fix for sesssetup.
Fix Coverity bug #26. Guard against NULL ref.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 17:52:41 +0000 (17:52 +0000)]
r14168: Fix Coverity #219. I think this is a false coverity
warning as it seems to get confused with assignment
and comparison. Clarify the code anyway.
Jeremy.
Jeremy Allison [Fri, 10 Mar 2006 17:51:22 +0000 (17:51 +0000)]
r14166: Fix const warning.
Jeremy.
Alexander Bokovoy [Fri, 10 Mar 2006 14:39:29 +0000 (14:39 +0000)]
r14158: Fix coverity CID #147 -- do not dereference pointers before checking their existence
Jim McDonough [Fri, 10 Mar 2006 14:28:51 +0000 (14:28 +0000)]
r14156: Fix coverity #114: free storage alloc'ed by sstring_sub()
Jim McDonough [Fri, 10 Mar 2006 14:20:09 +0000 (14:20 +0000)]
r14155: Fix coverity #115: free storage alloc'ed by sstring_sub()
Jim McDonough [Fri, 10 Mar 2006 14:17:44 +0000 (14:17 +0000)]
r14153: Fix coverity #116: free storage alloc'ed by sstring_sub()
Jim McDonough [Fri, 10 Mar 2006 14:14:23 +0000 (14:14 +0000)]
r14152: Fix coverity #117: free storage alloc'ed by sstring_sub
Jim McDonough [Fri, 10 Mar 2006 14:09:34 +0000 (14:09 +0000)]
r14150: Fix coverity #118: not freeing alloc'ed storage returned from
sstring_sub().
Günther Deschner [Fri, 10 Mar 2006 13:36:39 +0000 (13:36 +0000)]
r14148: Removing the not very well tested krb5 ticket refresh handling activated
over --with-kcm. No time to look after it for the moment.
Guenther
Jim McDonough [Fri, 10 Mar 2006 13:33:02 +0000 (13:33 +0000)]
r14147: Fix coverity #119. alloc'ed memory returned not saved, so not freed.
Need to go back and correct the assumption that an "ldap xxx suffix"
parm must have an OU.
Günther Deschner [Fri, 10 Mar 2006 13:14:01 +0000 (13:14 +0000)]
r14146: Just some typos.
Guenther
Günther Deschner [Fri, 10 Mar 2006 13:12:38 +0000 (13:12 +0000)]
r14145: Add missing WITH_KCM hunks from my local tree.
Guenther
Günther Deschner [Fri, 10 Mar 2006 13:01:08 +0000 (13:01 +0000)]
r14144: allow to set sec_info in rpcclients lsa_query_secobj.
Guenther
Jim McDonough [Fri, 10 Mar 2006 09:41:08 +0000 (09:41 +0000)]
r14135: Fix for Coverity #123: resource leak. Also rework much of the code to
make it cleaner. There's still more to do on this...
Volker Lendecke [Fri, 10 Mar 2006 09:07:03 +0000 (09:07 +0000)]
r14134: Fix Coverity bug # 137
Volker Lendecke [Fri, 10 Mar 2006 08:56:13 +0000 (08:56 +0000)]
r14133: Fix Coverity bug # 140
Volker Lendecke [Fri, 10 Mar 2006 08:53:15 +0000 (08:53 +0000)]
r14132: Fix Coverity bug # 150.
Jerry, you might want to check this.
Thanks
Volker
Volker Lendecke [Fri, 10 Mar 2006 08:47:59 +0000 (08:47 +0000)]
r14131: Fix Coverity bug # 127
Günther Deschner [Fri, 10 Mar 2006 08:43:32 +0000 (08:43 +0000)]
r14130: Remove make_server_info_pac alltogether, make_server_info_info3 does
already do what we need.
Guenther
Günther Deschner [Fri, 10 Mar 2006 08:26:40 +0000 (08:26 +0000)]
r14129: Add the group sids from the Kerberos PAC to the user token.
Guenther
Steve French [Fri, 10 Mar 2006 04:18:29 +0000 (04:18 +0000)]
r14128: Remove warning generated by coverity scan tool (missing SAFE_FREE in error path)
Steve French [Fri, 10 Mar 2006 04:05:49 +0000 (04:05 +0000)]
r14127: Remove coverity warning on mount.cifs.c
Steve French [Fri, 10 Mar 2006 03:47:57 +0000 (03:47 +0000)]
r14126: resolve two warnings from the coverity scan
Jeremy Allison [Thu, 9 Mar 2006 23:20:52 +0000 (23:20 +0000)]
r14121: We never pass NULL to the rpc_api_pipe fn so don't
trigger coverity checks by testing for NULL.
Jeremy.
git.samba.org / tprouty / samba.git / log