16 years agosplit replace into replace and replace1 to allow setenv to be used by
Herb Lewis [Tue, 29 Jul 2003 20:11:18 +0000 (20:11 +0000)]
split replace into replace and replace1 to allow setenv to be used by
nsswitch modules. Add required libraries to get rid of undefined
functions for and

16 years agoFix bug #226. Stop unmangle of name into a wildcard name from deleting more
Jeremy Allison [Tue, 29 Jul 2003 19:16:59 +0000 (19:16 +0000)]
Fix bug #226. Stop unmangle of name into a wildcard name from deleting more
than was intended.

16 years agoAdd NT quotas support. Users allowed now to manage quotas on systems with sysquotas...
Alexander Bokovoy [Tue, 29 Jul 2003 18:07:13 +0000 (18:07 +0000)]
Add NT quotas support. Users allowed now to manage quotas on systems with sysquotas interface detected (Linux at least) using native Windows tools. Also move default quota support for NT quotas to VFS module default_quota. Code by Metze

16 years agoFinish tridge's patch as referenced here :
Jeremy Allison [Tue, 29 Jul 2003 17:34:20 +0000 (17:34 +0000)]
Finish tridge's patch as referenced here :

make sure we don't allow the creation of directories containing
wildcard characters. I've only put this in mkdir at the moment, but I
suspect this will apply to all places that can create new filenames.

We need to allow the opening of existing filenames that contain
wildcards, but not allow the creation of new ones.


16 years agoTypo on my part. I typed KRB5_KDB_BAD_ENCTYPE when I meant to type KRB5_BAD_ENCTYPE.
Jeremy Allison [Tue, 29 Jul 2003 17:03:51 +0000 (17:03 +0000)]
Typo on my part. I typed KRB5_KDB_BAD_ENCTYPE when I meant to type KRB5_BAD_ENCTYPE.
Heimdal has the latter, not the former.

16 years agoFix the build on Heimdal. KRB5_KDB_BAD_ENCTYPE doesn't exist on Heimdal, and
Jim McDonough [Tue, 29 Jul 2003 16:34:31 +0000 (16:34 +0000)]
Fix the build on Heimdal.  KRB5_KDB_BAD_ENCTYPE doesn't exist on Heimdal, and
it's a different rc than KRB5_BAD_ENCTYPE (which exists on both MIT and
Heimdal).  This will just make the debug show up at level 3 always.

Jeremy, you may want to revisit this, but it's probably not worth the hassle.

16 years agoThis adds gss-spnego to ntlm_auth. It contains some new spnego support
Volker Lendecke [Tue, 29 Jul 2003 15:00:38 +0000 (15:00 +0000)]
This adds gss-spnego to ntlm_auth. It contains some new spnego support
from Jim McDonough. It is to enable cyrus sasl to provide the
gss-spnego support. For a preliminary patch to cyrus sasl see


16 years agoTypo fix for bug 258.
Tim Potter [Tue, 29 Jul 2003 02:34:18 +0000 (02:34 +0000)]
Typo fix for bug 258.

16 years agoImproved debug messages whilst trying to track down kerb issues.
Jeremy Allison [Tue, 29 Jul 2003 00:31:44 +0000 (00:31 +0000)]
Improved debug messages whilst trying to track down kerb issues.

16 years agoMore memory leak fixes from Brett! It turns out PyDict_SetItemString
Tim Potter [Tue, 29 Jul 2003 00:15:23 +0000 (00:15 +0000)]
More memory leak fixes from Brett!  It turns out PyDict_SetItemString
didn't behave exactly as I thought it did.  If you create an item using a
PyFoo_FromBar function you must decrement the reference to that object
afterwards (or use Py_BuildValue).

16 years agoMemory leak fixes from Brett A. Funderburg - don't use the connection talloc
Tim Potter [Tue, 29 Jul 2003 00:08:05 +0000 (00:08 +0000)]
Memory leak fixes from Brett A. Funderburg - don't use the connection talloc
context for data that is only needed on a per-call basis.

16 years agoAdd debug output api's from lsa/spoolss modules to smb module. Patch
Tim Potter [Tue, 29 Jul 2003 00:05:17 +0000 (00:05 +0000)]
Add debug output api's from lsa/spoolss modules to smb module.  Patch
from Brett A. Funderburg.

16 years agoCorrected description of SWAT FLAGS since they have changed as a result of the
John Terpstra [Mon, 28 Jul 2003 05:49:51 +0000 (05:49 +0000)]
Corrected description of SWAT FLAGS since they have changed as a result of the
cleanup of loadparm and swat.c

16 years agoCleanup of loadparm and swat to correctly display all parameters as required.
John Terpstra [Mon, 28 Jul 2003 05:47:15 +0000 (05:47 +0000)]
Cleanup of loadparm and swat to correctly display all parameters as required.
No change to what is displayed has been made at this time. I do intend to
change the display order before 3.0.0 ships.

16 years agoAdd buttons to Printers View
John Terpstra [Sun, 27 Jul 2003 19:49:23 +0000 (19:49 +0000)]
Add buttons to Printers View

16 years agoClarified what the SWAT FLAGS mean and what they do.
John Terpstra [Sun, 27 Jul 2003 17:24:24 +0000 (17:24 +0000)]
Clarified what the SWAT FLAGS mean and what they do.
Note: The comments in this file regarding the FLAGS has been in need of
maintenance for some time.

16 years agoFix comment
Andrew Bartlett [Sun, 27 Jul 2003 10:25:44 +0000 (10:25 +0000)]
Fix comment

16 years agothe testsuite lib needs dummyroot too.
Andrew Bartlett [Sun, 27 Jul 2003 03:43:41 +0000 (03:43 +0000)]
the testsuite lib needs dummyroot too.

16 years agoFix typo.
John Terpstra [Sun, 27 Jul 2003 03:43:40 +0000 (03:43 +0000)]
Fix typo.

16 years agoUse the specified workgroup in 'net ads'. (Defaults to lp_workgroup()).
Andrew Bartlett [Sun, 27 Jul 2003 03:42:10 +0000 (03:42 +0000)]
Use the specified workgroup in 'net ads'.  (Defaults to lp_workgroup()).

Andrew Bartlett

16 years agoAllow the stat cache to better handle invalid multibyte strings, by using
Andrew Bartlett [Sun, 27 Jul 2003 03:40:45 +0000 (03:40 +0000)]
Allow the stat cache to better handle invalid multibyte strings, by using
strdup_upper().  This function may fail - and we can just drop out of using
the cache in that case.  (Rather than panicing).

This also should get us closer to supporting all of the weird 'longer/shorter'
on uppercase/lowercase.

Andrew Bartlett

16 years agoTry again to fix up 'session request' name exchange. This time we actualy
Andrew Bartlett [Sun, 27 Jul 2003 03:29:40 +0000 (03:29 +0000)]
Try again to fix up 'session request' name exchange.  This time we actualy
get the names...

Andrew Bartlett

16 years agoIf we strupper_m after the alpha_strcpy() we know that it is less likaly
Andrew Bartlett [Sun, 27 Jul 2003 02:43:22 +0000 (02:43 +0000)]
If we strupper_m after the alpha_strcpy() we know that it is less likaly
to contain multibyte charcters, as these should have been stripped.

Andrew Bartlett

16 years agoWhen removing an 'unused' function, it helps to remove the 'unused' callers...
Andrew Bartlett [Sun, 27 Jul 2003 02:42:22 +0000 (02:42 +0000)]
When removing an 'unused' function, it helps to remove the 'unused' callers...

Andrew Bartlett

16 years agoUse push_ucs2_allocate(), rather than convert_string_allocate() directly.
Andrew Bartlett [Sun, 27 Jul 2003 02:40:06 +0000 (02:40 +0000)]
Use push_ucs2_allocate(), rather than convert_string_allocate() directly.

Remove strdup_upper/strdup_lower from their old file, now that they have
been moved to charcnv.c

Note that string_replace assumes that s is a pstring.  (doco change only)

Andrew Bartlett

16 years agoSome small fixes to our charset conversion code:
Andrew Bartlett [Sun, 27 Jul 2003 02:28:25 +0000 (02:28 +0000)]
Some small fixes to our charset conversion code:

 - Treat the NMB names in the 'session request' packet as 'ASCII'.  This means
   that we do not get invalid multibyte from the wire, even if we truncate
   in the conversion.  (Otherwise we panic when we try to strupper_m it).

 - Remove acnv_uxu2(), as it was duplicated by push_ucs2_allocate()
 - Remove acnv_dosu2(), as it is not used.

 - In push_ucs2(), with the STR_UPPER flag, do the case conversion *after*
   the UCS2 conversion, when it we know that the length can't change.  Also
   faster, as we don't need to do another 2 UCS2 conversions.

Andrew Bartlett

16 years agoAdding idmap backend man page section.
John Terpstra [Sun, 27 Jul 2003 01:16:24 +0000 (01:16 +0000)]
Adding idmap backend man page section.

16 years agoEnsure all code paths set add_script.
Jeremy Allison [Sun, 27 Jul 2003 00:20:45 +0000 (00:20 +0000)]
Ensure all code paths set add_script.

16 years agoFormat tidy up.
John Terpstra [Sat, 26 Jul 2003 17:46:47 +0000 (17:46 +0000)]
Format tidy up.

16 years agoFixes bug #243
John Terpstra [Sat, 26 Jul 2003 17:09:54 +0000 (17:09 +0000)]
Fixes bug #243

16 years agoAdded buttons to change view mode. Fixes bug #212
John Terpstra [Sat, 26 Jul 2003 16:56:38 +0000 (16:56 +0000)]
Added buttons to change view mode. Fixes bug #212

16 years agoremove unnceccsary $; spotted by Lee Taylor
Gerald Carter [Sat, 26 Jul 2003 15:50:00 +0000 (15:50 +0000)]
remove unnceccsary $; spotted by Lee Taylor

16 years agofix typo in debug
Gerald Carter [Sat, 26 Jul 2003 12:01:35 +0000 (12:01 +0000)]
fix typo in debug

16 years agoUpdating missing flags.
John Terpstra [Sat, 26 Jul 2003 01:57:16 +0000 (01:57 +0000)]
Updating missing flags.

16 years agoCorrectly detect an "add user script" - check that *lp_adduser_script() != '\0',
Jeremy Allison [Sat, 26 Jul 2003 01:21:06 +0000 (01:21 +0000)]
Correctly detect an "add user script" - check that *lp_adduser_script() != '\0',
not lp_adduser_script() != NULL.

16 years agoStart the packet signing engine in the kerberos case in the same place
Jeremy Allison [Fri, 25 Jul 2003 23:43:22 +0000 (23:43 +0000)]
Start the packet signing engine in the kerberos case in the same place
as the ntlmssp case.

16 years agoW00t! Client smb signing is now working correctly with krb5 and w2k server.
Jeremy Allison [Fri, 25 Jul 2003 23:15:30 +0000 (23:15 +0000)]
W00t! Client smb signing is now working correctly with krb5 and w2k server.
Server code *should* also work (I'll check shortly). May be the odd memory
leak. Problem was we (a) weren't setting signing on in the client krb5 sessionsetup
code (b) we need to ask for a subkey... (c). The client and server need to
ask for local and remote subkeys respectively.
Thanks to Paul Nelson @ Thursby for some sage advice on this :-).

16 years agoFix bug #184; set max_pw_age in account_pol to -1 so the default is never to expire
Gerald Carter [Fri, 25 Jul 2003 19:57:26 +0000 (19:57 +0000)]
Fix bug #184; set max_pw_age in account_pol to -1 so the default is never to expire

16 years agodomain in schannel bind credentials must be the dest domain, not ours
Gerald Carter [Fri, 25 Jul 2003 18:00:57 +0000 (18:00 +0000)]
domain in schannel bind credentials must be the dest domain, not ours

16 years agofix case where no realm or workgroup means to use our own
Gerald Carter [Fri, 25 Jul 2003 16:42:34 +0000 (16:42 +0000)]
fix case where no realm or workgroup means to use our own

16 years agofix user_in_list to work with winbind groups again; my bug
Gerald Carter [Fri, 25 Jul 2003 16:03:46 +0000 (16:03 +0000)]
fix user_in_list to work with winbind groups again; my bug

16 years agofix some error returns and strings; patch from metze
Gerald Carter [Fri, 25 Jul 2003 14:35:17 +0000 (14:35 +0000)]
fix some error returns and strings; patch from metze

16 years agoMore printf portability fixes. Got caught out by some gcc'isms last
Tim Potter [Fri, 25 Jul 2003 04:24:40 +0000 (04:24 +0000)]
More printf portability fixes.  Got caught out by some gcc'isms last
time.  )-:

16 years agonew swat icons from Marc Jacobsen @ HP
Gerald Carter [Fri, 25 Jul 2003 03:48:56 +0000 (03:48 +0000)]
new swat icons from Marc Jacobsen @ HP

16 years agocall chkconfig --del winbind on removal (bug #238)
Gerald Carter [Fri, 25 Jul 2003 03:26:03 +0000 (03:26 +0000)]
call chkconfig --del winbind on removal (bug #238)

16 years agofix libsmbclientr symlink (patch by Alex Duggan for bug #247)
Gerald Carter [Fri, 25 Jul 2003 02:38:23 +0000 (02:38 +0000)]
fix libsmbclientr symlink (patch by Alex Duggan for bug #247)

16 years agofix bug config file path in winbind init script (bug #237)
Gerald Carter [Fri, 25 Jul 2003 02:24:47 +0000 (02:24 +0000)]
fix bug config file path in winbind init script (bug #237)

16 years agoSchannel, once setup, may be used on *ANY* TCP/IP connection until the
Andrew Bartlett [Fri, 25 Jul 2003 01:26:19 +0000 (01:26 +0000)]
Schannel, once setup, may be used on *ANY* TCP/IP connection until the
connection that set it up has been shut down.

(Also, pipes still connected, and reconnections to the same pipe (eg SAMR)
may continue to use that session key until their TCP/IP connection is shut

Allow further testing by printing out the session key, and allowing it's input
into rpcclient.

Next step is automatic storage in a TDB.

Andrew Bartlett

16 years agoMake wbinfo -p work again. Fixes bug 251.
Tim Potter [Fri, 25 Jul 2003 01:18:10 +0000 (01:18 +0000)]
Make wbinfo -p work again.  Fixes bug 251.

16 years agoJean-Baptiste Marchand on the ethereal list used some auditing tricks to
Tim Potter [Fri, 25 Jul 2003 00:39:06 +0000 (00:39 +0000)]
Jean-Baptiste Marchand on the ethereal list used some auditing tricks to
discover names for the SAMR specific permissions that were previously unknown.

The existing constant names differ from what win2k calls them but since they
aren't heavily used in Samba at the moment I'll leave them as they are.

Jean-Baptiste's data is at:

16 years agoMore printf fixes - size_t is long on some architectures.
Tim Potter [Thu, 24 Jul 2003 23:46:27 +0000 (23:46 +0000)]
More printf fixes - size_t is long on some architectures.

16 years agoFix from to stop files being created on read-only
Jeremy Allison [Thu, 24 Jul 2003 19:10:52 +0000 (19:10 +0000)]
Fix from to stop files being created on read-only
shares in some circumstances.

16 years agoFix packet signing with asynchronous oplock breaks. Removed bad error message
Jeremy Allison [Thu, 24 Jul 2003 19:05:32 +0000 (19:05 +0000)]
Fix packet signing with asynchronous oplock breaks. Removed bad error message
due to w2k bug. I think this code is now working.... Need more testing of course
but works on all the obvious cases I can think of.

16 years agoAdd a macro to check whether module-specific data set already or not. Returns True...
Alexander Bokovoy [Thu, 24 Jul 2003 14:23:54 +0000 (14:23 +0000)]
Add a macro to check whether module-specific data set already or not. Returns True or False. Should support further encapsulation of VFS-specific structs

16 years agoRise debug level to 5 for not-found-nt-quota message (quota setting for user wasn...
Alexander Bokovoy [Thu, 24 Jul 2003 11:37:11 +0000 (11:37 +0000)]
Rise debug level to 5 for not-found-nt-quota message (quota setting for user wasn't found)

16 years agoSome fclose -> x_fclose found by Tony Jago.
Jeremy Allison [Thu, 24 Jul 2003 07:02:55 +0000 (07:02 +0000)]
Some fclose -> x_fclose found by Tony Jago.

16 years agoEnsure everywhere we defer an incoming SMB request (blocking lock queue,
Jeremy Allison [Thu, 24 Jul 2003 06:56:56 +0000 (06:56 +0000)]
Ensure everywhere we defer an incoming SMB request (blocking lock queue,
in oplock break state, change notify queue) we also push the MID onto
the deferred signing queue. Tomorrow I will test this with valgrind and
oplock tests.

16 years agoSMB signing is now working with change notify. Need to fix the disconnect
Jeremy Allison [Thu, 24 Jul 2003 06:19:37 +0000 (06:19 +0000)]
SMB signing is now working with change notify. Need to fix the disconnect
when bad signature received, plus check the oplock breaks....

16 years agoServer side NTLM signing works - until the first async packet. Working on this
Jeremy Allison [Thu, 24 Jul 2003 04:25:37 +0000 (04:25 +0000)]
Server side NTLM signing works - until the first async packet. Working on this

16 years agoSome more [ug]id_t printf fixes.
Tim Potter [Thu, 24 Jul 2003 00:01:10 +0000 (00:01 +0000)]
Some more [ug]id_t printf fixes.

16 years agoEnsure a prototype is generated for smb_snprintf()
Tim Potter [Wed, 23 Jul 2003 23:30:46 +0000 (23:30 +0000)]
Ensure a prototype is generated for smb_snprintf()

Final bit for bug 187.

16 years agoconnect to the right realm or domain for trusted AD domains
Gerald Carter [Wed, 23 Jul 2003 19:58:01 +0000 (19:58 +0000)]
connect to the right realm or domain for trusted AD domains

16 years agofix typo
Gerald Carter [Wed, 23 Jul 2003 12:42:48 +0000 (12:42 +0000)]
fix typo

16 years agoconvert snprintf() calls using pstrings & fstrings
Gerald Carter [Wed, 23 Jul 2003 12:33:59 +0000 (12:33 +0000)]
convert snprintf() calls using pstrings & fstrings
to pstr_sprintf() and fstr_sprintf() to try to standardize.
lots of snprintf() calls were using len-1; some were using
len.  At least this helps to be consistent.

16 years agofixed segv in calls to pstrcpy() in cliprint.c
Andrew Tridgell [Wed, 23 Jul 2003 10:09:29 +0000 (10:09 +0000)]
fixed segv in calls to pstrcpy() in cliprint.c

16 years agoFix out of date comment.
Tim Potter [Wed, 23 Jul 2003 07:14:33 +0000 (07:14 +0000)]
Fix out of date comment.

16 years agoMove a function to avoid a warning.
Tim Potter [Wed, 23 Jul 2003 06:37:51 +0000 (06:37 +0000)]
Move a function to avoid a warning.

16 years agoTypo in comment.
Tim Potter [Wed, 23 Jul 2003 06:11:38 +0000 (06:11 +0000)]
Typo in comment.

16 years agoDon't check in two places for signing turned off...
Jeremy Allison [Wed, 23 Jul 2003 06:04:20 +0000 (06:04 +0000)]
Don't check in two places for signing turned off...

16 years agoA fix for bug 174. I'm pushing this to the tree to test it on one of
Tim Potter [Wed, 23 Jul 2003 03:59:57 +0000 (03:59 +0000)]
A fix for bug 174.  I'm pushing this to the tree to test it on one of
the build farm machines that I don't have direct access to (hpntc9I).

16 years agoFix two memory leaks in the smb module:
Tim Potter [Wed, 23 Jul 2003 01:26:46 +0000 (01:26 +0000)]
Fix two memory leaks in the smb module:

 - free talloc context when cli_query_secdesc() fails

 - dispose of cli_state when python cli_state_object is garbage collected

16 years agoremoving unused function
Gerald Carter [Tue, 22 Jul 2003 15:08:34 +0000 (15:08 +0000)]
removing unused function

16 years agobumping version string
Gerald Carter [Tue, 22 Jul 2003 15:02:39 +0000 (15:02 +0000)]
bumping version string

16 years agoFix comment
Alexander Bokovoy [Tue, 22 Jul 2003 14:43:05 +0000 (14:43 +0000)]
Fix comment

16 years agosync from bea3 release
Gerald Carter [Tue, 22 Jul 2003 13:10:57 +0000 (13:10 +0000)]
sync from bea3 release

16 years agoAnother round of uid/gid/pid format string changes I missed the
Tim Potter [Tue, 22 Jul 2003 06:52:39 +0000 (06:52 +0000)]
Another round of uid/gid/pid format string changes I missed the
first time.

16 years agoFixup a bunch of printf-style functions and debugs to use unsigned long when
Tim Potter [Tue, 22 Jul 2003 04:31:20 +0000 (04:31 +0000)]
Fixup a bunch of printf-style functions and debugs to use unsigned long when
displaying pid_t, uid_t and gid_t values.  This removes a whole lot of warnings
on some of the 64-bit build farm machines as well as help us out when 64-bit
uid/gid/pid values come along.

16 years agoUse %p for a pointer type in a printf-style format string. Also casting
Tim Potter [Tue, 22 Jul 2003 01:18:24 +0000 (01:18 +0000)]
Use %p for a pointer type in a printf-style format string.  Also casting
a pointer to a uint32 value is incorrect on a 64-bit architecture.

16 years agoReplace the eight (!) copies of dummy become/unbecome root with a single one.
Tim Potter [Tue, 22 Jul 2003 00:20:53 +0000 (00:20 +0000)]
Replace the eight (!) copies of dummy become/unbecome root with a single one.

16 years agoUse lp_idmap_[ug]id() instead of lp_winbind_[ug]id()
Tim Potter [Tue, 22 Jul 2003 00:16:39 +0000 (00:16 +0000)]
Use lp_idmap_[ug]id() instead of lp_winbind_[ug]id()

16 years agoMetze's AD/LDAP detection patches mainly to do with library detection.
Tim Potter [Mon, 21 Jul 2003 23:42:45 +0000 (23:42 +0000)]
Metze's AD/LDAP detection patches mainly to do with library detection.
Tested on a large combination of operating systems and versions.
Hopefully the build farm will find any remaining nasties if they

16 years agoClarify a debug log a little. The path might not exist, so say so.
Richard Sharpe [Mon, 21 Jul 2003 20:20:09 +0000 (20:20 +0000)]
Clarify a debug log a little. The path might not exist, so say so.

16 years agoThis creates passdb backend files automatically when adding first account.
Rafal Szczesniak [Sun, 20 Jul 2003 21:43:41 +0000 (21:43 +0000)]
This creates passdb backend files automatically when adding first account.
An extra message notifying that needed file didn't exist is displayed.
There's still a little catch with tdb backend, but it's better than it was,
from end-user's point of view.

This fixes #198


16 years agoTypo fixes.
Rafal Szczesniak [Sun, 20 Jul 2003 14:50:38 +0000 (14:50 +0000)]
Typo fixes.

16 years agoFix typo
Jelmer Vernooij [Sun, 20 Jul 2003 00:34:24 +0000 (00:34 +0000)]
Fix typo

16 years agoFix memleak
Volker Lendecke [Sat, 19 Jul 2003 11:28:15 +0000 (11:28 +0000)]
Fix memleak

16 years agoFix StrCaseCmp() to avoid calling smb_panic() on invalid multibyte strings.
Andrew Bartlett [Sat, 19 Jul 2003 00:36:43 +0000 (00:36 +0000)]
Fix StrCaseCmp() to avoid calling smb_panic() on invalid multibyte strings.

This fix results in
 - we no longer use fixed-size buffers in StrCaseCmp (previously limited to
   a pstring)
 - we return strcmp(s, t) if either of the strings is invalid
 - for non-ascii cases, we call iconv twice, not 4 times.

The basic idea with this fix is that if a string is not valid in the currnet
charset, then (unless it is byte-equivilant) it cannot be case-equivilant
to any other string.

This should address the majority of our smb_panic() cases on this matter.  It
will not fix them all - we still call unix_strupper(), aka strupper_m()
elsewhere, but this was being called on every file in the directory when
we performed unix_convert().

Tested with the stf unit tests for this routine.

Andrew Bartlett

16 years agoAccording to the result of voting, net has default debug level with
Rafal Szczesniak [Sat, 19 Jul 2003 00:23:08 +0000 (00:23 +0000)]
According to the result of voting, net has default debug level with
ability to change it by command line instead of turn-off cmdline switch
for debug messages.
It's a bit more comfortable to use now.

16 years agoFix memleak
Volker Lendecke [Fri, 18 Jul 2003 11:36:16 +0000 (11:36 +0000)]
Fix memleak

16 years agoFix two memleaks in pdb_ldap.c.
Volker Lendecke [Fri, 18 Jul 2003 09:05:30 +0000 (09:05 +0000)]
Fix two memleaks in pdb_ldap.c.

Whoever put the private.backend_private_data_free_fn thingy into
SAM_ACCOUNT, could you please revisit my change to pdb_get_set.c and
comment on my comment there?



16 years agomake sure we don't allow the creation of directories containing
Andrew Tridgell [Fri, 18 Jul 2003 07:07:29 +0000 (07:07 +0000)]
make sure we don't allow the creation of directories containing
wildcard characters. I've only put this in mkdir at the moment, but I
suspect this will apply to all places that can create new filenames.

We need to allow the opening of existing filenames that contain
wildcards, but not allow the creation of new ones.

16 years agothis fixes a bug where Samba would under some circumstances return
Andrew Tridgell [Fri, 18 Jul 2003 06:48:28 +0000 (06:48 +0000)]
this fixes a bug where Samba would under some circumstances return
incomplete directory listings. The problem was the exact_match
optimisation that short circuited directory listings on exact
matches. This optimisation doesn't work when the unix filename
contains Microsoft wildcard characters.

16 years agoFix spelling typo.
Tim Potter [Fri, 18 Jul 2003 03:04:13 +0000 (03:04 +0000)]
Fix spelling typo.

16 years agoUninstall modules as part of uninstall. Partial fix for 236.
Tim Potter [Fri, 18 Jul 2003 02:57:43 +0000 (02:57 +0000)]
Uninstall modules as part of uninstall.  Partial fix for 236.

We still don't uninstall swat or the man pages properly.

16 years agofixed the pstrcpy() bug in directory recursion properly
Andrew Tridgell [Fri, 18 Jul 2003 01:36:11 +0000 (01:36 +0000)]
fixed the pstrcpy() bug in directory recursion properly

16 years agoSigning so far... the client code fails on a SMBtrans2 secondary transaction
Jeremy Allison [Fri, 18 Jul 2003 00:53:34 +0000 (00:53 +0000)]
Signing so far... the client code fails on a SMBtrans2 secondary transaction
I think (my changes haven't affected this I believe). Initial support on the
server side for smbclient. Still doesn't work for w2k clients I think...
Work in progress..... (don't change).

16 years agoFormatting tidyups to match the rest of the source.
Jeremy Allison [Thu, 17 Jul 2003 18:55:40 +0000 (18:55 +0000)]
Formatting tidyups to match the rest of the source.

16 years agoDisconnect an idle LDAP connection after 150 seconds.
Volker Lendecke [Thu, 17 Jul 2003 11:24:54 +0000 (11:24 +0000)]
Disconnect an idle LDAP connection after 150 seconds.

Not strictly a bugfix, but it should considerably reduce the load we
put on LDAP servers given that at least nss_ldap on Linux keeps a
connection open.

And it should also stress our reconnect-code a bit more ;-)

Thanks to metze for this!


16 years agoBan getgrouplist on linux glibc systems with glibc <= 2.3.
Volker Lendecke [Thu, 17 Jul 2003 10:03:37 +0000 (10:03 +0000)]
Ban getgrouplist on linux glibc systems with glibc <= 2.3.

This segfaults when you have to many group membership entries
in /etc/group.

Fixed in glibc CVS end of April 2003.


16 years agoFix for bug 222 from Marcin Owsiany.
Tim Potter [Thu, 17 Jul 2003 04:17:58 +0000 (04:17 +0000)]
Fix for bug 222 from Marcin Owsiany.

Don't get stuck in an infinite loop listing directories recursively
if the server returns an empty directory name.  This can happen with
incorrect i18n configuration on a Samba server.