tprouty/samba.git
15 years agos3-spoolss: use rpccli_spoolss_ReplyOpenPrinter.
Günther Deschner [Mon, 9 Feb 2009 14:15:26 +0000 (15:15 +0100)]
s3-spoolss: use rpccli_spoolss_ReplyOpenPrinter.

Guenther

15 years agos3: re-run make samba3-idl.
Günther Deschner [Mon, 9 Feb 2009 14:14:52 +0000 (15:14 +0100)]
s3: re-run make samba3-idl.

Guenther

15 years agospoolss: fix spoolss_ReplyOpenPrinter IDL.
Günther Deschner [Mon, 9 Feb 2009 14:14:30 +0000 (15:14 +0100)]
spoolss: fix spoolss_ReplyOpenPrinter IDL.

Guenther

15 years agoS3: Add in missing full audit entries.
todd stecher [Tue, 10 Feb 2009 20:14:39 +0000 (12:14 -0800)]
S3: Add in missing full audit entries.

15 years agoS3: Fixes for coverity issues.
todd stecher [Mon, 9 Feb 2009 21:25:59 +0000 (13:25 -0800)]
S3: Fixes for coverity issues.

15 years agoRemove an unused extern reference
Volker Lendecke [Sun, 8 Feb 2009 13:24:22 +0000 (14:24 +0100)]
Remove an unused extern reference

15 years agoConvert api_NetUserGetGroups to use samr instead of pdb
Volker Lendecke [Sun, 8 Feb 2009 13:20:17 +0000 (14:20 +0100)]
Convert api_NetUserGetGroups to use samr instead of pdb

15 years agoFix some nonempty blank lines
Volker Lendecke [Thu, 5 Feb 2009 14:53:04 +0000 (15:53 +0100)]
Fix some nonempty blank lines

15 years agoDo not use strlen if not necessary... :-)
Volker Lendecke [Sun, 1 Feb 2009 19:47:59 +0000 (20:47 +0100)]
Do not use strlen if not necessary... :-)

15 years agoIf we receive a DOS error code, nt_errstr should display it
Volker Lendecke [Sun, 1 Feb 2009 16:17:37 +0000 (17:17 +0100)]
If we receive a DOS error code, nt_errstr should display it

15 years agopackaging: add script fill-templates
Michael Adam [Tue, 10 Feb 2009 17:54:16 +0000 (18:54 +0100)]
packaging: add script fill-templates

This is a standalone-wrapper for update-pkginfo, which is
usually called from create-tarball. It basically repeats
some functionality of create-tarball.

Michael

15 years agoFix an uninitialized variable. Tim, please check!
Volker Lendecke [Tue, 10 Feb 2009 17:09:12 +0000 (18:09 +0100)]
Fix an uninitialized variable. Tim, please check!

15 years agoAdd queueing to np_write
Volker Lendecke [Tue, 10 Feb 2009 14:28:56 +0000 (15:28 +0100)]
Add queueing to np_write

15 years agoAdd queueing to np_read_state, simulate message-type named pipes.
Volker Lendecke [Mon, 9 Feb 2009 07:10:09 +0000 (08:10 +0100)]
Add queueing to np_read_state, simulate message-type named pipes.

The problem with msg-type pipes is that we have to return short reads when a
message ends before the read request. When reading from the unix domain socket,
the message limits are lost. So we would happily return more than a message,
which confuses for example the s4 rpc client horribly. I'd expect other np rpc
clients also to blow up over this.

The real solution is to properly implement a two-byte length field per message
on the unix domain socket, but this requires more changes there. And as we
right now only serve DCE/RPC over the named pipes, this implements a hack that
looks into the fragment headers to figure out hdr.frag_len.

15 years agoAdd read_pkt_send/recv
Volker Lendecke [Tue, 10 Feb 2009 16:29:02 +0000 (17:29 +0100)]
Add read_pkt_send/recv

15 years agoselftest/Samba4: pass down the kdc address down to provision_raw_*()
Stefan Metzmacher [Tue, 10 Feb 2009 17:00:48 +0000 (18:00 +0100)]
selftest/Samba4: pass down the kdc address down to provision_raw_*()

metze

15 years agoselftest/Samba4: split out ldap specific stuff from provision_raw_*()
Stefan Metzmacher [Tue, 10 Feb 2009 16:55:54 +0000 (17:55 +0100)]
selftest/Samba4: split out ldap specific stuff from provision_raw_*()

metze

15 years agoselftest/Samba4: split out share configurations of provision_raw*()
Stefan Metzmacher [Tue, 10 Feb 2009 16:01:51 +0000 (17:01 +0100)]
selftest/Samba4: split out share configurations of provision_raw*()

metze

15 years agoselftest/Samba4: split provision() into provision_raw_prepare() and provision_raw_run()
Stefan Metzmacher [Wed, 4 Feb 2009 10:18:32 +0000 (11:18 +0100)]
selftest/Samba4: split provision() into provision_raw_prepare() and provision_raw_run()

This functions will be reused soon for a Samba34.pm used by
a 'make selftest34'

metze

15 years agoselftest: s/SMBD/SAMBA/ in Samba.pm
Stefan Metzmacher [Wed, 4 Feb 2009 14:17:14 +0000 (15:17 +0100)]
selftest: s/SMBD/SAMBA/ in Samba.pm

metze

15 years agoselftest: allow "skip" as max runtime for smbd, nmbd and winbindd
Stefan Metzmacher [Wed, 4 Feb 2009 14:16:42 +0000 (15:16 +0100)]
selftest: allow "skip" as max runtime for smbd, nmbd and winbindd

metze

15 years agoselftest: Samba3 protect against removing /*
Stefan Metzmacher [Wed, 4 Feb 2009 10:26:46 +0000 (11:26 +0100)]
selftest: Samba3 protect against removing /*

metze

15 years agoselftest: add target::Template
Stefan Metzmacher [Wed, 4 Feb 2009 10:21:29 +0000 (11:21 +0100)]
selftest: add target::Template

metze

15 years agomerged-build: pass PYTHON and PERL down to make test4
Stefan Metzmacher [Wed, 4 Feb 2009 10:20:39 +0000 (11:20 +0100)]
merged-build: pass PYTHON and PERL down to make test4

metze

15 years agoselftest: add my copyright
Stefan Metzmacher [Wed, 4 Feb 2009 10:20:14 +0000 (11:20 +0100)]
selftest: add my copyright

metze

15 years agos3-spoolss: remove old spoolss_OpenPrinter.
Günther Deschner [Tue, 10 Feb 2009 00:58:46 +0000 (01:58 +0100)]
s3-spoolss: remove old spoolss_OpenPrinter.

Guenther

15 years agos3-spoolss: use pidl for _spoolss_OpenPrinter.
Günther Deschner [Tue, 10 Feb 2009 00:48:18 +0000 (01:48 +0100)]
s3-spoolss: use pidl for _spoolss_OpenPrinter.

Guenther

15 years agos3-spoolss: remove old spoolss_OpenPrinterEx.
Günther Deschner [Tue, 10 Feb 2009 00:53:32 +0000 (01:53 +0100)]
s3-spoolss: remove old spoolss_OpenPrinterEx.

Guenther

15 years agos3-spoolss: use pidl for _spoolss_OpenPrinterEx.
Günther Deschner [Tue, 10 Feb 2009 00:43:25 +0000 (01:43 +0100)]
s3-spoolss: use pidl for _spoolss_OpenPrinterEx.

Guenther

15 years agos3-spoolss: remove old spoolss_SetJob.
Günther Deschner [Mon, 9 Feb 2009 23:21:53 +0000 (00:21 +0100)]
s3-spoolss: remove old spoolss_SetJob.

Guenther

15 years agos3-spoolss: use pidl for _spoolss_SetJob.
Günther Deschner [Mon, 9 Feb 2009 23:21:26 +0000 (00:21 +0100)]
s3-spoolss: use pidl for _spoolss_SetJob.

Guenther

15 years agos3-spoolss: remove old spoolss_StartDocPrinter.
Günther Deschner [Mon, 9 Feb 2009 22:31:35 +0000 (23:31 +0100)]
s3-spoolss: remove old spoolss_StartDocPrinter.

Guenther

15 years agos3-spoolss: use pidl for _spoolss_StartDocPrinter.
Günther Deschner [Mon, 9 Feb 2009 22:28:34 +0000 (23:28 +0100)]
s3-spoolss: use pidl for _spoolss_StartDocPrinter.

Guenther

15 years agos3-spoolss: add temporary convert_devicemode_new function.
Günther Deschner [Tue, 10 Feb 2009 00:46:32 +0000 (01:46 +0100)]
s3-spoolss: add temporary convert_devicemode_new function.

Guenther

15 years agos3-spoolss: use SPOOLSS_JOB_CONTROL bits defined in IDL.
Günther Deschner [Mon, 9 Feb 2009 23:08:11 +0000 (00:08 +0100)]
s3-spoolss: use SPOOLSS_JOB_CONTROL bits defined in IDL.

Guenther

15 years agos3-rpcclient: use rpccli_spoolss_openprinter_ex helper.
Günther Deschner [Mon, 9 Feb 2009 17:49:34 +0000 (18:49 +0100)]
s3-rpcclient: use rpccli_spoolss_openprinter_ex helper.

Guenther

15 years agos3-rpcclient: add rpccli_spoolss_openprinter_ex() convenience wrapper.
Günther Deschner [Mon, 9 Feb 2009 16:56:20 +0000 (17:56 +0100)]
s3-rpcclient: add rpccli_spoolss_openprinter_ex() convenience wrapper.

Guenther

15 years agos3-spoolss: fix memleak in get_remote_printer_publishing_data().
Günther Deschner [Tue, 10 Feb 2009 09:45:55 +0000 (10:45 +0100)]
s3-spoolss: fix memleak in get_remote_printer_publishing_data().

Guenther

15 years agos3: OneFS bulk directory enumeration support
Steven Danneman [Tue, 27 Jan 2009 04:14:32 +0000 (20:14 -0800)]
s3: OneFS bulk directory enumeration support

OneFS provides the bulk directory enumeration syscall readdirplus().  This
syscall has the same semantics as the NFSv3 READDIRPLUS command, returning
a batch of directory entries with prefetched stat information via one
syscall.

This commit wraps the readdirplus() call in the existing POSIX
readdir/seekdir VFS interface.  By default a batch of 128 directory entries
are optimistically read from the kernel into a global cache, and fed to
iterative calls of VFS_OP_READDIR.

The global buffers could be avoided in the future by hanging connection
specific buffers off the conn struct.

Added new parameter "onefs:use readdirplus" which toggles usage of this
code on or off.

15 years agos3: Added SMB_VFS_INIT_SEARCH_OP to initialize data at the beginning of SMB search...
Steven Danneman [Tue, 3 Feb 2009 05:37:51 +0000 (21:37 -0800)]
s3: Added SMB_VFS_INIT_SEARCH_OP to initialize data at the beginning of SMB search requests.

By default this VFS call is a NOOP, but the onefs vfs module takes advantage
of it to initialize direntry search caches at the beginning of each
TRANS2_FIND_FIRST, TRANS2_FIND_NEXT, SMBffirst, SMBsearch, and SMBunique

15 years agoPass stat buffer down through all levels of VFS_READDIR wrappers
Steven Danneman [Fri, 23 Jan 2009 04:18:56 +0000 (20:18 -0800)]
Pass stat buffer down through all levels of VFS_READDIR wrappers

* VFS_OP_READDIR can now provide stat information, take advantage of it
  if it's available
* is_visible_file(): optimistically expect the provided stat buffer is
  already valid
* dptr_ReadDirName(): refactor code for easier readability, functionality
  is the same

15 years agoAdd an optional SMB_STRUCT_SMB parameter to VFS_OP_READDIR
Steven Danneman [Fri, 23 Jan 2009 04:14:38 +0000 (20:14 -0800)]
Add an optional SMB_STRUCT_SMB parameter to VFS_OP_READDIR

* this allows VFS implementations that prefetch stat information on
  readdir to return it through one VFS call
* backwards compatibility is maintained by passing in NULL
* if the system readdir doesn't return stat info, the stat struct is
  set to invalid

15 years agos3 OneFS: Change ACLs to do a stat-only open before get/set_security_descriptor
Tim Prouty [Thu, 5 Feb 2009 01:28:21 +0000 (17:28 -0800)]
s3 OneFS: Change ACLs to do a stat-only open before get/set_security_descriptor

This ensures that getting/stting a security descriptor does not
contend an oplock.  The correct access checks will be still be done in
the kernel on the get/set rather than the open.

15 years agos3 OneFS: Add kernel oplocks implementation
Tim Prouty [Wed, 28 Jan 2009 00:13:35 +0000 (16:13 -0800)]
s3 OneFS: Add kernel oplocks implementation

A few functions in oplocks_onefs.c need to be accessed from the onefs
vfs module.  It would be ideal if oplocks were implemented at the vfs
layer, but since they aren't yet, a new header is added to
source3/include to make these functions available to the onefs vfs
module.  oplocks_onefs.o doesn't need to be linked into the onefs vfs
module explicitly, since it is already linked into smbd by default.

15 years agos3 oplocks: Remove oplocks before handling delete on close semantics
Tim Prouty [Wed, 4 Feb 2009 07:17:48 +0000 (23:17 -0800)]
s3 oplocks: Remove oplocks before handling delete on close semantics

Unlinking a file while still holding an oplock can cause problems with
kernel oplocks.  This simply releases the oplock before actually
unlinking the file.

15 years agos3 oplocks: Add capabilites flags field to the kernel_oplocks struct
Tim Prouty [Tue, 3 Feb 2009 23:40:23 +0000 (15:40 -0800)]
s3 oplocks: Add capabilites flags field to the kernel_oplocks struct

Here is a short description for each of the new capability flags:

KOPLOCKS_LEVEL2_SUPPORTED: Level 2 oplocks are supported natively in
the kernel.

KOPLOCKS_DEFERRED_OPEN_NOTIFICATION: The kernel notifies deferred
openers when they can retry the open.

KOPLOCKS_TIMEOUT_NOTIFICATION: The kernel notifies smbds when an
oplock break times out.

KOPLOCKS_OPLOCK_BROKEN_NOTIFICATION: The kernel notifies smbds when an
oplock is broken.

15 years agos3 oplocks: Make the level2 oplock contention API more granular
Tim Prouty [Tue, 3 Feb 2009 19:56:35 +0000 (11:56 -0800)]
s3 oplocks: Make the level2 oplock contention API more granular

This replaces release_level2_oplocks_on_change with
contend_level2_oplock_begin/end in order to contend level2 oplocks
throughout an operation rather than just at the begining.  This is
necessary for some kernel oplock implementations, and also lays the
groundwork for better correctness in Samba's standard level2 oplock
handling.  The next step for non-kernel oplocks is to add additional
state to the share mode lock struct that prevents any new opens from
granting oplocks while a contending operation is in progress.

All operations that contend level 2 oplocks are now correctly spanned
except for aio and synchronous writes.  The two write paths both have
non-trivial error paths that need extra care to get right.

RAW-OPLOCK and the rest of 'make test' are still passing with this
change.

15 years agos3 oplocks: Differentiate between releasing an oplock vs. downgrading to Level 2...
Tim Prouty [Fri, 9 Jan 2009 21:07:58 +0000 (13:07 -0800)]
s3 oplocks: Differentiate between releasing an oplock vs. downgrading to Level 2 for kernel oplocks

Pass in an extra argument when releasing an oplock so kernel oplock
implementations can support downgrading from Level 1 to Level 2.

15 years agos3 vfs: Add a destructor to the fsp extension data API
Tim Prouty [Sun, 1 Feb 2009 04:51:04 +0000 (20:51 -0800)]
s3 vfs: Add a destructor to the fsp extension data API

I'm not certain if the dummy pointer is needed in struct vfs_fsp_data,
but I added it to be consistent with the comment below.

15 years agoadded a workaround to the handling of unicodePwd for Win7-beta
Andrew Tridgell [Tue, 10 Feb 2009 06:31:57 +0000 (17:31 +1100)]
added a workaround to the handling of unicodePwd for Win7-beta

The Win7-beta domain process has changed. It no longer uses SAMR for
setting the password, and instead uses a ldap modify on a SASL
encrypted ldap connection. We didn't handle that as the unicodePwd
attribute has a dual use, holding the nt style MD4 hases for DRS
replication, but holding a UTF-16 plaintext password for a LDAP
modify.

This patch copes with the ldap unicodePwd modify by recognising the
format and creating the correct attributes on the fly. Note that this
assumes we will never get a unicodePwd attribute set in NT MD4 format
with the first 2 and last 2 bytes set to 0x22 0x00.

Andrew Bartlett is looking at a more robust solution, possibly using a
flag to say that this modify came via ldap, and not internal ldb
calls.

15 years agofixed two problems with the DsRGetDCNameEx2 call, as used by
Andrew Tridgell [Tue, 10 Feb 2009 06:28:05 +0000 (17:28 +1100)]
fixed two problems with the DsRGetDCNameEx2 call, as used by
Win7-beta.

The first problem is that we removed the dnsDomain attribute a while
back, so we were returning NULL for two fields. We now return the
realm.

The second problem is that Win7-beta sends the domain in the form the
user typed it, so it may be in either the short or long form. We check
for the short form and convert if needed.

15 years agoS3: Various fixes for log2pcaphex utility
todd stecher [Mon, 9 Feb 2009 07:43:21 +0000 (23:43 -0800)]
S3: Various fixes for log2pcaphex utility

15 years agos3 spoolss: arch needs to be set before it's passed to get_version_id.
Tim Prouty [Tue, 10 Feb 2009 00:12:20 +0000 (16:12 -0800)]
s3 spoolss: arch needs to be set before it's passed to get_version_id.

7717ad688099860fa0989ed3582435404fd6d4fa left arch unitialized.

Guenther, please check.

15 years agoRevert "s3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary."
Michael Adam [Mon, 9 Feb 2009 22:24:31 +0000 (23:24 +0100)]
Revert "s3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary."

This reverts commit 487f5e7b4768cfe9e511b0ba56f16c411e21f702.

I was confused about the real meaning of find_domain_from_name_noinit()
vs. find_domain_from_name(). We don't need the connection established
here, just the domain struct which gets initialized by rescan_trusted_domains().

Sorry for the noise.

Michael

15 years agoRevert "Fix errornos assumption that all compilers are gcc"
Jelmer Vernooij [Mon, 9 Feb 2009 22:29:41 +0000 (23:29 +0100)]
Revert "Fix errornos assumption that all compilers are gcc"

This breaks (some?) files with gcc.

This reverts commit 98a4327b19e83ffad4e0be7e8895fdbd9e48d49f.

15 years agos3-spoolss: remove old spoolss_ScheduleJob.
Günther Deschner [Mon, 9 Feb 2009 21:30:54 +0000 (22:30 +0100)]
s3-spoolss: remove old spoolss_ScheduleJob.

Guenther

15 years agos3-spoolss: use pidl for _spoolss_ScheduleJob.
Günther Deschner [Mon, 9 Feb 2009 21:30:23 +0000 (22:30 +0100)]
s3-spoolss: use pidl for _spoolss_ScheduleJob.

Guenther

15 years agos3-spoolss: remove old spoolss_AddJob.
Günther Deschner [Mon, 9 Feb 2009 21:12:38 +0000 (22:12 +0100)]
s3-spoolss: remove old spoolss_AddJob.

Guenther

15 years agos3-spoolss: use pidl for _spoolss_AddJob.
Günther Deschner [Mon, 9 Feb 2009 21:12:15 +0000 (22:12 +0100)]
s3-spoolss: use pidl for _spoolss_AddJob.

Guenther

15 years agos3: re-run make samba3-idl.
Günther Deschner [Mon, 9 Feb 2009 21:11:25 +0000 (22:11 +0100)]
s3: re-run make samba3-idl.

Guenther

15 years agospoolss: fill in spoolss_ScheduleJob.
Günther Deschner [Mon, 9 Feb 2009 21:30:07 +0000 (22:30 +0100)]
spoolss: fill in spoolss_ScheduleJob.

Guenther

15 years agospoolss: fill in spoolss_AddJob.
Günther Deschner [Mon, 9 Feb 2009 21:10:47 +0000 (22:10 +0100)]
spoolss: fill in spoolss_AddJob.

Guenther

15 years agos3 async: Fix the build on systems that have ETIMEDOUT but not ETIME
Tim Prouty [Mon, 9 Feb 2009 17:36:40 +0000 (09:36 -0800)]
s3 async: Fix the build on systems that have ETIMEDOUT but not ETIME

Fallback on EAGAIN

15 years agoS3 OneFS: Add in Isilon specific performance counter module
todd stecher [Mon, 9 Feb 2009 07:12:02 +0000 (23:12 -0800)]
S3 OneFS: Add in Isilon specific performance counter module

15 years agoS3: New module interface for SMB message statistics gathering
todd stecher [Mon, 9 Feb 2009 07:10:34 +0000 (23:10 -0800)]
S3: New module interface for SMB message statistics gathering

This changelist allows for the addition of custom performance
monitoring modules through smb.conf. Entrypoints in the main message
processing code have been added to capture the command, subop, ioctl,
identity and message size statistics.

15 years agoFix errornos assumption that all compilers are gcc
Torgeir Lerkerod [Mon, 9 Feb 2009 20:11:13 +0000 (21:11 +0100)]
Fix errornos assumption that all compilers are gcc

When compiling Samba 4's IDL files buildsystem assumes that compiler
knows about -xc, which is a gcc spesefic switch as this switch isn't
needed on gcc either the flag was uneeded and can be removed. Thus no
warnings on non gcc systems.

Signed-off-by: Torgeir Lerkerod <Torgeir.Lerkerod@gmail.com>
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
15 years agodocs: Add man sharesec.
Karolin Seeger [Mon, 9 Feb 2009 20:00:47 +0000 (21:00 +0100)]
docs: Add man sharesec.

Karolin

15 years agoAttempt to fix the build
Volker Lendecke [Mon, 9 Feb 2009 19:18:57 +0000 (20:18 +0100)]
Attempt to fix the build

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Mon, 9 Feb 2009 18:44:50 +0000 (19:44 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agoFix warning in spoolss IDL file output.
Jelmer Vernooij [Mon, 9 Feb 2009 18:43:52 +0000 (19:43 +0100)]
Fix warning in spoolss IDL file output.

15 years agoRerun pidl.
Jelmer Vernooij [Mon, 9 Feb 2009 18:43:06 +0000 (19:43 +0100)]
Rerun pidl.

15 years agos3-spoolss: remove old rpccli_spoolss_routerreplyprinter.
Günther Deschner [Mon, 9 Feb 2009 14:00:49 +0000 (15:00 +0100)]
s3-spoolss: remove old rpccli_spoolss_routerreplyprinter.

Guenther

15 years agos3-spoolss: remove old spoolss_ReplyClosePrinter.
Günther Deschner [Mon, 9 Feb 2009 12:35:05 +0000 (13:35 +0100)]
s3-spoolss: remove old spoolss_ReplyClosePrinter.

Guenther

15 years agos3-spoolss: use rpccli_spoolss_ReplyClosePrinter.
Günther Deschner [Mon, 9 Feb 2009 12:34:35 +0000 (13:34 +0100)]
s3-spoolss: use rpccli_spoolss_ReplyClosePrinter.

Guenther

15 years agos3-spoolss: remove old spoolss_AddPrintProcessor.
Günther Deschner [Mon, 9 Feb 2009 14:32:34 +0000 (15:32 +0100)]
s3-spoolss: remove old spoolss_AddPrintProcessor.

Guenther

15 years agos3-spoolss: use pidl for _spoolss_AddPrintProcessor.
Günther Deschner [Mon, 9 Feb 2009 14:31:35 +0000 (15:31 +0100)]
s3-spoolss: use pidl for _spoolss_AddPrintProcessor.

Guenther

15 years agos3-rpcclient: remove a pointless fstring.
Günther Deschner [Mon, 9 Feb 2009 18:02:56 +0000 (19:02 +0100)]
s3-rpcclient: remove a pointless fstring.

Guenther

15 years agos3-rpcclient: use srv_name_slash instead of formating servername again and again.
Günther Deschner [Mon, 9 Feb 2009 17:10:18 +0000 (18:10 +0100)]
s3-rpcclient: use srv_name_slash instead of formating servername again and again.

Guenther

15 years agos4/wrepl_server: Fix typo in comment.
Karolin Seeger [Mon, 9 Feb 2009 18:05:20 +0000 (19:05 +0100)]
s4/wrepl_server: Fix typo in comment.

Karolin

15 years agoRemove an invalid discard_const_p() - it masks an actual
Jelmer Vernooij [Mon, 9 Feb 2009 17:39:27 +0000 (18:39 +0100)]
Remove an invalid discard_const_p() - it masks an actual
bug in pidl where pidl uses "const" in a struct where there should not be
const.

There is only a single place in the Samba codebase where this triggers a
warning.

15 years agoUse discard_const_p rather than CONST_DISCARD.
Jelmer Vernooij [Mon, 9 Feb 2009 16:50:35 +0000 (17:50 +0100)]
Use discard_const_p rather than CONST_DISCARD.

15 years agoRevert "s3/s4: Move CONST_DISCARD into lib/util so it's available from s3 and s4"
Jelmer Vernooij [Mon, 9 Feb 2009 16:48:30 +0000 (17:48 +0100)]
Revert "s3/s4: Move CONST_DISCARD into lib/util so it's available from s3 and s4"

lib/util already has discard_const_p.

This reverts commit 0cb430c22e9c0af2248fbc15ce97a4d760df189d.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Mon, 9 Feb 2009 15:51:46 +0000 (16:51 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agos3: re-run make samba3-idl.
Günther Deschner [Mon, 9 Feb 2009 13:54:02 +0000 (14:54 +0100)]
s3: re-run make samba3-idl.

Guenther

15 years agos3-spoolss: move PRINTER_ENUM_ICONMASK to IDL.
Günther Deschner [Mon, 9 Feb 2009 14:22:37 +0000 (15:22 +0100)]
s3-spoolss: move PRINTER_ENUM_ICONMASK to IDL.

Guenther

15 years agos3-spoolss: use PRINTER_ENUM_NAME and remove double enum define.
Günther Deschner [Mon, 9 Feb 2009 14:21:30 +0000 (15:21 +0100)]
s3-spoolss: use PRINTER_ENUM_NAME and remove double enum define.

Guenther

15 years agos3-spoolss: remove PRINTER_CHANGE* flags now defined in IDL.
Günther Deschner [Mon, 9 Feb 2009 13:54:20 +0000 (14:54 +0100)]
s3-spoolss: remove PRINTER_CHANGE* flags now defined in IDL.

Guenther

15 years agospoolss: fill in spoolss_AddPrintProcessor.
Günther Deschner [Mon, 9 Feb 2009 14:28:54 +0000 (15:28 +0100)]
spoolss: fill in spoolss_AddPrintProcessor.

Guenther

15 years agospoolss: fill in spoolss_RouterReplyPrinter.
Günther Deschner [Mon, 9 Feb 2009 14:53:07 +0000 (15:53 +0100)]
spoolss: fill in spoolss_RouterReplyPrinter.

Guenther

15 years agospoolss: add spoolss_PrinterChangeFlags.
Günther Deschner [Mon, 9 Feb 2009 13:53:31 +0000 (14:53 +0100)]
spoolss: add spoolss_PrinterChangeFlags.

Guenther

15 years agoeliminate compiler warnings
Derrell Lipman [Mon, 9 Feb 2009 14:53:44 +0000 (09:53 -0500)]
eliminate compiler warnings

15 years agos3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary.
Michael Adam [Mon, 9 Feb 2009 12:50:31 +0000 (13:50 +0100)]
s3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary.

Calling find_domain_from_name_noinit() might not be enough here.
This makes winbindd_getpwent() behave the same as winbindd_getgrent().

Michael

15 years agos3:winbindd_user: fix a debug message.
Michael Adam [Mon, 9 Feb 2009 10:07:11 +0000 (11:07 +0100)]
s3:winbindd_user: fix a debug message.

find_domain_from_name_noinit() is no longer called only for
name alias support.

Michael

15 years agotestprogs/win32: add an option to trigger small reads in npecho_client2.c
Stefan Metzmacher [Mon, 9 Feb 2009 12:31:03 +0000 (13:31 +0100)]
testprogs/win32: add an option to trigger small reads in npecho_client2.c

metze

15 years agos3-spoolss: remove old _spoolss_FindClosePrinterNotify.
Günther Deschner [Mon, 9 Feb 2009 12:03:23 +0000 (13:03 +0100)]
s3-spoolss: remove old _spoolss_FindClosePrinterNotify.

Guenther

15 years agos3-spoolss: use pidl for _spoolss_FindClosePrinterNotify.
Günther Deschner [Mon, 9 Feb 2009 12:03:07 +0000 (13:03 +0100)]
s3-spoolss: use pidl for _spoolss_FindClosePrinterNotify.

Guenther

15 years agos3-spoolss: remove whitespace in printing code.
Günther Deschner [Mon, 9 Feb 2009 11:40:12 +0000 (12:40 +0100)]
s3-spoolss: remove whitespace in printing code.

Guenther

15 years agoFix count in _srvsvc_NetDiskEnum()
Volker Lendecke [Mon, 9 Feb 2009 11:32:16 +0000 (12:32 +0100)]
Fix count in _srvsvc_NetDiskEnum()

Without this, remotely adding a share via MMC fails

15 years agos3-spoolss: remove old _spoolss_DeletePrinterDriverEx.
Günther Deschner [Mon, 9 Feb 2009 10:14:41 +0000 (11:14 +0100)]
s3-spoolss: remove old _spoolss_DeletePrinterDriverEx.

Guenther

15 years agos3-rpcclient: use rpccli_spoolss_DeletePrinterDriverEx.
Günther Deschner [Mon, 9 Feb 2009 10:14:00 +0000 (11:14 +0100)]
s3-rpcclient: use rpccli_spoolss_DeletePrinterDriverEx.

Guenther