11 years agoFix for CVE-2007-5398.
Gerald (Jerry) Carter [Thu, 15 Nov 2007 02:51:14 +0000 (20:51 -0600)]
Fix for CVE-2007-5398.

== Subject:     Remote code execution in Samba's WINS
==              server daemon (nmbd) when processing name
==              registration followed name query requests.
== CVE ID#:     CVE-2007-5398
== Versions:    Samba 3.0.0 - 3.0.26a (inclusive)
Secunia Research reported a vulnerability that allows for
the execution of arbitrary code in nmbd.  This defect may
only be exploited when the "wins support" parameter has
been enabled in smb.conf.

11 years agoFix bug #5083 (and duplicate bug #5084).
Michael Adam [Thu, 15 Nov 2007 10:08:53 +0000 (11:08 +0100)]
Fix bug #5083 (and duplicate bug #5084).

Make solarisacl_sys_acl_get_fd() return a result
when there is one (thereby fixing a memleak).

Thanks to Markus Zell for reporting this.


11 years agoFix bug where tdb lock call interrupted with
Jeremy Allison [Wed, 7 Nov 2007 05:48:01 +0000 (21:48 -0800)]
Fix bug where tdb lock call interrupted with
an alarm sig would not terminate and could lead
to runaway smbd processes.
Thanks to Dave Daugherty @ Centrify for pointing
this out to us.

11 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
Gerald (Jerry) Carter [Wed, 31 Oct 2007 02:22:43 +0000 (22:22 -0400)]
Merge branch 'v3-0-test' of git:// into v3-0-test

11 years agoEnsure we catch an error in the query_user() reply in the receive function.
Gerald (Jerry) Carter [Wed, 31 Oct 2007 02:21:49 +0000 (22:21 -0400)]
Ensure we catch an error in the query_user() reply in the receive function.
backport of v3-2-test patch from Dmitry Butskoy <>.

11 years ago[crash fix] don't use already free'ed memory
Stefan Metzmacher [Wed, 24 Oct 2007 12:29:06 +0000 (14:29 +0200)]
[crash fix] don't use already free'ed memory

(found by "make valgrindtest" and my "start winbindd on make test" patch)

(cherry picked from commit fe21e48489852720a05b305b251e4f5cbb200f7a)

12 years agofix crash bug in pidl generated client code, this
Stefan Metzmacher [Wed, 17 Oct 2007 08:59:24 +0000 (10:59 +0200)]
fix crash bug in pidl generated client code, this
could have happend with [in,out,unique] pointers
when the clients sends a valid pointer, but the server
reponse with a NULL pointer (as samba-3.0.26a do for some calls).

I've tested with midl to see how windows handles this situation
and also the reverse case where the client sends NULL and
the server reposnse with non-NULL.

It appears that midl generated code just ignores this
and only copies the result if both pointers are non-NULL.

Note: this is just cosmetic for the 3.0.x tree, as
rpccli_wkssvc_NetWkstaEnumUsers and rpccli_wkssvc_NetWkstaTransportEnum
are not used.


Stefan Metzmacher [Wed, 17 Oct 2007 08:03:22 +0000 (10:03 +0200)]


12 years agoFix warning messages for unused variables.
Jeremy Allison [Mon, 15 Oct 2007 22:52:30 +0000 (15:52 -0700)]
Fix warning messages for unused variables.
(cherry picked from commit 406737cd9a34ac498e5823b380e1768d41e16c1b)

12 years agoprepare the infrastructure for git branches in the build-farm
Stefan Metzmacher [Thu, 11 Oct 2007 10:27:38 +0000 (12:27 +0200)]
prepare the infrastructure for git branches in the build-farm


12 years agoFix dimap for trusted domains only case
Simo Sorce [Tue, 16 Oct 2007 18:06:33 +0000 (14:06 -0400)]
Fix dimap for trusted domains only case

12 years agocleanup and extent .gitignore
Stefan Metzmacher [Fri, 12 Oct 2007 14:46:24 +0000 (16:46 +0200)]
cleanup and extent .gitignore

(cherry picked from commit 9475993dae06fa023f2eb63d04d5f7b07b0b4d93)

12 years agoAdd .gitignore file from v3-2-test.
Michael Adam [Fri, 12 Oct 2007 14:35:46 +0000 (16:35 +0200)]
Add .gitignore file from v3-2-test.


12 years agoAdd become_root/unbecome_root around one call of getsampwsid()
Michael Adam [Fri, 12 Oct 2007 11:34:09 +0000 (13:34 +0200)]
Add become_root/unbecome_root around one call of getsampwsid()
in create_token_from_username(). This caused set_nt_acl to
partially fail in certain circumstances.

This is expected to bring an improvement to bug #4308.


12 years agoFix default domains support using compat syntax.
Simo Sorce [Thu, 11 Oct 2007 18:35:34 +0000 (14:35 -0400)]
Fix default domains support using compat syntax.
Without this fix idmap_rid can't be used with the compatible syntax.

12 years ago[GLUE] Rsync SAMBA_3_0 SVN r25598 in order to create the v3-0-test branch. initial-v3-0-test
Gerald (Jerry) Carter [Wed, 10 Oct 2007 20:28:53 +0000 (15:28 -0500)]
[GLUE] Rsync SAMBA_3_0 SVN r25598 in order to create the v3-0-test branch.

12 years agor25068: Older samba3 DCs will return DCERPC_FAULT_OP_RNG_ERROR for every opcode on the initial-v3-0-unstable
Günther Deschner [Mon, 10 Sep 2007 23:12:27 +0000 (23:12 +0000)]
r25068: Older samba3 DCs will return DCERPC_FAULT_OP_RNG_ERROR for every opcode on the
LSARPC_DS pipe, continue with no_lsarpc_ds mode here as well to get
domain->initialized set to True. This avoids permanent scanning of Samba3 DCs
in winbindd. Thanks Michael, for pointing this out.


12 years agor24770: Use infolevel 25 to set the machine account's password (just like winxp).
Rafal Szczesniak [Wed, 29 Aug 2007 10:42:53 +0000 (10:42 +0000)]
r24770: Use infolevel 25 to set the machine account's password (just like winxp).
This correctly updates pwdLastSet field on win2k3 server.


12 years agor24344: Make libreplace provide offsetof.
Jelmer Vernooij [Sun, 12 Aug 2007 02:30:25 +0000 (02:30 +0000)]
r24344: Make libreplace provide offsetof.

12 years agor24343: Use standard data type uint32_t rather than tdb-specific u32.
Jelmer Vernooij [Sun, 12 Aug 2007 02:28:15 +0000 (02:28 +0000)]
r24343: Use standard data type uint32_t rather than tdb-specific u32.

12 years agor24055: Remove a reference to the outdated samba-docs mailing list. This entire
Gerald Carter [Thu, 26 Jul 2007 12:08:13 +0000 (12:08 +0000)]
r24055: Remove a reference to the outdated samba-docs mailing list.  This entire
README really needs to be overhauled at some point.

12 years agor23773: One pstring a day...
Volker Lendecke [Mon, 9 Jul 2007 16:27:13 +0000 (16:27 +0000)]
r23773: One pstring a day...

12 years agor23772: Add ads_find_samaccount() helper function.
Günther Deschner [Mon, 9 Jul 2007 16:03:00 +0000 (16:03 +0000)]
r23772: Add ads_find_samaccount() helper function.


12 years agor23771: Merge useful W_ERROR_NOT_OK_RETURN macro from samba4.
Günther Deschner [Mon, 9 Jul 2007 15:53:08 +0000 (15:53 +0000)]
r23771: Merge useful W_ERROR_NOT_OK_RETURN macro from samba4.


12 years agor23770: Some minor cleanups in libgpo
Günther Deschner [Mon, 9 Jul 2007 15:48:17 +0000 (15:48 +0000)]
r23770: Some minor cleanups in libgpo
(including some valgrind errors, uninitialized vars, etc.)


12 years agor23769: Move removal of the tdb from the generic tdb_validate function
Michael Adam [Mon, 9 Jul 2007 15:34:46 +0000 (15:34 +0000)]
r23769: Move removal of the tdb from the generic tdb_validate function
to the caller (winbindd_validate_cache in this case).
Next, there will be a backup handling for the tdb files.


12 years agor23768: Get rid of the three global variables for the case semantics. I think
Volker Lendecke [Mon, 9 Jul 2007 14:43:36 +0000 (14:43 +0000)]
r23768: Get rid of the three global variables for the case semantics. I think
this is really not worth globals.

Jeremy, please check for 3.0.26.

12 years agor23767: Add GTYPE_SECURITY_UNIVERSAL_GROUP to as well.
Günther Deschner [Mon, 9 Jul 2007 13:31:32 +0000 (13:31 +0000)]


12 years agor23766: Add GTYPE_SECURITY_UNIVERSAL_GROUP define.
Günther Deschner [Mon, 9 Jul 2007 13:28:46 +0000 (13:28 +0000)]


12 years agor23765: Another error-path restore_case_semantics().
Volker Lendecke [Mon, 9 Jul 2007 13:24:31 +0000 (13:24 +0000)]
r23765: Another error-path restore_case_semantics().

12 years agor23764: Do restore_case_semantics in an error path. Jeremy, please check!
Volker Lendecke [Mon, 9 Jul 2007 13:04:44 +0000 (13:04 +0000)]
r23764: Do restore_case_semantics in an error path. Jeremy, please check!

12 years agor23763: Fix a typo in DEBUG message.
Michael Adam [Mon, 9 Jul 2007 12:59:17 +0000 (12:59 +0000)]
r23763: Fix a typo in DEBUG message.
Thanks to Karolin Seeger (

12 years agor23761: Rename reduce_name to check_reduced_name
Volker Lendecke [Mon, 9 Jul 2007 09:43:41 +0000 (09:43 +0000)]
r23761: Rename reduce_name to check_reduced_name

The function name reduce_name is misleading, making the user believe it
changes an argument.

12 years agor23760: Untangle use of strrchr_m and strequal and add some checks
Michael Adam [Mon, 9 Jul 2007 09:35:03 +0000 (09:35 +0000)]
r23760: Untangle use of strrchr_m and strequal and add some checks
for the validity of the given registry key name.


12 years agor23759: Fix make test -- sorry
Volker Lendecke [Mon, 9 Jul 2007 08:45:14 +0000 (08:45 +0000)]
r23759: Fix make test -- sorry

12 years agor23758: Fix Coverity id 385
Volker Lendecke [Mon, 9 Jul 2007 08:04:43 +0000 (08:04 +0000)]
r23758: Fix Coverity id 385

12 years agor23757: Fix Coverity id 386
Volker Lendecke [Mon, 9 Jul 2007 08:00:50 +0000 (08:00 +0000)]
r23757: Fix Coverity id 386

12 years agor23756: Fix Coverity id 388
Volker Lendecke [Mon, 9 Jul 2007 07:55:09 +0000 (07:55 +0000)]
r23756: Fix Coverity id 388

12 years agor23755: Fix Coverity id 384
Volker Lendecke [Mon, 9 Jul 2007 07:51:39 +0000 (07:51 +0000)]
r23755: Fix Coverity id 384

12 years agor23752: Fix bug introduced by checkin 22920, allow large
Jeremy Allison [Mon, 9 Jul 2007 00:48:07 +0000 (00:48 +0000)]
r23752: Fix bug introduced by checkin 22920, allow large
readX. Fix from Dmitry Shatrov <>.

"In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set
to an invalid large value due to integer overflow.
As for me, this resulted in MS Word hanging while trying to save
a 1.5Mb document."

This isn't in shipping code.


12 years agor23751: Call tdb_close even when validation was not successful.
Michael Adam [Sun, 8 Jul 2007 22:01:43 +0000 (22:01 +0000)]
r23751: Call tdb_close even when validation was not successful.


12 years agor23750: Change the behaviour of net conf import when there is a global section
Michael Adam [Sat, 7 Jul 2007 23:57:25 +0000 (23:57 +0000)]
r23750: Change the behaviour of net conf import when there is a global section
in the current registry and there is no global section in the input
file (or only global options with default values):
In that case the existing global section is now not touched. Before, it
would have been deleted and recreated empty. The new behaviour is how
other shares are treated too.

Note that since the input file is parsed by lp_load, there is currently
no way to distinguish between a section with only default parameters
and a non-existing section in net conf import.


PS: A couple of trailing white-spaces have been eliminated
and a line was broken to be not longer than 80 chars, too.

12 years agor23749: Simplify prototype of reg_setvalue_internal:
Michael Adam [Sat, 7 Jul 2007 22:33:45 +0000 (22:33 +0000)]
r23749: Simplify prototype of reg_setvalue_internal:
eliminate "type" parameter since we store only REG_SZ.


12 years agor23748: Clean use of talloc in import_process_service:
Michael Adam [Sat, 7 Jul 2007 22:29:34 +0000 (22:29 +0000)]
r23748: Clean use of talloc in import_process_service:
create a temporary talloc ctx for the function.


12 years agor23747: Move formatting of a parameter's value into a value string
Michael Adam [Sat, 7 Jul 2007 22:18:54 +0000 (22:18 +0000)]
r23747: Move formatting of a parameter's value into a value string
to a function of its own. (for storing it in registry),
Eliminate the valtype variable : store everything as "sz".
Eliminate some trailing white spaces on the way.


12 years agor23746: Fix missing assignments to target string of asprintf in import function.
Michael Adam [Sat, 7 Jul 2007 21:41:59 +0000 (21:41 +0000)]
r23746: Fix missing assignments to target string of asprintf in import function.


12 years agor23745: Fix: Check whether top subkeyname instead of whole registry key name
Michael Adam [Sat, 7 Jul 2007 21:33:48 +0000 (21:33 +0000)]
r23745: Fix: Check whether top subkeyname instead of whole registry key name
is equal to GLOBAL_NAME.


12 years agor23744: Remove TODO-comment. lp_load returns False if opening
Michael Adam [Sat, 7 Jul 2007 20:40:59 +0000 (20:40 +0000)]
r23744: Remove TODO-comment. lp_load returns False if opening
of the config file fails. That's enough of checking for
existence and readbility to my taste.


12 years agor23743: Simplify stat_cache_lookup() logic. For the history of this, see
Volker Lendecke [Sat, 7 Jul 2007 09:57:27 +0000 (09:57 +0000)]
r23743: Simplify stat_cache_lookup() logic. For the history of this, see

12 years agor23738: Re-add commented out code snipped that got lost by accident
Volker Lendecke [Sat, 7 Jul 2007 08:46:26 +0000 (08:46 +0000)]
r23738: Re-add commented out code snipped that got lost by accident

12 years agor23736: Use local variable of smb_flag2 instead of using the macro every time.
Jeremy Allison [Fri, 6 Jul 2007 23:07:40 +0000 (23:07 +0000)]
r23736: Use local variable of smb_flag2 instead of using the macro every time.

12 years agor23735: Second part of the bugfix for #4763
Jeremy Allison [Fri, 6 Jul 2007 21:46:43 +0000 (21:46 +0000)]
r23735: Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.

12 years agor23733: Limit LDAP lookup in lookup_usergroups_member() to security groups.
Lars Müller [Fri, 6 Jul 2007 18:49:49 +0000 (18:49 +0000)]
r23733: Limit LDAP lookup in lookup_usergroups_member() to security groups.

Credits to Ralf Haferkamp for the discussion and help on this.

12 years agor23732: removed reference to non-existent structure
Herb Lewis [Fri, 6 Jul 2007 17:48:19 +0000 (17:48 +0000)]
r23732: removed reference to non-existent structure

12 years agor23731: Forgot one reference to inbuf
Volker Lendecke [Fri, 6 Jul 2007 16:39:58 +0000 (16:39 +0000)]
r23731: Forgot one reference to inbuf

12 years agor23730: Squashed commit of the following:
Gerald Carter [Thu, 5 Jul 2007 19:55:40 +0000 (19:55 +0000)]
r23730: Squashed commit of the following:

commit 3941269fa01038fca242a197e8d7c1f234d45ea7
Author: Gerald (Jerry) Carter <>
Date:   Thu Jul 5 14:52:03 2007 -0500

    Two fixes for "winbind expand groups".

    (a) Update the counter for the number of new groups to resolve else
        we'll only expand one group member per level and drop the rest.
    (b) Don't reset the num_names counter in winbindd_ads.c:lookup_groupmem()
        or we'll drop the SIDs resolved to names via cache from the resulting

12 years agor23728: First part of bugfix for #4763. Limit notify responses
Jeremy Allison [Thu, 5 Jul 2007 18:28:18 +0000 (18:28 +0000)]
r23728: First part of bugfix for #4763. Limit notify responses
to client max buf size.

12 years agor23727: Explicitly pass down FLAGS2 to srvstr_get_path.
Volker Lendecke [Thu, 5 Jul 2007 16:36:15 +0000 (16:36 +0000)]
r23727: Explicitly pass down FLAGS2 to srvstr_get_path.

Next step is to remove the bug that in the trans2 code we use the inbuf
as the base pointer to decide whether we need ucs2 alignment where we
need to use the beginning of the params buffer

Jeremy, last one for today to reviw :-)

12 years agor23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
Volker Lendecke [Thu, 5 Jul 2007 16:33:37 +0000 (16:33 +0000)]
r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.

12 years agor23725: Remove get_current_mid()
Volker Lendecke [Thu, 5 Jul 2007 16:27:47 +0000 (16:27 +0000)]
r23725: Remove get_current_mid()

Jeremy, next one to review :-)

12 years agor23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
Volker Lendecke [Thu, 5 Jul 2007 16:26:27 +0000 (16:26 +0000)]
r23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
that contains some of the fields from the SMB header, removing the need
to access inbuf directly. This right now is used only in the open file
code & friends, and creating that header is only done when needed. This
needs more work, but it is a start.

Jeremy, I'm only checking this into 3_0, please review before I merge it
to _26.


12 years agor23723: Alexander Larsson pointed me at a missing mapping in clierror.c
Simo Sorce [Thu, 5 Jul 2007 13:46:47 +0000 (13:46 +0000)]
r23723: Alexander Larsson pointed me at a missing mapping in clierror.c
When renaming a file across 2 filesystem a samba server returns
NT_STATUS_NOT_SAME_DEVICE but thius is not translated to EXDEV,
and the generic EINVAL is returned instead.
This should fix it, Jeremy or Derrel please check if this is ok.

12 years agor23722: Fix the build of the catia module
Volker Lendecke [Thu, 5 Jul 2007 10:32:51 +0000 (10:32 +0000)]
r23722: Fix the build of the catia module

12 years agor23714: but now:
Michael Adam [Thu, 5 Jul 2007 00:12:24 +0000 (00:12 +0000)]
r23714: but now:

This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test


12 years agor23713: Oops accidentially checked in the wrong file - sorry!
Michael Adam [Thu, 5 Jul 2007 00:11:07 +0000 (00:11 +0000)]
r23713: Oops accidentially checked in the wrong file - sorry!


12 years agor23712: This script allows for adding lists of users (or other objects)
Michael Adam [Thu, 5 Jul 2007 00:07:40 +0000 (00:07 +0000)]
r23712: This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test


12 years agor23711: Refactor the actual creation of object into its own small function.
Michael Adam [Wed, 4 Jul 2007 23:21:51 +0000 (23:21 +0000)]
r23711: Refactor the actual creation of object into its own small function.


12 years agor23710: Remove some code duplication, we do have a random number generator
Volker Lendecke [Wed, 4 Jul 2007 22:30:25 +0000 (22:30 +0000)]
r23710: Remove some code duplication, we do have a random number generator

12 years agor23709: C++ warnings
Volker Lendecke [Wed, 4 Jul 2007 22:28:04 +0000 (22:28 +0000)]
r23709: C++ warnings

12 years agor23708: - Add define for WINBIND_WARN_PWD_EXPIRE.
Lars Müller [Wed, 4 Jul 2007 20:25:29 +0000 (20:25 +0000)]
r23708: - Add define for WINBIND_WARN_PWD_EXPIRE.
- Add parameter config_flag to get_config_item_int() and do the same
  check as in get_conf_item_string.

12 years agor23707: - Move the asprintf() call to create the key even in
Lars Müller [Wed, 4 Jul 2007 19:52:51 +0000 (19:52 +0000)]
r23707: - Move the asprintf() call to create the key even in
  get_conf_item_string() to the later if statement.
- Also move the key definition to the later if statement in
  get_conf_item_string() and get_conf_item_int().

12 years agor23706: Add a script to create domainusers,-groups and -aliases.
Michael Adam [Wed, 4 Jul 2007 16:17:48 +0000 (16:17 +0000)]
r23706: Add a script to create domainusers,-groups and -aliases.
This is done via rpc client. The main purpose is to
be able to fill a domain controller with a large number
of users / groups easily. A the object names are
built as <prefix><num> where number ranges from a given
start number counting up until a given number of objects
has been created.

In a next step, I will submit scripts to add (many) users to
a group and to add a user to (many) groups.


12 years agor23705: Add suggestion for vim from Andreas 'GlaDiaC' Schneider to show tabs,
Lars Müller [Wed, 4 Jul 2007 14:15:26 +0000 (14:15 +0000)]
r23705: Add suggestion for vim from Andreas 'GlaDiaC' Schneider to show tabs,
trailing whitespace, and continued lines visually.

12 years agor23704: Add pam_pwd_expire feature as discussed on samba-technical.
Lars Müller [Wed, 4 Jul 2007 14:03:10 +0000 (14:03 +0000)]
r23704: Add pam_pwd_expire feature as discussed on samba-technical.

This is a slightly modified version to set warn_pwd_expire to the
default value if 0, no, or a broken value is set.

This version also has one if statement less in get_config_item_int().

Thanks a lot to Andreas 'GlaDiaC' Schneider for this feature!

12 years agor23694: Make sure that when builddir != srcdir, we can still find the exports
Gerald Carter [Wed, 4 Jul 2007 00:41:58 +0000 (00:41 +0000)]
r23694: Make sure that when builddir != srcdir, we can still find the exports
files and library-versions file.

Also move the "-o $@" from the individual targets and into the SHLD_DSO

12 years agor23692: Couldn't wait, sorry :-). Did the style change.
Jeremy Allison [Tue, 3 Jul 2007 23:48:02 +0000 (23:48 +0000)]
r23692: Couldn't wait, sorry :-). Did the style change.

12 years agor23691: fix for bug on touching files as described here:
Simo Sorce [Tue, 3 Jul 2007 23:34:01 +0000 (23:34 +0000)]
r23691: fix for bug on touching files as described here:

12 years agor23689: Squashed commit of the following:
Gerald Carter [Tue, 3 Jul 2007 19:55:02 +0000 (19:55 +0000)]
r23689: Squashed commit of the following:

commit 0d4bbd197198a94bf4e29e0ccd175a40a60097f3
Author: Gerald (Jerry) Carter <>
Date:   Mon Jul 2 20:08:19 2007 -0500

    Introduce GNU ld linker export-script for hiding non-public symbols
    in shared libraries.

    Based on initial patch from Julien Cristau <>
    and suggestions from James Peach <>.  Currently
    the libsmbsharemodes libraries still exports *.  Signed off on
    my Derrell as well.

12 years agor23688: Fix bug #4759 reported by Raul <>.
Jeremy Allison [Tue, 3 Jul 2007 18:00:54 +0000 (18:00 +0000)]
r23688: Fix bug #4759 reported by Raul <>.
"N" is not a valid format entry for ber_printf, should be "n"

12 years agor23685: merge from SAMBA_4_0:
Stefan Metzmacher [Tue, 3 Jul 2007 14:46:06 +0000 (14:46 +0000)]
r23685: merge from SAMBA_4_0:

Only use the bzr and git information when there's
a .bzr or .git in the top branch directory

I use bzr for my home directory and
bzr version-info in ~/devel/samba/4.0/samba4-git
gives the info about the ~/.bzr branch


12 years agor23683: Check ports are in the correct range (1-65535)
Simo Sorce [Tue, 3 Jul 2007 13:11:56 +0000 (13:11 +0000)]
r23683: Check ports are in the correct range (1-65535)

12 years agor23682: Old patch I forgot in one of my 3.0.25 trees.
Simo Sorce [Tue, 3 Jul 2007 13:07:56 +0000 (13:07 +0000)]
r23682: Old patch I forgot in one of my 3.0.25 trees.
Make sure we honour the directive not to allow machine password changes.

12 years agor23673: Check for integer wrap on incoming data.
Jeremy Allison [Mon, 2 Jul 2007 20:51:09 +0000 (20:51 +0000)]
r23673: Check for integer wrap on incoming data.

12 years agor23672: Allow msrpc_name_to_sid() to be called without a domain_name and just a name.
Günther Deschner [Mon, 2 Jul 2007 09:46:18 +0000 (09:46 +0000)]
r23672: Allow msrpc_name_to_sid() to be called without a domain_name and just a name.


12 years agor23671: Remove unused code -- 16416 bytes of bss space...
Volker Lendecke [Sun, 1 Jul 2007 19:40:04 +0000 (19:40 +0000)]
r23671: Remove unused code -- 16416 bytes of bss space...

12 years agor23670: Fix for the git case: Only use the first line where
Volker Lendecke [Sun, 1 Jul 2007 19:11:40 +0000 (19:11 +0000)]
r23670: Fix for the git case: Only use the first line where
"commit" occurs

12 years agor23669: Move a variable into the only block where it is used.
Michael Adam [Sun, 1 Jul 2007 00:09:20 +0000 (00:09 +0000)]
r23669: Move a variable into the only block where it is used.

12 years agor23668: When creating a new string value, win2k regedit delivers
Michael Adam [Sat, 30 Jun 2007 23:52:23 +0000 (23:52 +0000)]
r23668: When creating a new string value, win2k regedit delivers
one byte of data despite characters being two-byte.

This modifies registry_pull_value, to change the data
to the correct two-byte version of the empty string,
(as delivered by winxp), when only one byte of data is


12 years agor23667: Prevent storing of forbidden parameter names in registry
Michael Adam [Sat, 30 Jun 2007 22:31:13 +0000 (22:31 +0000)]
r23667: Prevent storing of forbidden parameter names in registry
configuration as values. I would really like to check whether
the valuename is a valid parameter name (with lp_parameter_is_valid)
here, but unfortunately, regedit cereates new values as
"New Value #1" (and so on) first, before dropping into the
rename box. So this is impossible here.


12 years agor23666: Rename lp_parameter_valid -> lp_parameter_is_valid.
Michael Adam [Sat, 30 Jun 2007 21:35:39 +0000 (21:35 +0000)]
r23666: Rename lp_parameter_valid -> lp_parameter_is_valid.


12 years agor23665: Remove two unneeded global variables
Volker Lendecke [Sat, 30 Jun 2007 09:15:33 +0000 (09:15 +0000)]
r23665: Remove two unneeded global variables

12 years agor23664: Fix incorrect index - should be j not i. How did we ever
Jeremy Allison [Sat, 30 Jun 2007 00:22:59 +0000 (00:22 +0000)]
r23664: Fix incorrect index - should be j not i. How did we ever
live without valgrind :-).

12 years agor23663: Fix bug #4308 - Excel save operation corrupts file ACLs.
Jeremy Allison [Fri, 29 Jun 2007 17:57:05 +0000 (17:57 +0000)]
r23663: Fix bug #4308 - Excel save operation corrupts file ACLs.
You don't want to know what I discovered about Windows
ACLs to make this work :-(. See :

Search for "Q. How does Inheritance come into this?"
for details.

12 years agor23662: According to simo, check_dos_char is needed
Volker Lendecke [Fri, 29 Jun 2007 17:51:31 +0000 (17:51 +0000)]
r23662: According to simo, check_dos_char is needed

12 years agor23661: Another static pstring
Volker Lendecke [Fri, 29 Jun 2007 17:40:37 +0000 (17:40 +0000)]
r23661: Another static pstring

12 years agor23660: Anybody know what check_dos_char() was used for? It wasn't called at
Volker Lendecke [Fri, 29 Jun 2007 17:27:59 +0000 (17:27 +0000)]
r23660: Anybody know what check_dos_char() was used for? It wasn't called at
all, so it's gone. With it 8k bss went away.

12 years agor23659: file_pload is not used outside of util_file.c
Volker Lendecke [Fri, 29 Jun 2007 17:09:39 +0000 (17:09 +0000)]
r23659: file_pload is not used outside of util_file.c

12 years agor23658: One pstring a day....
Volker Lendecke [Fri, 29 Jun 2007 16:04:26 +0000 (16:04 +0000)]
r23658: One pstring a day....

This one was particularly tasty, it was a static one. So 1k less
footprint per process.

12 years agor23657: Prevent setting of a global option in a share definition
Michael Adam [Fri, 29 Jun 2007 13:07:54 +0000 (13:07 +0000)]
r23657: Prevent setting of a global option in a share definition
in "net conf setparm".


12 years agor23656: Add initial checking of the validity of a paramter
Michael Adam [Fri, 29 Jun 2007 12:30:41 +0000 (12:30 +0000)]
r23656: Add initial checking of the validity of a paramter
given to "net conf setparm". Add a utility function
lp_parameter_valid() for this to loadparm.c.