Jelmer Vernooij [Thu, 10 Jun 2004 18:45:45 +0000 (18:45 +0000)]
r1111: Rename vsnprintf to smb_vsnprintf so we don't get duplicate symbol errors
when linking against an app that does have vsnprintf() (bug #478)
Volker Lendecke [Thu, 10 Jun 2004 17:42:16 +0000 (17:42 +0000)]
r1108: Index: pdb_ldap.c
===================================================================
--- pdb_ldap.c (revision 1095)
+++ pdb_ldap.c (working copy)
@@ -1134,6 +1134,19 @@
return NT_STATUS_OK;
}
+static void append_attr(char ***attr_list, const char *new_attr)
+{
+ int i;
+
+ for (i=0; (*attr_list)[i] != NULL; i++)
+ ;
+
+ (*attr_list) = Realloc((*attr_list), sizeof(**attr_list) * (i+2));
+ SMB_ASSERT((*attr_list) != NULL);
+ (*attr_list)[i] = strdup(new_attr);
+ (*attr_list)[i+1] = NULL;
+}
+
/**********************************************************************
Get SAM_ACCOUNT entry from LDAP by username.
*********************************************************************/
@@ -1149,6 +1162,7 @@
int rc;
attr_list = get_userattr_list( ldap_state->schema_ver );
+ append_attr(&attr_list, MODIFY_TIMESTAMP_STRING);
rc = ldapsam_search_suffix_by_name(ldap_state, sname, &result, attr_list);
free_attr_list( attr_list );
@@ -1194,6 +1208,7 @@
switch ( ldap_state->schema_ver ) {
case SCHEMAVER_SAMBASAMACCOUNT:
attr_list = get_userattr_list(ldap_state->schema_ver);
+ append_attr(&attr_list, MODIFY_TIMESTAMP_STRING);
rc = ldapsam_search_suffix_by_sid(ldap_state, sid, result, attr_list);
free_attr_list( attr_list );
Index: login_cache.c
===================================================================
--- login_cache.c (revision 1095)
+++ login_cache.c (working copy)
@@ -95,10 +95,13 @@
&entry->bad_password_count,
&entry->bad_password_time) == -1) {
DEBUG(7, ("No cache entry found\n"));
+ SAFE_FREE(entry);
SAFE_FREE(databuf.dptr);
return NULL;
}
+ SAFE_FREE(databuf.dptr);
+
DEBUG(5, ("Found login cache entry: timestamp %12u, flags 0x%x, count %d, time %12u\n",
(unsigned int)entry->entry_timestamp, entry->acct_ctrl,
entry->bad_password_count, (unsigned int)entry->bad_password_time));
Volker Lendecke [Thu, 10 Jun 2004 17:13:30 +0000 (17:13 +0000)]
r1106: Lars Mueller <lmuelle@suse.de> asked me to apply this patch, as this is needed
for their build environment. The AFS stuff is linux 2.4 only currently, it
works for me on this platform, so apply it.
Volker
Volker Lendecke [Thu, 10 Jun 2004 17:09:00 +0000 (17:09 +0000)]
r1104: get_called_name is used in the printing subsystem. In case of multi-homed
servers we need to make sure that the clients are given back the IP address
they connected to.
Volker
Herb Lewis [Thu, 10 Jun 2004 14:23:34 +0000 (14:23 +0000)]
r1103: need to leave empty dacl so we can remove last ACE
Volker Lendecke [Thu, 10 Jun 2004 13:07:44 +0000 (13:07 +0000)]
r1101: Implement 'rpcclient setprintername'.
Thanks to Guenther Deschner <gd@sernet.de>.
This needs to be generalized somewhat. Jerry, which of the parameters in the
printer_info_2 struct are settable via cli_spoolss_setprinter?
Volker
Jeremy Allison [Wed, 9 Jun 2004 21:03:50 +0000 (21:03 +0000)]
r1097: Fix errno being incorrectly set. Noticed by Richard.
Jeremy.
Jeremy Allison [Wed, 9 Jun 2004 00:43:43 +0000 (00:43 +0000)]
r1093: Ensure we clear any cached errors on a deferred open call so
we don't return the wrong error code on the next packet.
Jeremy.
Jeremy Allison [Tue, 8 Jun 2004 22:13:59 +0000 (22:13 +0000)]
r1089: Removed spurious oplock message in deferred open processing.
Fix smb signing sequence counts.
Jeremy.
Gerald Carter [Tue, 8 Jun 2004 20:10:26 +0000 (20:10 +0000)]
r1087: BUG 1221: revert old change that used single and double quotes as delimters in next_token(), and change print_parameter() to print out parm values surrounded by double quotes (instead of single quotes)
Jeremy Allison [Tue, 8 Jun 2004 16:14:31 +0000 (16:14 +0000)]
r1085: Now it's had some proper user testing, merge in the deferred open fix. I'm
still doing more testing, but it fixes a behaviour that we've been wrong
on ever since the start of Samba.
Jeremy.
Gerald Carter [Fri, 4 Jun 2004 17:26:09 +0000 (17:26 +0000)]
r1011: fix bad merge (from a few months ago) and ensure that we always use tdb_open_log() instead of tdb_open_ex()
Stefan Metzmacher [Fri, 4 Jun 2004 11:29:50 +0000 (11:29 +0000)]
r1007: merge from SAMBA_4_0:
print out the SVN revision by configure,
so that the build farm can use it
metze
Jeremy Allison [Fri, 4 Jun 2004 00:20:58 +0000 (00:20 +0000)]
r998: Arrrgggh. Do it right this time :-(.
Jeremy.
Jeremy Allison [Fri, 4 Jun 2004 00:09:57 +0000 (00:09 +0000)]
r996: Fix error in change to queuing code (dlink).
Jeremy.
Gerald Carter [Thu, 3 Jun 2004 20:32:13 +0000 (20:32 +0000)]
r993: BUG 703 -- finishing patch by Eric Boehm <boehm@nortelnetworks.com> for netgroup case lookups
Gerald Carter [Thu, 3 Jun 2004 18:00:22 +0000 (18:00 +0000)]
r991: Allow winbindd to use the domain trust account password
for setting up an schannel connection. This solves the problem
of a Samba DC running winbind, trusting a native mode AD domain,
and needing to enumerate AD users via wbinfo -u.
Volker Lendecke [Thu, 3 Jun 2004 09:25:01 +0000 (09:25 +0000)]
r989: Calling sid_to_gid from within winbind makes no sense, as this calls
winbind_sid_to_gid. For the consistency check, local_sid_to_gid must set the
name_type it found.
Volker
Volker Lendecke [Thu, 3 Jun 2004 08:31:57 +0000 (08:31 +0000)]
r988: When adding local aliases' gids to the user token, don't do a idmap_sid_to_gid
on the user sid. This might lead to a user SID entered as a GID in the idmap.
Volker
Jeremy Allison [Wed, 2 Jun 2004 23:19:36 +0000 (23:19 +0000)]
r984: Ensure memmove & memcpy aren't called with len == 0.
Jeremy.
Volker Lendecke [Wed, 2 Jun 2004 14:58:18 +0000 (14:58 +0000)]
r979: Implement the 'cups server' option. This makes it possible to have virtual
smbd's connect to different cups daemons.
Volker
Volker Lendecke [Wed, 2 Jun 2004 14:25:29 +0000 (14:25 +0000)]
r977: Implement 'net rpc group rename' -- rename domain groups.
Volker
Jeremy Allison [Wed, 2 Jun 2004 02:12:54 +0000 (02:12 +0000)]
r974: Fix open code to pass more torture tests. We now pass the Samba4
oplock test. We do this be changing the algorithm when breaking
oplocks slightly. Previously we broke an oplock, then re-loaded
the share modes and re-iterated. Now we break all oplocks, then
re-load the share modes and check the share details - then iterate.
This seems to match the way Win2k3 does it.
Jeremy.
Jeremy Allison [Tue, 1 Jun 2004 20:43:32 +0000 (20:43 +0000)]
r971: Auto remove store dos attributes if underlying filesystem
doesn't support EA's.
Jeremy.
Gerald Carter [Tue, 1 Jun 2004 15:06:08 +0000 (15:06 +0000)]
r966: fixing package dependencies
Volker Lendecke [Tue, 1 Jun 2004 14:45:49 +0000 (14:45 +0000)]
r964: The max_size field in cli_samr_enum_als_groups is more like an account_control
field with indiviual bits what to retrieve. Set this to 0xffff as NT4
usrmgr.exe does to get everything. I'm too lazy (sorry) to get this through to
rpc_parse/ etc.
Volker
Jeremy Allison [Tue, 1 Jun 2004 04:55:42 +0000 (04:55 +0000)]
r957: Fixup moribund unix extensions mknod code path. Don't add in
configure test yet. Also allow unix domain socket create.
Jeremy.
Jelmer Vernooij [Sun, 30 May 2004 11:59:12 +0000 (11:59 +0000)]
r947: Patch from Fabian Franz <FabianFranz@gmx.de> that allows you
to specify a port in the device URL.
Jeremy Allison [Sun, 30 May 2004 07:21:50 +0000 (07:21 +0000)]
r945: "Correct" (as in, more correct) way to handle stat opens. Doesn't regress
the torture tester. Passes OPEN tests in Samba3 and Samba4 and oplock tests
in Samba4. Last thing to check, can an "attribute only" open actually create
a file. I think it can....
Jeremy.
Volker Lendecke [Fri, 28 May 2004 19:15:11 +0000 (19:15 +0000)]
r942: If using DOS error codes, we need to return ERRDOS/ERRbadpath for chkpth even
if only the last component failed. I'm not sure if all the other cases of
NT_STATUS_OBJECT_NAME_NOT_FOUND also need to be fixed, this at least helps
with 'copy test1.txt test2.txt' from DOS within a subdirectory.
Yes, I do have someone who needs this :-)
Jeremy, could you take a look at this?
Thanks,
Volker
Herb Lewis [Fri, 28 May 2004 17:57:18 +0000 (17:57 +0000)]
r938: on an error save the original errno before calling iconv to reset
the conversion state
Andrew Bartlett [Fri, 28 May 2004 08:57:00 +0000 (08:57 +0000)]
r936: Fix a rather weird error that crippled my site, when we upgraded to
Samba 3.0.4.
If we fail a query for the members of the 'administrators' group (and we may well just have the IDL wrong), this destroys later parts of the domain logon process.
For reasons I can't understand, the client-side 'heck, what happened'
bailout causes the connection to the DC to be dropped, and causes the
mandetory profile not to be loaded. (This also only occours after a reboot)
Return the members of 'administrators', and it all works fine.
The reason we hit this is because we run winbindd (to support
pam_winbind) on our DC, and the winbindd lookup in sid_to_gid was
messing things up. As we don't care what type of thing this is,
provided it exists in the group mapping db, we should not bother
winbindd here.
Andrew Bartlett
Jeremy Allison [Fri, 28 May 2004 01:54:01 +0000 (01:54 +0000)]
r933: When using widelinks = no, use realpath to canonicalize the
connection path on connection create for the user. We'll be
checking all symlinked paths are below this directory.
Jeremy.
Jeremy Allison [Fri, 28 May 2004 00:41:08 +0000 (00:41 +0000)]
r931: Ensure we push 16 bytes (including null termination)
not 15.
Jeremy Allison [Thu, 27 May 2004 22:57:50 +0000 (22:57 +0000)]
r928: Ensure we're calling send_mailslot() with a UNIX charset
target name.
Jeremy.
Gerald Carter [Thu, 27 May 2004 15:38:54 +0000 (15:38 +0000)]
r925: add changes frpm trunk (r841 and r842) -- enable background queue update process and allow printers to have different sharenames from printernames
John Terpstra [Thu, 27 May 2004 12:50:55 +0000 (12:50 +0000)]
r923: Fixes so tdbtool and tdbtest can be built. Added build specs for tdbdump and tdbbackup.
John Terpstra [Thu, 27 May 2004 09:06:09 +0000 (09:06 +0000)]
r922: Adding notes regarding location of documentation.
John Terpstra [Thu, 27 May 2004 08:25:20 +0000 (08:25 +0000)]
r921: Change notice from CVS to SVN.
Jeremy Allison [Thu, 27 May 2004 00:04:43 +0000 (00:04 +0000)]
r916: Memory leak fix from kawasa_r@itg.hitachi.co.jp.
Jeremy.
Jeremy Allison [Wed, 26 May 2004 18:52:45 +0000 (18:52 +0000)]
r914: Fix from "Jerome Borsboom" <j.borsboom@erasmusmc.nl> to ensure
correct sid type returned for builtin sids.
Jeremy.
Jeremy Allison [Wed, 26 May 2004 18:27:16 +0000 (18:27 +0000)]
r911: Patch from "Jerome Borsboom" <j.borsboom@erasmusmc.nl>, don't
overwrite error code.
Jeremy.
Jeremy Allison [Wed, 26 May 2004 17:45:12 +0000 (17:45 +0000)]
r910: Fix for bug #1385 found by Jason Mader <jason@ncac.gwu.edu>.
Don't use non-consts in a structure initialization.
Jeremy.
Gerald Carter [Wed, 26 May 2004 14:19:28 +0000 (14:19 +0000)]
r907: fixing browse.dat bug -- don't include the resouce byte from the netbios name when pulling a string from a packet (jra, please double check this
Gerald Carter [Tue, 25 May 2004 16:27:48 +0000 (16:27 +0000)]
r885: more packaging fixes
Gerald Carter [Tue, 25 May 2004 15:07:28 +0000 (15:07 +0000)]
r881: BUG 1357: add pam-devel to build requirements
Gerald Carter [Tue, 25 May 2004 14:12:25 +0000 (14:12 +0000)]
r878: fixing bug in packaging that crep back in
Gerald Carter [Mon, 24 May 2004 15:26:19 +0000 (15:26 +0000)]
r844: bumping version
Stefan Metzmacher [Mon, 24 May 2004 11:05:19 +0000 (11:05 +0000)]
r840: use quota debug class
metze
Stefan Metzmacher [Sat, 22 May 2004 14:52:34 +0000 (14:52 +0000)]
r824: merge from: SAMBA_4_0:
use 'Last Change Rev:' instead of 'Revision:' from the svn info output
for setting the SVN_REVISION in version.h
metze
Stefan Metzmacher [Sat, 22 May 2004 09:57:23 +0000 (09:57 +0000)]
r817: - fix a configure logic bug for linux/XFS quotas
when using --with-sys-quotas
metze
Herb Lewis [Sat, 22 May 2004 05:01:25 +0000 (05:01 +0000)]
r814: conn is 0 during ioctl (at least during smbtorture IOCTL test)
fix smbd panic
Jeremy Allison [Fri, 21 May 2004 18:06:27 +0000 (18:06 +0000)]
r810: Fix from "Jerome Borsboom" <j.borsboom@erasmusmc.nl> to ensure error status
codes don't get overwritten.
Jeremy.
Jeremy Allison [Fri, 21 May 2004 00:13:16 +0000 (00:13 +0000)]
r805: Fix to stop smbd hanging on missing group member from "Jianliang Lu" <j.lu@tiesse.com>.
Jeremy.
Jeremy Allison [Thu, 20 May 2004 18:28:21 +0000 (18:28 +0000)]
r801: Fix from "Jianliang Lu" <j.lu@tiesse.com> to return correct group
types.
Jeremy.
Gerald Carter [Thu, 20 May 2004 16:23:17 +0000 (16:23 +0000)]
r799: BUG 1259 -- add 'printcap cache time' patch from Lars
Gerald Carter [Thu, 20 May 2004 13:40:16 +0000 (13:40 +0000)]
r795: paranoia checks
Jeremy Allison [Thu, 20 May 2004 01:38:26 +0000 (01:38 +0000)]
r788: Inspired by patch from "Jianliang Lu" <j.lu@tiesse.com>. Correct
sid type is WKN_GROUP, not alias. Added some more known types.
Jeremy.
Jeremy Allison [Wed, 19 May 2004 21:49:58 +0000 (21:49 +0000)]
r786: Memory leak fixes in (mostly) error code paths from
kawasa_r@itg.hitachi.co.jp. A couple of mem leak fixes in
mainline code paths though :-).
Jeremy.
Gerald Carter [Wed, 19 May 2004 17:17:33 +0000 (17:17 +0000)]
r783: fix bug in reading printer data from disk; all ow valuenames with embedded '\'s
Andrew Bartlett [Wed, 19 May 2004 11:50:01 +0000 (11:50 +0000)]
r780: Fix segfault in ntlm_auth --diagnostics
Andrew Bartlett
Jeremy Allison [Wed, 19 May 2004 02:25:48 +0000 (02:25 +0000)]
r779: Fix specific case of open that doesn't cause oplock break, or share mode check.
Test case provided by Volker will be added later. There may be other tests
needed.
Jeremy.
Herb Lewis [Tue, 18 May 2004 20:48:14 +0000 (20:48 +0000)]
r776: I should have just cut and pasted from my build area and I would
have gotten this right :-)
Herb Lewis [Tue, 18 May 2004 18:13:19 +0000 (18:13 +0000)]
r775: merge trunk 774 to samba 3_0 - fix bad compare in for loop
Herb Lewis [Tue, 18 May 2004 17:24:59 +0000 (17:24 +0000)]
r772: fix cut and paste error in comment
Jeremy Allison [Tue, 18 May 2004 01:05:59 +0000 (01:05 +0000)]
r764: More memleak fixes in error code path from kawasa_r@itg.hitachi.co.jp.
Jeremy.
Jeremy Allison [Tue, 18 May 2004 00:26:06 +0000 (00:26 +0000)]
r762: Fix for #1319 when security > share.
Jeremy.
Jeremy Allison [Fri, 14 May 2004 22:08:19 +0000 (22:08 +0000)]
r742: Volker discovered that we can truncate a locked file. Well I never ! :-).
Jeremy
Richard Sharpe [Fri, 14 May 2004 20:58:26 +0000 (20:58 +0000)]
r740: Fix Bug #1301. Return NT_STATUS_SHARING_VIOLATION when share mode locking
requests fail.
Steve French [Fri, 14 May 2004 18:05:06 +0000 (18:05 +0000)]
r737: Handle -S and user mount parms
Simo Sorce [Fri, 14 May 2004 12:44:59 +0000 (12:44 +0000)]
r731: add the current debian directory for debian stable (woody) targeted releases
Simo Sorce [Fri, 14 May 2004 12:42:42 +0000 (12:42 +0000)]
r730: move the current debian dir to debian-unstable
Jeremy Allison [Fri, 14 May 2004 01:22:17 +0000 (01:22 +0000)]
r716: Fix for bugid #1345 (Macromedia Homesite cannot connect anymore after upgrade to 3.0.4).
Cause was premature optimization in unix_convert(). My fault, sorry.
Jeremy.
Jeremy Allison [Thu, 13 May 2004 23:34:00 +0000 (23:34 +0000)]
r710: Fix smbclient symlink command when widelinks = no.
Jeremy.
Jeremy Allison [Thu, 13 May 2004 21:23:40 +0000 (21:23 +0000)]
r706: Fix erroneous commit... I've not finished testing the
symlink stuff yet. Noticed by Stefan (metze).
Jeremy.
Gerald Carter [Thu, 13 May 2004 20:32:21 +0000 (20:32 +0000)]
r704: BUG 1315: fix for schannel client connections to server's that don't support 128 bit encryption
Jeremy Allison [Thu, 13 May 2004 18:37:54 +0000 (18:37 +0000)]
r698: Now wb pipe is non-blocking remember to read in non-blocking mode...
Jeremy.
Gerald Carter [Thu, 13 May 2004 16:11:24 +0000 (16:11 +0000)]
r689: removed unneeded forward declarations
Stefan Metzmacher [Thu, 13 May 2004 12:00:15 +0000 (12:00 +0000)]
r675: merge from SAMBA_4_0:
display the version on top of configure
this will help in the build farm
metze
Jeremy Allison [Thu, 13 May 2004 00:56:00 +0000 (00:56 +0000)]
r658: Oops - make smbclient work again with widelinks = no :-).
Jeremy.
Jeremy Allison [Thu, 13 May 2004 00:20:50 +0000 (00:20 +0000)]
r656: Make widelinks use realpath(). Tidy up cases where we need to become a service.
Jeremy.
Richard Sharpe [Wed, 12 May 2004 07:06:05 +0000 (07:06 +0000)]
r654: There is no point in having two lines of:
sbuf.st_mtime &= ~1;
So I had one refer to st_ctime.
Jeremy Allison [Wed, 12 May 2004 00:35:43 +0000 (00:35 +0000)]
r653: Ok, so tridge convinced me. Allow full UNIX path symlinks
to anywhere on the server filesystem so long as widelinks
is set to true.... :-).
Jeremy.
Jeremy Allison [Tue, 11 May 2004 22:09:09 +0000 (22:09 +0000)]
r651: Patch from kawasa_r@itg.hitachi.co.jp to connect to winbind
pipe in non-blocking mode to prevent process hang.
Jeremy.
Gerald Carter [Tue, 11 May 2004 14:54:54 +0000 (14:54 +0000)]
r647: fix for setting the called name to by our IP if the called name was *SMBSERVER and *SMBSERV -- fixes issue with connecting to printers via \ip.ad.dr.ess\printer UNC path
Jeremy Allison [Tue, 11 May 2004 01:05:59 +0000 (01:05 +0000)]
r645: Patch from kawasa_r@itg.hitachi.co.jp to correctly enable core dumps.
Jeremy.
Herb Lewis [Mon, 10 May 2004 23:59:23 +0000 (23:59 +0000)]
r643: fix typo
Herb Lewis [Mon, 10 May 2004 23:57:40 +0000 (23:57 +0000)]
r642: use RPC_CLIENT_OBJ instead of file name
already included in PROTO_OBJ by LIBMSRPC_OBJ
Jeremy Allison [Mon, 10 May 2004 23:04:31 +0000 (23:04 +0000)]
r640: Make cifsvfs symlinks work with paths within and external to the
share. Store external paths prefixed with smbln:.
Jeremy.
Herb Lewis [Mon, 10 May 2004 19:57:54 +0000 (19:57 +0000)]
r635: put files that are referenced multiple times in separate
definitions to be consistent.
Gerald Carter [Mon, 10 May 2004 13:54:12 +0000 (13:54 +0000)]
r632: pulling in release notes from 3.0.4 and getting ready to start 3.0.5pre1
Richard Sharpe [Sun, 9 May 2004 22:39:39 +0000 (22:39 +0000)]
r618: Bug #1333. Fix a problem pointed out by coolo where I was trying to ensure
that the errno is not trashed by a DEBUG statement, but screwed up.
Richard Sharpe [Sun, 9 May 2004 17:29:09 +0000 (17:29 +0000)]
r616: Bug #1333.
Make sure we return an error code when things go wrong.
Richard Sharpe [Sun, 9 May 2004 04:20:40 +0000 (04:20 +0000)]
r599: Bug #1178. Make the libsmbclient routines callable by C++ programs. Also
clean up the format of the file a bit.
Richard Sharpe [Sat, 8 May 2004 20:15:52 +0000 (20:15 +0000)]
r588: Some fixes from coolo ...
I think that the ECONNREFUSED should probably be ENOENT.
Gerald Carter [Fri, 7 May 2004 22:02:05 +0000 (22:02 +0000)]
r573: fixing packaging
Jeremy Allison [Fri, 7 May 2004 18:37:47 +0000 (18:37 +0000)]
r570: Remove lots of globals to handle case issues - move them
to connection struct entries (as they should have been from
the start). Jerry, once you've cut over to 3.0.4 release
branch I'll add this to 3.0 also.
- Jerry cut over :-).
Jeremy.
Gerald Carter [Fri, 7 May 2004 18:32:47 +0000 (18:32 +0000)]
r568: setting version to 3.0.5pre1
Jeremy Allison [Fri, 7 May 2004 18:14:38 +0000 (18:14 +0000)]
r565: Uninitialized data fixes from kawasa_r@itg.hitachi.co.jp.
Jeremy.
Jeremy Allison [Fri, 7 May 2004 17:58:06 +0000 (17:58 +0000)]
r562: Memory leak fix in error code path from kawasa_r@itg.hitachi.co.jp.
Jeremy.