Gerald Carter [Tue, 10 Sep 2002 21:41:25 +0000 (21:41 +0000)]
removed warning about shadowed globals
Gerald Carter [Tue, 10 Sep 2002 21:37:53 +0000 (21:37 +0000)]
AbortPrinter() fix merged from APP_HEAD.
Jeremy Allison [Tue, 10 Sep 2002 17:24:17 +0000 (17:24 +0000)]
Patch from Andy Levine andyl@epicrealm.com who discovered that W2K DMB's
return empty NetServerEnum2 on port 445, but not on port 139.
Jeremy.
Martin Pool [Tue, 10 Sep 2002 08:36:55 +0000 (08:36 +0000)]
Check in examples for tdb packer
Tim Potter [Tue, 10 Sep 2002 06:41:27 +0000 (06:41 +0000)]
Updated examples for new top level module layout.
Fixed some bugs also.
Gerald Carter [Tue, 10 Sep 2002 02:38:15 +0000 (02:38 +0000)]
change notify merge from APP_HEAD
Jeremy Allison [Tue, 10 Sep 2002 01:58:51 +0000 (01:58 +0000)]
Added final Steve French patch for "required" attributes with old
dir listings. Added regression test in smbtorture (in HEAD) also.
Jeremy.
Jeremy Allison [Mon, 9 Sep 2002 21:48:23 +0000 (21:48 +0000)]
Merged Steve French's fix for OS/2 EA return error being removed.
Jeremy.
Jelmer Vernooij [Mon, 9 Sep 2002 21:38:42 +0000 (21:38 +0000)]
Use SAM debug class in skeleton - patch from metze
Shouldn't we use dynamic debug classes here?
Jeremy Allison [Mon, 9 Sep 2002 21:06:06 +0000 (21:06 +0000)]
Patch from Steve French to fix difference in responses to
smbclient //server/share
ls /
on Samba and Windows 2000.
Jeremy.
Herb Lewis [Mon, 9 Sep 2002 21:01:53 +0000 (21:01 +0000)]
lowercase global_myname in %L substitution
Jeremy Allison [Mon, 9 Sep 2002 19:02:53 +0000 (19:02 +0000)]
Merged Volkers (correct) fix from 2.2 for crash on unable to connect.
Jeremy.
Martin Pool [Mon, 9 Sep 2002 08:51:55 +0000 (08:51 +0000)]
Add python_install target. Not called by default. Delegates most
of the work to setup.py
Martin Pool [Mon, 9 Sep 2002 08:34:35 +0000 (08:34 +0000)]
Put all Python modules into the 'samba' subpackage. Now you need to
write
import samba.tdbutil
samba.tdbutil.pack('f', ['hello'])
You need 'cvs update -d' to get the new subdirectory for this to build
properly.
Martin Pool [Mon, 9 Sep 2002 08:06:17 +0000 (08:06 +0000)]
Build py_tdbpack as well.
Martin Pool [Mon, 9 Sep 2002 07:49:25 +0000 (07:49 +0000)]
Python's setup.py does not need to be munged by configure.in -- it is
sufficient to just pass the relevant variables to Python from the
Makefile. Therefore, remove setup.py.in.
Jeremy Allison [Mon, 9 Sep 2002 06:44:29 +0000 (06:44 +0000)]
Actually, I think Jerrys patch was incorrect as it didn't ever
add the printing msg flag, only remove it. Also, we already
refcount the printer backchannel connection to add the connection
tdb flag just before after we register/deregister the notification
message handler.
Jerry please check !
Jeremy.
Martin Pool [Mon, 9 Sep 2002 06:30:48 +0000 (06:30 +0000)]
Import my code to do reasonably fast tdbpack/unpack from Python
Martin Pool [Mon, 9 Sep 2002 06:26:41 +0000 (06:26 +0000)]
Update documentation for newly merged modules
Martin Pool [Mon, 9 Sep 2002 06:23:43 +0000 (06:23 +0000)]
This patch has now been applied and no longer needs to exist separately
Martin Pool [Mon, 9 Sep 2002 06:05:39 +0000 (06:05 +0000)]
Add --with-python=PYTHONNAME configure option, so that the libraries
get linked for the appropriate version.
Martin Pool [Mon, 9 Sep 2002 05:54:11 +0000 (05:54 +0000)]
Merge tpot's Python patch. ./configure now writes to the Python
makefile-equivalent (setup.py). Remember to do "cvs update -d" to get
the new directory.
Martin Pool [Mon, 9 Sep 2002 05:46:59 +0000 (05:46 +0000)]
Merge tpot's patch to add targets to build Python stuff. It's not
built by default.
Martin Pool [Mon, 9 Sep 2002 05:22:13 +0000 (05:22 +0000)]
Add little meta note
Tim Potter [Mon, 9 Sep 2002 04:43:38 +0000 (04:43 +0000)]
Fix crash bugs in getprinter info level code (yay unit tests).
Let the cli_spoolss function return invalid info level error rather
than checking for it ourselves.
Tim Potter [Mon, 9 Sep 2002 04:42:01 +0000 (04:42 +0000)]
Pass level keyword down to cli_spoolss_getform()
Tim Potter [Mon, 9 Sep 2002 04:38:12 +0000 (04:38 +0000)]
Formatting tidyup.
Tim Potter [Mon, 9 Sep 2002 03:22:39 +0000 (03:22 +0000)]
Return WERR_UNKNOWN_LEVEL for unknown info levels.
Tim Potter [Mon, 9 Sep 2002 01:13:27 +0000 (01:13 +0000)]
Return WERR_UNKNOWN_LEVEL for getprinterdriver level 6 as we don't
know how to decode a printer driver into a DRIVER_INFO_6 structure.
Tim Potter [Mon, 9 Sep 2002 01:09:23 +0000 (01:09 +0000)]
Remove todo comment.
Tim Potter [Mon, 9 Sep 2002 01:06:20 +0000 (01:06 +0000)]
Check no extra fields are present when parsing credentials.
Tim Potter [Sun, 8 Sep 2002 23:57:40 +0000 (23:57 +0000)]
Update patch.
Jelmer Vernooij [Sun, 8 Sep 2002 15:25:22 +0000 (15:25 +0000)]
Patch from Kai Krüger for the new SAM system
Jelmer Vernooij [Sun, 8 Sep 2002 14:58:23 +0000 (14:58 +0000)]
Patch from Stefan (metze) Metzmacher with more updates for the SAM subsystem
Simo Sorce [Sun, 8 Sep 2002 03:55:37 +0000 (03:55 +0000)]
change parametric option name to vfs_recycle_bin it is more sane and do not pollute standard options namespace too much
changed also the mode options to be indipendente boolean values, make it easier to understand how to configure them
eg:
vfs_recycle_bin:keeptree=yes
vfs_recycle_bin:versions=yes
Simo Sorce [Sun, 8 Sep 2002 00:36:22 +0000 (00:36 +0000)]
forgot to commit configure with configure.in
Jelmer Vernooij [Sat, 7 Sep 2002 19:06:37 +0000 (19:06 +0000)]
"disable charset" -> "display charset". oops
Gerald Carter [Sat, 7 Sep 2002 17:08:59 +0000 (17:08 +0000)]
merge of printer change notify fix from APP_HEAD
Andrew Bartlett [Sat, 7 Sep 2002 09:25:36 +0000 (09:25 +0000)]
This is the 'main' inclue for for winbind clients - all clients should include
only this file, and not any others. It includes the function prototypes.
(Forgot to commit with earlier patch)
Andrew Bartlett
Andrew Bartlett [Sat, 7 Sep 2002 06:04:28 +0000 (06:04 +0000)]
Don't leak file desciptors in this (impossible?) error case.
Andrew Bartlett [Sat, 7 Sep 2002 05:41:23 +0000 (05:41 +0000)]
Winbind client-side cleanups.
The global winbind file descriptor can cause havoc in some situations -
particulary when it becomes 0, 1 or 2. This patch (based on some very nice
work by Hannes Schmidt <mail@schmidt-net.via.t-online.de>) starts to recitfy
the problem by ensuring that the close-on-exec flag is set, and that we move
above 3 in the file descriptor table.
I've also decided that the PAM module can close it's pipe handle on every
request - this isn't performance-critical code.
The next step is to do the same for nss_winbind. (But things like getent()
might get in our way there).
This also cleans up some function prototypes, puts them in just one place.
Andrew Bartlett
Simo Sorce [Sat, 7 Sep 2002 04:08:03 +0000 (04:08 +0000)]
configure.in:
reflect the new example/VFS/ directory organization
lib/substitue.c:
added helper functions needed by recycle bin
Simo Sorce [Sat, 7 Sep 2002 04:05:42 +0000 (04:05 +0000)]
recycle.c:
merged in modifications made my differnt people, cleaned up things, yet some work todo
the code works but there are still some cases to be handled properly
Makefile.in:
this one seem much simpler and effective than the previous hack with file inclusion
it should also be more portable
we still need to find a solution to support multiple platforms or go back to libtool
Andrew Bartlett [Fri, 6 Sep 2002 23:10:28 +0000 (23:10 +0000)]
As per the 'OK' at CIFS2002, only use the readline headers (and this crasy
#ifdef mess...) in readline.c, we don't need or use them in the rest of Samba.
(This OK was of course conditional on 'if you break it, you better fix it...')
Andrew Bartlett
Andrew Bartlett [Fri, 6 Sep 2002 13:46:36 +0000 (13:46 +0000)]
Seems I missed commiting this when I added the rest of metze's ADS patch.
Oh well, here it is...
Andrew Bartlett
Simo Sorce [Fri, 6 Sep 2002 13:39:46 +0000 (13:39 +0000)]
the current block module is completely broken, jelmer will commit a new one later.
simo
Simo Sorce [Fri, 6 Sep 2002 13:37:40 +0000 (13:37 +0000)]
move everything to flat VFS/ directory
Andrew Bartlett [Fri, 6 Sep 2002 13:37:11 +0000 (13:37 +0000)]
This is the 'easy' parts of the trusted domains patch n+3 patch from
Rafal Szczesniak <mimir@diament.ists.pwr.wroc.pl>
It includes a conversion of make_user_info*() to NTSTATUS and some minor
changes to other files.
It also picks up on a nasty segfault that can occour in some security=domain
cases.
Andrew Bartlett
Andrew Bartlett [Fri, 6 Sep 2002 13:21:54 +0000 (13:21 +0000)]
Fix some missing ; on the end of our SAM_ASSERT()...
Andrew Bartlett [Fri, 6 Sep 2002 13:17:55 +0000 (13:17 +0000)]
Get our consts back in line with current norms - only for pointer protection.
Debate about extending this policy welcomed on samba-technical.
Andrew Bartlett
Andrew Bartlett [Fri, 6 Sep 2002 13:05:04 +0000 (13:05 +0000)]
Make it possible to actually build these modules - process the Makefile.in at
the end of configure.
Andrew Bartlett [Fri, 6 Sep 2002 13:00:37 +0000 (13:00 +0000)]
Updates to sam_skel from metze, add sam/group.c and add a DEBUG() to the
SAM_ASSERT if we are not going to crash.
Andrew Bartlett [Fri, 6 Sep 2002 12:57:12 +0000 (12:57 +0000)]
This commit includes part of the patch from metze posted to the list, and a few
of my own changes.
In particular: I've added a SAM_ASSERT macro. This expands to either
SMB_ASSERT() (which should help us track down bugs) or a return of
NT_STATUS_CHECK_FAIL.
Metze's changes are mostly to bring the code into line with current discussions
on things like adding users/groups, flags etc.
I've adjusted a fair bit of the 'const' in the SAM stuff. Const is currently
used only for pointers, not for local variables or non-pointer paramters. The
benifits and reasons for extending this further need discussion on
samba-technical.
Also, some of the 'context' paramters should not be const, to allow backend
modules to do fancy caching etc in them.
Andrew Bartlett
Andrew Bartlett [Fri, 6 Sep 2002 11:58:18 +0000 (11:58 +0000)]
patch from metze: add a 'vfs' debug class
Andrew Bartlett [Fri, 6 Sep 2002 11:49:16 +0000 (11:49 +0000)]
Revert accidental commit - I'll need to do a fair bit more testing before I
commit changes to NTLMSSP flags.
Andrew Bartlett [Fri, 6 Sep 2002 11:46:59 +0000 (11:46 +0000)]
Patch from "Stefan (metze) Metzmacher" <metze@metzemix.de>
to extend the ADS_STATUS system to include NTSTATUS, and to provide a better
general infrustructure for his sam_ads work.
I've also added some extra failure mode DEBUG()s to parts of the code.
NOTE: The ADS_ERR_OK() macro is rather sensitive to braketing issues - without
the final set of brakets, the test is essentially inverted - causing some
intersting 'error = success' messages...
Andrew Bartlett
Andrew Bartlett [Fri, 6 Sep 2002 10:43:52 +0000 (10:43 +0000)]
Oops...
Andrew Bartlett [Fri, 6 Sep 2002 10:39:34 +0000 (10:39 +0000)]
Add some DEBUG()s to some libads failure modes.
Andrew Bartlett [Fri, 6 Sep 2002 10:38:26 +0000 (10:38 +0000)]
One less user of Get_Pwnam_modify()...
Andrew Bartlett
Andrew Bartlett [Fri, 6 Sep 2002 10:00:24 +0000 (10:00 +0000)]
Detect and use syslog.h or sys/syslog.h corretly. Fixes lack of prototype for
syslog() since Paul Green's POSIX patch.
Tim Potter [Fri, 6 Sep 2002 07:44:21 +0000 (07:44 +0000)]
Initial version of printerdata_ex browsing.
Tim Potter [Fri, 6 Sep 2002 07:34:57 +0000 (07:34 +0000)]
Move printerdata dictionary object into it's own file.
Tim Potter [Fri, 6 Sep 2002 07:01:40 +0000 (07:01 +0000)]
Decode list of dependent files in printer driver info3 and info6.
It's a null terminated list of null terminated unicode strings. What
a mess!
Tim Potter [Fri, 6 Sep 2002 06:59:40 +0000 (06:59 +0000)]
level keys are inserted by conv routines.
Tim Potter [Fri, 6 Sep 2002 06:13:16 +0000 (06:13 +0000)]
Display debug data we are marshalling/unmarshalling a UNISTR in a
similar format to UNISTR2.
Tim Potter [Fri, 6 Sep 2002 01:12:52 +0000 (01:12 +0000)]
cli_spoolss_enumprinterdrivers:
Return WERR_UNKNOWN_LEVEL if we can't decode the returned buffer.
Andrew Bartlett [Thu, 5 Sep 2002 15:47:22 +0000 (15:47 +0000)]
Move the fancy NT_STATUS macros to a new file, so we can include them earlier
in includes.h
Andrew Bartlett
Jeremy Allison [Thu, 5 Sep 2002 12:55:56 +0000 (12:55 +0000)]
Revert the "reverse" change to rpc_server/srv_spoolss_nt.c, simply
add then entries to the end of the list in printing/notify.c using
DLIST_ADD_END.
Jeremy.
Volker Lendecke [Thu, 5 Sep 2002 11:40:06 +0000 (11:40 +0000)]
Fixed a little, long standing bug: smbclient -M <name> should resolve
name#03, not name#20.
Volker
Tim Potter [Thu, 5 Sep 2002 06:49:08 +0000 (06:49 +0000)]
Delivery notify messages over the back channel in *reverse* order in
which they are sent in the message. This is because a DLIST_ADD is
used by the message sender which results in the first (post!) message
being at the end of the list. Notify messages must be delivered in
the order the events occur in otherwise the port monitor gets
confused.
Jeremy Allison [Thu, 5 Sep 2002 05:26:29 +0000 (05:26 +0000)]
Remove donotify as notifies are cheap now.
Jeremy.
Jeremy Allison [Thu, 5 Sep 2002 04:33:52 +0000 (04:33 +0000)]
We shouldn't add printing flag here.
Jeremy.
Tim Potter [Thu, 5 Sep 2002 04:33:07 +0000 (04:33 +0000)]
Send any queued up print notify messages in exit_server() so they
don't get lost if the client exits before timeout_processing()
has a chance to run.
Tim Potter [Thu, 5 Sep 2002 04:25:21 +0000 (04:25 +0000)]
A netshareenum reply always contains an enum_hnd. win2k returns zero
total entries on an error whereas nt4 must send uninitialised data so
we didn't catch this one before.
Tim Potter [Thu, 5 Sep 2002 04:22:16 +0000 (04:22 +0000)]
Roussed on Jeremy for not putting in enough debugs in the new print
notify stuff. (-:
Andrew Tridgell [Thu, 5 Sep 2002 03:06:26 +0000 (03:06 +0000)]
initial mem_ctx to NULL
patch from metze
Tim Potter [Thu, 5 Sep 2002 02:00:14 +0000 (02:00 +0000)]
The new popt_common_debug code obviates the need to muck around with
AllowDebugChange, saving the debuglevel across lp_load() calls etc.
Jeremy Allison [Wed, 4 Sep 2002 23:40:49 +0000 (23:40 +0000)]
Added better error code on out of space. Removed total jobs check - not
applicable any more.
Jeremy.
Andrew Bartlett [Wed, 4 Sep 2002 22:02:53 +0000 (22:02 +0000)]
Only cache the user list on the SAMR handle for a particular
acb_mask/all_machines flag combination. The avoids a bug where we were listing
users in the 'trusting domains' dialog in usrmgr.
We might also need to invalidate the cache for some other SAMR actions.
Andrew Bartlett
Jeremy Allison [Wed, 4 Sep 2002 21:59:38 +0000 (21:59 +0000)]
Merge ... (apparently working :-) new printing notify code.
Jeremy.
Jeremy Allison [Wed, 4 Sep 2002 19:13:06 +0000 (19:13 +0000)]
Add bcast_msg_flags to connection struct. Allows sender to filter when
sending broadcast messages. Also initial cut-down of printing notify
messages (not yet finished).
Jeremy.
Andrew Tridgell [Wed, 4 Sep 2002 10:58:42 +0000 (10:58 +0000)]
don't use ENCTYPE_ARCFOUR_HMAC unless the kerberos lib supports it
Andrew Bartlett [Wed, 4 Sep 2002 08:08:03 +0000 (08:08 +0000)]
Set default ACB attributes on 'unixsam' accounts. This means that machine
accounts added first to /etc/passwd will be honered correctly. Also, users
'upgraded' to smbpasswd will have the right flags.
Andrew Bartlett
Tim Potter [Wed, 4 Sep 2002 04:30:41 +0000 (04:30 +0000)]
Fix typo in comment.
Tim Potter [Wed, 4 Sep 2002 02:57:16 +0000 (02:57 +0000)]
Quietened some debugs.
Gerald Carter [Wed, 4 Sep 2002 01:15:01 +0000 (01:15 +0000)]
remove inet_aton()
Gerald Carter [Wed, 4 Sep 2002 01:14:24 +0000 (01:14 +0000)]
DeletePrinterDriver[Ex]() fixes from APP_HEAD
Richard Sharpe [Tue, 3 Sep 2002 21:35:26 +0000 (21:35 +0000)]
Fix the struct_blob.
Jeremy Allison [Tue, 3 Sep 2002 20:10:25 +0000 (20:10 +0000)]
Ensure we open UNIX fifo's non-blocking like we used to do.
Jeremy.
Jeremy Allison [Tue, 3 Sep 2002 19:19:20 +0000 (19:19 +0000)]
Fix crashbug discovered by "Kim R. Pedersen" <krp@filanet.dk> where
cli struct was being deallocated in a called function.
Jeremy.
Jeremy Allison [Tue, 3 Sep 2002 19:18:12 +0000 (19:18 +0000)]
Formatting tidyup and additon of cli_close_connection() before bugfix.
Jeremy.
Richard Sharpe [Tue, 3 Sep 2002 17:36:00 +0000 (17:36 +0000)]
Fix the client side NTLMSSP. It now works between smbclient and smbd!
However, it does not work with Win2K over 445 with raw NTLMSSP!
Richard Sharpe [Tue, 3 Sep 2002 06:34:40 +0000 (06:34 +0000)]
Parse the NTLMSSP Challenge in cliconnect.c.
This gets us closer ... Should have the challenge now. Need to check that it works.
Tim Potter [Tue, 3 Sep 2002 05:35:47 +0000 (05:35 +0000)]
Conver cli_spoolss routines to use REGISTRY_VALUE and REGVAL_CTR code. Nice one jerry!
(Hey I thought I checked this in already?)
Tim Potter [Tue, 3 Sep 2002 05:00:17 +0000 (05:00 +0000)]
Convert to new REGISTRY_VALUE cli_spoolss routines.
Tim Potter [Tue, 3 Sep 2002 04:58:36 +0000 (04:58 +0000)]
Fixed enumjobs command to use new JOB_INFO_CTR structure.
Tim Potter [Tue, 3 Sep 2002 04:56:39 +0000 (04:56 +0000)]
Fix setprinterdata rpcclient command to use new cli_spoolss_setprinterdata
function. Also fixed crash bug - I don't think anyone uses this
command anymore...
Richard Sharpe [Tue, 3 Sep 2002 04:10:58 +0000 (04:10 +0000)]
Make sure that an NTLMSSP negotiate blob has the correct stuff in it!
Richard Sharpe [Tue, 3 Sep 2002 03:53:50 +0000 (03:53 +0000)]
Add type A to the small MSRPC generator ...
Richard Sharpe [Tue, 3 Sep 2002 03:48:28 +0000 (03:48 +0000)]
The session key in NTLMSSP AUTH blobs is actually an empty string.
Also, the negotiate blob has two ASCI strings encoded in the same way that the
UNICODE strings are, they are just in ASCII. The PARSER and Generator will have to deal with that.