tprouty/samba.git
11 years agos4:setup: fix cut-n-paste error Builtin-Domain => Samba4-Local-Domain
Andrew Bartlett [Tue, 16 Dec 2008 07:48:44 +0000 (08:48 +0100)]
s4:setup: fix cut-n-paste error Builtin-Domain => Samba4-Local-Domain

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:setup: don't set objectCategory: CN=Domain-DNS,${SCHEMADN}
Andrew Bartlett [Tue, 16 Dec 2008 07:48:01 +0000 (08:48 +0100)]
s4:setup: don't set objectCategory: CN=Domain-DNS,${SCHEMADN}

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:torture: add ldb tests
Andrew Bartlett [Tue, 16 Dec 2008 07:45:43 +0000 (08:45 +0100)]
s4:torture: add ldb tests

These tests are for both the new extended DN functionality (and were
vital in finding bugs during implementation) and for the normal DN
parsing and comparison routines.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:ldap_server: return the extended dn to the LDAP client if available
Andrew Bartlett [Tue, 16 Dec 2008 07:44:11 +0000 (08:44 +0100)]
s4:ldap_server: return the extended dn to the LDAP client if available

This uses an early peek at the extended_dn_control (in the request) to see what output
format to use.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:ldb-samba: register samba specific extended dn handlers
Andrew Bartlett [Tue, 16 Dec 2008 07:43:12 +0000 (08:43 +0100)]
s4:ldb-samba: register samba specific extended dn handlers

This provides the two extended DN handlers for the GUID and SID types,
and makes the parsing more strict (where possible, it uses
ndr_pull_struct_blob_all(), to cause an error if trailing data is
found).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:samldb: make use of dom_sid_split_rid()
Andrew Bartlett [Tue, 16 Dec 2008 07:41:22 +0000 (08:41 +0100)]
s4:samldb: make use of dom_sid_split_rid()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:samldb: improve error strings
Andrew Bartlett [Tue, 16 Dec 2008 07:40:49 +0000 (08:40 +0100)]
s4:samldb: improve error strings

When things go wrong with LDB, this routine seems to be particularly
sensitive to it.  This extra debugging should help the next poor soul who
breaks LDB.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:ldb.i: hang the dn on the NULL context as the python destructor will free it
Andrew Bartlett [Tue, 16 Dec 2008 07:34:48 +0000 (08:34 +0100)]
s4:ldb.i: hang the dn on the NULL context as the python destructor will free it

This fixes a bug in the ldb.i python wrapper, that showed up under valgrind.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:ldb: use try to print the extended dn in the ldif output
Andrew Bartlett [Tue, 16 Dec 2008 07:33:32 +0000 (08:33 +0100)]
s4:ldb: use try to print the extended dn in the ldif output

This allows searches with the extended DN control to still print the
extended DN in ldif output (it would otherwise be parsed and hidden in
the structure).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:dsdb: add support for DSDB_OPENLDAP_DEREFERENCE_CONTROL
Andrew Bartlett [Tue, 16 Dec 2008 07:28:55 +0000 (08:28 +0100)]
s4:dsdb: add support for DSDB_OPENLDAP_DEREFERENCE_CONTROL

Encode and decode the OpenLDAP dereference control (draft-masarati-ldap-deref-00)

At this time, the ldb_controls infrustructure does not handle request
and reply controls having different formats, so this is purely the
client implementation (ie, there is no decode of the client->server
packet, and no encode of the server->client packet).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:libcli/ldap: split out a ldap_decode_attribs_bare() function
Andrew Bartlett [Tue, 16 Dec 2008 07:27:51 +0000 (08:27 +0100)]
s4:libcli/ldap: split out a ldap_decode_attribs_bare() function

The OpenLDAP dereference control (draft-masarati-ldap-deref-00) uses
an attribute list, as found in the search reply, but without one
enclosing ASN1_SEQUENCE(0)

This allows the dereference control parsing code to use this as a
helper function.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:ldb_ildap: try to pass extended DNs to the server
Andrew Bartlett [Tue, 16 Dec 2008 07:25:44 +0000 (08:25 +0100)]
s4:ldb_ildap: try to pass extended DNs to the server

Whenever we pass a DN to the LDAP server, we now use
ldb_dn_get_extended_linearized().  This allows us to send the extended
DN if set, and therefore allows searches of the form
'<GUID=aaa45ea0-94cd-45e9-8753-abe455d9a8f1>'.

We actually use the '0' format (GUID=aaa45ea094cd45e98753abe455d9a8f1)
because it is more widely supported (by Win2k in particular).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:ldb: add infrastructure for extended dn handlers
Andrew Bartlett [Tue, 16 Dec 2008 07:19:07 +0000 (08:19 +0100)]
s4:ldb: add infrastructure for extended dn handlers

This introduces a new set of pluggable syntax, for use on the
extended DN, and uses them when parsing the DN.

If the DN appears to be in the extended form, we no longer return the
full DN 'as is', but only return the normal part from
ldb_dn_get_linearized().

When validating/parsing the DN we validate not only the format of the
DN, but also the contents of the GUID or SID (to ensure they are
plausable).

We also have functions to set and get the extended components on the DN.

For now, extended_dn_get_linearized() returns a newly constructed and
allocated string each time.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoAdd hint to use passwordAttributes in @KLUDGE_ACL in future
Andrew Bartlett [Mon, 8 Dec 2008 11:22:21 +0000 (22:22 +1100)]
Add hint to use passwordAttributes in @KLUDGE_ACL in future

This module is not used at the moment, but if we do use it again, we
should try to avoid duplicate lists.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoMake greater use of 'GUID_from_data_blob'
Andrew Bartlett [Wed, 3 Dec 2008 23:38:07 +0000 (10:38 +1100)]
Make greater use of 'GUID_from_data_blob'

This avoids accidentily running off the end of a string, and uses a
single 'guess which type of GUID I have' algorithm.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoFix sequence number generation against OpenLDAP
Andrew Bartlett [Wed, 10 Dec 2008 06:23:44 +0000 (17:23 +1100)]
Fix sequence number generation against OpenLDAP

It seems that in 2deeb99fff1a90c79ba1927e1a069362e250a63c adding the
partition control to this request was missed out.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agonsswitch: fix compiler warnings in winbind_nss_linux.c
Stefan Metzmacher [Tue, 16 Dec 2008 23:30:21 +0000 (00:30 +0100)]
nsswitch: fix compiler warnings in winbind_nss_linux.c

metze

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 16 Dec 2008 21:59:18 +0000 (22:59 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agoDon't write out forward declarations for enums, as some compilers don't
Jelmer Vernooij [Tue, 16 Dec 2008 21:58:10 +0000 (22:58 +0100)]
Don't write out forward declarations for enums, as some compilers don't
seem to like it.

11 years ago(Fixed) Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentatio...
Kai Blin [Tue, 16 Dec 2008 21:40:38 +0000 (13:40 -0800)]
(Fixed) Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NAS-BASIC server).

11 years agoMerge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Jeremy Allison [Tue, 16 Dec 2008 21:35:44 +0000 (13:35 -0800)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba

11 years agoRevert "Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentatio...
Jeremy Allison [Tue, 16 Dec 2008 21:31:52 +0000 (13:31 -0800)]
Revert "Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NASBASIC server)."
Error in commit !

This reverts commit bbd5824140992ea457d4270ee77018ebb367abc9.

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 16 Dec 2008 21:22:15 +0000 (22:22 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agoFix header installation after move of gen_ndr headers.
Jelmer Vernooij [Tue, 16 Dec 2008 21:20:21 +0000 (22:20 +0100)]
Fix header installation after move of gen_ndr headers.

11 years agoFinal part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault...
Kai Blin [Tue, 16 Dec 2008 21:19:15 +0000 (13:19 -0800)]
Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NASBASIC server).

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Tue, 16 Dec 2008 20:17:54 +0000 (07:17 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agoan experimental patch for fixing ldb bloat
Andrew Tridgell [Tue, 16 Dec 2008 07:45:28 +0000 (18:45 +1100)]
an experimental patch for fixing ldb bloat

ldb indexing can cause huge files, and huge memory usage. This
experiment allows us to keep indexes in memory during a transaction,
then to write the indexes to disk when the transaction completes. The
result is that the db is much smaller (we have seen improvements of
about 100x in file size) and memory usage during large transactions is
also greatly reduced

Note that this patch uses the unusual strategy of putting pointers
into a ldb (and thus into a tdb). This works because the pointers are
only there during a transaction, so the pointers are not exposed to
any other users of the database. The pointers allow us to avoid some
really bad allocation problems with tdb record allocation during the
re-indexing.

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 16 Dec 2008 18:51:35 +0000 (19:51 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agoUse py_* files to check whether generated files are out of date / not
Jelmer Vernooij [Tue, 16 Dec 2008 18:46:43 +0000 (19:46 +0100)]
Use py_* files to check whether generated files are out of date / not
present.

ndr_*.c files are in git (required for Samba 3), py_*.c files are not.

11 years agoIgnore generated files.
Jelmer Vernooij [Tue, 16 Dec 2008 18:43:52 +0000 (19:43 +0100)]
Ignore generated files.

11 years agoRemove ndrdump - it's available in merged build mode as bin/ndrdump4 and uses the...
Jelmer Vernooij [Tue, 16 Dec 2008 18:08:36 +0000 (19:08 +0100)]
Remove ndrdump - it's available in merged build mode as bin/ndrdump4 and uses the exact same object files there.

11 years agoRemove use of C++ keywords.
Jelmer Vernooij [Tue, 16 Dec 2008 18:07:02 +0000 (19:07 +0100)]
Remove use of C++ keywords.

11 years agoShare object files for gen_ndr.
Jelmer Vernooij [Tue, 16 Dec 2008 17:56:21 +0000 (18:56 +0100)]
Share object files for gen_ndr.

11 years agocommit b520befe6f51644d20434add9864d7a2fa30aa2e
SATOH Fumiyasu [Tue, 16 Dec 2008 15:54:30 +0000 (00:54 +0900)]
commit b520befe6f51644d20434add9864d7a2fa30aa2e
Author: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Date:   Wed Dec 17 00:42:25 2008 +0900

    libsmbclient: Fix SIGBUS on non-x86 CPUs

    We must align the struct smbc_dirent in the struct
    SMBC_internal_data because the struct smbc_dirent
    has numeric values that require alignment.

Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
11 years agoMake some fatal errors non-fatal. This means we generate invalid code in
Jelmer Vernooij [Tue, 16 Dec 2008 17:02:14 +0000 (18:02 +0100)]
Make some fatal errors non-fatal. This means we generate invalid code in
some cases, but we do print errors. We don't use all generated code yet at the
moment, so this isn't much of a problem.

11 years agoFix [out] pointers in DCOM-related IDL files.
Jelmer Vernooij [Tue, 16 Dec 2008 16:42:23 +0000 (17:42 +0100)]
Fix [out] pointers in DCOM-related IDL files.

11 years agos3/s4: Fix "shadows a global declaration" warning
Tim Prouty [Tue, 16 Dec 2008 16:33:58 +0000 (08:33 -0800)]
s3/s4: Fix "shadows a global declaration" warning

11 years agonss_winbind: Solaris 64-bit fix and...
SATOH Fumiyasu [Tue, 16 Dec 2008 15:59:07 +0000 (16:59 +0100)]
nss_winbind: Solaris 64-bit fix and...

PATCH 1:
Fix gmem->numgids and gmem->maxgids breakage on Solaris 64-bit
because sizeof(int) != sizeof(long int).

PATCH 2:
This patch fixes a compile-time warning
"warning: implicit function declaration: _nss_winbind_initgroups_dyn".
(cherry picked from commit cb036772d09227f870c2fec3ecd8c3f53787dfbc)

11 years agoRemove pidl SWIG backend; the native Python one works much better, and
Jelmer Vernooij [Tue, 16 Dec 2008 15:48:48 +0000 (16:48 +0100)]
Remove pidl SWIG backend; the native Python one works much better, and
that's also the best way to go for any other languages.

11 years agoSimplify idl-deps.pl script a bit.
Jelmer Vernooij [Tue, 16 Dec 2008 15:46:13 +0000 (16:46 +0100)]
Simplify idl-deps.pl script a bit.

11 years agoOnly create (D)COM output files if there were COM objects in the IDL files.
Jelmer Vernooij [Tue, 16 Dec 2008 15:37:54 +0000 (16:37 +0100)]
Only create (D)COM output files if there were COM objects in the IDL files.

11 years agoAdd new script for building IDL files in librpc/idl, generating both
Jelmer Vernooij [Tue, 16 Dec 2008 15:32:18 +0000 (16:32 +0100)]
Add new script for building IDL files in librpc/idl, generating both
Samba 3 and Samba 4 output.

11 years agos4/provision: Upper case default realm, use only first part of realm as default domai...
Jelmer Vernooij [Tue, 16 Dec 2008 15:17:30 +0000 (16:17 +0100)]
s4/provision: Upper case default realm, use only first part of realm as default domain name.

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 16 Dec 2008 15:14:16 +0000 (16:14 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agoFix path to ndr_notify.c.
Jelmer Vernooij [Tue, 16 Dec 2008 15:02:05 +0000 (16:02 +0100)]
Fix path to ndr_notify.c.

11 years agoMove shared gen_ndr files to librpc/gen_ndr in the root.
Jelmer Vernooij [Tue, 16 Dec 2008 14:59:06 +0000 (15:59 +0100)]
Move shared gen_ndr files to librpc/gen_ndr in the root.

At the moment these files are used just by Samba 3, but the next step
will be using them from Samba 4 as well.

11 years agonsswitch: Fix paths for Samba4 blackbox wbinfo test
Kai Blin [Tue, 16 Dec 2008 14:45:12 +0000 (15:45 +0100)]
nsswitch: Fix paths for Samba4 blackbox wbinfo test

11 years agoConsider shared IDL files and Samba3-specific IDL files separately, allow overriding...
Jelmer Vernooij [Tue, 16 Dec 2008 14:42:47 +0000 (15:42 +0100)]
Consider shared IDL files and Samba3-specific IDL files separately, allow overriding output directory.

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 16 Dec 2008 14:36:53 +0000 (15:36 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agoRename dom_sid.idl -> server_id.idl (since it no longer actually contains the dom_sid...
Jelmer Vernooij [Tue, 16 Dec 2008 14:36:18 +0000 (15:36 +0100)]
Rename dom_sid.idl -> server_id.idl (since it no longer actually contains the dom_sid). No longer include it from security.idl.

11 years agodocs: "acl compatibility" is a global parameter.
Karolin Seeger [Tue, 16 Dec 2008 14:10:29 +0000 (15:10 +0100)]
docs: "acl compatibility" is a global parameter.

This fixes bug #5866.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!

Karolin

11 years agoIgnore setup symlink.
Jelmer Vernooij [Tue, 16 Dec 2008 13:39:54 +0000 (14:39 +0100)]
Ignore setup symlink.

11 years agoAdd an entry for the "check" command to the tdbtool manpage.
Holger Hetterich [Thu, 20 Nov 2008 09:32:14 +0000 (10:32 +0100)]
Add an entry for the "check" command to the tdbtool manpage.

11 years agoAdded a simple tdb integrity check to tdbtool. The command "check" runs traverse...
Holger Hetterich [Sat, 1 Nov 2008 23:12:32 +0000 (00:12 +0100)]
Added a simple tdb integrity check to tdbtool. The command "check" runs traverse on the currently open tdb, and returns the number of entries if the integrity check is successful.

11 years agonsswitch: Move nsswitch files from source4 to top level nsswitch dir
Kai Blin [Tue, 16 Dec 2008 09:06:04 +0000 (10:06 +0100)]
nsswitch: Move nsswitch files from source4 to top level nsswitch dir

11 years agonsswitch: Move source3 files to top level dir.
Kai Blin [Tue, 16 Dec 2008 08:30:16 +0000 (09:30 +0100)]
nsswitch: Move source3 files to top level dir.

Don't move source4 files yet to not confuse git's rename tracking too much.

11 years agodocs: Remove comment about default backend.
Karolin Seeger [Tue, 16 Dec 2008 10:18:45 +0000 (11:18 +0100)]
docs: Remove comment about default backend.

Karolin

11 years agodocs: Fix typo in the idmap_ad manpage.
Karolin Seeger [Tue, 16 Dec 2008 08:04:32 +0000 (09:04 +0100)]
docs: Fix typo in the idmap_ad manpage.

Karolin

11 years agos3:net_status: use dbwrap to open sessionid.tdb
Stefan Metzmacher [Mon, 15 Dec 2008 15:47:38 +0000 (16:47 +0100)]
s3:net_status: use dbwrap to open sessionid.tdb

metze

11 years agos3: Use DEBUGADD instead of DEBUG to avoid printing the header
Dan Sledz [Tue, 16 Dec 2008 01:12:49 +0000 (17:12 -0800)]
s3: Use DEBUGADD instead of DEBUG to avoid printing the header

11 years agos3: Fix "differing signedness" build warnings
Tim Prouty [Tue, 16 Dec 2008 07:13:26 +0000 (23:13 -0800)]
s3: Fix "differing signedness" build warnings

11 years agos3: Fix a few build warnings
Tim Prouty [Tue, 16 Dec 2008 06:34:07 +0000 (22:34 -0800)]
s3: Fix a few build warnings

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Andrew Bartlett [Tue, 16 Dec 2008 05:23:10 +0000 (16:23 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel

11 years agorepack the ldb after re-indexing
Andrew Tridgell [Tue, 16 Dec 2008 03:41:21 +0000 (14:41 +1100)]
repack the ldb after re-indexing

re-indexing in ldb is triggered on any modification to the @ATTRIBUTES
or @INDEXLIST records. This happens to produce a worst-case
fragmentation of the database, as all @INDEX records are deleted then
re-created. By repacking after re-indexing we ensure that the database
ends up without extreme fragmentation.

11 years agouse transactions in ldbadd, ldbmodify and ldbedit
Andrew Tridgell [Tue, 16 Dec 2008 03:39:42 +0000 (14:39 +1100)]
use transactions in ldbadd, ldbmodify and ldbedit

The command line tools ldbadd, ldbmodify and ldbedit should operate
within a transaction to make them more efficient. The ldbadd tool in
particular is much faster when adding a large number of records if all
the adds happen within a transaction. Previously there was a
transaction per record.

11 years agoimported the tdb_repack() code from CTDB
Andrew Tridgell [Tue, 16 Dec 2008 03:38:17 +0000 (14:38 +1100)]
imported the tdb_repack() code from CTDB

The tdb_repack() function repacks a TDB so that it has a single
freelist entry. The file doesn't shrink, but it does remove all
freelist fragmentation. This code originated in the CTDB vacuuming
code, but will now be used in ldb to cope with fragmentation from
re-indexing

11 years agomake tdbbackup use transactions
Andrew Tridgell [Tue, 16 Dec 2008 03:36:56 +0000 (14:36 +1100)]
make tdbbackup use transactions

tdbbackup was originally written before we had transactions, and it
attempted to use its own fsync() calls to make it safe. Now that we
have transactions we can do it in a much safer (and faster!) fashion

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Tue, 16 Dec 2008 00:41:20 +0000 (11:41 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agoA more-commented version of rpc_server crash fix, matching closer the
Andrew Bartlett [Tue, 16 Dec 2008 00:25:29 +0000 (11:25 +1100)]
A more-commented version of rpc_server crash fix, matching closer the
previous behaviour for the 'bad bind' case.

(It is only close, not matching - Windows 2008 sends a different,
non-zero, assoc_group_id each time)

Andrew Bartlett

11 years agoAdd python extensions for dom_sid.
Jelmer Vernooij [Mon, 15 Dec 2008 23:16:02 +0000 (00:16 +0100)]
Add python extensions for dom_sid.

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Mon, 15 Dec 2008 22:19:49 +0000 (23:19 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agos3:loadparm: fix copy service error (canonicalize_servicename: NULL source name)
Michael Adam [Mon, 15 Dec 2008 13:42:13 +0000 (14:42 +0100)]
s3:loadparm: fix copy service error (canonicalize_servicename: NULL source name)

this was introduced by commit 3358a139d2dc77eb4c842d41722b1acc24bd2cb2.

Michael

11 years agos3:loadparm: add service-struct based variants of the free-parameter routines
Michael Adam [Mon, 15 Dec 2008 13:38:51 +0000 (14:38 +0100)]
s3:loadparm: add service-struct based variants of the free-parameter routines

and use the abstracted free_one_parameter_common() in old
free_one_parameter_by_snum() as well as in new free_one_parameter()

Michael

11 years agos3:loadparm: rename free_parameters() to free_parameters_by_snum()
Michael Adam [Mon, 15 Dec 2008 13:29:34 +0000 (14:29 +0100)]
s3:loadparm: rename free_parameters() to free_parameters_by_snum()

Michael

11 years agos3:loadparm: rename free_parameter() to free_one_parameter_by_snum()
Michael Adam [Mon, 15 Dec 2008 13:28:03 +0000 (14:28 +0100)]
s3:loadparm: rename free_parameter() to free_one_parameter_by_snum()

Michael

11 years agos3:loadparm: add lp_local_ptr() that operates on a service struct
Michael Adam [Mon, 15 Dec 2008 13:20:16 +0000 (14:20 +0100)]
s3:loadparm: add lp_local_ptr() that operates on a service struct

and use this in lp_local_ptr_by_snum().

Michael

11 years agos3:loadparm: rename lp_local_ptr() to lp_local_ptr_by_snum()
Michael Adam [Mon, 15 Dec 2008 13:16:06 +0000 (14:16 +0100)]
s3:loadparm: rename lp_local_ptr() to lp_local_ptr_by_snum()

Michael

11 years agos3:loadparm: fix newly introduced leading whitespaces to tabs
Michael Adam [Mon, 15 Dec 2008 12:33:24 +0000 (13:33 +0100)]
s3:loadparm: fix newly introduced leading whitespaces to tabs

Michael

11 years agos3:fix build of pam_winbind.so on older Linux systems.
Michael Adam [Mon, 15 Dec 2008 10:32:45 +0000 (11:32 +0100)]
s3:fix build of pam_winbind.so on older Linux systems.

Older pam implementations on Linux define PAM_AUTHTOK_RECOVER_ERR
instead of PAM_AUTHTOK_RECOVERY_ERR. We have always defined and
are using PAM_AUTHTOK_RECOVER_ERR in all other places.

Michael

11 years agoRename ldap.h to ldap-util.h to avoid clashing with the system ldap.h
Jelmer Vernooij [Sun, 14 Dec 2008 18:08:22 +0000 (19:08 +0100)]
Rename ldap.h to ldap-util.h to avoid clashing with the system ldap.h

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Sun, 14 Dec 2008 16:17:55 +0000 (17:17 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

11 years agoRemove the global "cmdline_auth_info" from source3/lib/util.c
Volker Lendecke [Sun, 14 Dec 2008 12:06:19 +0000 (13:06 +0100)]
Remove the global "cmdline_auth_info" from source3/lib/util.c

This involves changing all our clients, that's why it's so large.

11 years agoMove 128 bytes from the data to the text segment
Volker Lendecke [Sun, 14 Dec 2008 12:11:41 +0000 (13:11 +0100)]
Move 128 bytes from the data to the text segment

11 years agoRemove a pointless static variable
Volker Lendecke [Sun, 14 Dec 2008 11:30:04 +0000 (12:30 +0100)]
Remove a pointless static variable

11 years agoAdded torture test for doing an openX over a directory
Jeremy Allison [Sat, 13 Dec 2008 21:10:48 +0000 (13:10 -0800)]
Added torture test for doing an openX over a directory
to ensure we get the correct error message.
Jeremy.

11 years agodon't return 0 on error - bad for scripts
Herb Lewis [Sat, 13 Dec 2008 19:31:20 +0000 (11:31 -0800)]
don't return 0 on error - bad for scripts

11 years agoRemove a pointless static variable
Volker Lendecke [Sat, 13 Dec 2008 15:40:25 +0000 (16:40 +0100)]
Remove a pointless static variable

Every sane compiler will only allocate "*SMBSERVER" once

11 years agoRemove a static variable
Volker Lendecke [Sat, 13 Dec 2008 16:04:12 +0000 (17:04 +0100)]
Remove a static variable

Derrell, please check!

Thanks,

Volker

11 years agoMicro-Optimize cliconnect.c
Volker Lendecke [Sat, 13 Dec 2008 15:53:17 +0000 (16:53 +0100)]
Micro-Optimize cliconnect.c

In this form, the prots array is fully read-only in the text segment and thus
can be shared between processes.

Probably pointless, but I had fun doing it :-)

11 years agos3:dsgetdcname: retry with the clients site
Stefan Metzmacher [Fri, 21 Nov 2008 07:28:13 +0000 (08:28 +0100)]
s3:dsgetdcname: retry with the clients site

metze

11 years agos3:libnet_join: use DS_FORCE_REDISCOVERY
Stefan Metzmacher [Fri, 21 Nov 2008 07:22:38 +0000 (08:22 +0100)]
s3:libnet_join: use DS_FORCE_REDISCOVERY

metze

11 years agos3:libnet_join: call saf_join_store() after a the join.
Stefan Metzmacher [Mon, 27 Oct 2008 18:40:23 +0000 (19:40 +0100)]
s3:libnet_join: call saf_join_store() after a the join.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(similar to commit feef594d275881466e2c3f59c0ff54609a9cc53b)

11 years agos3:libads/ldap.c: store the dc name in the saf cache as in all other places
Stefan Metzmacher [Mon, 27 Oct 2008 18:39:30 +0000 (19:39 +0100)]
s3:libads/ldap.c: store the dc name in the saf cache as in all other places

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 543fa85a711337e979c7b631bda5db95d109ef59)

11 years agos3:libads/ldap.c: if the client belongs to no site at all any dc is the closest
Stefan Metzmacher [Mon, 27 Oct 2008 18:38:15 +0000 (19:38 +0100)]
s3:libads/ldap.c: if the client belongs to no site at all any dc is the closest

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit f86ef9b53a903485deba94febf90dd4e657cc02b)

11 years agos3:libads/ldap.c: pass the real workgroup name to get_dc_name()
Stefan Metzmacher [Mon, 27 Oct 2008 18:36:25 +0000 (19:36 +0100)]
s3:libads/ldap.c: pass the real workgroup name to get_dc_name()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit c2d4a84abe1b6cbf68d6e9f1bb1f8974d0b628fc)

11 years agos3:libsmb/namequery.c: add saf_join_store() function
Stefan Metzmacher [Mon, 27 Oct 2008 18:31:30 +0000 (19:31 +0100)]
s3:libsmb/namequery.c: add saf_join_store() function

saf_join_store() should be called after a successful
domain join, the affinity to the dc used at join time
has a larger ttl, to avoid problems with delayed replication.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 80e74a27c55c01221091e3eec930c2ac4433c22c)

11 years agos3: libsmb/namequery: fallback to returning all dcs, when none is available in the...
Stefan Metzmacher [Mon, 27 Oct 2008 08:40:25 +0000 (09:40 +0100)]
s3: libsmb/namequery: fallback to returning all dcs, when none is available in the requested site

It could happen that all dcs in a site are unavailable
(some sites have only one dc) and then we need to fallback
to get all dcs.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit c127367b1dd622eeceb1f47de0a047c297dda222)

11 years agos3: libads: use get_dc_name() instead of get_sorted_dc_list() in the LDAP case
Stefan Metzmacher [Wed, 22 Oct 2008 09:14:10 +0000 (11:14 +0200)]
s3: libads: use get_dc_name() instead of get_sorted_dc_list() in the LDAP case

We use get_dc_name() for LDAP because it generates the selfwritten
krb5.conf with the correct kdc addresses and sets KRB5_CONFIG.

For CLDAP we need to use get_sorted_dc_list() to avoid recursion.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit d2f7f81f4d61bae9c4be65cbc1bf962b6c24a31f)

11 years agos3: correctly detect if the current dc is the closest one
Stefan Metzmacher [Wed, 22 Oct 2008 08:36:21 +0000 (10:36 +0200)]
s3: correctly detect if the current dc is the closest one

ads->config.tried_closest_dc was never set.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit dfe5b00db35e1e7c7bb3ba36729fc3f97eb48db3)

11 years agoFix a valgrind error in get_relative_fid_filename
Volker Lendecke [Sat, 13 Dec 2008 09:31:11 +0000 (10:31 +0100)]
Fix a valgrind error in get_relative_fid_filename

It doesn't really make sense to check the length of a not-yet-allocated string
:-)

Volker