tprouty/samba.git
10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Wed, 10 Sep 2008 09:15:02 +0000 (11:15 +0200)]
WHATSNEW: Update changes since 3.2.3.

Karolin
(cherry picked from commit eec57823cd6503339f8a54fed7dce0d4d41ab9a5)

10 years agopackaging(RHEL): remove libmsrpc stuff which is no more...
Michael Adam [Fri, 29 Aug 2008 14:48:37 +0000 (16:48 +0200)]
packaging(RHEL): remove libmsrpc stuff which is no more...

Michael
(cherry picked from commit 3eaa33e9df6d58ef93f13a840b38a063649fffbc)
(cherry picked from commit 165691927cdaaafc057de667294dff7a7bc8a991)

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Tue, 9 Sep 2008 11:23:28 +0000 (13:23 +0200)]
WHATSNEW: Update changes since 3.2.3.

Karolin
(cherry picked from commit 903868a474d4875807a131dffe74b5090c0dbcea)

10 years agoFix calculation of useable_space for trans2 and nttrans replies
Volker Lendecke [Mon, 8 Sep 2008 20:53:50 +0000 (22:53 +0200)]
Fix calculation of useable_space for trans2 and nttrans replies

When alignment was in place, we pretended to send more data/params according to
the param_offset/param_length and data_offset/data_length parameters than would
actually fit into the SMB according to the NBSS length field.
(cherry picked from commit 2ae870aead5e0ea7e7f9f6f9730f989ae34755b9)

10 years agosmbd: some write time fixes
Stefan Metzmacher [Mon, 8 Sep 2008 13:12:24 +0000 (15:12 +0200)]
smbd: some write time fixes

- only the first non truncating write causes
  the write time update with 2 seconds delay.
  It's not enough to check for an existing update event
  as it will be NULL after the event was triggered.

- SMBwrite truncates always update the write time
  unless the sticky write time is set.

- SMBwrite truncates don't trigger a write time update on close.

metze
(cherry picked from commit 142a9703ae19a467a23ee72429f899dae156df64)

10 years agoWhen setting an NFSv4 ACL, map generic bits
Volker Lendecke [Mon, 8 Sep 2008 14:42:06 +0000 (16:42 +0200)]
When setting an NFSv4 ACL, map generic bits
(cherry picked from commit dbe7a61be2beac50d1665e38ac374cefbbabec00)
(cherry picked from commit c2faa48abce1d656527b89f601e084e3ba70e36d)

10 years agoFix debug message to show correct function name.
Jeremy Allison [Sat, 6 Sep 2008 03:40:02 +0000 (20:40 -0700)]
Fix debug message to show correct function name.
Jeremy.
(cherry picked from commit b2fcb8b6b17302e5ec29914f4e3dde853ffe5283)

10 years agoWrite times code update.
Jeremy Allison [Sat, 6 Sep 2008 02:01:09 +0000 (19:01 -0700)]
Write times code update.

Ok, here's the fix for the write times breakage
with the new tests in S4 smbtorture.

The key is keeping in the share mode struct
the "old_file_time" as the real write time,
set by all the write and allocation calls,
and the "changed_write_time" as the "sticky"
write time - set by the SET_FILE_TIME calls.

We can set them independently (although I
kept the optimization of not setting the
"old_file_time" is a "changed_write_time"
was already set, as we'll never see it.

This allows us to update the write time
immediately on the SMBwrite truncate case,
SET_END_OF_FILE and SET_ALLOCATION_SIZE calls,
whilst still have the 2 second delay on the
"normal" SMBwrite, SMBwriteX calls.

I think in a subsequent patch I'd like to
change the name of these from "old_file_time"
to "write_time" and "changed_write_time" to
"sticky_write_time" to make this clearer.

I think I also fixed a bug in Metze's original
code in that once a write timestamp had been
set from a "normal" SMBwriteX call the fsp->update_write_time_triggered
variable was set and then never reset - thus
meaning the write timestamp would never get
updated again on subsequent SMBwriteX's.

The new code checks the update_write_time_event
event instead, and doesn't update is there's
an event already scheduled.

Metze especially, please check this over for
your understanding.

Jeremy.
(cherry picked from commit f2fb6321b6666a30ca7fa11bc8d395f1a1865bb2)

10 years agoWHATSNEW: Update changes since 3.2.3.
Karolin Seeger [Mon, 8 Sep 2008 10:42:52 +0000 (12:42 +0200)]
WHATSNEW: Update changes since 3.2.3.

Karolin
(cherry picked from commit 9082c77af4fb9fda6bb0a85810e454302130a71f)

10 years agoRemove unecessary msync.
Jeremy Allison [Fri, 5 Sep 2008 22:35:04 +0000 (15:35 -0700)]
Remove unecessary msync.
Jeremy.
(cherry picked from commit d7eab4b20af47401d281dd672e012d4eb96e5f4a)

10 years agoFix a memleak
Qiao Yang [Fri, 5 Sep 2008 12:08:09 +0000 (14:08 +0200)]
Fix a memleak

request.extra_data is not freed if there is no extra_data in response or
when there is some error happens in processing. This patch will free the
buffer right after processing a request before sending back a response.
(cherry picked from commit be6f12273f171a3eb1967d2299064e57d737f6a4)
(cherry picked from commit 72865f5e4ff30861d58b928baaf7be3373301f37)

10 years agoDo proper error handling if the socket is closed
Volker Lendecke [Fri, 5 Sep 2008 09:48:36 +0000 (11:48 +0200)]
Do proper error handling if the socket is closed

This is a step in fixing bug 5707.

Thanks to Igor Galić <i.galic@brainsware.org> for reporting!

Volker
(cherry picked from commit 1558a5c1977b1f87600ec487238fa8db009f41fd)

10 years agorun "make idl" after after idl change "Handle arbitrary new PAC types"
Michael Adam [Tue, 26 Aug 2008 15:19:33 +0000 (17:19 +0200)]
run "make idl" after after idl change "Handle arbitrary new PAC types"

Michael
(cherry picked from commit cc54b4d74171d27e7a0b09aff0376804ac7ab69b)

10 years agoHandle arbitrary new PAC types
Andrew Tridgell [Sun, 24 Aug 2008 04:00:58 +0000 (14:00 +1000)]
Handle arbitrary new PAC types

When MS introduces a new PAC type, we should just ignore it, not
generate a parse error. New PAC info structures are supposed to be
backwards compatible with old ones
(cherry picked from commit 2971b926c835412b02c93ad1e30f1471bc0a3612)
(cherry picked from commit 843e9ebbf63f84270f8638a8e79538523b2148a8)

10 years agore-run make idl after Jelmer's "poperly cast array lengths" pidl change.
Michael Adam [Tue, 26 Aug 2008 15:17:14 +0000 (17:17 +0200)]
re-run make idl after Jelmer's "poperly cast array lengths" pidl change.

(f321240fa91fa19c1131f119c42f64897d220682)

Michael
(cherry picked from commit cd3f4ee593e606e48cd104df222f8bda8e370a58)

10 years agofixed an errno handling bug that could lead to an infinite loop
Andrew Tridgell [Sun, 24 Aug 2008 03:53:19 +0000 (13:53 +1000)]
fixed an errno handling bug that could lead to an infinite loop
(cherry picked from commit 5ccdc58ce91ee40ca7171dd040191291aeb7fe02)
(cherry picked from commit 1361caecb355047001f8a351ec2e6f10d7f0e741)

10 years agofixed tsmsm_sendfile(). The logic was totally broken.
Andrew Tridgell [Sat, 23 Aug 2008 01:36:27 +0000 (11:36 +1000)]
fixed tsmsm_sendfile(). The logic was totally broken.
(cherry picked from commit 794e48b809036871287df8416a2c669b7e26f216)
(cherry picked from commit 3ce3f7f58402b98ce386bab1c40988e5ccd40d15)

10 years agoconfigure: fix typo in GNU ld version-script test.
Michael Adam [Fri, 5 Sep 2008 09:39:38 +0000 (11:39 +0200)]
configure: fix typo in GNU ld version-script test.

Michael
(cherry picked from commit 0d9f3dfc4c139938ee57b6cf60c29cf4ce404be7)
(cherry picked from commit 2381ec3b3f6a4798c15f4d3f3aee8caea8f48941)

10 years agoFix winbindd crash bug with trusted domains. Bug #5736
James Ding [Thu, 4 Sep 2008 22:17:18 +0000 (15:17 -0700)]
Fix winbindd crash bug with trusted domains. Bug #5736
(cherry picked from commit 2d84b9a1024f68657f75aa7e0c4091b8c7afd194)

10 years agoget rid of unneeded argument for get_alloc_methods as well
Herb Lewis [Thu, 4 Sep 2008 21:32:09 +0000 (14:32 -0700)]
get rid of unneeded argument for get_alloc_methods as well
(cherry picked from commit 59415cb8b3ce7981dbf576086e13675f343581a4)

10 years agoget rid of unneeded argument for get_methods
Herb Lewis [Thu, 4 Sep 2008 20:58:06 +0000 (13:58 -0700)]
get rid of unneeded argument for get_methods
(cherry picked from commit 2a085d5343ab954e1bd60c11033506dc7c9040e3)

10 years agoCleanup of DC enumeration in get_dcs()
Steven Danneman [Thu, 4 Sep 2008 19:05:13 +0000 (12:05 -0700)]
Cleanup of DC enumeration in get_dcs()

This is a fix for a few small inefficiencies/bugs in the get_dcs() path.

* because the third add_one_dc_unique() loop was outside the ADS check all DCs
  returned from the non-sitename lookup were being tacked onto the dc_name_ip
  list twice.
* add_one_dc_unique() now checks if the given IP address already exists before
  adding it to the list, making the returned list actually unique
* added more thorough doxygen comment headers
(cherry picked from commit edd234e7a22dab105256f90df36d86f168dcea4c)

10 years agokerberos: fix indent of enc type lines in generated krb5.conf files.
Günther Deschner [Thu, 4 Sep 2008 13:11:22 +0000 (15:11 +0200)]
kerberos: fix indent of enc type lines in generated krb5.conf files.

Guenther
(cherry picked from commit 18a26f08b6fab4119a1421a7ca59c32dde8bb8cb)
(cherry picked from commit 8d6220a94667c5906ead5fa80b6afabc82159b53)

10 years agoFix bug #5729. Explicitly allow "-valid".
Jeremy Allison [Wed, 3 Sep 2008 20:06:20 +0000 (13:06 -0700)]
Fix bug #5729. Explicitly allow "-valid".
Jeremy
(cherry picked from commit 96b5e691149c449253e4875a743c8603b3298c2b)

10 years agoThe msync manpage reports that msync *must* be called before munmap. Failure to do...
Simo Sorce [Wed, 3 Sep 2008 14:44:09 +0000 (10:44 -0400)]
The msync manpage reports that msync *must* be called before munmap. Failure to do so may result in lost data. Fix an ifdef check, I really think we meant to check HAVE_MMAP here.
(cherry picked from commit bfced01a92ae1a4913c0c9aba27e7b43e06f9032)

10 years agoFix Coverity ID 587
Volker Lendecke [Mon, 1 Sep 2008 11:46:27 +0000 (13:46 +0200)]
Fix Coverity ID 587

The following test program prints "8" on 64-bit :-)

static void print_size(const char lenbuf[4])
{
        printf("sizeof(lenbuf) = %d\n", (int)sizeof(lenbuf));
}
int main(void)
{
        const char lenbuf[4];
        print_size(lenbuf);
        return 0;
}

Jeremy, please check :-)

Volker
(cherry picked from commit 9daea0ccfdda58450be3c9a9a94c016f5900c319)
(cherry picked from commit 11fdeeeb551ac3287b75e114b15bc4f76cf2d337)

10 years agoAdd workaround for docs build and dependency on parameters.all.xml
Gerald (Jerry) Carter [Mon, 25 Aug 2008 21:08:28 +0000 (16:08 -0500)]
Add workaround for docs build and dependency on parameters.all.xml
(cherry picked from commit d4f5b5255f9b95050ddd9d67bd3958402be77918)
(cherry picked from commit c8154142d97ccf973feb36d77f932c893fda0af5)
(cherry picked from commit c91e7e9f7f392d5ba850619395eddac34617f1e4)
(cherry picked from commit bdb0a5d5fdbc331e11391f7b6e0aae963cebd3fc)
(cherry picked from commit babe47a0ca130888eb478e2f5ff8d5ec04810938)

10 years agoRelease scripts: Update create-tarball to include docs and other packaging details.
Gerald W. Carter [Tue, 27 May 2008 21:27:21 +0000 (16:27 -0500)]
Release scripts: Update create-tarball to include docs and other packaging details.

I've updated the create-tarball script to support command line options,
docs build (or copy and existing build), and to run the packaging update
scripts.

  $ release-scripts/create-tarball --help
  Usage release-scripts/create-tarball [options]
      --help             Print command usage
      --branch <name>    Specify the branch to to create the archive file from
      --copy-docs <dir>  Copy documentation from <dir> rather than building
      --tag <name>       Tag name for release
      --keyid <email>    The GnuPG key ID used to sign the release tag
(cherry picked from commit 7c96795e5954b6a716beb6f5a30d6c7bb1647717)
(cherry picked from commit 4a5830fb03152cf59f27c762046554eb6df5cb65)

10 years agoAdd simple script to build docs
Gerald (Jerry) Carter [Tue, 27 May 2008 17:00:00 +0000 (12:00 -0500)]
Add simple script to build docs
(cherry picked from commit 0865f4615d3ee91673dd6d02c6537765f34b3129)
(cherry picked from commit 16fe020367f3d63c4ff1391f265bdaa48764900f)

10 years agoDeal with systems that don't initialize birthtime correctly.
Jeremy Allison [Fri, 29 Aug 2008 16:29:35 +0000 (09:29 -0700)]
Deal with systems that don't initialize birthtime correctly.
Pointed out by SATOH Fumiyasu <fumiyas@osstech.jp>.
Jeremy.
(cherry picked from commit 4876e4ffe9f5142bf90dc14b105436eaca35d3f4)

10 years agoClarify usage of "force create mode".
Jeremy Allison [Thu, 28 Aug 2008 23:04:30 +0000 (16:04 -0700)]
Clarify usage of "force create mode".
Jeremy.
(cherry picked from commit 10f036829aca0b6b4cde03893f71effbf4d30a91)

10 years agoAdd st_birthtime and friends for accurate create times on systems that support it...
Jeremy Allison [Thu, 28 Aug 2008 19:09:06 +0000 (12:09 -0700)]
Add st_birthtime and friends for accurate create times on systems that support it (*BSD and MacOSX). This really needs to be in 3.2.x.
Should have done this ages ago, sorry.
Jeremy.
(cherry picked from commit 0cba30073410ba499834ac26dee3f81a75c8de4f)

10 years agowinbindd: fix invalid sid copy (hit when enumerating sibling domains).
Günther Deschner [Thu, 28 Aug 2008 10:29:24 +0000 (12:29 +0200)]
winbindd: fix invalid sid copy (hit when enumerating sibling domains).

Guenther
(cherry picked from commit 5eee7423351ffd05486e33ff8eb905babcbc9422)
(cherry picked from commit 9f0bc4ff17b5a11dc412d0b5bc136476f3209a0c)

10 years agoFix the wcache_invalidate_samlogon calls.
Jeremy Allison [Thu, 28 Aug 2008 00:26:59 +0000 (17:26 -0700)]
Fix the wcache_invalidate_samlogon calls.
Jeremy.
(cherry picked from commit 0a0795fd0310cc44dac0df312325df6d08e38cdb)

10 years agoCorrect the netsamlogon_clear_cached_user function.
Ephi Dror [Thu, 28 Aug 2008 00:26:36 +0000 (17:26 -0700)]
Correct the netsamlogon_clear_cached_user function.
(cherry picked from commit 85dd9c64ca2ffa31d02ee10a3745fd596e80786e)

10 years agoBe explicit about setting perms for the ldb. Helps others who may use this api.
Jeremy Allison [Wed, 27 Aug 2008 18:30:02 +0000 (11:30 -0700)]
Be explicit about setting perms for the ldb. Helps others who may use this api.
Jeremy.
(cherry picked from commit 9f1bb27bf566069dab48eea125c22a5e20849774)

10 years ago mount.cifs: unclear error message with "credentials"
Steve French [Tue, 26 Aug 2008 18:04:44 +0000 (13:04 -0500)]
mount.cifs: unclear error message with "credentials"

Thanks to Christophe Curis for the suggestion
(cherry picked from commit a122df5dc01ed9767c53d77a73aabd44f7c8a7ca)

10 years agobecome root for AIO operations
Andrew Tridgell [Sun, 24 Aug 2008 03:58:05 +0000 (13:58 +1000)]
become root for AIO operations

We need to become root for AIO read and write to allow the AIO thread
to send a completion signal to the parent process when the IO
completes
(cherry picked from commit 27b1ae601542ebe2e23ab4ff81eb14f8e03a3caf)

10 years agoEINVAL is also a valid error return, meaning "this filesystem
Andrew Tridgell [Tue, 26 Aug 2008 04:06:42 +0000 (14:06 +1000)]
EINVAL is also a valid error return, meaning "this filesystem
cannot do sendfile for this file"
(cherry picked from commit dc04b5adf7569b3501cb95f86d01e00276b41c23)

10 years agoAvoid a race condition in glibc between AIO and setresuid().
Andrew Tridgell [Sun, 24 Aug 2008 03:56:59 +0000 (13:56 +1000)]
Avoid a race condition in glibc between AIO and setresuid().

See this test: http://samba.org/~tridge/junkcode/aio_uid.c

The problem is that setresuid() tries to be clever about threads, and
tries to change the euid of any threads that are running. If a AIO read
or write completes while this is going on then the signal from the thread
where the IO completed is lost, as it gets -1/EPERM from rt_sigqueueinfo()

The simplest fix is to try to use setreuid() instead of setresuid(),
as setreuid() doesn't try to be clever. Unfortunately this also means
we must use become_root()/unbecome_root() in the aio code.
(cherry picked from commit 319cea52d259e347061658cfbae56ab350b09671)

10 years agoFix bug 4516, no IPv6 on Solaris 2.6.
David Leonard [Mon, 25 Aug 2008 22:15:35 +0000 (15:15 -0700)]
Fix bug 4516, no IPv6 on Solaris 2.6.
(cherry picked from commit ec178599d37d6633697650c54c3588afedea9b7e)

10 years agocifs.upcall: bump SPNEGO msg version number and don't reject old versions
Jeff Layton [Sun, 24 Aug 2008 21:31:49 +0000 (17:31 -0400)]
cifs.upcall: bump SPNEGO msg version number and don't reject old versions

When we added the ability for the kernel to send sec=mskrb5 to the
upcall, we subtly broke old cifs.upcall versions that don't understand
it. Bump the spnego message version to 2 to make this clear. Also,
change cifs.upcall to not reject requests with a version that's lower
than the current one, and to send the reply with the same version that
the request sent. The idea is to try and keep cifs.upcall backward
compatible with old kernels.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit 2744bcbf3f22102911b5a3c4676e7d2f970a86eb)

10 years agoDon't re-initialize a token when we already have one. This fixes the build farm failu...
Jeremy Allison [Fri, 22 Aug 2008 20:50:53 +0000 (13:50 -0700)]
Don't re-initialize a token when we already have one. This fixes the build farm failures when winbindd connects as guest.
This one took a *lot* of tracking down :-).
Jeremy.
(cherry picked from commit f845c95dcfa0b1630a0057c62941bb8a72ebdd83)

10 years agowinbindd: Fix crash in cm_connect_sam()
Gerald (Jerry) Carter [Fri, 22 Aug 2008 15:17:04 +0000 (10:17 -0500)]
winbindd: Fix crash in cm_connect_sam()

Fix segv when talking to parent DC (joined to child domain).

The root cause was

(a) storing the parent domain in the cli_state struct caused
    the NTLMSSP pipe bind to fail which made us fallover to
    the schannel code path
(b) the dcinfo pointer in cm_get_schannel_dcinfo() was returning
    NULL even though the function indicated success.
(cherry picked from commit 5ce4a2ae6697970ea37d0078a506615b4b7a9a9c)
(cherry picked from commit 72d138adc200ab36e324721900af1a06d0879318)

10 years agocifs.upcall: fix build warning
Jeff Layton [Fri, 22 Aug 2008 01:41:19 +0000 (21:41 -0400)]
cifs.upcall: fix build warning

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit dffb2d8eea03bb75224c3d8b4d0ab210993c645a)

10 years agoFix Bug #5710 and make machine account password changing work again.
Günther Deschner [Thu, 21 Aug 2008 13:05:35 +0000 (15:05 +0200)]
Fix Bug #5710 and make machine account password changing work again.

When we negotiated NETLOGON_NEG_PASSWORD_SET2 we need to use
NetrServerPasswordSet2 to change the machine password.

Tested with NT4, W2k, W2k3 and W2k8.

Guenther
(cherry picked from commit 8ae7040a5e64f1a1d2088aeca1dab90470455d8a)

10 years agore-run make idl.
Günther Deschner [Thu, 21 Aug 2008 13:02:03 +0000 (15:02 +0200)]
re-run make idl.

Guenther
(cherry picked from commit f24cef9fa7be45212744d39b7c66804e64147afd)
(cherry picked from commit 059979f8e7d7d0459f83184ad5b06a8e6281f558)

10 years agoIDL: fix IDL for netr_ServerPasswordSet2().
Günther Deschner [Thu, 21 Aug 2008 13:01:36 +0000 (15:01 +0200)]
IDL: fix IDL for netr_ServerPasswordSet2().

Guenther
(cherry picked from commit 7b312a0abc6de5a51555ccfbde7f8f78fc11d043)
(cherry picked from commit d9fa27a079dde0ebd9c2d6dc1c1bff3ae570f9e8)

10 years agoFix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegsch...
Jeremy Allison [Thu, 21 Aug 2008 17:25:51 +0000 (10:25 -0700)]
Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegscheid@whirlpool.com>.
Jeremy.
(cherry picked from commit 02e260ab5254c9691846f7009f685e1b11032f80)

10 years agobuild: fix bug #5590 by not linking in the static libs but the objects.
Michael Adam [Wed, 20 Aug 2008 12:56:18 +0000 (14:56 +0200)]
build: fix bug #5590 by not linking in the static libs but the objects.

Michael
(cherry picked from commit 6ad2090391a92ebe822b2d7b80e180c251dc8e7a)
(cherry picked from commit 24459c7eda080a4fed2d4f2a576c97f878f905f9)

10 years agobuild: fall down to the same place when using an internal lib statically.
Michael Adam [Wed, 20 Aug 2008 12:55:24 +0000 (14:55 +0200)]
build: fall down to the same place when using an internal lib statically.

Michael
(cherry picked from commit 702c0bc04668117e3521d687b9b5a87fd7e0f1b1)
(cherry picked from commit f3ad03d0f909ff862411511d9f63e77047034c01)

10 years agobuild: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency.
Michael Adam [Wed, 20 Aug 2008 11:22:13 +0000 (13:22 +0200)]
build: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency.

Michael
(cherry picked from commit ead9b9d7167d999d73cf4111f3b321236aac2a15)
(cherry picked from commit 8dd57f31b2ba621654f989e1ed58bd2dd80b7849)

10 years agofix build warning.
Günther Deschner [Wed, 20 Aug 2008 16:40:58 +0000 (18:40 +0200)]
fix build warning.

Guenther
(cherry picked from commit a75055be5ff7ebe3476cfac86c6597a56a843c23)
(cherry picked from commit d0a4b9f69984ca5da0007af91013f1bc78dcbf2b)

10 years agofix another build warning.
Günther Deschner [Wed, 20 Aug 2008 18:24:45 +0000 (20:24 +0200)]
fix another build warning.

Guenther
(cherry picked from commit 43693ce6c678b961fa516bbf502af92f87cd5346)
(cherry picked from commit 2a5ae59f77c05c41c97747dee9bc8c196dfe6b89)

10 years agonss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT
Gerald (Jerry) Carter [Wed, 20 Aug 2008 18:00:40 +0000 (13:00 -0500)]
nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT

According to the GNU libc nss guide, we should always set
errno to ENOENT when returning NSS_UNAVAIL.

http://www.gnu.org/software/libtool/manual/libc/NSS-Modules-Interface.html#NSS-Modules-Interface

At least the MQ Series message queing service that runs
on WebSphere will fail if you return any other errno in this case.
(cherry picked from commit ee26664602445fa7798e2061f6bcbef0756d6528)
(cherry picked from commit 29b39723b82f363d32dc4678d6b71a78485c65ce)

10 years agosmbd: fix the handling of create_options to pass RAW-OPEN
Stefan Metzmacher [Tue, 19 Aug 2008 14:34:50 +0000 (16:34 +0200)]
smbd: fix the handling of create_options to pass RAW-OPEN

Some of the bits generate INVALID_PARAMETER and some bits
are ignored when they come from a client, that's why we need
to use bits from the ignored range for our internal usage.

metze
(cherry picked from commit 7b4c8a4e39f310eb450918fa841b0ea1b4af19f7)
(cherry picked from commit 3366ac2857820d87fb36a1357786a3564d258da5)

10 years agocifs.upcall: handle MSKRB5 OID properly
Jeff Layton [Wed, 20 Aug 2008 01:35:35 +0000 (21:35 -0400)]
cifs.upcall: handle MSKRB5 OID properly

When the kernel sends the upcall a sec=mskrb5 parameter, that means
the the MSKRB5 OID is preferred by the server. This patch fixes the
upcall to use that OID in place of the "normal" krb5 OID when it
gets a sec=mskrb5 parameter.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <smfrench@gmail.com>
(cherry picked from commit 3d96409c115b3ad4ef29ff75e40b39a26e316afe)

10 years agoFix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address
Jeremy Allison [Wed, 20 Aug 2008 00:31:46 +0000 (17:31 -0700)]
Fix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address
reported by Ted Percival <ted@midg3t.net>.
Jeremy.
(cherry picked from commit 4ac537d1b78c915fe25c219958312cf22f3cba80)

10 years agobuild: fix linking cifs.upcall when nscd_flush_cache() is found.
Michael Adam [Tue, 19 Aug 2008 11:29:24 +0000 (13:29 +0200)]
build: fix linking cifs.upcall when nscd_flush_cache() is found.

Michael
(cherry picked from commit 661b7fdffda40a9ca7cb36627dbaf91cb4357cd0)
(cherry picked from commit 7401c6a5b74c9c82c02923e6eafa6072a5d5678f)

10 years agoVERSION: Raise version number up tp 3.2.4.
Karolin Seeger [Thu, 28 Aug 2008 14:04:42 +0000 (16:04 +0200)]
VERSION: Raise version number up tp 3.2.4.

Karolin

10 years agoldb: Fix permissions of new ldg files. release-3-2-3
Karolin Seeger [Wed, 27 Aug 2008 11:23:20 +0000 (13:23 +0200)]
ldb: Fix permissions of new ldg files.

This one fixes together with 2eaf4ed62 bug #5715 and CVE-2008-3789.

Thanks to Steve Langasek <vorlon@debian.org> for reporting!

Karolin

10 years agoWHATSNEW: Add updates for 3.2.3.
Karolin Seeger [Wed, 27 Aug 2008 09:09:54 +0000 (11:09 +0200)]
WHATSNEW: Add updates for 3.2.3.

Karolin

10 years agoldb: Fix permissions of group_mapping.ldb.
Andrew Tridgell [Wed, 27 Aug 2008 08:45:43 +0000 (10:45 +0200)]
ldb: Fix permissions of group_mapping.ldb.

This one fixes bug #5715 and CVE-2008-3789.

10 years agoRevert "build: fix linking cifs.upcall when nscd_flush_cache() is found."
Karolin Seeger [Wed, 27 Aug 2008 08:38:42 +0000 (10:38 +0200)]
Revert "build: fix linking cifs.upcall when nscd_flush_cache() is found."

This reverts commit a7058ed1ef2622abdb75fe997ce4a5c570898929.

10 years agoRevert "Fix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4...
Karolin Seeger [Wed, 27 Aug 2008 08:38:35 +0000 (10:38 +0200)]
Revert "Fix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address"

This reverts commit 435c10268bb6987ab7e8206cd6c45bd9961c5632.

10 years agoRevert "cifs.upcall: handle MSKRB5 OID properly"
Karolin Seeger [Wed, 27 Aug 2008 08:38:25 +0000 (10:38 +0200)]
Revert "cifs.upcall: handle MSKRB5 OID properly"

This reverts commit 64ebfe4b2e5b7e3e07a0af424b35000693148e48.

10 years agoRevert "smbd: fix the handling of create_options to pass RAW-OPEN"
Karolin Seeger [Wed, 27 Aug 2008 08:38:18 +0000 (10:38 +0200)]
Revert "smbd: fix the handling of create_options to pass RAW-OPEN"

This reverts commit ebd1f8f9297b31353d094ddccc320a83f02877ce.

10 years agoRevert "nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT"
Karolin Seeger [Wed, 27 Aug 2008 08:38:08 +0000 (10:38 +0200)]
Revert "nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT"

This reverts commit 15e8e23466ae959bd0efc540c287338dbcd0b7a6.

10 years agoRevert "fix another build warning."
Karolin Seeger [Wed, 27 Aug 2008 08:38:00 +0000 (10:38 +0200)]
Revert "fix another build warning."

This reverts commit e3ff1cb7709d93fb91602d3d25deca3f4ecce2ce.

10 years agoRevert "fix build warning."
Karolin Seeger [Wed, 27 Aug 2008 08:37:49 +0000 (10:37 +0200)]
Revert "fix build warning."

This reverts commit c48f247d76569bfdc844499cc64f504bce7085cd.

10 years agoRevert "build: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency."
Karolin Seeger [Wed, 27 Aug 2008 08:37:41 +0000 (10:37 +0200)]
Revert "build: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency."

This reverts commit eb892f90c9be0ebc2217fc459d4249190986c003.

10 years agoRevert "build: fall down to the same place when using an internal lib statically."
Karolin Seeger [Wed, 27 Aug 2008 08:37:30 +0000 (10:37 +0200)]
Revert "build: fall down to the same place when using an internal lib statically."

This reverts commit 8145b0a7d7bacb818b8dadadae65ecd0877b5ce2.

10 years agoRevert "build: fix bug #5590 by not linking in the static libs but the objects."
Karolin Seeger [Wed, 27 Aug 2008 08:37:22 +0000 (10:37 +0200)]
Revert "build: fix bug #5590 by not linking in the static libs but the objects."

This reverts commit ef801d12a309c4c9f6429739b835fb32f5c309b8.

10 years agoRevert "Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_...
Karolin Seeger [Wed, 27 Aug 2008 08:36:58 +0000 (10:36 +0200)]
Revert "Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegscheid@whirlpool.com>."

This reverts commit 3c205320cd1eb19ed275572f975487e92c611f13.

10 years agoRevert "IDL: fix IDL for netr_ServerPasswordSet2()."
Karolin Seeger [Wed, 27 Aug 2008 08:36:51 +0000 (10:36 +0200)]
Revert "IDL: fix IDL for netr_ServerPasswordSet2()."

This reverts commit 7a53e1e83a070394f77da4a0f7b2ed480165c376.

10 years agoRevert "re-run make idl."
Karolin Seeger [Wed, 27 Aug 2008 08:36:31 +0000 (10:36 +0200)]
Revert "re-run make idl."

This reverts commit 94dd61a4e8e070e175339defce4da08eaf87429d.

10 years agoRevert "Fix Bug #5710 and make machine account password changing work again."
Karolin Seeger [Wed, 27 Aug 2008 08:36:20 +0000 (10:36 +0200)]
Revert "Fix Bug #5710 and make machine account password changing work again."

This reverts commit 6d42b1e372b67eba83dbd5200bfb131b74cac180.

10 years agoRevert "cifs.upcall: fix build warning"
Karolin Seeger [Wed, 27 Aug 2008 08:36:10 +0000 (10:36 +0200)]
Revert "cifs.upcall: fix build warning"

This reverts commit b3a8b823361d6144f14c2d800e956f26ff9ad6d6.

10 years agoRevert "winbindd: Fix crash in cm_connect_sam()"
Karolin Seeger [Wed, 27 Aug 2008 08:36:00 +0000 (10:36 +0200)]
Revert "winbindd: Fix crash in cm_connect_sam()"

This reverts commit 9bbd6ee5db03747499bd263bb1365c8cd352076d.

10 years agoRevert "Don't re-initialize a token when we already have one. This fixes the build...
Karolin Seeger [Wed, 27 Aug 2008 08:35:51 +0000 (10:35 +0200)]
Revert "Don't re-initialize a token when we already have one. This fixes the build farm failures when winbindd connects as guest."

This reverts commit a90648e905aebc98c78897adf76729bea269cedf.

10 years agoDon't re-initialize a token when we already have one. This fixes the build farm failu...
Jeremy Allison [Fri, 22 Aug 2008 20:50:53 +0000 (13:50 -0700)]
Don't re-initialize a token when we already have one. This fixes the build farm failures when winbindd connects as guest.
This one took a *lot* of tracking down :-).
Jeremy.
(cherry picked from commit f845c95dcfa0b1630a0057c62941bb8a72ebdd83)

10 years agowinbindd: Fix crash in cm_connect_sam()
Gerald (Jerry) Carter [Fri, 22 Aug 2008 15:17:04 +0000 (10:17 -0500)]
winbindd: Fix crash in cm_connect_sam()

Fix segv when talking to parent DC (joined to child domain).

The root cause was

(a) storing the parent domain in the cli_state struct caused
    the NTLMSSP pipe bind to fail which made us fallover to
    the schannel code path
(b) the dcinfo pointer in cm_get_schannel_dcinfo() was returning
    NULL even though the function indicated success.
(cherry picked from commit 5ce4a2ae6697970ea37d0078a506615b4b7a9a9c)
(cherry picked from commit 72d138adc200ab36e324721900af1a06d0879318)

10 years agocifs.upcall: fix build warning
Jeff Layton [Fri, 22 Aug 2008 01:41:19 +0000 (21:41 -0400)]
cifs.upcall: fix build warning

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit dffb2d8eea03bb75224c3d8b4d0ab210993c645a)

10 years agoFix Bug #5710 and make machine account password changing work again.
Günther Deschner [Thu, 21 Aug 2008 13:05:35 +0000 (15:05 +0200)]
Fix Bug #5710 and make machine account password changing work again.

When we negotiated NETLOGON_NEG_PASSWORD_SET2 we need to use
NetrServerPasswordSet2 to change the machine password.

Tested with NT4, W2k, W2k3 and W2k8.

Guenther
(cherry picked from commit 8ae7040a5e64f1a1d2088aeca1dab90470455d8a)

10 years agore-run make idl.
Günther Deschner [Thu, 21 Aug 2008 13:02:03 +0000 (15:02 +0200)]
re-run make idl.

Guenther
(cherry picked from commit f24cef9fa7be45212744d39b7c66804e64147afd)
(cherry picked from commit 059979f8e7d7d0459f83184ad5b06a8e6281f558)

10 years agoIDL: fix IDL for netr_ServerPasswordSet2().
Günther Deschner [Thu, 21 Aug 2008 13:01:36 +0000 (15:01 +0200)]
IDL: fix IDL for netr_ServerPasswordSet2().

Guenther
(cherry picked from commit 7b312a0abc6de5a51555ccfbde7f8f78fc11d043)
(cherry picked from commit d9fa27a079dde0ebd9c2d6dc1c1bff3ae570f9e8)

10 years agoFix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegsch...
Jeremy Allison [Thu, 21 Aug 2008 17:25:51 +0000 (10:25 -0700)]
Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegscheid@whirlpool.com>.
Jeremy.
(cherry picked from commit 02e260ab5254c9691846f7009f685e1b11032f80)

10 years agobuild: fix bug #5590 by not linking in the static libs but the objects.
Michael Adam [Wed, 20 Aug 2008 12:56:18 +0000 (14:56 +0200)]
build: fix bug #5590 by not linking in the static libs but the objects.

Michael
(cherry picked from commit 6ad2090391a92ebe822b2d7b80e180c251dc8e7a)
(cherry picked from commit 24459c7eda080a4fed2d4f2a576c97f878f905f9)

10 years agobuild: fall down to the same place when using an internal lib statically.
Michael Adam [Wed, 20 Aug 2008 12:55:24 +0000 (14:55 +0200)]
build: fall down to the same place when using an internal lib statically.

Michael
(cherry picked from commit 702c0bc04668117e3521d687b9b5a87fd7e0f1b1)
(cherry picked from commit f3ad03d0f909ff862411511d9f63e77047034c01)

10 years agobuild: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency.
Michael Adam [Wed, 20 Aug 2008 11:22:13 +0000 (13:22 +0200)]
build: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency.

Michael
(cherry picked from commit ead9b9d7167d999d73cf4111f3b321236aac2a15)
(cherry picked from commit 8dd57f31b2ba621654f989e1ed58bd2dd80b7849)

10 years agofix build warning.
Günther Deschner [Wed, 20 Aug 2008 16:40:58 +0000 (18:40 +0200)]
fix build warning.

Guenther
(cherry picked from commit a75055be5ff7ebe3476cfac86c6597a56a843c23)
(cherry picked from commit d0a4b9f69984ca5da0007af91013f1bc78dcbf2b)

10 years agofix another build warning.
Günther Deschner [Wed, 20 Aug 2008 18:24:45 +0000 (20:24 +0200)]
fix another build warning.

Guenther
(cherry picked from commit 43693ce6c678b961fa516bbf502af92f87cd5346)
(cherry picked from commit 2a5ae59f77c05c41c97747dee9bc8c196dfe6b89)

10 years agonss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT
Gerald (Jerry) Carter [Wed, 20 Aug 2008 18:00:40 +0000 (13:00 -0500)]
nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT

According to the GNU libc nss guide, we should always set
errno to ENOENT when returning NSS_UNAVAIL.

http://www.gnu.org/software/libtool/manual/libc/NSS-Modules-Interface.html#NSS-Modules-Interface

At least the MQ Series message queing service that runs
on WebSphere will fail if you return any other errno in this case.
(cherry picked from commit ee26664602445fa7798e2061f6bcbef0756d6528)
(cherry picked from commit 29b39723b82f363d32dc4678d6b71a78485c65ce)

10 years agosmbd: fix the handling of create_options to pass RAW-OPEN
Stefan Metzmacher [Tue, 19 Aug 2008 14:34:50 +0000 (16:34 +0200)]
smbd: fix the handling of create_options to pass RAW-OPEN

Some of the bits generate INVALID_PARAMETER and some bits
are ignored when they come from a client, that's why we need
to use bits from the ignored range for our internal usage.

metze
(cherry picked from commit 7b4c8a4e39f310eb450918fa841b0ea1b4af19f7)
(cherry picked from commit 3366ac2857820d87fb36a1357786a3564d258da5)

10 years agocifs.upcall: handle MSKRB5 OID properly
Jeff Layton [Wed, 20 Aug 2008 01:35:35 +0000 (21:35 -0400)]
cifs.upcall: handle MSKRB5 OID properly

When the kernel sends the upcall a sec=mskrb5 parameter, that means
the the MSKRB5 OID is preferred by the server. This patch fixes the
upcall to use that OID in place of the "normal" krb5 OID when it
gets a sec=mskrb5 parameter.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <smfrench@gmail.com>
(cherry picked from commit 3d96409c115b3ad4ef29ff75e40b39a26e316afe)

10 years agoFix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address
Jeremy Allison [Wed, 20 Aug 2008 00:31:46 +0000 (17:31 -0700)]
Fix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address
reported by Ted Percival <ted@midg3t.net>.
Jeremy.
(cherry picked from commit 4ac537d1b78c915fe25c219958312cf22f3cba80)

10 years agobuild: fix linking cifs.upcall when nscd_flush_cache() is found.
Michael Adam [Tue, 19 Aug 2008 11:29:24 +0000 (13:29 +0200)]
build: fix linking cifs.upcall when nscd_flush_cache() is found.

Michael
(cherry picked from commit 661b7fdffda40a9ca7cb36627dbaf91cb4357cd0)
(cherry picked from commit 7401c6a5b74c9c82c02923e6eafa6072a5d5678f)

10 years agoWHATSNEW: Start WHATSNEW for 3.2.3.
Karolin Seeger [Tue, 19 Aug 2008 09:36:45 +0000 (11:36 +0200)]
WHATSNEW: Start WHATSNEW for 3.2.3.

Karolin
(cherry picked from commit efbd263131228281eca30d7834de52502d2806d6)

10 years agoVERSION: Raise version number up to 3.2.3.
Karolin Seeger [Tue, 19 Aug 2008 09:35:27 +0000 (11:35 +0200)]
VERSION: Raise version number up to 3.2.3.

Karolin
(cherry picked from commit 902349b956e26f4f9255045162ce5310c44a4166)

10 years agoFix length error in wrapping spnego blob. Karoling this needs to be in 3.2.2 (sorry). release-3-2-2
Igor Mammedov [Mon, 18 Aug 2008 16:55:44 +0000 (09:55 -0700)]
Fix length error in wrapping spnego blob. Karoling this needs to be in 3.2.2 (sorry).
(cherry picked from commit e2caa65a698ca7109aa44656ff9399104cf0663b)