Günther Deschner [Thu, 28 Sep 2006 23:49:36 +0000 (23:49 +0000)]
r18985: Add parse_gpt_ini() to parse GPT.INI files using iniparser.
Guenther
Günther Deschner [Thu, 28 Sep 2006 23:13:15 +0000 (23:13 +0000)]
r18984: Removing ads_gpo_get_sysvol_gpt_version() which was just doing stupid
things.
Guenther
Günther Deschner [Thu, 28 Sep 2006 23:04:17 +0000 (23:04 +0000)]
r18983: Add some comments for the LDAP based GPO routines.
Guenther
Günther Deschner [Thu, 28 Sep 2006 21:33:54 +0000 (21:33 +0000)]
r18982: Move the gpo related functions to "libgpo".
Guenther
Gerald Carter [Thu, 28 Sep 2006 21:19:08 +0000 (21:19 +0000)]
r18981: * cleanup some vestiges of old cli_reg.c code and mark some TODO
items in cac_winreg.c
* Get 'net rpc registry enumerate' to list values again
* Fix winreg.idl QueryInfoKey(). The max_subkeysize is the
max_classlen (we previously had this correct in Samba3")
* fix valgrind error about uninitialized memory and use-before-set
on size value inmemset() call
* Fix key enumeration in 'net rpc registry enumerate'
* regenerate gen_dir files based on local pidl patches
Please note that the generated ndr files are from my local
copy of pidl. If you need to regenerate, please apply the
patch that I posted to the samba-technical list earlier today.
Jeremy Allison [Thu, 28 Sep 2006 18:08:03 +0000 (18:08 +0000)]
r18980: Be a little more intelligent about "startup_time",
move into the domain struct. Allow message to go online
to set this state and cope with removing it.
Jeremy.
Stefan Metzmacher [Thu, 28 Sep 2006 15:13:08 +0000 (15:13 +0000)]
r18976: follow the advice from "William Jojo" <jojowil@hvcc.edu>
and pass -bbigtoc also to the linker when building shared libs
metze
Stefan Metzmacher [Thu, 28 Sep 2006 14:08:44 +0000 (14:08 +0000)]
r18973: we should always set LDFLAGS and DYNEXP depending on the host_os
but disable building of shared libs and modules whe enable_shared != yes
Also make it easier to track down the problem with lost LDFLAGS values
on AIX.
metze
Günther Deschner [Thu, 28 Sep 2006 03:21:49 +0000 (03:21 +0000)]
r18969: Fix typo.
Guenther
Andrew Tridgell [Wed, 27 Sep 2006 23:31:53 +0000 (23:31 +0000)]
r18966: this bug affects Samba3 too. I'm actually surprised nobody has
reported that Samba3 on Solaris Sparc with the native compiler can't
join Windows domains. If it worked we were just lucky. I suspect it
just didn't work.
Gerald Carter [Wed, 27 Sep 2006 21:37:43 +0000 (21:37 +0000)]
r18964: fix 'net rpc registry save' to use the new wnireg client code
Gerald Carter [Wed, 27 Sep 2006 19:03:54 +0000 (19:03 +0000)]
r18963: * Move parts of registry headers that were still in
use to reg_objects.h
* Remove unused rpc headers
Gerald Carter [Wed, 27 Sep 2006 16:05:25 +0000 (16:05 +0000)]
r18962: * Add IDL for SaveKey() and RestoreKey() and regenerated
* Tested RegSaveKey() using win32 app. Apparently
this code has been brokne for a really long time.
Stefan Metzmacher [Wed, 27 Sep 2006 14:47:36 +0000 (14:47 +0000)]
r18961: merge from samba4:
fix caching of some configure tests AC_CACHE_CHECK()
*needs* '_cv_' in the shell var to do caching...
metze
Gerald Carter [Wed, 27 Sep 2006 14:32:18 +0000 (14:32 +0000)]
r18959: reformat using indent
Stefan Metzmacher [Wed, 27 Sep 2006 14:18:08 +0000 (14:18 +0000)]
r18958: merge from samba4:
we need to include unistd.h in system/network.h because
it contains the ioctl() prototype on some systems
and we need to make sure it gets included before socket_wrapper
defines ioctl swrap_ioctl
metze
Stefan Metzmacher [Wed, 27 Sep 2006 14:10:35 +0000 (14:10 +0000)]
r18956: fix -pie and -fPIE together with configure -C
metze
Stefan Metzmacher [Wed, 27 Sep 2006 13:52:14 +0000 (13:52 +0000)]
r18955: fix the build on solaris where unistd.h needs to be includes before
socket_wrapper defined ioctl swrap_ioctl
metze
Gerald Carter [Wed, 27 Sep 2006 13:24:57 +0000 (13:24 +0000)]
r18954: Fix segv in QueryValue and Enumvalue. regedit.exe now
is happy again when creating keys and values
Stefan Metzmacher [Wed, 27 Sep 2006 12:43:51 +0000 (12:43 +0000)]
r18953: sync socket_wrapper with samba4
metze
Stefan Metzmacher [Wed, 27 Sep 2006 12:43:08 +0000 (12:43 +0000)]
r18952: fix compiler warning (merge from samba4)
metze
Stefan Metzmacher [Wed, 27 Sep 2006 12:42:24 +0000 (12:42 +0000)]
r18951: socket_wrapper has only 16 interfaces anymore...
metze
Stefan Metzmacher [Wed, 27 Sep 2006 11:39:43 +0000 (11:39 +0000)]
r18950: I can't see where stropts.h and poll.h are needed
(I just removed the only reference to poll() in my last commit)
they were added in this commit, without make usage of them.
http://cvs.samba.org/cgi-bin/cvsweb/samba/source/configure.in.diff?r1=1.21&r2=1.22&f=h
http://cvs.samba.org/cgi-bin/cvsweb/samba/source/include/includes.h.diff?r1=1.105&r2=1.106&f=h
metze
Stefan Metzmacher [Wed, 27 Sep 2006 11:37:02 +0000 (11:37 +0000)]
r18949: use sys_usleep()
metze
Günther Deschner [Wed, 27 Sep 2006 04:37:34 +0000 (04:37 +0000)]
r18941: Minor cleanup in ads_parse_gpo().
Guenther
Gerald Carter [Wed, 27 Sep 2006 03:43:42 +0000 (03:43 +0000)]
r18940: Fix a few memory corruption bugs to make CreateKey() and DeleteKey() work
Andrew Tridgell [Wed, 27 Sep 2006 03:34:50 +0000 (03:34 +0000)]
r18939: don't rely on the umask being right in ldb creation. Both Samba3 and
Samba4 smbd force the umask to 0, which meant we ended up with ldb
being world writable.
This isn't really an ideal fix, as it means ldb no longer honors umask
(as it should do, like all good libraries).
Unfortunately the 'proper' fix is too complex for now
this also merges a tiny code style fix from s4 to s3
Andrew Tridgell [Wed, 27 Sep 2006 03:29:38 +0000 (03:29 +0000)]
r18938: fixed a group map bug reported by Jerry. The caller in mapping.c
relies on appending to this list. Unfortunately this can't be tested
using 'net groupmap'
Gerald Carter [Wed, 27 Sep 2006 02:26:03 +0000 (02:26 +0000)]
r18937: Protect against segc in the idmap winbindd child process
(the domain is NULL here)
Günther Deschner [Tue, 26 Sep 2006 23:43:58 +0000 (23:43 +0000)]
r18935: Make "netshareenum" work again. There is most probably a better way to
do this... Any pointers?
Guenther
Gerald Carter [Tue, 26 Sep 2006 22:39:40 +0000 (22:39 +0000)]
r18934: fix a segv in CreateKey()
Gerald Carter [Tue, 26 Sep 2006 22:03:52 +0000 (22:03 +0000)]
r18932: In RegEnumvalue() and RegQueryValue(), the output buffer
size must match the real value of the data.
Gerald Carter [Tue, 26 Sep 2006 21:01:57 +0000 (21:01 +0000)]
r18931: * Fix the IDL for QueryInfoKey. teh Classname in an
in,out ref pointer
* Clarify variable names in EnumValue IDL
* Fix server code for _winreg_EnumValue() and _winreg_QueryInfoKe()
Gerald Carter [Tue, 26 Sep 2006 19:37:37 +0000 (19:37 +0000)]
r18929: * Clarify QueryValue IDL and regenerate code
* Fix server _winreg_Query_Value() implementation so that
usrmgr.exe starts now
Günther Deschner [Tue, 26 Sep 2006 19:12:39 +0000 (19:12 +0000)]
r18928: Some more const for iniparser.
Guenther
Gerald Carter [Tue, 26 Sep 2006 18:31:47 +0000 (18:31 +0000)]
r18927: Fix build. *please* compile the code at least once before checking it in.
Günther Deschner [Tue, 26 Sep 2006 17:22:15 +0000 (17:22 +0000)]
r18926: Add some useful macros.
Guenther
Günther Deschner [Tue, 26 Sep 2006 16:35:34 +0000 (16:35 +0000)]
r18924: Minor cleanup.
Guenther
Günther Deschner [Tue, 26 Sep 2006 16:27:18 +0000 (16:27 +0000)]
r18923: Fix more memleaks.
Guenther
Günther Deschner [Tue, 26 Sep 2006 16:26:43 +0000 (16:26 +0000)]
r18922: Apply some const.
Guenther
Günther Deschner [Tue, 26 Sep 2006 16:26:17 +0000 (16:26 +0000)]
r18921: Fix some c++ warnings.
Guenther
Stefan Metzmacher [Tue, 26 Sep 2006 15:23:59 +0000 (15:23 +0000)]
r18920: merge socket_wrapper changes from samba4
metze
Gerald Carter [Tue, 26 Sep 2006 15:15:26 +0000 (15:15 +0000)]
r18919: * Get the new rpccli_winreg_XXXX() functions into the tree
There some broken functionality here that I'm still working on.
* remove unneeded parsing routines
Andrew Tridgell [Tue, 26 Sep 2006 02:49:16 +0000 (02:49 +0000)]
r18912: we don't need the special case for comments now in the
This also fixes comments in group mappings, as the code accidentially
put in "ntName" in the comment field :-)
Andrew Tridgell [Tue, 26 Sep 2006 01:21:34 +0000 (01:21 +0000)]
r18910: Change ldb_msg_add_string() to not actually add an attribute if the
string is zero length. This allows callers to not have to worry about
creating an invalid ldap attribute.
See extensive discussion on samba-technical list :-)
Jeremy Allison [Mon, 25 Sep 2006 20:59:48 +0000 (20:59 +0000)]
r18907: W00t. My original fix was correct after all :-).
Re-checking it in.
Fix bug #4095 - username composed into domain\user
twice in spnego path.
Jeremy.
Gerald Carter [Mon, 25 Sep 2006 18:33:15 +0000 (18:33 +0000)]
r18906: Fix 'make clean' to deal with new lib/ldb/ directory structure.
Gerald Carter [Mon, 25 Sep 2006 18:18:40 +0000 (18:18 +0000)]
r18905: I'm not really proud of this but I don't want to maintain
2 separate CPPFLAGS variables. So just cleanup the SAMBA_CPPFLAGS
for out of tree builds. This has been tested locally and works.
Maybe metze can find a better way tomorrow.
Gerald Carter [Mon, 25 Sep 2006 17:34:32 +0000 (17:34 +0000)]
r18904: * Revert previous fix for building out of tree and
add a better one which fixes the network interface detection
breakage (caused by the previous commit).
Günther Deschner [Mon, 25 Sep 2006 16:55:19 +0000 (16:55 +0000)]
r18902: Also dump mS-DS-CreatorSID.
Guenther
Stefan Metzmacher [Mon, 25 Sep 2006 16:47:50 +0000 (16:47 +0000)]
r18901: try to fix the samba3 build without having ldap
vl: you were a few seconds faster than me...:-)
metze
Volker Lendecke [Mon, 25 Sep 2006 16:29:26 +0000 (16:29 +0000)]
r18900: Next attempt to fix the Solaris build. Not sure about whether to merge this
one. Tridge? Metze?
Volker
Gerald Carter [Mon, 25 Sep 2006 16:27:33 +0000 (16:27 +0000)]
r18899: remove check for root when running configure since it does not appear to be used anymore
Jeremy Allison [Mon, 25 Sep 2006 16:26:25 +0000 (16:26 +0000)]
r18898: Fix for bug #4100 from Udo Eberhardt <udo.eberhardt@thesycon.de>.
Ensure we initialize values for smb_io_notify_info_data_strings to
fix crash.
Jeremy.
Jeremy Allison [Mon, 25 Sep 2006 16:19:30 +0000 (16:19 +0000)]
r18897: Fix valgrind bug found by Volker.
Jeremy.
Gerald Carter [Mon, 25 Sep 2006 14:07:33 +0000 (14:07 +0000)]
r18896: * Fix out of tree builds after libreplace merge
* Remove unused -D define in Makefile
Stefan Metzmacher [Mon, 25 Sep 2006 12:59:31 +0000 (12:59 +0000)]
r18895: AIX need to call pidl with --uint-enums as the compiler doesn't
like negative values in the generated code.
I'm not sure how we can solve that in samba3 as the generated code is commited
Maybe we need to alsways pass --uint-enums
metze
Volker Lendecke [Mon, 25 Sep 2006 05:35:51 +0000 (05:35 +0000)]
r18893: Attempt to fix the Solaris build
Volker Lendecke [Mon, 25 Sep 2006 05:11:16 +0000 (05:11 +0000)]
r18892: Copy over the Samba4 valgrind suppressions
Volker Lendecke [Mon, 25 Sep 2006 05:06:42 +0000 (05:06 +0000)]
r18891: Fix "double const" warning from host opi
Volker Lendecke [Mon, 25 Sep 2006 04:55:07 +0000 (04:55 +0000)]
r18889: Add some const. What's the policy here? Should I do this in Samba4 as well?
Volker
Volker Lendecke [Mon, 25 Sep 2006 04:52:30 +0000 (04:52 +0000)]
r18888: Fix a 64-bit warning
Volker Lendecke [Mon, 25 Sep 2006 04:17:38 +0000 (04:17 +0000)]
r18886: First, RPC_SRVSVC is called RPC-SRVSVC and second, we're so far off on that
one that there's no point yet to run this in the build farm.
Volker
Günther Deschner [Sun, 24 Sep 2006 23:44:00 +0000 (23:44 +0000)]
r18879: Fix crash for "net ads gpo list".
Guenther
Volker Lendecke [Sun, 24 Sep 2006 22:13:43 +0000 (22:13 +0000)]
r18878: With the recent checkins for me Samba3 compiles again with the NTSTATUS/WERROR
checks enabled. I'll look at the build farm in a couple of hours and fix it if
not.
Volker
Volker Lendecke [Sun, 24 Sep 2006 22:11:36 +0000 (22:11 +0000)]
r18877: More WERROR/NTSTATUS bugs
Volker Lendecke [Sun, 24 Sep 2006 22:11:14 +0000 (22:11 +0000)]
r18876: Fix smbclient -L
Volker Lendecke [Sun, 24 Sep 2006 22:10:48 +0000 (22:10 +0000)]
r18875: The comment field can be empty
Volker Lendecke [Sun, 24 Sep 2006 22:10:20 +0000 (22:10 +0000)]
r18874: Fix some NTSTATUS/WERROR mixups
Günther Deschner [Sun, 24 Sep 2006 07:25:08 +0000 (07:25 +0000)]
r18871: Fix copy/paste mixup.
Guenther
Andrew Tridgell [Sun, 24 Sep 2006 07:11:34 +0000 (07:11 +0000)]
r18870: - enable the ldb ldap backend properly based on configure tests for
ldap
- use ldb_global_init() instead of the backend specific
ldb_tdb_init().
Andrew Tridgell [Sun, 24 Sep 2006 03:15:58 +0000 (03:15 +0000)]
r18869: two build fixes for systems without ldap
the first is to not enable the ldap ldb backend just yet. This will
need configure tests to conditionally include. We should be able to
use the m4 files from lib/ldb/
The 2nd is to fix libads/gpo.o not to publicly prototype a function
that needs ldap.h
Andrew Tridgell [Sun, 24 Sep 2006 02:58:58 +0000 (02:58 +0000)]
r18868: just in case there is a disaster (with our code? never ...) use a
rename to group_mapping.tdb.upgraded rather than an unlink when
upgrading. So if we absolutely have to go back to the tdb, we can
change mapping_ldb.o to mapping_tdb.o in Makefile.in and recover
peoples group mappings.
We could go one step futher and make the backend configurable. Any
opinions on that?
Andrew Tridgell [Sun, 24 Sep 2006 02:52:25 +0000 (02:52 +0000)]
r18867: change the group mapping code to use ldb instead of tdb
See the discussion of this on the samba-technical list
Andrew Tridgell [Sun, 24 Sep 2006 02:49:04 +0000 (02:49 +0000)]
r18866: Jeremy and Volker have given the go-ahead on the group mapping ldb
code. Yay!
This first commit copies lib/ldb/ from Samba4. A huge congratulations
should go to Simo on this - he has put an enormous amount of work into
ldb, and it's great to see it go into the Samba3 tree.
Andrew Tridgell [Sun, 24 Sep 2006 02:32:34 +0000 (02:32 +0000)]
r18865: fixed some of the most obvious NTSTATUS/WERROR mixups in Samba3. It
still doesn't compile with immediate structures and the
NTSTATUS/WERROR separation, as there are still several places where
the two error types are mixed up. I haven't fixed those as they
require decisions about the rpcclient code that I really don't want to
get into (the error handling there is a mess)
So samba3 compiles now, but only becaise HAVE_IMMEDIATE_STRUCTURES is
not used (look for HAVE_IMMEDIATE_STRUCTURES_XX_DISABLED)
Andrew Tridgell [Sun, 24 Sep 2006 02:29:12 +0000 (02:29 +0000)]
r18864: merge lib/replace changes from samba4
Andrew Tridgell [Sun, 24 Sep 2006 02:28:28 +0000 (02:28 +0000)]
r18863: the test for immediate structures has moved to lib/replace/
Andrew Tridgell [Sat, 23 Sep 2006 21:41:41 +0000 (21:41 +0000)]
r18858: arrgh! - since HAVE_IMMEDIATE_STRUCTURES were last enabled the code
can no longer handle it (at least with gcc 4.1.2). Disable it until
investigated and fixed properly.
Volker Lendecke [Sat, 23 Sep 2006 21:35:25 +0000 (21:35 +0000)]
r18857: Re-enable the CC checks from libreplace after Tridge's fix. Thanks for that!
Volker
Andrew Tridgell [Sat, 23 Sep 2006 21:29:51 +0000 (21:29 +0000)]
r18856: fixed HAVE_IMMEDIATE_STRUCTURES and thus checking of NTSTATUS/BOOL
mixups
Volker Lendecke [Sat, 23 Sep 2006 21:27:48 +0000 (21:27 +0000)]
r18855: Tell the diff between WERROR and NTSTATUS
Volker
Volker Lendecke [Sat, 23 Sep 2006 21:23:48 +0000 (21:23 +0000)]
r18854: Disable the AC_LIBREPLACE_CC_CHECKS, this breaks the HAVE_IMMEDIATE_STRUCTURES
test with gcc 4.1.0. As the build farm is not in the best state right now,
this should not matter.
Stefan, is there any chance we get the IMMEDIATE_STRUCTURES back and have
libreplace at the same time?
Volker
Günther Deschner [Sat, 23 Sep 2006 21:06:33 +0000 (21:06 +0000)]
r18853: Fix remaining warnings. Volker, should be fine now.
Guenther
Günther Deschner [Sat, 23 Sep 2006 20:53:45 +0000 (20:53 +0000)]
r18852: Fix compiler warning (thanks Volker).
Guenther
Jeremy Allison [Sat, 23 Sep 2006 18:24:03 +0000 (18:24 +0000)]
r18846: Fix the same bug Volker noticed when marshalling/unmarshalling
SEC_ACE. "type" is also an enum that may be any size. Treat as
a uint8.
Jeremy.
Volker Lendecke [Sat, 23 Sep 2006 17:59:52 +0000 (17:59 +0000)]
r18845: Fix a type-punned warning that turned out to be a real bug: The secdesc
revision is now an enum that might be represented as anything, in particular
as an int. It's definitely not a uint16 :-)
Volker
Günther Deschner [Sat, 23 Sep 2006 06:42:28 +0000 (06:42 +0000)]
r18842: Protect against "winbind cache time = 0" on two other occasions.
Guenther
Günther Deschner [Sat, 23 Sep 2006 06:36:22 +0000 (06:36 +0000)]
r18841: Protect against potential event loop when someone is using "winbind
cache time = 0".
Guenther
Jelmer Vernooij [Fri, 22 Sep 2006 15:09:08 +0000 (15:09 +0000)]
r18823: Fix some errors in the srsvc handling code and start running the RPC-SRVSVC
test against samba3.
Günther Deschner [Fri, 22 Sep 2006 10:09:15 +0000 (10:09 +0000)]
r18820: Comment out some unused functions.
Guenther
Günther Deschner [Fri, 22 Sep 2006 09:34:25 +0000 (09:34 +0000)]
r18819: Fix build without LDAP.
Guenther
Günther Deschner [Fri, 22 Sep 2006 09:09:01 +0000 (09:09 +0000)]
r18818: Forgot header file.
Guenther
Günther Deschner [Fri, 22 Sep 2006 09:07:31 +0000 (09:07 +0000)]
r18817: Enable the build of the gpo tool but do not make it available yet.
Guenther
Günther Deschner [Fri, 22 Sep 2006 09:00:59 +0000 (09:00 +0000)]
r18816: Fix some build warnings.
Guenther
Stefan Metzmacher [Fri, 22 Sep 2006 05:46:03 +0000 (05:46 +0000)]
r18814: diable immediate structs for now until we completely build with them again
metze
Stefan Metzmacher [Fri, 22 Sep 2006 05:36:15 +0000 (05:36 +0000)]
r18813: the generated rpccli_ functions give NTSTATUS
metze
Stefan Metzmacher [Fri, 22 Sep 2006 05:26:26 +0000 (05:26 +0000)]
r18812: newer compilers don't allow non consts in static arrays
give us a chance to detect NTSTATUS vs. WERROR bugs...
metze
Gerald Carter [Fri, 22 Sep 2006 04:31:11 +0000 (04:31 +0000)]
r18811: rename stat field to avoid compiler warnings about
shadowed variables
Stefan Metzmacher [Fri, 22 Sep 2006 04:16:58 +0000 (04:16 +0000)]
r18810: use a copy of samba4's talloc under lib/talloc/
to make mergeing easier.
metze