tprouty/samba.git
11 years agor20202: fix make clean
Herb Lewis [Sat, 16 Dec 2006 00:51:15 +0000 (00:51 +0000)]
r20202: fix make clean

11 years agor20201: merge makefile changes from 3_0_24
Herb Lewis [Sat, 16 Dec 2006 00:25:34 +0000 (00:25 +0000)]
r20201: merge makefile changes from 3_0_24

11 years agor20197: merge talloc fixes from samba4:
Stefan Metzmacher [Fri, 15 Dec 2006 22:58:06 +0000 (22:58 +0000)]
r20197: merge talloc fixes from samba4:

- make most static functions inline
- handle NULL pointers in talloc_parent_chunk()
- use talloc_parent_chunk() in talloc_parent_name()
  to fix a bug found by the IBM checker

metze

11 years agor20186: Fix winbind crash bug in WINBIND_GETGROUPS.
Günther Deschner [Fri, 15 Dec 2006 16:45:39 +0000 (16:45 +0000)]
r20186: Fix winbind crash bug in WINBIND_GETGROUPS.

response_extra_sent() expects to free a malloced
extra_data.data while the add_XX_to_array functions all return talloced
memory now. Jeremy, please check.

Guenther

11 years agor20183: Fix the build.
Günther Deschner [Fri, 15 Dec 2006 12:35:20 +0000 (12:35 +0000)]
r20183: Fix the build.

Guenther

11 years agor20181: Improve NT status to pam error mapping.
Jeremy Allison [Fri, 15 Dec 2006 06:44:16 +0000 (06:44 +0000)]
r20181: Improve NT status to pam error mapping.
Jeremy.

11 years agor20180: Ensure that pam returns the correct error messages
Jeremy Allison [Fri, 15 Dec 2006 06:06:15 +0000 (06:06 +0000)]
r20180: Ensure that pam returns the correct error messages
when offline and or doing password changes.
Jeremy.

11 years agor20179: Sync up with Samba4 - remove blank lines at the
Jeremy Allison [Fri, 15 Dec 2006 01:50:04 +0000 (01:50 +0000)]
r20179: Sync up with Samba4 - remove blank lines at the
end parsing a file.
Jeremy.

11 years agor20178: Ensure we allocate the intermediate trans structs
Jeremy Allison [Fri, 15 Dec 2006 00:49:12 +0000 (00:49 +0000)]
r20178: Ensure we allocate the intermediate trans structs
off conn->mem_ctx, not the null context so we can
safefy free everything on conn close. Should fix
possible memleak.
Jeremy.

11 years agor20174: If we're only going to call one handler per message
Jeremy Allison [Thu, 14 Dec 2006 22:11:17 +0000 (22:11 +0000)]
r20174: If we're only going to call one handler per message
then terminate the traversal once we've done that.
Jeremy.

11 years agor20173: DNS update fixes:
Gerald Carter [Thu, 14 Dec 2006 17:00:10 +0000 (17:00 +0000)]
r20173: DNS update fixes:

* Fix DNS updates for multi-homed hosts
* Child domains often don't have an NS record in
  DNS so we have to fall back to looking up the the NS
  records for the forest root.
* Fix compile warning caused by mismatched 'struct in_addr'
  and 'in_addr_t' parameters called to DoDNSUpdate()

11 years agor20171: Don't delete the krb5 credential if others still reference to it.
Günther Deschner [Thu, 14 Dec 2006 16:34:24 +0000 (16:34 +0000)]
r20171: Don't delete the krb5 credential if others still reference to it.

Guenther

11 years agor20170: Fix secure DNS updates to work against
Gerald Carter [Thu, 14 Dec 2006 16:27:45 +0000 (16:27 +0000)]
r20170: Fix secure DNS updates to work against
Wnidows 2000 DNS which expects the TKEY payload to
be in the answer section and not in the additional
set of records (like Windows 2003 and the RFC).

11 years agor20169: Support for fallback to legacy mapping code was not completely tested.
Simo Sorce [Thu, 14 Dec 2006 15:30:54 +0000 (15:30 +0000)]
r20169: Support for fallback to legacy mapping code was not completely tested.
Add necessary fixes.

11 years agor20165: Change messaging subsystem to only allow one message
Jeremy Allison [Thu, 14 Dec 2006 01:00:16 +0000 (01:00 +0000)]
r20165: Change messaging subsystem to only allow one message
per type - this is all we use right now and makes
re-entrancy problems with deleting handlers with
a message dispatch loop go away.
Jeremy.

11 years agor20160: Fix long-standing (ie. from initial code I think) bug
Jeremy Allison [Wed, 13 Dec 2006 22:19:10 +0000 (22:19 +0000)]
r20160: Fix long-standing (ie. from initial code I think) bug
in tdb message processing. If we're inside a dispatch
function and we delete our own handler we'd walk onto
the next pointer from a deleted memory block. Fixes
crash bug in winbindd (and goodness knows where else).
Jeremy.

11 years agor20155: revert, I misread
Simo Sorce [Wed, 13 Dec 2006 21:05:47 +0000 (21:05 +0000)]
r20155: revert, I misread

11 years agor20154: Fix nasty typo, hunting another bug
Simo Sorce [Wed, 13 Dec 2006 21:03:38 +0000 (21:03 +0000)]
r20154: Fix nasty typo, hunting another bug

11 years agor20151: remove meaningless checks
Simo Sorce [Wed, 13 Dec 2006 18:29:00 +0000 (18:29 +0000)]
r20151: remove meaningless checks

11 years agor20150: better memory handling for some functions, make sure we don't
Simo Sorce [Wed, 13 Dec 2006 16:39:50 +0000 (16:39 +0000)]
r20150: better memory handling for some functions, make sure we don't
leak memory by using the wrong(long lived)  mem context

11 years agor20148: Forgot to merge. Ensure open_any_socket_out()
Jeremy Allison [Wed, 13 Dec 2006 05:54:39 +0000 (05:54 +0000)]
r20148: Forgot to merge. Ensure open_any_socket_out()
is safe from signals.
Jeremy.

11 years agor20146: Now online checks are fully async we can do them
Jeremy Allison [Wed, 13 Dec 2006 01:11:29 +0000 (01:11 +0000)]
r20146: Now online checks are fully async we can do them
every cache timeout times.
Jeremy.

11 years agor20140: Make online/offline detection completely asynchronous.
Jeremy Allison [Tue, 12 Dec 2006 22:41:42 +0000 (22:41 +0000)]
r20140: Make online/offline detection completely asynchronous.
Now I've done this I might be able to reduce the probe
timeout and reduce the backoff algorithm, going back
to checking every cache time seconds (5 mins by default),
as the parent or forked domain child will never block.
Jeremy.

11 years agor20136: Fix #4290. Properly compute time to password expiration in message from
Jim McDonough [Tue, 12 Dec 2006 22:05:48 +0000 (22:05 +0000)]
r20136: Fix #4290.  Properly compute time to password expiration in message from
pam_winbind.  Thanks to Andrew Benham <andrew.benham@thus.net>

11 years agor20133: get rid of defined but not used warning - static function only used
Herb Lewis [Tue, 12 Dec 2006 20:30:31 +0000 (20:30 +0000)]
r20133: get rid of defined but not used warning - static function only used
inside the #ifdef HAVE_NATIVE_ICONV

11 years agor20132: get rid of defined but not used warning - static function only used
Herb Lewis [Tue, 12 Dec 2006 20:27:01 +0000 (20:27 +0000)]
r20132: get rid of defined but not used warning - static function only used
inside the #ifdef HAVE_KRB5

11 years agor20131: get rid of a few no previous prototype warnings
Herb Lewis [Tue, 12 Dec 2006 20:15:47 +0000 (20:15 +0000)]
r20131: get rid of a few no previous prototype warnings

11 years agor20124: clean up nested extern declaration warnings
Herb Lewis [Tue, 12 Dec 2006 17:38:42 +0000 (17:38 +0000)]
r20124: clean up nested extern declaration warnings

11 years agor20119: Update help info indicating how to use separators (forward slash only)
Jim McDonough [Tue, 12 Dec 2006 16:40:57 +0000 (16:40 +0000)]
r20119: Update help info indicating how to use separators (forward slash only)
and properly use backslashes in "net ads join computername="

11 years agor20118: Fix some more warnings
Simo Sorce [Tue, 12 Dec 2006 15:16:26 +0000 (15:16 +0000)]
r20118: Fix some more warnings

11 years agor20117: 1st Error in the merge
Simo Sorce [Tue, 12 Dec 2006 15:14:27 +0000 (15:14 +0000)]
r20117: 1st Error in the merge

11 years agor20116: Start merging in the work done to create the new idmap subsystem.
Simo Sorce [Tue, 12 Dec 2006 14:52:13 +0000 (14:52 +0000)]
r20116: Start merging in the work done to create the new idmap subsystem.

Simo.

11 years agor20110: Fix interaction between paranoid malloc checker
Jeremy Allison [Mon, 11 Dec 2006 18:56:36 +0000 (18:56 +0000)]
r20110: Fix interaction between paranoid malloc checker
and lib/replace. Found by Herb - thanks !
Jeremy.

11 years agor20098: Properly fix issues with create_token_from_username()
Jeremy Allison [Sun, 10 Dec 2006 05:23:47 +0000 (05:23 +0000)]
r20098: Properly fix issues with create_token_from_username()
reported by James. Ensure that this function allocates
everything on the temporary context except the return
memory. Never call this with a null mem context, and
now use conn->mem_ctx instead in smbd/service.c.
Remove separate free functions for conn->ngroups
and conn->nt_user_token as they are now always
talloc'ed off the conn->mem_ctx. Future optimization
will be to remove conn->mem_ctx and make all objects
pointed to in the conn struct talloc'ed off conn itself.
Easy to free then :-).
Jeremy.

11 years agor20097: Ensure found_username is freed correctly when
Jeremy Allison [Sat, 9 Dec 2006 23:55:20 +0000 (23:55 +0000)]
r20097: Ensure found_username is freed correctly when
talloced on the null context.
Jeremy.

11 years agor20090: Fix a class of bugs found by James Peach. Ensure
Jeremy Allison [Sat, 9 Dec 2006 02:58:18 +0000 (02:58 +0000)]
r20090: Fix a class of bugs found by James Peach. Ensure
we never mix malloc and talloc'ed contexts in the
add_XX_to_array() and add_XX_to_array_unique()
calls. Ensure that these calls always return
False on out of memory, True otherwise and always
check them. Ensure that the relevent parts of
the conn struct and the nt_user_tokens are
TALLOC_DESTROYED not SAFE_FREE'd.
James - this should fix your crash bug in both
branches.
Jeremy.

11 years agor20089: Put gpfs acl function into vfs_gpfs module. Thanks to Gomati Mohanan
Jim McDonough [Fri, 8 Dec 2006 18:56:01 +0000 (18:56 +0000)]
r20089: Put gpfs acl function into vfs_gpfs module.  Thanks to Gomati Mohanan
<gomati.mohanan@in.ibm.com>.

Also fix fields for sec_desc differences between 3.0 and 3.0.24 in
nfs4_acls.c.

11 years agor20087: Ensure we clean up any random pending events we
Jeremy Allison [Fri, 8 Dec 2006 18:40:13 +0000 (18:40 +0000)]
r20087: Ensure we clean up any random pending events we
may have inherited from our parent in the winbindd
forked child.
Jeremy.

11 years agor20082: When fork_domain_child is forked when we're offline
Jeremy Allison [Fri, 8 Dec 2006 18:07:44 +0000 (18:07 +0000)]
r20082: When fork_domain_child is forked when we're offline
the child inherits *all* active check_online timout handlers.
This is bad when it's not our domain (ie. BUILTIN).
Jeremy.

11 years agor20069: Fix logic bug I introduced
Volker Lendecke [Thu, 7 Dec 2006 19:21:37 +0000 (19:21 +0000)]
r20069: Fix logic bug I introduced

11 years agor20063: Fix a missing protoype warning in freelistcheck.c
Volker Lendecke [Thu, 7 Dec 2006 10:49:17 +0000 (10:49 +0000)]
r20063: Fix a missing protoype warning in freelistcheck.c

11 years agor20060: Fix the timout calculation.
Jeremy Allison [Thu, 7 Dec 2006 05:48:01 +0000 (05:48 +0000)]
r20060: Fix the timout calculation.
Jeremy.

11 years agor20058: Ensure we actually do the increasing time
Jeremy Allison [Thu, 7 Dec 2006 00:08:10 +0000 (00:08 +0000)]
r20058: Ensure we actually do the increasing time
calculation when in offline mode.
Jeremy.

11 years agor20057: Attempt to fix connect timeouts when connected on
Jeremy Allison [Wed, 6 Dec 2006 23:14:15 +0000 (23:14 +0000)]
r20057: Attempt to fix connect timeouts when connected on
a network but not one on which any home DC's can
be found (hotel network problem). Still testing
but this is getting close.
Jeremy.

11 years agor20054: Revert my changes, Simo promised to work on it :-)
Volker Lendecke [Wed, 6 Dec 2006 14:40:47 +0000 (14:40 +0000)]
r20054: Revert my changes, Simo promised to work on it :-)

11 years agor20050: Remove a bogus NULL check, LTDB_OBJECTCLASS is a static string
Volker Lendecke [Wed, 6 Dec 2006 11:45:33 +0000 (11:45 +0000)]
r20050: Remove a bogus NULL check, LTDB_OBJECTCLASS is a static string

11 years agor20049: Reformatting
Volker Lendecke [Wed, 6 Dec 2006 11:01:27 +0000 (11:01 +0000)]
r20049: Reformatting

11 years agor20048: Fix vfs_full_audit after Jims kernel_flock addition
Volker Lendecke [Wed, 6 Dec 2006 10:21:20 +0000 (10:21 +0000)]
r20048: Fix vfs_full_audit after Jims kernel_flock addition

11 years agor20046: Add ldb_search_exp_fmt and port comment to 4
Volker Lendecke [Tue, 5 Dec 2006 16:20:39 +0000 (16:20 +0000)]
r20046: Add ldb_search_exp_fmt and port comment to 4

11 years agor20037: Reduce code size slightly by shuffling stuff around
Volker Lendecke [Tue, 5 Dec 2006 07:36:14 +0000 (07:36 +0000)]
r20037: Reduce code size slightly by shuffling stuff around

11 years agor20036: Merge ldb_search_exp_fmt -- Thanks simo
Volker Lendecke [Tue, 5 Dec 2006 06:25:12 +0000 (06:25 +0000)]
r20036: Merge ldb_search_exp_fmt -- Thanks simo

11 years agor20035: Fix obvious horrible bug in falling back to MS-RPC
Jeremy Allison [Tue, 5 Dec 2006 06:15:23 +0000 (06:15 +0000)]
r20035: Fix obvious horrible bug in falling back to MS-RPC
methods.
Jeremy.

11 years agor20020: Arglll... eventlogadm links against reg_db but not the rest of the registry
Volker Lendecke [Sun, 3 Dec 2006 17:34:11 +0000 (17:34 +0000)]
r20020: Arglll... eventlogadm links against reg_db but not the rest of the registry
stuff. Revert the last change.

This needs better fixing.

Volker

11 years agor20019: Replace one set of tricky code by calls to another set of tricky code:
Volker Lendecke [Sun, 3 Dec 2006 17:16:45 +0000 (17:16 +0000)]
r20019: Replace one set of tricky code by calls to another set of tricky code:
Initializing the reg_db now uses reg_createkey and reg_setvalue.

Volker

11 years agor20018: Fix a memleak in reg_createkey
Volker Lendecke [Sun, 3 Dec 2006 16:51:31 +0000 (16:51 +0000)]
r20018: Fix a memleak in reg_createkey

11 years agor20017: Make srvsvc_NetShareAdd & friends take care of registry shares
Volker Lendecke [Sun, 3 Dec 2006 16:19:29 +0000 (16:19 +0000)]
r20017: Make srvsvc_NetShareAdd & friends take care of registry shares

11 years agor20016: Add two utility functions for easy opening/creating registry keys
Volker Lendecke [Sun, 3 Dec 2006 16:19:15 +0000 (16:19 +0000)]
r20016: Add two utility functions for easy opening/creating registry keys

11 years agor20015: We have to zero out handle on key_close, otherwise the NT4 regedit will re...
Volker Lendecke [Sun, 3 Dec 2006 16:18:31 +0000 (16:18 +0000)]
r20015: We have to zero out handle on key_close, otherwise the NT4 regedit will re-use the handle

11 years agor20014: Ouch.... "res" is not a flag here, it is the service number...
Volker Lendecke [Sun, 3 Dec 2006 15:34:52 +0000 (15:34 +0000)]
r20014: Ouch.... "res" is not a flag here, it is the service number...

11 years agor20013: Fix segfaults: parm_error is a unique in/out ptr
Volker Lendecke [Sun, 3 Dec 2006 10:09:37 +0000 (10:09 +0000)]
r20013: Fix segfaults: parm_error is a unique in/out ptr

11 years agor20012: Reformatting
Volker Lendecke [Sat, 2 Dec 2006 23:01:34 +0000 (23:01 +0000)]
r20012: Reformatting

11 years agor20007: Fix a const warning just introduced
Volker Lendecke [Sat, 2 Dec 2006 11:18:19 +0000 (11:18 +0000)]
r20007: Fix a const warning just introduced

11 years agor20006: Convert the registry shares to use the new API
Volker Lendecke [Sat, 2 Dec 2006 10:53:00 +0000 (10:53 +0000)]
r20006: Convert the registry shares to use the new API

11 years agor20005: reg_open_path should become the replacement for regkey_open_internal.
Volker Lendecke [Sat, 2 Dec 2006 10:52:37 +0000 (10:52 +0000)]
r20005: reg_open_path should become the replacement for regkey_open_internal.

11 years agor20004: Remove a const, "name" is allocated anyway
Volker Lendecke [Sat, 2 Dec 2006 10:51:54 +0000 (10:51 +0000)]
r20004: Remove a const, "name" is allocated anyway

11 years agor20003: Fix error message
Volker Lendecke [Sat, 2 Dec 2006 10:51:21 +0000 (10:51 +0000)]
r20003: Fix error message

11 years agor20001: Fix bug 4273, thanks to Pascal Terjan
Volker Lendecke [Sat, 2 Dec 2006 09:17:18 +0000 (09:17 +0000)]
r20001: Fix bug 4273, thanks to Pascal Terjan

11 years agor19993: Fix the problem with Linux clients requesting O_WRONLY
Jeremy Allison [Fri, 1 Dec 2006 23:46:07 +0000 (23:46 +0000)]
r19993: Fix the problem with Linux clients requesting O_WRONLY
on write-only files. Jim please check. Should not affect
Windows clients - I ensured all the relevent Samba4
torture tests still pass.
Jeremy.

11 years agor19992: Add support to the tdb Makefile.in for executable extensions and for
Paul Green [Fri, 1 Dec 2006 20:45:43 +0000 (20:45 +0000)]
r19992: Add support to the tdb Makefile.in for executable extensions and for
separately specifying CPPFLAGS and LDFLAGS.

11 years agor19991: Sorry for this 2000-liner...
Volker Lendecke [Fri, 1 Dec 2006 20:01:09 +0000 (20:01 +0000)]
r19991: Sorry for this 2000-liner...

The main thing here is a rewrite of srv_winreg_nt.c. The core functionality
has moved to registry/reg_api.c which is then usable by the rest of Samba as
well.

On that way it fixes creating keys with more than one element in the
path. This did not work before.

Two things that sneaked in (sorry :-) is the change of some routines from
NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal.

Volker

11 years agor19990: Fix comment
Volker Lendecke [Fri, 1 Dec 2006 19:55:29 +0000 (19:55 +0000)]
r19990: Fix comment

11 years agor19986: ooops
Simo Sorce [Fri, 1 Dec 2006 16:37:25 +0000 (16:37 +0000)]
r19986: ooops

11 years agor19984: Must have been drunk yesterday.
Simo Sorce [Fri, 1 Dec 2006 16:13:06 +0000 (16:13 +0000)]
r19984: Must have been drunk yesterday.
Freeing memctx is all we need, fix double free stupidity

11 years agor19982: From Michael Adam (ma@sernet.de) (thanks!:-)
Stefan Metzmacher [Fri, 1 Dec 2006 15:12:22 +0000 (15:12 +0000)]
r19982: From Michael Adam (ma@sernet.de) (thanks!:-)

  Metze: as noted by "shattered" and discussed on the irc,
  here is a patch to lib/sysquotas_linux.c replacing some
  "get"s by "set"s. The other lib/sysquotas*.c files look
  ok to me. But in the linux variant, the problem is not
  in the actual call of quotactl but in the preparation of
  the respective "D" structs. This makes the difference
  between the get and set calls for SMB_USER_FS_QUOTA_TYPE
  and SMB_GROUP_FS_QUOTA_TYPE.

metze

11 years agor19980: Implement pam account stack checks when obey pam restrictions is true.
Simo Sorce [Fri, 1 Dec 2006 15:06:34 +0000 (15:06 +0000)]
r19980: Implement pam account stack checks when obey pam restrictions is true.
It was missing for security=server/domain/ads

Simo.

11 years agor19979: Fix memleak on pw and change talloc_destroy to TALLOC_FREE for mem_ctx
Simo Sorce [Fri, 1 Dec 2006 15:04:53 +0000 (15:04 +0000)]
r19979: Fix memleak on pw and change talloc_destroy to TALLOC_FREE for mem_ctx

11 years agor19978: More "net sam policy" improvements. Thanks to Karolin Seeger <ks@sernet.de>
Volker Lendecke [Fri, 1 Dec 2006 14:54:31 +0000 (14:54 +0000)]
r19978: More "net sam policy" improvements. Thanks to Karolin Seeger <ks@sernet.de>

Volker

11 years agor19977: * Fix a crash in the secure DNS update code. Don't free
Gerald Carter [Fri, 1 Dec 2006 14:18:35 +0000 (14:18 +0000)]
r19977: * Fix a crash in the secure DNS update code.  Don't free
  the host_principal memory while it is still being referenced
  by the gss code.

11 years agor19975: Deal with 2 keytypes I messed previously (DR/DE).
Jeremy Allison [Fri, 1 Dec 2006 01:58:43 +0000 (01:58 +0000)]
r19975: Deal with 2 keytypes I messed previously (DR/DE).
Fix code that mistakenly assumed tdb_traverse
returned 0 or -1, it actually returns -1 or the
number of entries traversed. Add a static as another
way to return the bad cache value.
Jeremy.

11 years agor19974: Add freelist check for cache. Fix testing of entry
Jeremy Allison [Fri, 1 Dec 2006 00:06:35 +0000 (00:06 +0000)]
r19974: Add freelist check for cache. Fix testing of entry
names (all except SEQNUM are *not* null terminated
strings).
Jeremy.

11 years agor19963: Add 'registry shares = yes' and registry key security descriptors.
Volker Lendecke [Thu, 30 Nov 2006 07:38:40 +0000 (07:38 +0000)]
r19963: Add 'registry shares = yes' and registry key security descriptors.

11 years agor19962: Revert bogus change in r19961. In future I will check configure.in
James Peach [Thu, 30 Nov 2006 06:26:11 +0000 (06:26 +0000)]
r19962: Revert bogus change in r19961. In future I will check configure.in
as well as Makefile.in :(

11 years agor19961: Remove VARDIR. Nothing is ever installed into this, so there's no
James Peach [Thu, 30 Nov 2006 04:55:42 +0000 (04:55 +0000)]
r19961: Remove VARDIR. Nothing is ever installed into this, so there's no
need to create it.

11 years agor19959: Allow tdb to be built standalone in Samba3.
Jeremy Allison [Thu, 30 Nov 2006 03:05:55 +0000 (03:05 +0000)]
r19959: Allow tdb to be built standalone in Samba3.
Add code to check for loops in the free list.
Should help us validate tdb's against corruption.
Jeremy.

11 years agor19958: Add check for WINBIND_OFFLINE key.
Jeremy Allison [Thu, 30 Nov 2006 00:09:34 +0000 (00:09 +0000)]
r19958: Add check for WINBIND_OFFLINE key.
Jeremy.

11 years agor19957: Initial framework to make winbindd robust
Jeremy Allison [Wed, 29 Nov 2006 23:20:22 +0000 (23:20 +0000)]
r19957: Initial framework to make winbindd robust
against tdb corruption. Needs fleshing out
(and I forgot one record type) and needs helpful
suggestion from Volker to validate freelist,
but should give an idea of how this will look.
Jeremy.

11 years agor19950: talloc_destroy is replaced these days
Volker Lendecke [Wed, 29 Nov 2006 15:46:57 +0000 (15:46 +0000)]
r19950: talloc_destroy is replaced these days

11 years agor19948: Fix a memleak
Volker Lendecke [Wed, 29 Nov 2006 12:39:33 +0000 (12:39 +0000)]
r19948: Fix a memleak

11 years agor19947: Change regkey_open_internal to take the parent key and a talloc_ctx as
Volker Lendecke [Wed, 29 Nov 2006 10:51:00 +0000 (10:51 +0000)]
r19947: Change regkey_open_internal to take the parent key and a talloc_ctx as
arguments. This also replaces regkey_close_internal by TALLOC_FREE.

Volker

11 years agor19946: in SetKeySec, sd is just a [in,ref] ptr
Volker Lendecke [Wed, 29 Nov 2006 08:51:18 +0000 (08:51 +0000)]
r19946: in SetKeySec, sd is just a [in,ref] ptr

11 years agor19945: Fix a segfault -- lookup_rids needs to init the names even on failure
Volker Lendecke [Wed, 29 Nov 2006 08:11:33 +0000 (08:11 +0000)]
r19945: Fix a segfault -- lookup_rids needs to init the names even on failure

11 years agor19944: Fix from Don Watson -- thanks
Volker Lendecke [Wed, 29 Nov 2006 06:26:12 +0000 (06:26 +0000)]
r19944: Fix from Don Watson -- thanks

11 years agor19943: Fix bug 4267 -- Thanks to David!
Volker Lendecke [Wed, 29 Nov 2006 06:15:28 +0000 (06:15 +0000)]
r19943: Fix bug 4267 -- Thanks to David!

11 years agor19942: Fix Coverity id 333, a dereference before a NULL check.
Volker Lendecke [Wed, 29 Nov 2006 06:09:24 +0000 (06:09 +0000)]
r19942: Fix Coverity id 333, a dereference before a NULL check.

Metze, you wanted to port talloc_get_type_abort() to 4. Should I just use it
in 3-ldb?

Volker

11 years agor19941: One copy of this code should be sufficient.
James Peach [Tue, 28 Nov 2006 22:55:32 +0000 (22:55 +0000)]
r19941: One copy of this code should be sufficient.

11 years agor19939: ,fix compile warning about unused functions when not using heimdal
Gerald Carter [Tue, 28 Nov 2006 21:11:20 +0000 (21:11 +0000)]
r19939: ,fix compile warning about unused functions when not using heimdal

11 years agor19936: Patch from Kai Blin <kai.blin@gmail.com> to
Jeremy Allison [Tue, 28 Nov 2006 18:51:49 +0000 (18:51 +0000)]
r19936: Patch from Kai Blin <kai.blin@gmail.com> to
match Windows NTLMSSP flags.
Jeremy.

11 years agor19935: always use discard_const_p() in lib/ldb/
Stefan Metzmacher [Tue, 28 Nov 2006 17:47:41 +0000 (17:47 +0000)]
r19935: always use discard_const_p() in lib/ldb/

metze

11 years agor19932: Add some const
Volker Lendecke [Tue, 28 Nov 2006 13:41:45 +0000 (13:41 +0000)]
r19932: Add some const

11 years agor19930: Revert the winreg idl changes. At least enumkey does not work anymore today.
Volker Lendecke [Tue, 28 Nov 2006 13:09:32 +0000 (13:09 +0000)]
r19930: Revert the winreg idl changes. At least enumkey does not work anymore today.

With more than 5 different trees I can't swear that I did test this properly
yesterday. Sorry for the noise.

Volker