tprouty/samba.git
10 years agos3-spoolss: remove old spoolss_RemoteFindFirstPrinterChangeNotifyEx.
Günther Deschner [Mon, 16 Feb 2009 22:34:12 +0000 (23:34 +0100)]
s3-spoolss: remove old spoolss_RemoteFindFirstPrinterChangeNotifyEx.

Guenther

10 years agos3-spoolss: remove SPOOL_NOTIFY_INFO_DATA and SPOOL_NOTIFY_INFO alltogether.
Günther Deschner [Thu, 12 Feb 2009 13:33:26 +0000 (14:33 +0100)]
s3-spoolss: remove SPOOL_NOTIFY_INFO_DATA and SPOOL_NOTIFY_INFO alltogether.

Guenther

10 years agos3-spoolss: remove old spoolss_RouterReplyPrinterEx.
Günther Deschner [Thu, 12 Feb 2009 13:28:33 +0000 (14:28 +0100)]
s3-spoolss: remove old spoolss_RouterReplyPrinterEx.

Guenther

10 years agos3-spoolss: remove old spoolss_RouterRefreshPrinterChangeNotify.
Günther Deschner [Thu, 12 Feb 2009 15:21:59 +0000 (16:21 +0100)]
s3-spoolss: remove old spoolss_RouterRefreshPrinterChangeNotify.

Guenther

10 years agos3-spoolss: use pidl for _spoolss_RemoteFindFirstPrinterChangeNotifyEx.
Günther Deschner [Mon, 16 Feb 2009 22:33:10 +0000 (23:33 +0100)]
s3-spoolss: use pidl for _spoolss_RemoteFindFirstPrinterChangeNotifyEx.

Guenther

10 years agos3-spoolss: use spoolss_NotifyOption and spoolss_NotifyType instead of SPOOL_NOTIFY_O...
Günther Deschner [Mon, 16 Feb 2009 23:12:21 +0000 (00:12 +0100)]
s3-spoolss: use spoolss_NotifyOption and spoolss_NotifyType instead of SPOOL_NOTIFY_OPTION and SPOOL_NOTIFY_OPTION_TYPE.

Guenther

10 years agos3-spoolss: add dup_spoolss_NotifyOption.
Günther Deschner [Mon, 23 Feb 2009 12:06:04 +0000 (13:06 +0100)]
s3-spoolss: add dup_spoolss_NotifyOption.

Guenther

10 years agos3-spoolss: use more idl types in spoolss server.
Günther Deschner [Fri, 13 Feb 2009 11:47:32 +0000 (12:47 +0100)]
s3-spoolss: use more idl types in spoolss server.

Guenther

10 years agos3-spoolss: fix memleak of spoolss_Notify array in _spoolss_RouterRefreshPrinterChang...
Günther Deschner [Thu, 12 Feb 2009 15:38:13 +0000 (16:38 +0100)]
s3-spoolss: fix memleak of spoolss_Notify array in _spoolss_RouterRefreshPrinterChangeNotify.

Guenther

10 years agos3-spoolss: use rpccli_spoolss_RouterReplyPrinterEx.
Günther Deschner [Wed, 11 Feb 2009 23:40:37 +0000 (00:40 +0100)]
s3-spoolss: use rpccli_spoolss_RouterReplyPrinterEx.

Guenther

10 years agos3-spoolss: use pidl for _spoolss_RouterRefreshPrinterChangeNotify.
Günther Deschner [Thu, 12 Feb 2009 13:18:28 +0000 (14:18 +0100)]
s3-spoolss: use pidl for _spoolss_RouterRefreshPrinterChangeNotify.

Guenther

10 years agos3-spoolss: use struct spoolss_NotifyInfo instead of SPOOL_NOTIFY_INFO.
Günther Deschner [Thu, 12 Feb 2009 13:17:53 +0000 (14:17 +0100)]
s3-spoolss: use struct spoolss_NotifyInfo instead of SPOOL_NOTIFY_INFO.

Guenther

10 years agos3-spoolss: use struct spoolss_Notify instead of SPOOL_NOTIFY_INFO_DATA.
Günther Deschner [Thu, 12 Feb 2009 12:59:28 +0000 (13:59 +0100)]
s3-spoolss: use struct spoolss_Notify instead of SPOOL_NOTIFY_INFO_DATA.

Guenther

10 years agoprefer gssapi header files from subdirectory
Björn Jacke [Sun, 22 Feb 2009 18:46:40 +0000 (19:46 +0100)]
prefer gssapi header files from subdirectory

this fixes some compile time noise on FreeBSD 7

10 years agos3-rpcclient: use correct clientname in spoolss_RemoteFindFirstPrinterChangeNotifyEx...
Günther Deschner [Mon, 23 Feb 2009 09:29:46 +0000 (10:29 +0100)]
s3-rpcclient: use correct clientname in spoolss_RemoteFindFirstPrinterChangeNotifyEx command.

Guenther

10 years agos3: re-run make samba3-idl.
Günther Deschner [Mon, 23 Feb 2009 11:47:53 +0000 (12:47 +0100)]
s3: re-run make samba3-idl.

Guenther

10 years agospoolss: spoolss_NotifyData contains a devmode container, not devmode pointer.
Günther Deschner [Mon, 23 Feb 2009 10:50:27 +0000 (11:50 +0100)]
spoolss: spoolss_NotifyData contains a devmode container, not devmode pointer.

Guenther

10 years agospoolss: fix some PRINTER_CHANGE_ defines (and add a new windows 7 flag).
Günther Deschner [Sat, 21 Feb 2009 22:11:49 +0000 (23:11 +0100)]
spoolss: fix some PRINTER_CHANGE_ defines (and add a new windows 7 flag).

Guenther

10 years agoall BSDs use this evironment variable
Björn Jacke [Sat, 21 Feb 2009 23:43:38 +0000 (00:43 +0100)]
all BSDs use this evironment variable

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3/docs: Fix typo in man mount.cifs.
Karolin Seeger [Mon, 23 Feb 2009 08:24:50 +0000 (09:24 +0100)]
s3/docs: Fix typo in man mount.cifs.

Thanks to Tobias Stoeckmann for reporting!

Karolin

10 years agos3: Wrap usage of rlimit in configure checks
Steven Danneman [Mon, 23 Feb 2009 05:55:25 +0000 (21:55 -0800)]
s3: Wrap usage of rlimit in configure checks

10 years agoFor some unknown reason ldbrename was not being built in samba3.
Simo Sorce [Sun, 22 Feb 2009 06:06:28 +0000 (01:06 -0500)]
For some unknown reason ldbrename was not being built in samba3.

10 years agos3 OneFS: Add an atomic sendfile implementation
Tim Prouty [Fri, 20 Feb 2009 21:27:39 +0000 (13:27 -0800)]
s3 OneFS: Add an atomic sendfile implementation

10 years agos3: If sendfile returns 0 bytes read, fall back to the normal read path
Tim Prouty [Fri, 20 Feb 2009 21:28:36 +0000 (13:28 -0800)]
s3: If sendfile returns 0 bytes read, fall back to the normal read path

This allows sendfile implementations that are atomic to avoid having
to send zeros or kill the client connection on a short read (usually
the file was truncated).

10 years agoRevert "s3 auth: Add parameter that forces every user through an NSS lookup"
Tim Prouty [Sat, 21 Feb 2009 21:57:10 +0000 (13:57 -0800)]
Revert "s3 auth: Add parameter that forces every user through an NSS lookup"

After the discussion on samba-technical, it was decided that the best
answer for now was to revert this change.  The right way to do this is
to rewrite the token api to use opaque tokens with pluggable modules.

This reverts commit 8e19a288052bca5efdb0277a40c1e0fdd099cc2b.

10 years agoFix shadowed declaration warning
Tim Prouty [Sat, 21 Feb 2009 21:54:43 +0000 (13:54 -0800)]
Fix shadowed declaration warning

10 years agos3-spoolss: fix client name in rpccli_spoolss_openprinter_ex.
Günther Deschner [Sat, 21 Feb 2009 20:07:37 +0000 (21:07 +0100)]
s3-spoolss: fix client name in rpccli_spoolss_openprinter_ex.

Guenther

10 years agos3-spoolss: remove duplicate flag.
Günther Deschner [Sat, 21 Feb 2009 20:03:36 +0000 (21:03 +0100)]
s3-spoolss: remove duplicate flag.

Guenther

10 years agos3-spoolss: fix _spoolss_GetPrinterDriverDirectory and spoolss_GetPrintProcessorDirec...
Günther Deschner [Fri, 20 Feb 2009 13:55:31 +0000 (14:55 +0100)]
s3-spoolss: fix _spoolss_GetPrinterDriverDirectory and spoolss_GetPrintProcessorDirectory.

Both calls need to return NULL in the error case to avoid ndr encoding problems.
(found by smbtorture spoolss test).

Guenther

10 years agos3-eventlog: fix rpcclient and server stub for eventlog_GetLogInformation.
Günther Deschner [Fri, 20 Feb 2009 13:24:59 +0000 (14:24 +0100)]
s3-eventlog: fix rpcclient and server stub for eventlog_GetLogInformation.

Guenther

10 years agos4-smbtorture: fix eventlog getinformation test.
Günther Deschner [Fri, 20 Feb 2009 13:22:39 +0000 (14:22 +0100)]
s4-smbtorture: fix eventlog getinformation test.

Guenther

10 years agos3: re-run make samba3-idl.
Günther Deschner [Sat, 21 Feb 2009 20:13:46 +0000 (21:13 +0100)]
s3: re-run make samba3-idl.

Guenther

10 years agospoolss: add spoolssNotifyOptionFlags.
Günther Deschner [Sat, 21 Feb 2009 20:03:13 +0000 (21:03 +0100)]
spoolss: add spoolssNotifyOptionFlags.

Guenther

10 years agoeventlog: remove unused eventlog_Record struct.
Günther Deschner [Fri, 20 Feb 2009 13:20:05 +0000 (14:20 +0100)]
eventlog: remove unused eventlog_Record struct.

Guenther

10 years agoeventlog: fix eventlog_GetLogInformation typo in IDL.
Günther Deschner [Fri, 20 Feb 2009 13:18:06 +0000 (14:18 +0100)]
eventlog: fix eventlog_GetLogInformation typo in IDL.

Guenther

10 years agopytevent: Fix include path - tevent_util is not installed.
Jelmer Vernooij [Sat, 21 Feb 2009 18:08:24 +0000 (19:08 +0100)]
pytevent: Fix include path - tevent_util is not installed.

10 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Sat, 21 Feb 2009 18:00:18 +0000 (19:00 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

10 years agoLet --enable-external-libldb default to no (since linking against
Jelmer Vernooij [Sat, 21 Feb 2009 17:59:12 +0000 (18:59 +0100)]
Let --enable-external-libldb default to no (since linking against
external LDB doesn't work yet).
Fix flags when using internal libs.

10 years agoFix the build on Solaris
Volker Lendecke [Sat, 21 Feb 2009 17:55:35 +0000 (18:55 +0100)]
Fix the build on Solaris

10 years agoAdd --enable-external-* flags for libraries shipped with Samba, to allow
Jelmer Vernooij [Sat, 21 Feb 2009 17:21:20 +0000 (18:21 +0100)]
Add --enable-external-* flags for libraries shipped with Samba, to allow
explicitly enabling or disabling the use of the version provided by the
system.

10 years agoFix some nonempty blank lines
Volker Lendecke [Sat, 21 Feb 2009 12:20:08 +0000 (13:20 +0100)]
Fix some nonempty blank lines

10 years agoRemove the static "chal" from ntlmssp.c:get_challenge()
Volker Lendecke [Thu, 19 Feb 2009 22:41:48 +0000 (23:41 +0100)]
Remove the static "chal" from ntlmssp.c:get_challenge()

10 years agoFix a typo
Volker Lendecke [Thu, 12 Feb 2009 15:21:45 +0000 (16:21 +0100)]
Fix a typo

10 years agoDo not close an fd we know is -1
Volker Lendecke [Sat, 14 Feb 2009 12:43:09 +0000 (13:43 +0100)]
Do not close an fd we know is -1

10 years agoMove some bytes from the data to the text segment
Volker Lendecke [Thu, 19 Feb 2009 22:26:06 +0000 (23:26 +0100)]
Move some bytes from the data to the text segment

10 years agoFix an uninitialized variable
Volker Lendecke [Sat, 21 Feb 2009 11:49:01 +0000 (12:49 +0100)]
Fix an uninitialized variable

10 years agos3: Fix build break in d9a842b2
Steven Danneman [Sat, 21 Feb 2009 07:25:49 +0000 (23:25 -0800)]
s3: Fix build break in d9a842b2

* actually check for existance of sysctlbyname()

10 years agoIntroduce a new passdb backend: pdb_onefs_sam
Dan Sledz [Fri, 13 Feb 2009 20:28:57 +0000 (12:28 -0800)]
Introduce a new passdb backend: pdb_onefs_sam

Implements a custom backend for onefs that exclusively uses the wbclient
interface for all passdb calls.
It lacks some features of a standard passdb.
In particular it's a read only interface and doesn't implement privileges.

10 years agoIntroduce a new authentication backend auth_onefs_wb
Dan Sledz [Fri, 13 Feb 2009 20:24:22 +0000 (12:24 -0800)]
Introduce a new authentication backend auth_onefs_wb

This new backend is custom tailored to onefs' unique requirements:
1) No fallback logic
2) Does not validate the domain of the user
3) Handles unencrypted passwords

10 years agoAllow building with an external libwbclient library
Dan Sledz [Tue, 9 Dec 2008 08:29:26 +0000 (08:29 +0000)]
Allow building with an external libwbclient library

Introduce a new configure option --with-wbclient which specifies a
location to find a compatible libwbclient library to link against.  This
options is overwritten by --with-winbind

10 years agos4 torture: Add comment to clarify test
Zack Kirsch [Fri, 20 Feb 2009 23:29:29 +0000 (15:29 -0800)]
s4 torture: Add comment to clarify test

10 years agos3 BRL: Add more clarifying comments and add implied logic to make conditional more...
Zack Kirsch [Fri, 20 Feb 2009 23:22:15 +0000 (15:22 -0800)]
s3 BRL: Add more clarifying comments and add implied logic to make conditional more clear

10 years agos3 OneFS: Add debugging for createfile_flags
Zack Kirsch [Fri, 20 Feb 2009 23:20:39 +0000 (15:20 -0800)]
s3 OneFS: Add debugging for createfile_flags

10 years agoChange smbc_set_credentials_with_fallback() (unreleased) to use
Jeremy Allison [Sat, 21 Feb 2009 00:41:41 +0000 (16:41 -0800)]
Change smbc_set_credentials_with_fallback() (unreleased) to use
const approptiately.
Jeremy.

10 years agoS3: Detect max_open_files from system
todd stecher [Thu, 19 Feb 2009 17:33:30 +0000 (09:33 -0800)]
S3: Detect max_open_files from system
- Attempt to use syscalls to determine max-open-files value.
- Add in periodic logging when max file limit reached

10 years agos3: Refactor of madvise() usage in c441f58d
Steven Danneman [Sat, 21 Feb 2009 00:24:08 +0000 (16:24 -0800)]
s3: Refactor of madvise() usage in c441f58d

* move to reinit_after_fork() to protect all Samba daemons
* only protect parent processes

10 years agoMoved become_daemon() and close_low_fds() to shared util lib
Steven Danneman [Fri, 20 Feb 2009 23:10:21 +0000 (15:10 -0800)]
Moved become_daemon() and close_low_fds() to shared util lib

10 years agos3: OneFS implementation of change notify
Steven Danneman [Fri, 20 Feb 2009 21:25:17 +0000 (13:25 -0800)]
s3: OneFS implementation of change notify

The OneFS Samba implementation of change notify is modeled after the
usage of Linux's inotify kernel subsystem.  A single call is made
into the onefs.so VFS module to initialize kernel tracking of certain
file change events.  When these events occur a kernel notification is
sent to smbd and the notification event is translated and given to the
general Samba Change Notify layer through a callback function.

The most difficult aspect is converting an SMB CompletionFilter to
a matching ifs_event mask, and then back to an appropriate change
notify action.  Currently, not all possible cases are handled by the
this module, but the most prevalent ones, which are tested by
smbtorture, are implemented.

10 years agos3: Make change notify immediately return a catch-all packet on underlying error
Steven Danneman [Wed, 18 Feb 2009 00:20:18 +0000 (16:20 -0800)]
s3: Make change notify immediately return a catch-all packet on underlying error

* This allows a problem in the underlying CN backend to be bubbled up
  to the general CN layer so a catch-all reply can be returned
* We now also return a catch-all response immediately if the server-side
  event queue becomes too big

10 years agos3: Modifications to generic notify structures to allow implementation of OneFS notify.
Steven Danneman [Fri, 20 Feb 2009 21:23:53 +0000 (13:23 -0800)]
s3: Modifications to generic notify structures to allow implementation of OneFS notify.

The OneFS kernel based change notify system takes an fd of the directory
to watch in it's initialization syscall.  Since we already have this
directory open, this commit plumbs that fd down to the VFS layer via the
notify_entry struct.

We also need to know if the watch is taken out on a snapshot directory.
The full file_id struct is also passed down to make this determination.
The file_id marshalling wrappers are hand written here, but should
eventually be auto-generated by moving the struct file_id into the idl.

10 years agoAdded torture tests to RAW-NOTIFY
Steven Danneman [Fri, 20 Feb 2009 01:06:27 +0000 (17:06 -0800)]
Added torture tests to RAW-NOTIFY

* This adds a test to check the change notify behavior of the SMB server
  when more events have been generated than can be returned in a single
  change notify response.

* Second test makes sure the server doesn't return notification events
  for changes to the watched directory itself

10 years agoFix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
Jeremy Allison [Fri, 20 Feb 2009 16:23:52 +0000 (08:23 -0800)]
Fix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
As the NFSv4 ACL mapping code doesn't map write directory into the DELETE_CHILD
permission bit (which we require before allowing a delete) no one can delete
files without an explicit DELETE_CHILD bit set on the directory. Add this mapping.
Jeremy.

10 years agovariable grouping: just my OCD desire to keep similar things together
Derrell Lipman [Fri, 20 Feb 2009 14:51:36 +0000 (09:51 -0500)]
variable grouping: just my OCD desire to keep similar things together

10 years agoMake libsmbclient work with DFS
Bo Yang [Fri, 20 Feb 2009 04:00:46 +0000 (12:00 +0800)]
Make libsmbclient work with DFS

Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
10 years agos3/docs: Add hint about getfattr in man vfs_acl_xattr.
Karolin Seeger [Fri, 20 Feb 2009 13:14:54 +0000 (14:14 +0100)]
s3/docs: Add hint about getfattr in man vfs_acl_xattr.

Karolin

10 years agos3/docs: Add man vfs_acl_tdb.
Karolin Seeger [Fri, 20 Feb 2009 12:32:44 +0000 (13:32 +0100)]
s3/docs: Add man vfs_acl_tdb.

Karolin

10 years agos3/docs: Add man vfs_acl_xattr.
Karolin Seeger [Fri, 20 Feb 2009 12:32:22 +0000 (13:32 +0100)]
s3/docs: Add man vfs_acl_xattr.

Karolin

10 years agos3/docs: Fix several typos.
Karolin Seeger [Fri, 20 Feb 2009 08:20:16 +0000 (09:20 +0100)]
s3/docs: Fix several typos.

This fixes bug #6127.
Thanks to Justin T Pryzby <justinpryzby [at] users.sourceforge.net>
for the review!

Karolin

10 years agos3 OneFS: Add shadow copy module
Tim Prouty [Wed, 18 Feb 2009 04:39:03 +0000 (20:39 -0800)]
s3 OneFS: Add shadow copy module

10 years agos3 OneFS: Add file_id_create implementation to take advantage of snapshots
Tim Prouty [Wed, 18 Feb 2009 02:38:58 +0000 (18:38 -0800)]
s3 OneFS: Add file_id_create implementation to take advantage of snapshots

10 years agos3: Change the vfs_GetWd cache to use the file_id struct
Tim Prouty [Tue, 17 Feb 2009 00:06:45 +0000 (16:06 -0800)]
s3: Change the vfs_GetWd cache to use the file_id struct

10 years agos3: Remove unused inform_level2_message struct
Tim Prouty [Mon, 16 Feb 2009 22:55:52 +0000 (14:55 -0800)]
s3: Remove unused inform_level2_message struct

10 years agos3: Add extid to the dev/inode pair
Tim Prouty [Mon, 16 Feb 2009 07:45:28 +0000 (23:45 -0800)]
s3: Add extid to the dev/inode pair

This extends the file_id struct to add an additional generic uint64_t
field: extid.  For backwards compatibility with dev/inodes stored in
xattr_tdbs and acl_tdbs, the ext id is ignored for these databases.
This patch should cause no functional change on systems that don't use
SMB_VFS_FILE_ID_CREATE to set the extid.

Existing code that uses the smb_share_mode library will need to be
updated to be compatibile with the new extid.

10 years agos3: Modify SMB_VFS_FILE_ID_CREATE to take a stat struct
Tim Prouty [Mon, 16 Feb 2009 07:38:53 +0000 (23:38 -0800)]
s3: Modify SMB_VFS_FILE_ID_CREATE to take a stat struct

Since file_id_create_dev is incompatible with the concept of file_ids,
it is now static and in the one file that needs it.

10 years agoFix printf warnings found on systems where time_t <> long int.
Jeremy Allison [Thu, 19 Feb 2009 21:36:20 +0000 (13:36 -0800)]
Fix printf warnings found on systems where time_t <> long int.
Jeremy.

10 years agoFix printf type warning.
Jeremy Allison [Thu, 19 Feb 2009 21:11:36 +0000 (13:11 -0800)]
Fix printf type warning.
Jeremy.

10 years agoFix an uninitialized variable
Volker Lendecke [Thu, 19 Feb 2009 19:59:31 +0000 (20:59 +0100)]
Fix an uninitialized variable

10 years agoFix a O(n^2) algorithm in regdb_fetch_keys()
Volker Lendecke [Thu, 19 Feb 2009 19:03:06 +0000 (20:03 +0100)]
Fix a O(n^2) algorithm in regdb_fetch_keys()

10 years agos3-spoolss: fix vista fallback in _spoolss_AddPrinterDriverEx.
Günther Deschner [Thu, 19 Feb 2009 18:02:48 +0000 (19:02 +0100)]
s3-spoolss: fix vista fallback in _spoolss_AddPrinterDriverEx.

Martin Zielinski, if you're reading this, please have a look. Vista nicely takes
just a WERR_UNKNOWN_LEVEL here and retries with a level 6 add.

Guenther

10 years agos3-spoolss: remove old spoolss_AddPrinterDriver{Ex}.
Günther Deschner [Wed, 18 Feb 2009 18:00:29 +0000 (19:00 +0100)]
s3-spoolss: remove old spoolss_AddPrinterDriver{Ex}.

Guenther

10 years agos3-spoolss: use pidl for _spoolss_AddPrinterDriver{Ex}.
Günther Deschner [Wed, 18 Feb 2009 17:59:43 +0000 (18:59 +0100)]
s3-spoolss: use pidl for _spoolss_AddPrinterDriver{Ex}.

Guenther

10 years agos3-spoolss: remove old spoolss_GetPrintProcessorDirectory.
Günther Deschner [Thu, 19 Feb 2009 09:44:42 +0000 (10:44 +0100)]
s3-spoolss: remove old spoolss_GetPrintProcessorDirectory.

Guenther

10 years agos3-spoolss: use pidl for _spoolss_GetPrintProcessorDirectory.
Günther Deschner [Thu, 19 Feb 2009 09:42:49 +0000 (10:42 +0100)]
s3-spoolss: use pidl for _spoolss_GetPrintProcessorDirectory.

Guenther.

10 years agos3-rpcclient: use rpccli_spoolss_GetPrintProcessorDirectory in rpcclient.
Günther Deschner [Thu, 19 Feb 2009 09:26:00 +0000 (10:26 +0100)]
s3-rpcclient: use rpccli_spoolss_GetPrintProcessorDirectory in rpcclient.

Guenther

10 years agos3-spoolss: fix _spoolss_GetPrinterDriverDirectory.
Günther Deschner [Thu, 19 Feb 2009 18:17:19 +0000 (19:17 +0100)]
s3-spoolss: fix _spoolss_GetPrinterDriverDirectory.

treat architecture correctly as it is a [unique] pointer, and newer
Windows versions sometimes send in an empty string.

Guenther

10 years agos3-rpcclient: use SPOOLSS_ARCHITECTURE_NT_X86 define in spoolss getdriverdir cmd.
Günther Deschner [Thu, 19 Feb 2009 16:41:10 +0000 (17:41 +0100)]
s3-rpcclient: use SPOOLSS_ARCHITECTURE_NT_X86 define in spoolss getdriverdir cmd.

Guenther

10 years agos3-spoolss: _spoolss_OpenPrinterEx needs to wipe out policy handle upon failure.
Günther Deschner [Thu, 19 Feb 2009 14:56:05 +0000 (15:56 +0100)]
s3-spoolss: _spoolss_OpenPrinterEx needs to wipe out policy handle upon failure.

Guenther

10 years agos3-spoolss: _spoolss_AddPrinterEx needs to wipe out policy handle upon failure.
Günther Deschner [Thu, 19 Feb 2009 16:40:21 +0000 (17:40 +0100)]
s3-spoolss: _spoolss_AddPrinterEx needs to wipe out policy handle upon failure.

Guenther

10 years agospoolss: add ndr_size_spoolss_StringArray to spoolss helper.
Günther Deschner [Thu, 19 Feb 2009 16:39:36 +0000 (17:39 +0100)]
spoolss: add ndr_size_spoolss_StringArray to spoolss helper.

Guenther

10 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 19 Feb 2009 16:59:51 +0000 (17:59 +0100)]
s3: re-run make samba3-idl.

Guenther

10 years agospoolss: remove gensize calculation from spoolss_StringArray. Thanks metze!
Günther Deschner [Thu, 19 Feb 2009 16:38:47 +0000 (17:38 +0100)]
spoolss: remove gensize calculation from spoolss_StringArray. Thanks metze!

Guenther

10 years agoFix a buffer handling bug when adding lots of registry keys
Volker Lendecke [Thu, 19 Feb 2009 13:16:44 +0000 (14:16 +0100)]
Fix a buffer handling bug when adding lots of registry keys

This is *ancient*... From 2002, and nobody noticed until someone added lots of
shares using net conf... :-)

10 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 19 Feb 2009 12:06:11 +0000 (13:06 +0100)]
s3: re-run make samba3-idl.

Guenther

10 years agospoolss: fill in spoolss_GetPrintProcessorDirectory.
Günther Deschner [Thu, 19 Feb 2009 09:45:12 +0000 (10:45 +0100)]
spoolss: fill in spoolss_GetPrintProcessorDirectory.

Guenther

10 years agos3-libnet: fix coverity #848 (UNINIT).
Günther Deschner [Thu, 19 Feb 2009 01:35:20 +0000 (02:35 +0100)]
s3-libnet: fix coverity #848 (UNINIT).

Guenther

10 years agos4:librpc/ndr: if uninitialized variable in string_array code
Stefan Metzmacher [Thu, 19 Feb 2009 10:12:33 +0000 (11:12 +0100)]
s4:librpc/ndr: if uninitialized variable in string_array code

metze

10 years agos3:librpc/ndr: if uninitialized variable in string_array code
Stefan Metzmacher [Thu, 19 Feb 2009 10:11:28 +0000 (11:11 +0100)]
s3:librpc/ndr: if uninitialized variable in string_array code

metze

10 years agolibrpc: rerun make idl
Stefan Metzmacher [Thu, 19 Feb 2009 10:11:04 +0000 (11:11 +0100)]
librpc: rerun make idl

10 years agopidl:NDR/Parser: don't call [noopnum] function when creating the ndr_interface_table
Stefan Metzmacher [Thu, 19 Feb 2009 09:32:48 +0000 (10:32 +0100)]
pidl:NDR/Parser: don't call [noopnum] function when creating the ndr_interface_table

metze

10 years agos3 OneFS: Fixes "inherit permissions" and "nt acl support" for Onefs.
Zack Kirsch [Wed, 18 Feb 2009 05:03:33 +0000 (21:03 -0800)]
s3 OneFS: Fixes "inherit permissions" and "nt acl support" for Onefs.